mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-26 14:40:41 +00:00
54841ab50c
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands. Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".
This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:
int main (int argc, char **argv)
{
while (--argc > 0 && **++argv == '-') {
/* ====> */ while (*++*argv) {
switch (**argv) {
case 'd':
debug++;
break;
...
default:
usage ();
}
}
}
...
}
The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell. With the modification, the compiler will prevent this with
an
error: increment of read-only location '*argv'
N.B.: The code above can be trivially rewritten like this:
while (--argc > 0 && **++argv == '-') {
char *arg = *argv;
while (*++arg) {
switch (*arg) {
...
Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
|
||
|---|---|---|
| .. | ||
| adciop | ||
| apc405 | ||
| ar405 | ||
| ash405 | ||
| canbt | ||
| cms700 | ||
| common | ||
| cpci2dp | ||
| cpci405 | ||
| cpci750 | ||
| cpci5200 | ||
| cpciiser4 | ||
| dasa_sim | ||
| dp405 | ||
| du405 | ||
| du440 | ||
| hh405 | ||
| hub405 | ||
| mecp5123 | ||
| mecp5200 | ||
| meesc | ||
| ocrtc | ||
| otc570 | ||
| pci405 | ||
| pf5200 | ||
| plu405 | ||
| pmc405 | ||
| pmc405de | ||
| pmc440 | ||
| tasreg | ||
| vme8349 | ||
| voh405 | ||
| vom405 | ||
| wuh405 | ||