u-boot/arch/arm/lib/interrupts_m.c
Harald Seiler 35b65dd8ef reset: Remove addr parameter from reset_cpu()
Historically, the reset_cpu() function had an `addr` parameter which was
meant to pass in an address of the reset vector location, where the CPU
should reset to.  This feature is no longer used anywhere in U-Boot as
all reset_cpu() implementations now ignore the passed value.  Generic
code has been added which always calls reset_cpu() with `0` which means
this feature can no longer be used easily anyway.

Over time, many implementations seem to have "misunderstood" the
existence of this parameter as a way to customize/parameterize the reset
(e.g.  COLD vs WARM resets).  As this is not properly supported, the
code will almost always not do what it is intended to (because all
call-sites just call reset_cpu() with 0).

To avoid confusion and to clean up the codebase from unused left-overs
of the past, remove the `addr` parameter entirely.  Code which intends
to support different kinds of resets should be rewritten as a sysreset
driver instead.

This transformation was done with the following coccinelle patch:

    @@
    expression argvalue;
    @@
    - reset_cpu(argvalue)
    + reset_cpu()

    @@
    identifier argname;
    type argtype;
    @@
    - reset_cpu(argtype argname)
    + reset_cpu(void)
    { ... }

Signed-off-by: Harald Seiler <hws@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
2021-03-02 14:03:02 -05:00

98 lines
1.8 KiB
C

// SPDX-License-Identifier: GPL-2.0+
/*
* (C) Copyright 2015
* Kamil Lulko, <kamil.lulko@gmail.com>
*/
#include <common.h>
#include <cpu_func.h>
#include <irq_func.h>
/*
* Upon exception entry ARMv7-M processors automatically save stack
* frames containing some registers. For simplicity initial
* implementation uses only this auto-saved stack frame.
* This does not contain complete register set dump,
* only R0-R3, R12, LR, PC and xPSR are saved.
*/
struct autosave_regs {
long uregs[8];
};
#define ARM_XPSR uregs[7]
#define ARM_PC uregs[6]
#define ARM_LR uregs[5]
#define ARM_R12 uregs[4]
#define ARM_R3 uregs[3]
#define ARM_R2 uregs[2]
#define ARM_R1 uregs[1]
#define ARM_R0 uregs[0]
int interrupt_init(void)
{
enable_interrupts();
return 0;
}
void enable_interrupts(void)
{
return;
}
int disable_interrupts(void)
{
return 0;
}
void dump_regs(struct autosave_regs *regs)
{
printf("pc : %08lx lr : %08lx xPSR : %08lx\n",
regs->ARM_PC, regs->ARM_LR, regs->ARM_XPSR);
printf("r12 : %08lx r3 : %08lx r2 : %08lx\n"
"r1 : %08lx r0 : %08lx\n",
regs->ARM_R12, regs->ARM_R3, regs->ARM_R2,
regs->ARM_R1, regs->ARM_R0);
}
void bad_mode(void)
{
panic("Resetting CPU ...\n");
reset_cpu();
}
void do_hard_fault(struct autosave_regs *autosave_regs)
{
printf("Hard fault\n");
dump_regs(autosave_regs);
bad_mode();
}
void do_mm_fault(struct autosave_regs *autosave_regs)
{
printf("Memory management fault\n");
dump_regs(autosave_regs);
bad_mode();
}
void do_bus_fault(struct autosave_regs *autosave_regs)
{
printf("Bus fault\n");
dump_regs(autosave_regs);
bad_mode();
}
void do_usage_fault(struct autosave_regs *autosave_regs)
{
printf("Usage fault\n");
dump_regs(autosave_regs);
bad_mode();
}
void do_invalid_entry(struct autosave_regs *autosave_regs)
{
printf("Exception\n");
dump_regs(autosave_regs);
bad_mode();
}