Mirrors/u-boot
2
0
Fork 0
mirror of https://github.com/AsahiLinux/u-boot synced 2024-11-10 15:14:43 +00:00
Code Issues Projects Releases Packages Wiki Activity
u-boot/cmd
History
Alison Chaiken 2fcaa413b3 gpt: harden set_gpt_info() against non NULL-terminated strings 
Strings read from devices may sometimes fail to be
NULL-terminated.   The functions in lib/string.c are subject to
failure in this case.   Protect against observed failures in
set_gpt_info() by switching to length-checking variants with a length
limit of the maximum possible partition table length.  At the same
time, add a few checks for NULL string pointers.

Here is an example as observed in sandbox under GDB:

    => gpt verify host 0 $partitions
    Program received signal SIGSEGV, Segmentation fault.
    0x0000000000477747 in strlen (s=0x0) at lib/string.c:267
    267             for (sc = s; *sc != '\0'; ++sc)
    (gdb) bt
    #0  0x0000000000477747 in strlen (s=0x0) at lib/string.c:267
    #1  0x00000000004140b2 in set_gpt_info (str_part=<optimized out>,
    str_disk_guid=str_disk_guid@entry=0x7fffffffdbe8, partitions=partitions@entry=0x7fffffffdbd8,
    parts_count=parts_count@entry=0x7fffffffdbcf "", dev_desc=<optimized out>) at cmd/gpt.c:415
    #2  0x00000000004145b9 in gpt_verify (str_part=<optimized out>, blk_dev_desc=0x7fffef09a9d0) at cmd/gpt.c:580
    #3  do_gpt (cmdtp=<optimized out>, flag=<optimized out>, argc=<optimized out>, argv=0x7fffef09a8f0)
    at cmd/gpt.c:783
    #4  0x00000000004295b0 in cmd_call (argv=0x7fffef09a8f0, argc=0x5, flag=<optimized out>,
    cmdtp=0x714e20 <_u_boot_list_2_cmd_2_gpt>) at common/command.c:500
    #5  cmd_process (flag=<optimized out>, argc=0x5, argv=0x7fffef09a8f0,
    repeatable=repeatable@entry=0x726c04 <flag_repeat>, ticks=ticks@entry=0x0) at common/command.c:539

Suggested-by: Lothar Waßmann <LW@karo-electronics.de>
Signed-off-by: Alison Chaiken <alison@peloton-tech.com>
2017-08-04 20:38:32 -04:00
..
fastboot fastboot: simplify the Kconfig logic 2016-11-21 14:07:33 -05:00
mvebu cmd: mvebu: bubt: use get_nand_dev_by_index() 2017-07-11 22:41:49 -04:00
.gitignore cmd: rework "license" command 2017-02-08 15:56:28 -05:00
aes.c Rename aes.h to uboot_aes.h 2017-04-12 13:28:27 -04:00
armflash.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
bdinfo.c spl: make SPL and normal u-boot stage use independent SYS_MALLOC_F_LEN 2017-07-27 14:59:03 +02:00
bedbug.c powerpc: remove 4xx support 2017-07-03 17:35:28 -04:00
blkcache.c cmd: blkcache: simplify sub-command handling 2016-04-11 12:44:38 -04:00
blob.c crypto/fsl: Update blob cmd to accept 64bit addresses 2016-08-02 09:45:39 -07:00
bmp.c dm: Use uclass_first_device_err() where it is useful 2016-03-14 15:34:50 -06:00
boot.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
bootefi.c efi_loader: Fix configuration table override 2017-07-26 15:24:47 +02:00
booti.c arm64: booti: allow to place kernel image anywhere in physical memory 2017-03-14 20:40:23 -04:00
bootm.c cmd: bootm: use get_nand_dev_by_index() 2017-07-11 22:41:45 -04:00
bootmenu.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
bootstage.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
bootz.c bootz/booti: relocate ramdisk if CONFIG_SYS_BOOT_RAMDISK_HIGH set 2017-01-24 10:35:55 -05:00
cache.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
cbfs.c cbfs: Update a function to be static 2016-03-22 12:16:08 -04:00
clk.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
config.c cmd: add a new command "config" to show .config contents 2017-02-08 15:56:26 -05:00
console.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
cpu.c cmd: cpu: refactor to ensure devices are probed and improve code style 2017-05-10 16:16:09 +02:00
cramfs.c fs: Kconfig: Add a separate option for FS_JFFS2 2017-05-22 12:45:31 -04:00
cros_ec.c dm: core: Add flags parameter to device_remove() 2017-04-04 20:15:10 -06:00
dataflash_mmc_mux.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
date.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
demo.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
dfu.c common: dfu: saperate the dfu common functionality 2016-09-27 23:30:18 +02:00
diag.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
disk.c cmd: Rework disk.c usage 2016-09-09 15:53:14 -04:00
display.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
echo.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
eeprom.c Convert CONFIG_CMD_EEPROM et al to Kconfig 2017-05-22 09:33:49 -04:00
efi.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
elf.c cmd/elf.c: Support passing arguments with bootelf 2017-06-05 14:13:03 -04:00
ethsw.c cmd: ethsw: Fix out-of-bounds error 2017-06-16 10:11:42 -04:00
exit.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
ext2.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
ext4.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
fastboot.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
fat.c cmd/fat: Do not crash on write when <bytes> is not specified 2016-09-23 08:55:58 -04:00
fdc.c Fix spelling of "occurred". 2016-05-02 18:37:09 -04:00
fdt.c fdt: Check for NULL return from fdt_getprop in 'fdt set' 2017-07-11 10:08:20 -06:00
fitupd.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
flash.c flash: complete CONFIG_SYS_NO_FLASH move with renaming 2017-02-12 14:30:25 -05:00
fpga.c fpga: Use enum for bitstream command types 2017-01-10 10:21:59 +01:00
fpgad.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
fs.c efi_loader: Pass file path to payload 2016-04-18 17:11:36 -04:00
fs_uuid.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
fuse.c treewide: replace #include <asm/errno.h> with <linux/errno.h> 2016-09-23 17:55:42 -04:00
gettime.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
gpio.c gpio: Report errors when GPIOs cannot be read 2016-03-17 21:27:37 -06:00
gpt.c gpt: harden set_gpt_info() against non NULL-terminated strings 2017-08-04 20:38:32 -04:00
hash.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
help.c Drop command-processing code when CONFIG_CMDLINE is disabled 2016-04-01 17:17:40 -04:00
host.c cmd/host: add missing \n in help text 2017-01-20 09:15:24 -05:00
i2c.c i2c: Set default I2C bus number 2017-03-28 06:27:54 +02:00
ide.c powerpc, 8xx: remove support for 8xx 2017-06-12 08:37:55 -04:00
ini.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
io.c cmd/io.c: Fix comparison of unsigned expression warning 2017-05-12 08:37:38 -04:00
iotrace.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
irq.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
itest.c cmd: itest: correct calculus for long format 2017-03-17 14:15:10 -04:00
jffs2.c cmd: jffs2: use get_nand_dev_by_index() 2017-07-11 22:41:46 -04:00
Kconfig GPT: provide commands to selectively rename partitions 2017-08-04 20:35:27 -04:00
led.c cmd/led.c: Remove unnecessary check on 'cmd' value 2017-05-12 08:37:38 -04:00
legacy_led.c led: Mark existing driver as legacy 2017-04-14 19:38:57 -06:00
license.c cmd: rework "license" command 2017-02-08 15:56:28 -05:00
load.c flash: complete CONFIG_SYS_NO_FLASH move with renaming 2017-02-12 14:30:25 -05:00
log.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
lzmadec.c lzmadec: Use the same type as the lzma call 2016-07-25 12:05:54 -04:00
mac.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
Makefile powerpc: remove 4xx support 2017-07-03 17:35:28 -04:00
md5sum.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
mdio.c common: miiphyutil: Work and report phy address in hex in mdio cmd 2016-12-02 14:36:02 +01:00
mem.c Kconfig: Finish migration of hashing commands 2017-05-31 19:38:14 -04:00
mfsl.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
mii.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
misc.c cmd: misc: Add support for fractions in sleep 2016-07-25 12:00:05 -04:00
mmc.c mmc: use new hwpart API when CONFIG_BLK enabled 2017-07-19 19:13:59 +09:00
mmc_spi.c dm: block: Rename device number member dev to devnum 2016-03-14 15:34:50 -06:00
mp.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
mtdparts.c cmd: mtdparts: fix uninitialized variable warning 2017-06-12 08:38:42 -04:00
nand.c cmd: nand: remove direct access to struct mtd_info->priv 2017-07-11 22:41:47 -04:00
net.c cmd: net: fix function name in comment 2016-12-27 11:24:18 -05:00
nvedit.c cmd: nvedit: bring error message in sync with condition under which it appears 2017-06-12 08:38:43 -04:00
onenand.c cmd/onenand.c: block align warning 2016-10-06 20:57:42 -04:00
part.c cmd, disk: convert CONFIG_PARTITION_UUIDS, CMD_PART and CMD_GPT 2017-01-28 08:48:03 -05:00
pci.c pci: Correct cast for sandbox 2017-06-02 10:16:46 -06:00
pcmcia.c powerpc, 8xx: remove support for 8xx 2017-06-12 08:37:55 -04:00
pmic.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
portio.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
pxe.c pxe: Fix pxe boot with FIT image 2016-09-07 08:49:02 -04:00
qfw.c cmd: qfw: do not require default macros when building qfw command 2016-05-23 15:18:00 +08:00
read.c dm: block: Adjust device calls to go through helpers function 2016-03-14 15:34:50 -06:00
reginfo.c powerpc: Remove unneccessary #ifdefs in reginfo 2017-07-22 22:22:49 -04:00
regulator.c power: regulator: Introduce regulator_set_value_force function 2016-11-25 10:00:04 -07:00
reiser.c disk: convert CONFIG_DOS_PARTITION to Kconfig 2017-01-28 08:47:34 -05:00
remoteproc.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
sata.c cmd: sata: fix init command return value 2017-01-14 16:46:23 -05:00
scsi.c cmd: scsi: Fix null pointer dereference in 'scsi reset' 2017-07-28 12:02:47 -06:00
setexpr.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
sf.c dm: core: Add flags parameter to device_remove() 2017-04-04 20:15:10 -06:00
sha1sum.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
sound.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
source.c powerpc, 8xx: remove support for 8xx 2017-06-12 08:37:55 -04:00
spi.c cmd: spi: check return value of strdup 2016-03-27 09:12:55 -04:00
spl.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
strings.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
terminal.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
test.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
thordown.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
time.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
tpm.c lib: tpm: Add command to list resources 2017-03-26 13:22:58 -06:00
tpm_test.c cmd/tpm_test: Fix misleading code indentation 2016-12-02 10:37:47 -07:00
trace.c trace: Fix compiler warnings in trace 2016-02-26 08:53:10 -07:00
tsi148.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
ubi.c cmd: ubi: remove unnecessary logical constraint 2017-04-18 06:08:32 +02:00
ubifs.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
universe.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
unzip.c dm: blk: Rename get_device() to blk_get_device_by_str() 2016-03-14 15:34:50 -06:00
usb.c usb: cmd: Print actual packet size for super speed devices 2017-07-28 23:34:25 +02:00
usb_mass_storage.c cmd: usb_mass_storage: Staticize do_usb_mass_storage() 2017-06-18 21:11:10 +02:00
version.c display_options: Refactor to allow obtaining the banner 2017-07-11 10:08:19 -06:00
ximg.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
yaffs2.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00
zfs.c disk: convert CONFIG_EFI_PARTITION to Kconfig 2017-01-28 08:47:42 -05:00
zip.c Remove the cmd_ prefix from command files 2016-01-25 10:39:43 -05:00