mirror of
https://github.com/AsahiLinux/u-boot
synced 2024-11-16 01:38:22 +00:00
35b65dd8ef
Historically, the reset_cpu() function had an `addr` parameter which was
meant to pass in an address of the reset vector location, where the CPU
should reset to. This feature is no longer used anywhere in U-Boot as
all reset_cpu() implementations now ignore the passed value. Generic
code has been added which always calls reset_cpu() with `0` which means
this feature can no longer be used easily anyway.
Over time, many implementations seem to have "misunderstood" the
existence of this parameter as a way to customize/parameterize the reset
(e.g. COLD vs WARM resets). As this is not properly supported, the
code will almost always not do what it is intended to (because all
call-sites just call reset_cpu() with 0).
To avoid confusion and to clean up the codebase from unused left-overs
of the past, remove the `addr` parameter entirely. Code which intends
to support different kinds of resets should be rewritten as a sysreset
driver instead.
This transformation was done with the following coccinelle patch:
@@
expression argvalue;
@@
- reset_cpu(argvalue)
+ reset_cpu()
@@
identifier argname;
type argtype;
@@
- reset_cpu(argtype argname)
+ reset_cpu(void)
{ ... }
Signed-off-by: Harald Seiler <hws@denx.de>
Reviewed-by: Simon Glass <sjg@chromium.org>
60 lines
1.2 KiB
C
60 lines
1.2 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* R-Car Gen3 recovery SPL
|
|
*
|
|
* Copyright (C) 2019 Marek Vasut <marek.vasut@gmail.com>
|
|
*/
|
|
|
|
#include <common.h>
|
|
#include <cpu_func.h>
|
|
#include <image.h>
|
|
#include <init.h>
|
|
#include <log.h>
|
|
#include <asm/io.h>
|
|
#include <spl.h>
|
|
#include <linux/bitops.h>
|
|
|
|
#define RCAR_CNTC_BASE 0xE6080000
|
|
#define CNTCR_EN BIT(0)
|
|
|
|
void board_init_f(ulong dummy)
|
|
{
|
|
writel(CNTCR_EN, RCAR_CNTC_BASE);
|
|
timer_init();
|
|
}
|
|
|
|
void spl_board_init(void)
|
|
{
|
|
/* UART clocks enabled and gd valid - init serial console */
|
|
preloader_console_init();
|
|
}
|
|
|
|
u32 spl_boot_device(void)
|
|
{
|
|
return BOOT_DEVICE_UART;
|
|
}
|
|
|
|
void __noreturn jump_to_image_no_args(struct spl_image_info *spl_image)
|
|
{
|
|
debug("image entry point: 0x%lx\n", spl_image->entry_point);
|
|
if (spl_image->os == IH_OS_ARM_TRUSTED_FIRMWARE) {
|
|
typedef void (*image_entry_arg_t)(int, int, int, int)
|
|
__attribute__ ((noreturn));
|
|
image_entry_arg_t image_entry =
|
|
(image_entry_arg_t)(uintptr_t) spl_image->entry_point;
|
|
image_entry(IH_MAGIC, CONFIG_SPL_TEXT_BASE, 0, 0);
|
|
} else {
|
|
typedef void __noreturn (*image_entry_noargs_t)(void);
|
|
image_entry_noargs_t image_entry =
|
|
(image_entry_noargs_t)spl_image->entry_point;
|
|
image_entry();
|
|
}
|
|
}
|
|
|
|
void s_init(void)
|
|
{
|
|
}
|
|
|
|
void reset_cpu(void)
|
|
{
|
|
}
|