u-boot/board/esd/cpci750
Wolfgang Denk 54841ab50c Make sure that argv[] argument pointers are not modified.
The hush shell dynamically allocates (and re-allocates) memory for the
argument strings in the "char *argv[]" argument vector passed to
commands.  Any code that modifies these pointers will cause serious
corruption of the malloc data structures and crash U-Boot, so make
sure the compiler can check that no such modifications are being done
by changing the code into "char * const argv[]".

This modification is the result of debugging a strange crash caused
after adding a new command, which used the following argument
processing code which has been working perfectly fine in all Unix
systems since version 6 - but not so in U-Boot:

int main (int argc, char **argv)
{
	while (--argc > 0 && **++argv == '-') {
/* ====> */	while (*++*argv) {
			switch (**argv) {
			case 'd':
				debug++;
				break;
			...
			default:
				usage ();
			}
		}
	}
	...
}

The line marked "====>" will corrupt the malloc data structures and
usually cause U-Boot to crash when the next command gets executed by
the shell.  With the modification, the compiler will prevent this with
an
	error: increment of read-only location '*argv'

N.B.: The code above can be trivially rewritten like this:

	while (--argc > 0 && **++argv == '-') {
		char *arg = *argv;
		while (*++arg) {
			switch (*arg) {
			...

Signed-off-by: Wolfgang Denk <wd@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
2010-07-04 23:55:42 +02:00
..
64360.h CPCI750 board support added 2004-12-16 18:21:17 +00:00
config.mk CPCI750 board support added 2004-12-16 18:21:17 +00:00
cpci750.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
eth.h CPCI750 board support added 2004-12-16 18:21:17 +00:00
i2c.c cpci750: i2c cleanup 2009-06-12 20:39:45 +02:00
i2c.h CPCI750 board support added 2004-12-16 18:21:17 +00:00
ide.c board/esd/cpci750/ide.c: fix compile warning 2009-09-15 00:13:15 +02:00
local.h rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
Makefile Move "ar" flags to config.mk to allow for silent "make -s" 2006-10-09 01:02:05 +02:00
misc.S rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
mpsc.c rename CFG_ macros to CONFIG_SYS 2008-10-18 21:54:03 +02:00
mpsc.h Big white-space cleanup. 2008-05-21 00:14:08 +02:00
mv_eth.c Move arch/ppc to arch/powerpc 2010-04-21 23:42:38 +02:00
mv_eth.h CPCI750: fix compile problem 2009-07-18 15:05:44 +02:00
mv_regs.h CPCI750 board support added 2004-12-16 18:21:17 +00:00
pci.c 74xx_7xx: CPCI750: Add CPCI adapter/target support 2009-06-12 20:47:18 +02:00
sdram_init.c Make sure that argv[] argument pointers are not modified. 2010-07-04 23:55:42 +02:00
serial.c board/[A-Za-i]*: Remove lingering references to CFG_CMD_* symbols. 2007-07-10 10:39:10 -05:00
serial.h CPCI750 board support added 2004-12-16 18:21:17 +00:00
u-boot.lds Move arch/ppc to arch/powerpc 2010-04-21 23:42:38 +02:00