2018-05-06 21:58:06 +00:00
|
|
|
// SPDX-License-Identifier: GPL-2.0+
|
2009-07-20 07:59:37 +00:00
|
|
|
/*
|
2010-08-27 16:26:05 +00:00
|
|
|
* Driver for the TWSI (i2c) controller found on the Marvell
|
|
|
|
* orion5x and kirkwood SoC families.
|
2009-07-20 07:59:37 +00:00
|
|
|
*
|
2011-04-22 17:41:02 +00:00
|
|
|
* Author: Albert Aribaud <albert.u.boot@aribaud.net>
|
2010-08-27 16:26:05 +00:00
|
|
|
* Copyright (c) 2010 Albert Aribaud.
|
2009-07-20 07:59:37 +00:00
|
|
|
*/
|
2010-08-27 16:26:05 +00:00
|
|
|
|
2009-07-20 07:59:37 +00:00
|
|
|
#include <common.h>
|
|
|
|
#include <i2c.h>
|
2020-05-10 17:40:05 +00:00
|
|
|
#include <log.h>
|
2020-10-31 03:38:53 +00:00
|
|
|
#include <asm/global_data.h>
|
2020-05-10 17:40:11 +00:00
|
|
|
#include <linux/delay.h>
|
2016-09-21 02:28:55 +00:00
|
|
|
#include <linux/errno.h>
|
2009-07-20 07:59:37 +00:00
|
|
|
#include <asm/io.h>
|
2018-06-07 09:38:10 +00:00
|
|
|
#include <linux/bitops.h>
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
#include <linux/compat.h>
|
2021-02-09 11:52:45 +00:00
|
|
|
#if CONFIG_IS_ENABLED(DM_I2C)
|
2021-09-12 15:21:39 +00:00
|
|
|
#include <clk.h>
|
2016-07-21 09:57:10 +00:00
|
|
|
#include <dm.h>
|
2021-09-12 15:21:39 +00:00
|
|
|
#include <reset.h>
|
2016-07-21 09:57:10 +00:00
|
|
|
#endif
|
|
|
|
|
|
|
|
DECLARE_GLOBAL_DATA_PTR;
|
2009-07-20 07:59:37 +00:00
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:03 +00:00
|
|
|
* Include a file that will provide CONFIG_I2C_MVTWSI_BASE*, and possibly other
|
|
|
|
* settings
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
2009-07-20 07:59:37 +00:00
|
|
|
|
2021-02-09 11:52:45 +00:00
|
|
|
#if !CONFIG_IS_ENABLED(DM_I2C)
|
2020-05-06 12:02:38 +00:00
|
|
|
#if defined(CONFIG_ARCH_ORION5X)
|
2010-08-27 16:26:05 +00:00
|
|
|
#include <asm/arch/orion5x.h>
|
2020-05-06 12:02:40 +00:00
|
|
|
#elif (defined(CONFIG_ARCH_KIRKWOOD) || defined(CONFIG_ARCH_MVEBU))
|
2014-10-22 10:13:06 +00:00
|
|
|
#include <asm/arch/soc.h>
|
2016-10-13 08:49:35 +00:00
|
|
|
#elif defined(CONFIG_ARCH_SUNXI)
|
2014-06-13 20:55:49 +00:00
|
|
|
#include <asm/arch/i2c.h>
|
2010-08-27 16:26:05 +00:00
|
|
|
#else
|
|
|
|
#error Driver mvtwsi not supported by SoC or board
|
2009-07-20 07:59:37 +00:00
|
|
|
#endif
|
2016-07-21 09:57:10 +00:00
|
|
|
#endif /* CONFIG_DM_I2C */
|
2009-07-20 07:59:37 +00:00
|
|
|
|
2017-04-26 22:03:36 +00:00
|
|
|
/*
|
2022-11-16 18:10:41 +00:00
|
|
|
* On SUNXI, we get CFG_SYS_TCLK from this include, so we want to
|
2017-04-26 22:03:36 +00:00
|
|
|
* always have it.
|
|
|
|
*/
|
2021-02-09 11:52:45 +00:00
|
|
|
#if CONFIG_IS_ENABLED(DM_I2C) && defined(CONFIG_ARCH_SUNXI)
|
2017-04-26 22:03:36 +00:00
|
|
|
#include <asm/arch/i2c.h>
|
|
|
|
#endif
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
|
|
|
* TWSI register structure
|
|
|
|
*/
|
2009-07-20 07:59:37 +00:00
|
|
|
|
2016-10-13 08:49:35 +00:00
|
|
|
#ifdef CONFIG_ARCH_SUNXI
|
2014-06-13 20:55:49 +00:00
|
|
|
|
|
|
|
struct mvtwsi_registers {
|
|
|
|
u32 slave_address;
|
|
|
|
u32 xtnd_slave_addr;
|
|
|
|
u32 data;
|
|
|
|
u32 control;
|
|
|
|
u32 status;
|
|
|
|
u32 baudrate;
|
|
|
|
u32 soft_reset;
|
2018-06-07 09:38:10 +00:00
|
|
|
u32 debug; /* Dummy field for build compatibility with mvebu */
|
2014-06-13 20:55:49 +00:00
|
|
|
};
|
|
|
|
|
|
|
|
#else
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
struct mvtwsi_registers {
|
|
|
|
u32 slave_address;
|
|
|
|
u32 data;
|
|
|
|
u32 control;
|
|
|
|
union {
|
2016-07-21 09:57:03 +00:00
|
|
|
u32 status; /* When reading */
|
|
|
|
u32 baudrate; /* When writing */
|
2010-08-27 16:26:05 +00:00
|
|
|
};
|
|
|
|
u32 xtnd_slave_addr;
|
2018-06-07 09:38:10 +00:00
|
|
|
u32 reserved0[2];
|
2010-08-27 16:26:05 +00:00
|
|
|
u32 soft_reset;
|
2018-06-07 09:38:10 +00:00
|
|
|
u32 reserved1[27];
|
|
|
|
u32 debug;
|
2009-07-20 07:59:37 +00:00
|
|
|
};
|
|
|
|
|
2014-06-13 20:55:49 +00:00
|
|
|
#endif
|
|
|
|
|
2021-02-09 11:52:45 +00:00
|
|
|
#if CONFIG_IS_ENABLED(DM_I2C)
|
2016-07-21 09:57:10 +00:00
|
|
|
struct mvtwsi_i2c_dev {
|
|
|
|
/* TWSI Register base for the device */
|
|
|
|
struct mvtwsi_registers *base;
|
|
|
|
/* Number of the device (determined from cell-index property) */
|
|
|
|
int index;
|
|
|
|
/* The I2C slave address for the device */
|
|
|
|
u8 slaveadd;
|
|
|
|
/* The configured I2C speed in Hz */
|
|
|
|
uint speed;
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
/* The current length of a clock period (depending on speed) */
|
|
|
|
uint tick;
|
2016-07-21 09:57:10 +00:00
|
|
|
};
|
|
|
|
#endif /* CONFIG_DM_I2C */
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:02 +00:00
|
|
|
* enum mvtwsi_ctrl_register_fields - Bit masks for flags in the control
|
|
|
|
* register
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
2016-07-21 09:57:02 +00:00
|
|
|
enum mvtwsi_ctrl_register_fields {
|
|
|
|
/* Acknowledge bit */
|
|
|
|
MVTWSI_CONTROL_ACK = 0x00000004,
|
|
|
|
/* Interrupt flag */
|
|
|
|
MVTWSI_CONTROL_IFLG = 0x00000008,
|
|
|
|
/* Stop bit */
|
|
|
|
MVTWSI_CONTROL_STOP = 0x00000010,
|
|
|
|
/* Start bit */
|
|
|
|
MVTWSI_CONTROL_START = 0x00000020,
|
|
|
|
/* I2C enable */
|
|
|
|
MVTWSI_CONTROL_TWSIEN = 0x00000040,
|
|
|
|
/* Interrupt enable */
|
|
|
|
MVTWSI_CONTROL_INTEN = 0x00000080,
|
|
|
|
};
|
2009-07-20 07:59:37 +00:00
|
|
|
|
2016-01-14 13:06:25 +00:00
|
|
|
/*
|
2016-07-21 09:57:03 +00:00
|
|
|
* On sun6i and newer, IFLG is a write-clear bit, which is cleared by writing 1;
|
|
|
|
* on other platforms, it is a normal r/w bit, which is cleared by writing 0.
|
2016-01-14 13:06:25 +00:00
|
|
|
*/
|
|
|
|
|
2022-10-05 16:54:19 +00:00
|
|
|
#if defined(CONFIG_SUNXI_GEN_SUN6I) || defined(CONFIG_SUN50I_GEN_H6) || \
|
|
|
|
defined(CONFIG_SUNXI_GEN_NCAT2)
|
2016-01-14 13:06:25 +00:00
|
|
|
#define MVTWSI_CONTROL_CLEAR_IFLG 0x00000008
|
|
|
|
#else
|
|
|
|
#define MVTWSI_CONTROL_CLEAR_IFLG 0x00000000
|
|
|
|
#endif
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:02 +00:00
|
|
|
* enum mvstwsi_status_values - Possible values of I2C controller's status
|
|
|
|
* register
|
|
|
|
*
|
|
|
|
* Only those statuses expected in normal master operation on
|
|
|
|
* non-10-bit-address devices are specified.
|
|
|
|
*
|
|
|
|
* Every status that's unexpected during normal operation (bus errors,
|
|
|
|
* arbitration losses, missing ACKs...) is passed back to the caller as an error
|
2010-08-27 16:26:05 +00:00
|
|
|
* code.
|
|
|
|
*/
|
2016-07-21 09:57:02 +00:00
|
|
|
enum mvstwsi_status_values {
|
i2c: mvtwsi: reset controller if stuck in "bus error" state
The MVTWSI controller can act either as a master or slave device. When
acting as a master, the FSM is driven by the CPU. As a slave, the FSM is
driven by the bus directly. In what is (apparently) a safety mechanism,
if the bus transitions our FSM in any improper way, the FSM goes to a
"bus error" state (0x00). I could find no documented or experimental way
to get the FSM out of this state, except for a controller reset.
Since U-Boot only uses the MVTWSI controller as a bus master, this
feature only gets in the way: we do not care what happened on the bus
previously as long as the bus is ready for a new transaction. So, when
trying to start a new transaction, check for this state and reset the
controller if necessary.
Note that this should not be confused with the "deblocking" technique
(used by the `i2c reset` command), which involves pulsing SCL repeatedly
if SDA is found to be held low, in an attempt to force the bus back to
an idle state. This patch only resets the controller in case something
else had previously upset it, and (in principle) results in no
externally-observable change in behavior.
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Heiko Schocher <hs@denx.de>
2023-07-25 22:13:05 +00:00
|
|
|
/* Protocol violation on bus; this is a terminal state */
|
|
|
|
MVTWSI_BUS_ERROR = 0x00,
|
2016-07-21 09:57:02 +00:00
|
|
|
/* START condition transmitted */
|
|
|
|
MVTWSI_STATUS_START = 0x08,
|
|
|
|
/* Repeated START condition transmitted */
|
|
|
|
MVTWSI_STATUS_REPEATED_START = 0x10,
|
|
|
|
/* Address + write bit transmitted, ACK received */
|
|
|
|
MVTWSI_STATUS_ADDR_W_ACK = 0x18,
|
|
|
|
/* Data transmitted, ACK received */
|
|
|
|
MVTWSI_STATUS_DATA_W_ACK = 0x28,
|
|
|
|
/* Address + read bit transmitted, ACK received */
|
|
|
|
MVTWSI_STATUS_ADDR_R_ACK = 0x40,
|
|
|
|
/* Address + read bit transmitted, ACK not received */
|
|
|
|
MVTWSI_STATUS_ADDR_R_NAK = 0x48,
|
|
|
|
/* Data received, ACK transmitted */
|
|
|
|
MVTWSI_STATUS_DATA_R_ACK = 0x50,
|
|
|
|
/* Data received, ACK not transmitted */
|
|
|
|
MVTWSI_STATUS_DATA_R_NAK = 0x58,
|
|
|
|
/* No relevant status */
|
|
|
|
MVTWSI_STATUS_IDLE = 0xF8,
|
|
|
|
};
|
2010-08-27 16:26:05 +00:00
|
|
|
|
i2c: mvtwsi: Eliminate flags parameter
Due to breaking boots from NOR flashes, commit d6b7757 ("i2c: mvtwsi:
Eliminate twsi_control_flags") removed the static global
twsi_control_flags variable, which kept a set of default flags that were
always or'd to the control register when writing. It was replaced with a
flags parameter, which was passed around between the functions that
needed it.
Since the twsi_control_flags variable was used just for the purposes of
a) setting the MVTWSI_CONTROL_TWSIEN on every control register write,
and
b) setting the MVTWSI_CONTROL_ACK from twsi_i2c_read if needed,
anyway, the added overhead of another variable being passed around is no
longer justified, and we are better off implementing this flag setting
logic locally in the functions that actually write to the control
register.
Therefore, this patch sets MVTWSI_CONTROL_TWSIEN on every control
register write, replaces the twsi_i2c_read's flags parameter with a
ack_flag parameter, which tells the function whether to acknowledge the
read or not, and removes every other instance of the flags variable.
This has the added benefit that now every notion of "global default
flags" is gone, and it's much easier to see which control flags are
actually set at which point in time.
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:04 +00:00
|
|
|
/*
|
|
|
|
* enum mvstwsi_ack_flags - Determine whether a read byte should be
|
|
|
|
* acknowledged or not.
|
|
|
|
*/
|
|
|
|
enum mvtwsi_ack_flags {
|
|
|
|
/* Send NAK after received byte */
|
|
|
|
MVTWSI_READ_NAK = 0,
|
|
|
|
/* Send ACK after received byte */
|
|
|
|
MVTWSI_READ_ACK = 1,
|
|
|
|
};
|
|
|
|
|
2016-07-21 09:57:13 +00:00
|
|
|
/*
|
|
|
|
* calc_tick() - Calculate the duration of a clock cycle from the I2C speed
|
|
|
|
*
|
|
|
|
* @speed: The speed in Hz to calculate the clock cycle duration for.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: The duration of a clock cycle in ns.
|
2016-07-21 09:57:13 +00:00
|
|
|
*/
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
inline uint calc_tick(uint speed)
|
|
|
|
{
|
|
|
|
/* One tick = the duration of a period at the specified speed in ns (we
|
|
|
|
* add 100 ns to be on the safe side) */
|
|
|
|
return (1000000000u / speed) + 100;
|
|
|
|
}
|
|
|
|
|
2021-02-09 11:52:45 +00:00
|
|
|
#if !CONFIG_IS_ENABLED(DM_I2C)
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* twsi_get_base() - Get controller register base for specified adapter
|
|
|
|
*
|
|
|
|
* @adap: Adapter to get the register base for.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Register base for the specified adapter.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
2015-04-10 21:09:51 +00:00
|
|
|
static struct mvtwsi_registers *twsi_get_base(struct i2c_adapter *adap)
|
|
|
|
{
|
|
|
|
switch (adap->hwadapnr) {
|
2022-12-04 15:04:09 +00:00
|
|
|
#ifdef CFG_I2C_MVTWSI_BASE0
|
2015-04-10 21:09:51 +00:00
|
|
|
case 0:
|
2022-12-04 15:04:09 +00:00
|
|
|
return (struct mvtwsi_registers *)CFG_I2C_MVTWSI_BASE0;
|
2015-04-10 21:09:51 +00:00
|
|
|
#endif
|
2022-12-04 15:04:10 +00:00
|
|
|
#ifdef CFG_I2C_MVTWSI_BASE1
|
2015-04-10 21:09:51 +00:00
|
|
|
case 1:
|
2022-12-04 15:04:10 +00:00
|
|
|
return (struct mvtwsi_registers *)CFG_I2C_MVTWSI_BASE1;
|
2015-04-10 21:09:51 +00:00
|
|
|
#endif
|
2023-01-10 16:19:45 +00:00
|
|
|
#ifdef CFG_I2C_MVTWSI_BASE2
|
2015-04-10 21:09:51 +00:00
|
|
|
case 2:
|
2023-01-10 16:19:45 +00:00
|
|
|
return (struct mvtwsi_registers *)CFG_I2C_MVTWSI_BASE2;
|
2015-04-10 21:09:51 +00:00
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_I2C_MVTWSI_BASE3
|
|
|
|
case 3:
|
2016-07-21 09:57:01 +00:00
|
|
|
return (struct mvtwsi_registers *)CONFIG_I2C_MVTWSI_BASE3;
|
2015-04-10 21:09:51 +00:00
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_I2C_MVTWSI_BASE4
|
|
|
|
case 4:
|
2016-07-21 09:57:01 +00:00
|
|
|
return (struct mvtwsi_registers *)CONFIG_I2C_MVTWSI_BASE4;
|
2016-01-14 13:06:26 +00:00
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_I2C_MVTWSI_BASE5
|
|
|
|
case 5:
|
2016-07-21 09:57:01 +00:00
|
|
|
return (struct mvtwsi_registers *)CONFIG_I2C_MVTWSI_BASE5;
|
2015-04-10 21:09:51 +00:00
|
|
|
#endif
|
|
|
|
default:
|
|
|
|
printf("Missing mvtwsi controller %d base\n", adap->hwadapnr);
|
|
|
|
break;
|
|
|
|
}
|
|
|
|
|
|
|
|
return NULL;
|
|
|
|
}
|
2016-07-21 09:57:10 +00:00
|
|
|
#endif
|
2009-07-20 07:59:37 +00:00
|
|
|
|
|
|
|
/*
|
2016-07-21 09:57:02 +00:00
|
|
|
* enum mvtwsi_error_class - types of I2C errors
|
2009-07-20 07:59:37 +00:00
|
|
|
*/
|
2016-07-21 09:57:02 +00:00
|
|
|
enum mvtwsi_error_class {
|
|
|
|
/* The controller returned a different status than expected */
|
|
|
|
MVTWSI_ERROR_WRONG_STATUS = 0x01,
|
|
|
|
/* The controller timed out */
|
|
|
|
MVTWSI_ERROR_TIMEOUT = 0x02,
|
|
|
|
};
|
2009-07-20 07:59:37 +00:00
|
|
|
|
2016-07-21 09:57:02 +00:00
|
|
|
/*
|
|
|
|
* mvtwsi_error() - Build I2C return code from error information
|
|
|
|
*
|
|
|
|
* For debugging purposes, this function packs some information of an occurred
|
|
|
|
* error into a return code. These error codes are returned from I2C API
|
|
|
|
* functions (i2c_{read,write}, dm_i2c_{read,write}, etc.).
|
|
|
|
*
|
|
|
|
* @ec: The error class of the error (enum mvtwsi_error_class).
|
|
|
|
* @lc: The last value of the control register.
|
|
|
|
* @ls: The last value of the status register.
|
|
|
|
* @es: The expected value of the status register.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: The generated error code.
|
2016-07-21 09:57:02 +00:00
|
|
|
*/
|
|
|
|
inline uint mvtwsi_error(uint ec, uint lc, uint ls, uint es)
|
|
|
|
{
|
|
|
|
return ((ec << 24) & 0xFF000000)
|
|
|
|
| ((lc << 16) & 0x00FF0000)
|
|
|
|
| ((ls << 8) & 0x0000FF00)
|
|
|
|
| (es & 0xFF);
|
|
|
|
}
|
2009-07-20 07:59:37 +00:00
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* twsi_wait() - Wait for I2C bus interrupt flag and check status, or time out.
|
|
|
|
*
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if status is as expected, or a non-zero code if either a time
|
2016-07-21 09:57:13 +00:00
|
|
|
* out occurred, or the status was not the expected one.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
static int twsi_wait(struct mvtwsi_registers *twsi, int expected_status,
|
|
|
|
uint tick)
|
2010-08-27 16:26:05 +00:00
|
|
|
{
|
|
|
|
int control, status;
|
|
|
|
int timeout = 1000;
|
|
|
|
|
|
|
|
do {
|
|
|
|
control = readl(&twsi->control);
|
|
|
|
if (control & MVTWSI_CONTROL_IFLG) {
|
2019-05-02 14:53:38 +00:00
|
|
|
/*
|
|
|
|
* On Armada 38x it seems that the controller works as
|
|
|
|
* if it first set the MVTWSI_CONTROL_IFLAG in the
|
|
|
|
* control register and only after that it changed the
|
|
|
|
* status register.
|
|
|
|
* This sometimes caused weird bugs which only appeared
|
|
|
|
* on selected I2C speeds and even then only sometimes.
|
|
|
|
* We therefore add here a simple ndealy(100), which
|
|
|
|
* seems to fix this weird bug.
|
|
|
|
*/
|
|
|
|
ndelay(100);
|
2010-08-27 16:26:05 +00:00
|
|
|
status = readl(&twsi->status);
|
|
|
|
if (status == expected_status)
|
|
|
|
return 0;
|
|
|
|
else
|
2016-07-21 09:57:02 +00:00
|
|
|
return mvtwsi_error(
|
2010-08-27 16:26:05 +00:00
|
|
|
MVTWSI_ERROR_WRONG_STATUS,
|
|
|
|
control, status, expected_status);
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
ndelay(tick); /* One clock cycle */
|
2010-08-27 16:26:05 +00:00
|
|
|
} while (timeout--);
|
|
|
|
status = readl(&twsi->status);
|
2016-07-21 09:57:02 +00:00
|
|
|
return mvtwsi_error(MVTWSI_ERROR_TIMEOUT, control, status,
|
|
|
|
expected_status);
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* twsi_start() - Assert a START condition on the bus.
|
|
|
|
*
|
|
|
|
* This function is used in both single I2C transactions and inside
|
|
|
|
* back-to-back transactions (repeated starts).
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @expected_status: The I2C bus status expected to be asserted after the
|
|
|
|
* operation completion.
|
|
|
|
* @tick: The duration of a clock cycle at the current I2C speed.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if status is as expected, or a non-zero code if either a time
|
2016-07-21 09:57:13 +00:00
|
|
|
* out occurred or the status was not the expected one.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
static int twsi_start(struct mvtwsi_registers *twsi, int expected_status,
|
|
|
|
uint tick)
|
2009-07-20 07:59:37 +00:00
|
|
|
{
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Assert START */
|
i2c: mvtwsi: Eliminate flags parameter
Due to breaking boots from NOR flashes, commit d6b7757 ("i2c: mvtwsi:
Eliminate twsi_control_flags") removed the static global
twsi_control_flags variable, which kept a set of default flags that were
always or'd to the control register when writing. It was replaced with a
flags parameter, which was passed around between the functions that
needed it.
Since the twsi_control_flags variable was used just for the purposes of
a) setting the MVTWSI_CONTROL_TWSIEN on every control register write,
and
b) setting the MVTWSI_CONTROL_ACK from twsi_i2c_read if needed,
anyway, the added overhead of another variable being passed around is no
longer justified, and we are better off implementing this flag setting
logic locally in the functions that actually write to the control
register.
Therefore, this patch sets MVTWSI_CONTROL_TWSIEN on every control
register write, replaces the twsi_i2c_read's flags parameter with a
ack_flag parameter, which tells the function whether to acknowledge the
read or not, and removes every other instance of the flags variable.
This has the added benefit that now every notion of "global default
flags" is gone, and it's much easier to see which control flags are
actually set at which point in time.
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:04 +00:00
|
|
|
writel(MVTWSI_CONTROL_TWSIEN | MVTWSI_CONTROL_START |
|
2016-07-21 09:57:03 +00:00
|
|
|
MVTWSI_CONTROL_CLEAR_IFLG, &twsi->control);
|
|
|
|
/* Wait for controller to process START */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
return twsi_wait(twsi, expected_status, tick);
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* twsi_send() - Send a byte on the I2C bus.
|
|
|
|
*
|
|
|
|
* The byte may be part of an address byte or data.
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @byte: The byte to send.
|
|
|
|
* @expected_status: The I2C bus status expected to be asserted after the
|
|
|
|
* operation completion.
|
|
|
|
* @tick: The duration of a clock cycle at the current I2C speed.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if status is as expected, or a non-zero code if either a time
|
2016-07-21 09:57:13 +00:00
|
|
|
* out occurred or the status was not the expected one.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
2016-07-21 09:57:08 +00:00
|
|
|
static int twsi_send(struct mvtwsi_registers *twsi, u8 byte,
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
int expected_status, uint tick)
|
2009-07-20 07:59:37 +00:00
|
|
|
{
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Write byte to data register for sending */
|
2010-08-27 16:26:05 +00:00
|
|
|
writel(byte, &twsi->data);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Clear any pending interrupt -- that will cause sending */
|
i2c: mvtwsi: Eliminate flags parameter
Due to breaking boots from NOR flashes, commit d6b7757 ("i2c: mvtwsi:
Eliminate twsi_control_flags") removed the static global
twsi_control_flags variable, which kept a set of default flags that were
always or'd to the control register when writing. It was replaced with a
flags parameter, which was passed around between the functions that
needed it.
Since the twsi_control_flags variable was used just for the purposes of
a) setting the MVTWSI_CONTROL_TWSIEN on every control register write,
and
b) setting the MVTWSI_CONTROL_ACK from twsi_i2c_read if needed,
anyway, the added overhead of another variable being passed around is no
longer justified, and we are better off implementing this flag setting
logic locally in the functions that actually write to the control
register.
Therefore, this patch sets MVTWSI_CONTROL_TWSIEN on every control
register write, replaces the twsi_i2c_read's flags parameter with a
ack_flag parameter, which tells the function whether to acknowledge the
read or not, and removes every other instance of the flags variable.
This has the added benefit that now every notion of "global default
flags" is gone, and it's much easier to see which control flags are
actually set at which point in time.
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:04 +00:00
|
|
|
writel(MVTWSI_CONTROL_TWSIEN | MVTWSI_CONTROL_CLEAR_IFLG,
|
|
|
|
&twsi->control);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Wait for controller to receive byte, and check ACK */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
return twsi_wait(twsi, expected_status, tick);
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* twsi_recv() - Receive a byte on the I2C bus.
|
|
|
|
*
|
|
|
|
* The static variable mvtwsi_control_flags controls whether we ack or nak.
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @byte: The byte to send.
|
|
|
|
* @ack_flag: Flag that determines whether the received byte should
|
|
|
|
* be acknowledged by the controller or not (sent ACK/NAK).
|
|
|
|
* @tick: The duration of a clock cycle at the current I2C speed.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if status is as expected, or a non-zero code if either a time
|
2016-07-21 09:57:13 +00:00
|
|
|
* out occurred or the status was not the expected one.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
static int twsi_recv(struct mvtwsi_registers *twsi, u8 *byte, int ack_flag,
|
|
|
|
uint tick)
|
2009-07-20 07:59:37 +00:00
|
|
|
{
|
i2c: mvtwsi: Eliminate flags parameter
Due to breaking boots from NOR flashes, commit d6b7757 ("i2c: mvtwsi:
Eliminate twsi_control_flags") removed the static global
twsi_control_flags variable, which kept a set of default flags that were
always or'd to the control register when writing. It was replaced with a
flags parameter, which was passed around between the functions that
needed it.
Since the twsi_control_flags variable was used just for the purposes of
a) setting the MVTWSI_CONTROL_TWSIEN on every control register write,
and
b) setting the MVTWSI_CONTROL_ACK from twsi_i2c_read if needed,
anyway, the added overhead of another variable being passed around is no
longer justified, and we are better off implementing this flag setting
logic locally in the functions that actually write to the control
register.
Therefore, this patch sets MVTWSI_CONTROL_TWSIEN on every control
register write, replaces the twsi_i2c_read's flags parameter with a
ack_flag parameter, which tells the function whether to acknowledge the
read or not, and removes every other instance of the flags variable.
This has the added benefit that now every notion of "global default
flags" is gone, and it's much easier to see which control flags are
actually set at which point in time.
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:04 +00:00
|
|
|
int expected_status, status, control;
|
2010-08-27 16:26:05 +00:00
|
|
|
|
i2c: mvtwsi: Eliminate flags parameter
Due to breaking boots from NOR flashes, commit d6b7757 ("i2c: mvtwsi:
Eliminate twsi_control_flags") removed the static global
twsi_control_flags variable, which kept a set of default flags that were
always or'd to the control register when writing. It was replaced with a
flags parameter, which was passed around between the functions that
needed it.
Since the twsi_control_flags variable was used just for the purposes of
a) setting the MVTWSI_CONTROL_TWSIEN on every control register write,
and
b) setting the MVTWSI_CONTROL_ACK from twsi_i2c_read if needed,
anyway, the added overhead of another variable being passed around is no
longer justified, and we are better off implementing this flag setting
logic locally in the functions that actually write to the control
register.
Therefore, this patch sets MVTWSI_CONTROL_TWSIEN on every control
register write, replaces the twsi_i2c_read's flags parameter with a
ack_flag parameter, which tells the function whether to acknowledge the
read or not, and removes every other instance of the flags variable.
This has the added benefit that now every notion of "global default
flags" is gone, and it's much easier to see which control flags are
actually set at which point in time.
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:04 +00:00
|
|
|
/* Compute expected status based on passed ACK flag */
|
|
|
|
expected_status = ack_flag ? MVTWSI_STATUS_DATA_R_ACK :
|
|
|
|
MVTWSI_STATUS_DATA_R_NAK;
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Acknowledge *previous state*, and launch receive */
|
i2c: mvtwsi: Eliminate flags parameter
Due to breaking boots from NOR flashes, commit d6b7757 ("i2c: mvtwsi:
Eliminate twsi_control_flags") removed the static global
twsi_control_flags variable, which kept a set of default flags that were
always or'd to the control register when writing. It was replaced with a
flags parameter, which was passed around between the functions that
needed it.
Since the twsi_control_flags variable was used just for the purposes of
a) setting the MVTWSI_CONTROL_TWSIEN on every control register write,
and
b) setting the MVTWSI_CONTROL_ACK from twsi_i2c_read if needed,
anyway, the added overhead of another variable being passed around is no
longer justified, and we are better off implementing this flag setting
logic locally in the functions that actually write to the control
register.
Therefore, this patch sets MVTWSI_CONTROL_TWSIEN on every control
register write, replaces the twsi_i2c_read's flags parameter with a
ack_flag parameter, which tells the function whether to acknowledge the
read or not, and removes every other instance of the flags variable.
This has the added benefit that now every notion of "global default
flags" is gone, and it's much easier to see which control flags are
actually set at which point in time.
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:04 +00:00
|
|
|
control = MVTWSI_CONTROL_TWSIEN;
|
|
|
|
control |= ack_flag == MVTWSI_READ_ACK ? MVTWSI_CONTROL_ACK : 0;
|
|
|
|
writel(control | MVTWSI_CONTROL_CLEAR_IFLG, &twsi->control);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Wait for controller to receive byte, and assert ACK or NAK */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
status = twsi_wait(twsi, expected_status, tick);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* If we did receive the expected byte, store it */
|
2010-08-27 16:26:05 +00:00
|
|
|
if (status == 0)
|
|
|
|
*byte = readl(&twsi->data);
|
|
|
|
return status;
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* twsi_stop() - Assert a STOP condition on the bus.
|
|
|
|
*
|
|
|
|
* This function is also used to force the bus back to idle state (SDA =
|
|
|
|
* SCL = 1).
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @tick: The duration of a clock cycle at the current I2C speed.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if the operation succeeded, or a non-zero code if a time out
|
2016-07-21 09:57:13 +00:00
|
|
|
* occurred.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
static int twsi_stop(struct mvtwsi_registers *twsi, uint tick)
|
2009-07-20 07:59:37 +00:00
|
|
|
{
|
2010-08-27 16:26:05 +00:00
|
|
|
int control, stop_status;
|
2016-07-21 09:57:05 +00:00
|
|
|
int status = 0;
|
2010-08-27 16:26:05 +00:00
|
|
|
int timeout = 1000;
|
|
|
|
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Assert STOP */
|
2010-08-27 16:26:05 +00:00
|
|
|
control = MVTWSI_CONTROL_TWSIEN | MVTWSI_CONTROL_STOP;
|
2016-01-14 13:06:25 +00:00
|
|
|
writel(control | MVTWSI_CONTROL_CLEAR_IFLG, &twsi->control);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Wait for IDLE; IFLG won't rise, so we can't use twsi_wait() */
|
2010-08-27 16:26:05 +00:00
|
|
|
do {
|
|
|
|
stop_status = readl(&twsi->status);
|
|
|
|
if (stop_status == MVTWSI_STATUS_IDLE)
|
|
|
|
break;
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
ndelay(tick); /* One clock cycle */
|
2010-08-27 16:26:05 +00:00
|
|
|
} while (timeout--);
|
|
|
|
control = readl(&twsi->control);
|
|
|
|
if (stop_status != MVTWSI_STATUS_IDLE)
|
2016-07-21 09:57:05 +00:00
|
|
|
status = mvtwsi_error(MVTWSI_ERROR_TIMEOUT,
|
|
|
|
control, status, MVTWSI_STATUS_IDLE);
|
2010-08-27 16:26:05 +00:00
|
|
|
return status;
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2016-07-21 09:57:13 +00:00
|
|
|
/*
|
|
|
|
* twsi_calc_freq() - Compute I2C frequency depending on m and n parameters.
|
|
|
|
*
|
|
|
|
* @n: Parameter 'n' for the frequency calculation algorithm.
|
|
|
|
* @m: Parameter 'm' for the frequency calculation algorithm.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: The I2C frequency corresponding to the passed m and n parameters.
|
2016-07-21 09:57:13 +00:00
|
|
|
*/
|
2016-07-21 09:57:06 +00:00
|
|
|
static uint twsi_calc_freq(const int n, const int m)
|
2015-03-18 08:30:54 +00:00
|
|
|
{
|
2016-10-13 08:49:35 +00:00
|
|
|
#ifdef CONFIG_ARCH_SUNXI
|
2022-11-16 18:10:41 +00:00
|
|
|
return CFG_SYS_TCLK / (10 * (m + 1) * (1 << n));
|
2015-03-18 08:30:54 +00:00
|
|
|
#else
|
2022-11-16 18:10:41 +00:00
|
|
|
return CFG_SYS_TCLK / (10 * (m + 1) * (2 << n));
|
2015-03-18 08:30:54 +00:00
|
|
|
#endif
|
|
|
|
}
|
2010-08-27 16:26:05 +00:00
|
|
|
|
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* twsi_reset() - Reset the I2C controller.
|
|
|
|
*
|
|
|
|
* Resetting the controller also resets the baud rate and slave address, hence
|
|
|
|
* they must be re-established after the reset.
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
2016-07-21 09:57:08 +00:00
|
|
|
static void twsi_reset(struct mvtwsi_registers *twsi)
|
2010-08-27 16:26:05 +00:00
|
|
|
{
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Reset controller */
|
2010-08-27 16:26:05 +00:00
|
|
|
writel(0, &twsi->soft_reset);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Wait 2 ms -- this is what the Marvell LSP does */
|
2010-08-27 16:26:05 +00:00
|
|
|
udelay(20000);
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* __twsi_i2c_set_bus_speed() - Set the speed of the I2C controller.
|
|
|
|
*
|
|
|
|
* This function sets baud rate to the highest possible value that does not
|
|
|
|
* exceed the requested rate.
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @requested_speed: The desired frequency the controller should run at
|
|
|
|
* in Hz.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: The actual frequency the controller was configured to.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
2016-07-21 09:57:08 +00:00
|
|
|
static uint __twsi_i2c_set_bus_speed(struct mvtwsi_registers *twsi,
|
2016-07-21 09:57:07 +00:00
|
|
|
uint requested_speed)
|
2009-07-20 07:59:37 +00:00
|
|
|
{
|
2016-07-21 09:57:06 +00:00
|
|
|
uint tmp_speed, highest_speed, n, m;
|
|
|
|
uint baud = 0x44; /* Baud rate after controller reset */
|
2010-08-27 16:26:05 +00:00
|
|
|
|
|
|
|
highest_speed = 0;
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Successively try m, n combinations, and use the combination
|
|
|
|
* resulting in the largest speed that's not above the requested
|
|
|
|
* speed */
|
2010-08-27 16:26:05 +00:00
|
|
|
for (n = 0; n < 8; n++) {
|
|
|
|
for (m = 0; m < 16; m++) {
|
2015-03-18 08:30:54 +00:00
|
|
|
tmp_speed = twsi_calc_freq(n, m);
|
2016-07-21 09:57:01 +00:00
|
|
|
if ((tmp_speed <= requested_speed) &&
|
|
|
|
(tmp_speed > highest_speed)) {
|
2010-08-27 16:26:05 +00:00
|
|
|
highest_speed = tmp_speed;
|
|
|
|
baud = (m << 3) | n;
|
|
|
|
}
|
|
|
|
}
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
2014-06-13 20:55:48 +00:00
|
|
|
writel(baud, &twsi->baudrate);
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
|
|
|
|
/* Wait for controller for one tick */
|
2021-02-09 11:52:45 +00:00
|
|
|
#if CONFIG_IS_ENABLED(DM_I2C)
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
ndelay(calc_tick(highest_speed));
|
|
|
|
#else
|
|
|
|
ndelay(10000);
|
|
|
|
#endif
|
|
|
|
return highest_speed;
|
2014-06-13 20:55:48 +00:00
|
|
|
}
|
|
|
|
|
2016-07-21 09:57:13 +00:00
|
|
|
/*
|
|
|
|
* __twsi_i2c_init() - Initialize the I2C controller.
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @speed: The initial frequency the controller should run at
|
|
|
|
* in Hz.
|
|
|
|
* @slaveadd: The I2C address to be set for the I2C master.
|
|
|
|
* @actual_speed: A output parameter that receives the actual frequency
|
|
|
|
* in Hz the controller was set to by the function.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if the operation succeeded, or a non-zero code if a time out
|
2016-07-21 09:57:13 +00:00
|
|
|
* occurred.
|
|
|
|
*/
|
2016-07-21 09:57:08 +00:00
|
|
|
static void __twsi_i2c_init(struct mvtwsi_registers *twsi, int speed,
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
int slaveadd, uint *actual_speed)
|
2014-06-13 20:55:48 +00:00
|
|
|
{
|
2018-02-13 07:27:40 +00:00
|
|
|
uint tmp_speed;
|
|
|
|
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Reset controller */
|
2016-07-21 09:57:08 +00:00
|
|
|
twsi_reset(twsi);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Set speed */
|
2018-02-13 07:27:40 +00:00
|
|
|
tmp_speed = __twsi_i2c_set_bus_speed(twsi, speed);
|
2018-01-30 23:57:17 +00:00
|
|
|
if (actual_speed)
|
2018-02-13 07:27:40 +00:00
|
|
|
*actual_speed = tmp_speed;
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Set slave address; even though we don't use it */
|
2014-06-13 20:55:48 +00:00
|
|
|
writel(slaveadd, &twsi->slave_address);
|
|
|
|
writel(0, &twsi->xtnd_slave_addr);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Assert STOP, but don't care for the result */
|
2021-02-09 11:52:45 +00:00
|
|
|
#if CONFIG_IS_ENABLED(DM_I2C)
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
(void) twsi_stop(twsi, calc_tick(*actual_speed));
|
|
|
|
#else
|
|
|
|
(void) twsi_stop(twsi, 10000);
|
|
|
|
#endif
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
i2c: mvtwsi: reset controller if stuck in "bus error" state
The MVTWSI controller can act either as a master or slave device. When
acting as a master, the FSM is driven by the CPU. As a slave, the FSM is
driven by the bus directly. In what is (apparently) a safety mechanism,
if the bus transitions our FSM in any improper way, the FSM goes to a
"bus error" state (0x00). I could find no documented or experimental way
to get the FSM out of this state, except for a controller reset.
Since U-Boot only uses the MVTWSI controller as a bus master, this
feature only gets in the way: we do not care what happened on the bus
previously as long as the bus is ready for a new transaction. So, when
trying to start a new transaction, check for this state and reset the
controller if necessary.
Note that this should not be confused with the "deblocking" technique
(used by the `i2c reset` command), which involves pulsing SCL repeatedly
if SDA is found to be held low, in an attempt to force the bus back to
an idle state. This patch only resets the controller in case something
else had previously upset it, and (in principle) results in no
externally-observable change in behavior.
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Heiko Schocher <hs@denx.de>
2023-07-25 22:13:05 +00:00
|
|
|
/*
|
|
|
|
* __twsi_i2c_reinit() - Reset and reinitialize the I2C controller.
|
|
|
|
*
|
|
|
|
* This function should be called to get the MVTWSI controller out of the
|
|
|
|
* "bus error" state. It saves and restores the baud and address registers.
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @tick: The duration of a clock cycle at the current I2C speed.
|
|
|
|
*/
|
|
|
|
static void __twsi_i2c_reinit(struct mvtwsi_registers *twsi, uint tick)
|
|
|
|
{
|
|
|
|
uint baud;
|
|
|
|
uint slaveadd;
|
|
|
|
|
|
|
|
/* Save baud, address registers */
|
|
|
|
baud = readl(&twsi->baudrate);
|
|
|
|
slaveadd = readl(&twsi->slave_address);
|
|
|
|
|
|
|
|
/* Reset controller */
|
|
|
|
twsi_reset(twsi);
|
|
|
|
|
|
|
|
/* Restore baud, address registers */
|
|
|
|
writel(baud, &twsi->baudrate);
|
|
|
|
writel(slaveadd, &twsi->slave_address);
|
|
|
|
writel(0, &twsi->xtnd_slave_addr);
|
|
|
|
|
|
|
|
/* Assert STOP, but don't care for the result */
|
|
|
|
(void) twsi_stop(twsi, tick);
|
|
|
|
}
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* i2c_begin() - Start a I2C transaction.
|
|
|
|
*
|
|
|
|
* Begin a I2C transaction with a given expected start status and chip address.
|
|
|
|
* A START is asserted, and the address byte is sent to the I2C controller. The
|
|
|
|
* expected address status will be derived from the direction bit (bit 0) of
|
|
|
|
* the address byte.
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @expected_start_status: The I2C status the controller is expected to
|
|
|
|
* assert after the address byte was sent.
|
|
|
|
* @addr: The address byte to be sent.
|
|
|
|
* @tick: The duration of a clock cycle at the current
|
|
|
|
* I2C speed.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if the operation succeeded, or a non-zero code if a time out or
|
2016-07-21 09:57:13 +00:00
|
|
|
* unexpected I2C status occurred.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
2016-07-21 09:57:08 +00:00
|
|
|
static int i2c_begin(struct mvtwsi_registers *twsi, int expected_start_status,
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
u8 addr, uint tick)
|
2009-07-20 07:59:37 +00:00
|
|
|
{
|
2010-08-27 16:26:05 +00:00
|
|
|
int status, expected_addr_status;
|
|
|
|
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Compute the expected address status from the direction bit in
|
|
|
|
* the address byte */
|
|
|
|
if (addr & 1) /* Reading */
|
2010-08-27 16:26:05 +00:00
|
|
|
expected_addr_status = MVTWSI_STATUS_ADDR_R_ACK;
|
2016-07-21 09:57:03 +00:00
|
|
|
else /* Writing */
|
2010-08-27 16:26:05 +00:00
|
|
|
expected_addr_status = MVTWSI_STATUS_ADDR_W_ACK;
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Assert START */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
status = twsi_start(twsi, expected_start_status, tick);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Send out the address if the start went well */
|
2010-08-27 16:26:05 +00:00
|
|
|
if (status == 0)
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
status = twsi_send(twsi, addr, expected_addr_status, tick);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Return 0, or the status of the first failure */
|
2010-08-27 16:26:05 +00:00
|
|
|
return status;
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* __twsi_i2c_probe_chip() - Probe the given I2C chip address.
|
|
|
|
*
|
|
|
|
* This function begins a I2C read transaction, does a dummy read and NAKs; if
|
|
|
|
* the procedure succeeds, the chip is considered to be present.
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @chip: The chip address to probe.
|
|
|
|
* @tick: The duration of a clock cycle at the current I2C speed.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if the operation succeeded, or a non-zero code if a time out or
|
2016-07-21 09:57:13 +00:00
|
|
|
* unexpected I2C status occurred.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
static int __twsi_i2c_probe_chip(struct mvtwsi_registers *twsi, uchar chip,
|
|
|
|
uint tick)
|
2009-07-20 07:59:37 +00:00
|
|
|
{
|
2010-08-27 16:26:05 +00:00
|
|
|
u8 dummy_byte;
|
|
|
|
int status;
|
|
|
|
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Begin i2c read */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
status = i2c_begin(twsi, MVTWSI_STATUS_START, (chip << 1) | 1, tick);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Dummy read was accepted: receive byte, but NAK it. */
|
2010-08-27 16:26:05 +00:00
|
|
|
if (status == 0)
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
status = twsi_recv(twsi, &dummy_byte, MVTWSI_READ_NAK, tick);
|
2010-08-27 16:26:05 +00:00
|
|
|
/* Stop transaction */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
twsi_stop(twsi, tick);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Return 0, or the status of the first failure */
|
2010-08-27 16:26:05 +00:00
|
|
|
return status;
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* __twsi_i2c_read() - Read data from a I2C chip.
|
|
|
|
*
|
|
|
|
* This function begins a I2C write transaction, and transmits the address
|
|
|
|
* bytes; then begins a I2C read transaction, and receives the data bytes.
|
2010-08-27 16:26:05 +00:00
|
|
|
*
|
2016-07-21 09:57:03 +00:00
|
|
|
* NOTE: Some devices want a stop right before the second start, while some
|
|
|
|
* will choke if it is there. Since deciding this is not yet supported in
|
|
|
|
* higher level APIs, we need to make a decision here, and for the moment that
|
|
|
|
* will be a repeated start without a preceding stop.
|
2016-07-21 09:57:13 +00:00
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @chip: The chip address to read from.
|
|
|
|
* @addr: The address bytes to send.
|
|
|
|
* @alen: The length of the address bytes in bytes.
|
|
|
|
* @data: The buffer to receive the data read from the chip (has to have
|
|
|
|
* a size of at least 'length' bytes).
|
|
|
|
* @length: The amount of data to be read from the chip in bytes.
|
|
|
|
* @tick: The duration of a clock cycle at the current I2C speed.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if the operation succeeded, or a non-zero code if a time out or
|
2016-07-21 09:57:13 +00:00
|
|
|
* unexpected I2C status occurred.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
2016-07-21 09:57:08 +00:00
|
|
|
static int __twsi_i2c_read(struct mvtwsi_registers *twsi, uchar chip,
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
u8 *addr, int alen, uchar *data, int length,
|
|
|
|
uint tick)
|
2009-07-20 07:59:37 +00:00
|
|
|
{
|
2016-07-21 09:57:05 +00:00
|
|
|
int status = 0;
|
|
|
|
int stop_status;
|
2016-07-21 09:57:11 +00:00
|
|
|
int expected_start = MVTWSI_STATUS_START;
|
|
|
|
|
i2c: mvtwsi: reset controller if stuck in "bus error" state
The MVTWSI controller can act either as a master or slave device. When
acting as a master, the FSM is driven by the CPU. As a slave, the FSM is
driven by the bus directly. In what is (apparently) a safety mechanism,
if the bus transitions our FSM in any improper way, the FSM goes to a
"bus error" state (0x00). I could find no documented or experimental way
to get the FSM out of this state, except for a controller reset.
Since U-Boot only uses the MVTWSI controller as a bus master, this
feature only gets in the way: we do not care what happened on the bus
previously as long as the bus is ready for a new transaction. So, when
trying to start a new transaction, check for this state and reset the
controller if necessary.
Note that this should not be confused with the "deblocking" technique
(used by the `i2c reset` command), which involves pulsing SCL repeatedly
if SDA is found to be held low, in an attempt to force the bus back to
an idle state. This patch only resets the controller in case something
else had previously upset it, and (in principle) results in no
externally-observable change in behavior.
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Heiko Schocher <hs@denx.de>
2023-07-25 22:13:05 +00:00
|
|
|
/* Check for (and clear) a bus error from a previous failed transaction
|
|
|
|
* or another master on the same bus */
|
|
|
|
if (readl(&twsi->status) == MVTWSI_BUS_ERROR)
|
|
|
|
__twsi_i2c_reinit(twsi, tick);
|
|
|
|
|
2016-07-21 09:57:11 +00:00
|
|
|
if (alen > 0) {
|
|
|
|
/* Begin i2c write to send the address bytes */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
status = i2c_begin(twsi, expected_start, (chip << 1), tick);
|
2016-07-21 09:57:11 +00:00
|
|
|
/* Send address bytes */
|
|
|
|
while ((status == 0) && alen--)
|
2016-08-25 13:20:01 +00:00
|
|
|
status = twsi_send(twsi, addr[alen],
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
MVTWSI_STATUS_DATA_W_ACK, tick);
|
2016-07-21 09:57:11 +00:00
|
|
|
/* Send repeated STARTs after the initial START */
|
|
|
|
expected_start = MVTWSI_STATUS_REPEATED_START;
|
|
|
|
}
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Begin i2c read to receive data bytes */
|
2010-08-27 16:26:05 +00:00
|
|
|
if (status == 0)
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
status = i2c_begin(twsi, expected_start, (chip << 1) | 1, tick);
|
i2c: mvtwsi: Eliminate flags parameter
Due to breaking boots from NOR flashes, commit d6b7757 ("i2c: mvtwsi:
Eliminate twsi_control_flags") removed the static global
twsi_control_flags variable, which kept a set of default flags that were
always or'd to the control register when writing. It was replaced with a
flags parameter, which was passed around between the functions that
needed it.
Since the twsi_control_flags variable was used just for the purposes of
a) setting the MVTWSI_CONTROL_TWSIEN on every control register write,
and
b) setting the MVTWSI_CONTROL_ACK from twsi_i2c_read if needed,
anyway, the added overhead of another variable being passed around is no
longer justified, and we are better off implementing this flag setting
logic locally in the functions that actually write to the control
register.
Therefore, this patch sets MVTWSI_CONTROL_TWSIEN on every control
register write, replaces the twsi_i2c_read's flags parameter with a
ack_flag parameter, which tells the function whether to acknowledge the
read or not, and removes every other instance of the flags variable.
This has the added benefit that now every notion of "global default
flags" is gone, and it's much easier to see which control flags are
actually set at which point in time.
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:04 +00:00
|
|
|
/* Receive actual data bytes; set NAK if we if we have nothing more to
|
|
|
|
* read */
|
|
|
|
while ((status == 0) && length--)
|
2016-07-21 09:57:08 +00:00
|
|
|
status = twsi_recv(twsi, data++,
|
i2c: mvtwsi: Eliminate flags parameter
Due to breaking boots from NOR flashes, commit d6b7757 ("i2c: mvtwsi:
Eliminate twsi_control_flags") removed the static global
twsi_control_flags variable, which kept a set of default flags that were
always or'd to the control register when writing. It was replaced with a
flags parameter, which was passed around between the functions that
needed it.
Since the twsi_control_flags variable was used just for the purposes of
a) setting the MVTWSI_CONTROL_TWSIEN on every control register write,
and
b) setting the MVTWSI_CONTROL_ACK from twsi_i2c_read if needed,
anyway, the added overhead of another variable being passed around is no
longer justified, and we are better off implementing this flag setting
logic locally in the functions that actually write to the control
register.
Therefore, this patch sets MVTWSI_CONTROL_TWSIEN on every control
register write, replaces the twsi_i2c_read's flags parameter with a
ack_flag parameter, which tells the function whether to acknowledge the
read or not, and removes every other instance of the flags variable.
This has the added benefit that now every notion of "global default
flags" is gone, and it's much easier to see which control flags are
actually set at which point in time.
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:04 +00:00
|
|
|
length > 0 ?
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
MVTWSI_READ_ACK : MVTWSI_READ_NAK, tick);
|
2010-08-27 16:26:05 +00:00
|
|
|
/* Stop transaction */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
stop_status = twsi_stop(twsi, tick);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Return 0, or the status of the first failure */
|
2016-07-21 09:57:05 +00:00
|
|
|
return status != 0 ? status : stop_status;
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2010-08-27 16:26:05 +00:00
|
|
|
/*
|
2016-07-21 09:57:13 +00:00
|
|
|
* __twsi_i2c_write() - Send data to a I2C chip.
|
|
|
|
*
|
|
|
|
* This function begins a I2C write transaction, and transmits the address
|
|
|
|
* bytes; then begins a new I2C write transaction, and sends the data bytes.
|
|
|
|
*
|
|
|
|
* @twsi: The MVTWSI register structure to use.
|
|
|
|
* @chip: The chip address to read from.
|
|
|
|
* @addr: The address bytes to send.
|
|
|
|
* @alen: The length of the address bytes in bytes.
|
|
|
|
* @data: The buffer containing the data to be sent to the chip.
|
|
|
|
* @length: The length of data to be sent to the chip in bytes.
|
|
|
|
* @tick: The duration of a clock cycle at the current I2C speed.
|
2022-01-19 17:05:50 +00:00
|
|
|
* Return: Zero if the operation succeeded, or a non-zero code if a time out or
|
2016-07-21 09:57:13 +00:00
|
|
|
* unexpected I2C status occurred.
|
2010-08-27 16:26:05 +00:00
|
|
|
*/
|
2016-07-21 09:57:08 +00:00
|
|
|
static int __twsi_i2c_write(struct mvtwsi_registers *twsi, uchar chip,
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
u8 *addr, int alen, uchar *data, int length,
|
|
|
|
uint tick)
|
2009-07-20 07:59:37 +00:00
|
|
|
{
|
2016-07-21 09:57:05 +00:00
|
|
|
int status, stop_status;
|
2010-08-27 16:26:05 +00:00
|
|
|
|
i2c: mvtwsi: reset controller if stuck in "bus error" state
The MVTWSI controller can act either as a master or slave device. When
acting as a master, the FSM is driven by the CPU. As a slave, the FSM is
driven by the bus directly. In what is (apparently) a safety mechanism,
if the bus transitions our FSM in any improper way, the FSM goes to a
"bus error" state (0x00). I could find no documented or experimental way
to get the FSM out of this state, except for a controller reset.
Since U-Boot only uses the MVTWSI controller as a bus master, this
feature only gets in the way: we do not care what happened on the bus
previously as long as the bus is ready for a new transaction. So, when
trying to start a new transaction, check for this state and reset the
controller if necessary.
Note that this should not be confused with the "deblocking" technique
(used by the `i2c reset` command), which involves pulsing SCL repeatedly
if SDA is found to be held low, in an attempt to force the bus back to
an idle state. This patch only resets the controller in case something
else had previously upset it, and (in principle) results in no
externally-observable change in behavior.
Signed-off-by: Sam Edwards <CFSworks@gmail.com>
Reviewed-by: Stefan Roese <sr@denx.de>
Reviewed-by: Heiko Schocher <hs@denx.de>
2023-07-25 22:13:05 +00:00
|
|
|
/* Check for (and clear) a bus error from a previous failed transaction
|
|
|
|
* or another master on the same bus */
|
|
|
|
if (readl(&twsi->status) == MVTWSI_BUS_ERROR)
|
|
|
|
__twsi_i2c_reinit(twsi, tick);
|
|
|
|
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Begin i2c write to send first the address bytes, then the
|
|
|
|
* data bytes */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
status = i2c_begin(twsi, MVTWSI_STATUS_START, (chip << 1), tick);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Send address bytes */
|
2016-07-21 09:57:09 +00:00
|
|
|
while ((status == 0) && (alen-- > 0))
|
2016-08-25 13:20:01 +00:00
|
|
|
status = twsi_send(twsi, addr[alen], MVTWSI_STATUS_DATA_W_ACK,
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
tick);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Send data bytes */
|
2010-08-27 16:26:05 +00:00
|
|
|
while ((status == 0) && (length-- > 0))
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
status = twsi_send(twsi, *(data++), MVTWSI_STATUS_DATA_W_ACK,
|
|
|
|
tick);
|
2010-08-27 16:26:05 +00:00
|
|
|
/* Stop transaction */
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
stop_status = twsi_stop(twsi, tick);
|
2016-07-21 09:57:03 +00:00
|
|
|
/* Return 0, or the status of the first failure */
|
2016-07-21 09:57:05 +00:00
|
|
|
return status != 0 ? status : stop_status;
|
2009-07-20 07:59:37 +00:00
|
|
|
}
|
|
|
|
|
2021-02-09 11:52:45 +00:00
|
|
|
#if !CONFIG_IS_ENABLED(DM_I2C)
|
2016-07-21 09:57:07 +00:00
|
|
|
static void twsi_i2c_init(struct i2c_adapter *adap, int speed,
|
|
|
|
int slaveadd)
|
|
|
|
{
|
2016-07-21 09:57:08 +00:00
|
|
|
struct mvtwsi_registers *twsi = twsi_get_base(adap);
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
__twsi_i2c_init(twsi, speed, slaveadd, NULL);
|
2016-07-21 09:57:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static uint twsi_i2c_set_bus_speed(struct i2c_adapter *adap,
|
|
|
|
uint requested_speed)
|
|
|
|
{
|
2016-07-21 09:57:08 +00:00
|
|
|
struct mvtwsi_registers *twsi = twsi_get_base(adap);
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
__twsi_i2c_set_bus_speed(twsi, requested_speed);
|
|
|
|
return 0;
|
2016-07-21 09:57:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int twsi_i2c_probe(struct i2c_adapter *adap, uchar chip)
|
|
|
|
{
|
2016-07-21 09:57:08 +00:00
|
|
|
struct mvtwsi_registers *twsi = twsi_get_base(adap);
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
return __twsi_i2c_probe_chip(twsi, chip, 10000);
|
2016-07-21 09:57:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int twsi_i2c_read(struct i2c_adapter *adap, uchar chip, uint addr,
|
|
|
|
int alen, uchar *data, int length)
|
|
|
|
{
|
2016-07-21 09:57:08 +00:00
|
|
|
struct mvtwsi_registers *twsi = twsi_get_base(adap);
|
2016-07-21 09:57:09 +00:00
|
|
|
u8 addr_bytes[4];
|
|
|
|
|
|
|
|
addr_bytes[0] = (addr >> 0) & 0xFF;
|
|
|
|
addr_bytes[1] = (addr >> 8) & 0xFF;
|
|
|
|
addr_bytes[2] = (addr >> 16) & 0xFF;
|
|
|
|
addr_bytes[3] = (addr >> 24) & 0xFF;
|
|
|
|
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
return __twsi_i2c_read(twsi, chip, addr_bytes, alen, data, length,
|
|
|
|
10000);
|
2016-07-21 09:57:07 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int twsi_i2c_write(struct i2c_adapter *adap, uchar chip, uint addr,
|
|
|
|
int alen, uchar *data, int length)
|
|
|
|
{
|
2016-07-21 09:57:08 +00:00
|
|
|
struct mvtwsi_registers *twsi = twsi_get_base(adap);
|
2016-07-21 09:57:09 +00:00
|
|
|
u8 addr_bytes[4];
|
|
|
|
|
|
|
|
addr_bytes[0] = (addr >> 0) & 0xFF;
|
|
|
|
addr_bytes[1] = (addr >> 8) & 0xFF;
|
|
|
|
addr_bytes[2] = (addr >> 16) & 0xFF;
|
|
|
|
addr_bytes[3] = (addr >> 24) & 0xFF;
|
|
|
|
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
return __twsi_i2c_write(twsi, chip, addr_bytes, alen, data, length,
|
|
|
|
10000);
|
2016-07-21 09:57:07 +00:00
|
|
|
}
|
|
|
|
|
2022-12-04 15:04:09 +00:00
|
|
|
#ifdef CFG_I2C_MVTWSI_BASE0
|
2014-06-13 20:55:48 +00:00
|
|
|
U_BOOT_I2C_ADAP_COMPLETE(twsi0, twsi_i2c_init, twsi_i2c_probe,
|
|
|
|
twsi_i2c_read, twsi_i2c_write,
|
|
|
|
twsi_i2c_set_bus_speed,
|
|
|
|
CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, 0)
|
2015-04-10 21:09:51 +00:00
|
|
|
#endif
|
2022-12-04 15:04:10 +00:00
|
|
|
#ifdef CFG_I2C_MVTWSI_BASE1
|
2015-04-10 21:09:51 +00:00
|
|
|
U_BOOT_I2C_ADAP_COMPLETE(twsi1, twsi_i2c_init, twsi_i2c_probe,
|
|
|
|
twsi_i2c_read, twsi_i2c_write,
|
|
|
|
twsi_i2c_set_bus_speed,
|
|
|
|
CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, 1)
|
|
|
|
|
|
|
|
#endif
|
2023-01-10 16:19:45 +00:00
|
|
|
#ifdef CFG_I2C_MVTWSI_BASE2
|
2015-04-10 21:09:51 +00:00
|
|
|
U_BOOT_I2C_ADAP_COMPLETE(twsi2, twsi_i2c_init, twsi_i2c_probe,
|
|
|
|
twsi_i2c_read, twsi_i2c_write,
|
|
|
|
twsi_i2c_set_bus_speed,
|
|
|
|
CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, 2)
|
|
|
|
|
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_I2C_MVTWSI_BASE3
|
|
|
|
U_BOOT_I2C_ADAP_COMPLETE(twsi3, twsi_i2c_init, twsi_i2c_probe,
|
|
|
|
twsi_i2c_read, twsi_i2c_write,
|
|
|
|
twsi_i2c_set_bus_speed,
|
|
|
|
CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, 3)
|
|
|
|
|
|
|
|
#endif
|
|
|
|
#ifdef CONFIG_I2C_MVTWSI_BASE4
|
|
|
|
U_BOOT_I2C_ADAP_COMPLETE(twsi4, twsi_i2c_init, twsi_i2c_probe,
|
|
|
|
twsi_i2c_read, twsi_i2c_write,
|
|
|
|
twsi_i2c_set_bus_speed,
|
|
|
|
CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, 4)
|
|
|
|
|
|
|
|
#endif
|
2016-01-14 13:06:26 +00:00
|
|
|
#ifdef CONFIG_I2C_MVTWSI_BASE5
|
|
|
|
U_BOOT_I2C_ADAP_COMPLETE(twsi5, twsi_i2c_init, twsi_i2c_probe,
|
|
|
|
twsi_i2c_read, twsi_i2c_write,
|
|
|
|
twsi_i2c_set_bus_speed,
|
|
|
|
CONFIG_SYS_I2C_SPEED, CONFIG_SYS_I2C_SLAVE, 5)
|
|
|
|
|
|
|
|
#endif
|
2016-07-21 09:57:10 +00:00
|
|
|
#else /* CONFIG_DM_I2C */
|
|
|
|
|
|
|
|
static int mvtwsi_i2c_probe_chip(struct udevice *bus, u32 chip_addr,
|
|
|
|
u32 chip_flags)
|
|
|
|
{
|
|
|
|
struct mvtwsi_i2c_dev *dev = dev_get_priv(bus);
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
return __twsi_i2c_probe_chip(dev->base, chip_addr, dev->tick);
|
2016-07-21 09:57:10 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static int mvtwsi_i2c_set_bus_speed(struct udevice *bus, uint speed)
|
|
|
|
{
|
|
|
|
struct mvtwsi_i2c_dev *dev = dev_get_priv(bus);
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
|
|
|
|
dev->speed = __twsi_i2c_set_bus_speed(dev->base, speed);
|
|
|
|
dev->tick = calc_tick(dev->speed);
|
|
|
|
|
|
|
|
return 0;
|
2016-07-21 09:57:10 +00:00
|
|
|
}
|
|
|
|
|
2020-12-03 23:55:21 +00:00
|
|
|
static int mvtwsi_i2c_of_to_plat(struct udevice *bus)
|
2016-07-21 09:57:10 +00:00
|
|
|
{
|
|
|
|
struct mvtwsi_i2c_dev *dev = dev_get_priv(bus);
|
|
|
|
|
2020-08-04 05:14:43 +00:00
|
|
|
dev->base = dev_read_addr_ptr(bus);
|
2016-07-21 09:57:10 +00:00
|
|
|
|
|
|
|
if (!dev->base)
|
|
|
|
return -ENOMEM;
|
|
|
|
|
2017-01-17 23:52:55 +00:00
|
|
|
dev->index = fdtdec_get_int(gd->fdt_blob, dev_of_offset(bus),
|
2016-07-21 09:57:10 +00:00
|
|
|
"cell-index", -1);
|
2017-01-17 23:52:55 +00:00
|
|
|
dev->slaveadd = fdtdec_get_int(gd->fdt_blob, dev_of_offset(bus),
|
2016-07-21 09:57:10 +00:00
|
|
|
"u-boot,i2c-slave-addr", 0x0);
|
2020-01-23 18:48:22 +00:00
|
|
|
dev->speed = dev_read_u32_default(bus, "clock-frequency",
|
|
|
|
I2C_SPEED_STANDARD_RATE);
|
|
|
|
|
2016-07-21 09:57:10 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2018-06-07 09:38:10 +00:00
|
|
|
static void twsi_disable_i2c_slave(struct mvtwsi_registers *twsi)
|
|
|
|
{
|
|
|
|
clrbits_le32(&twsi->debug, BIT(18));
|
|
|
|
}
|
|
|
|
|
|
|
|
static int mvtwsi_i2c_bind(struct udevice *bus)
|
|
|
|
{
|
2020-08-04 05:14:43 +00:00
|
|
|
struct mvtwsi_registers *twsi = dev_read_addr_ptr(bus);
|
2018-06-07 09:38:10 +00:00
|
|
|
|
|
|
|
/* Disable the hidden slave in i2c0 of these platforms */
|
2020-12-17 04:20:15 +00:00
|
|
|
if ((IS_ENABLED(CONFIG_ARMADA_38X) ||
|
|
|
|
IS_ENABLED(CONFIG_ARCH_KIRKWOOD) ||
|
|
|
|
IS_ENABLED(CONFIG_ARMADA_8K)) && !dev_seq(bus))
|
2018-06-07 09:38:10 +00:00
|
|
|
twsi_disable_i2c_slave(twsi);
|
|
|
|
|
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
2016-07-21 09:57:10 +00:00
|
|
|
static int mvtwsi_i2c_probe(struct udevice *bus)
|
|
|
|
{
|
|
|
|
struct mvtwsi_i2c_dev *dev = dev_get_priv(bus);
|
2021-09-12 15:21:39 +00:00
|
|
|
struct reset_ctl reset;
|
|
|
|
struct clk clk;
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
uint actual_speed;
|
2021-09-12 15:21:39 +00:00
|
|
|
int ret;
|
|
|
|
|
|
|
|
ret = reset_get_by_index(bus, 0, &reset);
|
|
|
|
if (!ret)
|
|
|
|
reset_deassert(&reset);
|
|
|
|
|
|
|
|
ret = clk_get_by_index(bus, 0, &clk);
|
|
|
|
if (!ret)
|
|
|
|
clk_enable(&clk);
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
|
|
|
|
__twsi_i2c_init(dev->base, dev->speed, dev->slaveadd, &actual_speed);
|
|
|
|
dev->speed = actual_speed;
|
|
|
|
dev->tick = calc_tick(dev->speed);
|
2016-07-21 09:57:10 +00:00
|
|
|
return 0;
|
|
|
|
}
|
|
|
|
|
|
|
|
static int mvtwsi_i2c_xfer(struct udevice *bus, struct i2c_msg *msg, int nmsgs)
|
|
|
|
{
|
|
|
|
struct mvtwsi_i2c_dev *dev = dev_get_priv(bus);
|
|
|
|
struct i2c_msg *dmsg, *omsg, dummy;
|
2021-11-18 08:18:41 +00:00
|
|
|
u8 *addr_buf_ptr;
|
|
|
|
u8 addr_buf[4];
|
|
|
|
int i;
|
2016-07-21 09:57:10 +00:00
|
|
|
|
|
|
|
memset(&dummy, 0, sizeof(struct i2c_msg));
|
|
|
|
|
|
|
|
/* We expect either two messages (one with an offset and one with the
|
|
|
|
* actual data) or one message (just data or offset/data combined) */
|
|
|
|
if (nmsgs > 2 || nmsgs == 0) {
|
|
|
|
debug("%s: Only one or two messages are supported.", __func__);
|
|
|
|
return -1;
|
|
|
|
}
|
|
|
|
|
|
|
|
omsg = nmsgs == 1 ? &dummy : msg;
|
|
|
|
dmsg = nmsgs == 1 ? msg : msg + 1;
|
|
|
|
|
2021-11-18 08:18:41 +00:00
|
|
|
/* We need to swap the register address if its size is > 1 */
|
|
|
|
addr_buf_ptr = &addr_buf[0];
|
|
|
|
for (i = omsg->len; i > 0; i--)
|
|
|
|
*addr_buf_ptr++ = omsg->buf[i - 1];
|
|
|
|
|
2016-07-21 09:57:10 +00:00
|
|
|
if (dmsg->flags & I2C_M_RD)
|
2021-11-18 08:18:41 +00:00
|
|
|
return __twsi_i2c_read(dev->base, dmsg->addr, addr_buf,
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
omsg->len, dmsg->buf, dmsg->len,
|
|
|
|
dev->tick);
|
2016-07-21 09:57:10 +00:00
|
|
|
else
|
2021-11-18 08:18:41 +00:00
|
|
|
return __twsi_i2c_write(dev->base, dmsg->addr, addr_buf,
|
i2c: mvtwsi: Make delay times frequency-dependent
Some devices using the MVTWSI driver have the option to run at speeds
faster than Standard Mode (100kHZ). On the Armada 38x controllers, this
is actually necessary, since due to erratum FE-8471889, a timing
violation concerning repeated starts prevents the controller from
working correctly in Standard Mode. One of the workarounds recommended
in the erratum is to set the bus to Fast Mode (400kHZ) operation and
ensure all connected devices are set to Fast Mode.
In the current version of the driver, however, the delay times are
hard-coded to 10ms, corresponding to Standard Mode operation. To take
full advantage of the faster modes, we would need to either keep the
currently configured I2C speed in a globally accessible variable, or
pass it to the necessary functions as a parameter. For DM, the first
option is not a problem, and we can simply keep the speed in the private
data of the driver. For the legacy interface, however, we would need to
introduce a static variable, which would cause problems with boots from
NOR flashes; see commit d6b7757 "i2c: mvtwsi: Eliminate
twsi_control_flags."
As to not clutter the interface with yet another parameter, we therefore
keep the default 10ms delays for the legacy functions.
In DM mode, we make the delay time dependant on the frequency to allow
taking full advantage of faster modes of operation (tested with up to
1MHZ frequency on Armada MV88F6820).
Signed-off-by: Mario Six <mario.six@gdsys.cc>
Reviewed-by: Stefan Roese <sr@denx.de>
2016-07-21 09:57:12 +00:00
|
|
|
omsg->len, dmsg->buf, dmsg->len,
|
|
|
|
dev->tick);
|
2016-07-21 09:57:10 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
static const struct dm_i2c_ops mvtwsi_i2c_ops = {
|
|
|
|
.xfer = mvtwsi_i2c_xfer,
|
|
|
|
.probe_chip = mvtwsi_i2c_probe_chip,
|
|
|
|
.set_bus_speed = mvtwsi_i2c_set_bus_speed,
|
|
|
|
};
|
|
|
|
|
|
|
|
static const struct udevice_id mvtwsi_i2c_ids[] = {
|
|
|
|
{ .compatible = "marvell,mv64xxx-i2c", },
|
2016-09-16 13:07:55 +00:00
|
|
|
{ .compatible = "marvell,mv78230-i2c", },
|
2022-01-07 17:52:54 +00:00
|
|
|
{ .compatible = "allwinner,sun4i-a10-i2c", },
|
2017-04-26 22:03:36 +00:00
|
|
|
{ .compatible = "allwinner,sun6i-a31-i2c", },
|
2016-07-21 09:57:10 +00:00
|
|
|
{ /* sentinel */ }
|
|
|
|
};
|
|
|
|
|
|
|
|
U_BOOT_DRIVER(i2c_mvtwsi) = {
|
|
|
|
.name = "i2c_mvtwsi",
|
|
|
|
.id = UCLASS_I2C,
|
|
|
|
.of_match = mvtwsi_i2c_ids,
|
2018-06-07 09:38:10 +00:00
|
|
|
.bind = mvtwsi_i2c_bind,
|
2016-07-21 09:57:10 +00:00
|
|
|
.probe = mvtwsi_i2c_probe,
|
2020-12-03 23:55:21 +00:00
|
|
|
.of_to_plat = mvtwsi_i2c_of_to_plat,
|
2020-12-03 23:55:17 +00:00
|
|
|
.priv_auto = sizeof(struct mvtwsi_i2c_dev),
|
2016-07-21 09:57:10 +00:00
|
|
|
.ops = &mvtwsi_i2c_ops,
|
|
|
|
};
|
|
|
|
#endif /* CONFIG_DM_I2C */
|