mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-22 19:13:29 +00:00
3f62fc3a7e
This is somewhat misleading, as those are actually external crates, and don't need a crate:: prefix.
63 lines
1.9 KiB
Rust
63 lines
1.9 KiB
Rust
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
use crate::utils::span_lint;
|
|
use rustc::hir::{Expr, ExprKind};
|
|
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
|
use rustc::ty;
|
|
use rustc::{declare_tool_lint, lint_array};
|
|
|
|
/// **What it does:** Checks for needlessly including a base struct on update
|
|
/// when all fields are changed anyway.
|
|
///
|
|
/// **Why is this bad?** This will cost resources (because the base has to be
|
|
/// somewhere), and make the code less readable.
|
|
///
|
|
/// **Known problems:** None.
|
|
///
|
|
/// **Example:**
|
|
/// ```rust
|
|
/// Point {
|
|
/// x: 1,
|
|
/// y: 0,
|
|
/// ..zero_point
|
|
/// }
|
|
/// ```
|
|
declare_clippy_lint! {
|
|
pub NEEDLESS_UPDATE,
|
|
complexity,
|
|
"using `Foo { ..base }` when there are no missing fields"
|
|
}
|
|
|
|
#[derive(Copy, Clone)]
|
|
pub struct Pass;
|
|
|
|
impl LintPass for Pass {
|
|
fn get_lints(&self) -> LintArray {
|
|
lint_array!(NEEDLESS_UPDATE)
|
|
}
|
|
}
|
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
|
if let ExprKind::Struct(_, ref fields, Some(ref base)) = expr.node {
|
|
let ty = cx.tables.expr_ty(expr);
|
|
if let ty::Adt(def, _) = ty.sty {
|
|
if fields.len() == def.non_enum_variant().fields.len() {
|
|
span_lint(
|
|
cx,
|
|
NEEDLESS_UPDATE,
|
|
base.span,
|
|
"struct update has no effect, all the fields in the struct have already been specified",
|
|
);
|
|
}
|
|
}
|
|
}
|
|
}
|
|
}
|