2018-10-06 16:18:06 +00:00
|
|
|
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
|
|
// file at the top-level directory of this distribution.
|
|
|
|
//
|
|
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
|
|
// option. This file may not be copied, modified, or distributed
|
|
|
|
// except according to those terms.
|
|
|
|
|
2018-05-30 08:15:50 +00:00
|
|
|
use crate::utils::span_lint;
|
2018-12-29 15:04:45 +00:00
|
|
|
use rustc::hir::{Expr, ExprKind};
|
|
|
|
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
|
|
|
use rustc::ty;
|
|
|
|
use rustc::{declare_tool_lint, lint_array};
|
2015-10-21 15:25:16 +00:00
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for needlessly including a base struct on update
|
|
|
|
/// when all fields are changed anyway.
|
2015-12-14 21:16:56 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Why is this bad?** This will cost resources (because the base has to be
|
|
|
|
/// somewhere), and make the code less readable.
|
2015-12-14 21:16:56 +00:00
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
2016-07-15 22:25:44 +00:00
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
2018-11-27 20:14:15 +00:00
|
|
|
/// Point {
|
|
|
|
/// x: 1,
|
|
|
|
/// y: 0,
|
|
|
|
/// ..zero_point
|
|
|
|
/// }
|
2016-07-15 22:25:44 +00:00
|
|
|
/// ```
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2015-10-21 15:25:16 +00:00
|
|
|
pub NEEDLESS_UPDATE,
|
2018-03-28 13:24:26 +00:00
|
|
|
complexity,
|
2016-07-15 22:25:44 +00:00
|
|
|
"using `Foo { ..base }` when there are no missing fields"
|
2015-10-21 15:25:16 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Copy, Clone)]
|
2016-06-10 14:17:20 +00:00
|
|
|
pub struct Pass;
|
2015-10-21 15:25:16 +00:00
|
|
|
|
2016-06-10 14:17:20 +00:00
|
|
|
impl LintPass for Pass {
|
2015-10-21 15:25:16 +00:00
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(NEEDLESS_UPDATE)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2016-12-07 12:13:40 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
2018-07-12 07:30:57 +00:00
|
|
|
if let ExprKind::Struct(_, ref fields, Some(ref base)) = expr.node {
|
2017-01-13 16:04:56 +00:00
|
|
|
let ty = cx.tables.expr_ty(expr);
|
2018-08-22 21:34:52 +00:00
|
|
|
if let ty::Adt(def, _) = ty.sty {
|
2018-01-10 08:50:58 +00:00
|
|
|
if fields.len() == def.non_enum_variant().fields.len() {
|
2017-08-09 07:30:56 +00:00
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
NEEDLESS_UPDATE,
|
|
|
|
base.span,
|
|
|
|
"struct update has no effect, all the fields in the struct have already been specified",
|
|
|
|
);
|
2015-10-21 15:25:16 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|