mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-12-23 03:23:33 +00:00
159 lines
5.6 KiB
Rust
159 lines
5.6 KiB
Rust
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
|
|
// file at the top-level directory of this distribution.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
|
|
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
|
|
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
|
|
// option. This file may not be copied, modified, or distributed
|
|
// except according to those terms.
|
|
|
|
|
|
|
|
|
|
#![feature(const_string_new, const_vec_new)]
|
|
#![allow(clippy::ref_in_deref, dead_code)]
|
|
|
|
use std::sync::atomic::{ATOMIC_USIZE_INIT, AtomicUsize, Ordering};
|
|
use std::cell::Cell;
|
|
use std::sync::Once;
|
|
use std::borrow::Cow;
|
|
use std::fmt::Display;
|
|
|
|
const ATOMIC: AtomicUsize = AtomicUsize::new(5); //~ ERROR interior mutable
|
|
const CELL: Cell<usize> = Cell::new(6); //~ ERROR interior mutable
|
|
const ATOMIC_TUPLE: ([AtomicUsize; 1], Vec<AtomicUsize>, u8) = ([ATOMIC], Vec::new(), 7);
|
|
//~^ ERROR interior mutable
|
|
|
|
macro_rules! declare_const {
|
|
($name:ident: $ty:ty = $e:expr) => { const $name: $ty = $e; };
|
|
}
|
|
declare_const!(_ONCE: Once = Once::new()); //~ ERROR interior mutable
|
|
|
|
// const ATOMIC_REF: &AtomicUsize = &AtomicUsize::new(7); // This will simply trigger E0492.
|
|
|
|
const INTEGER: u8 = 8;
|
|
const STRING: String = String::new();
|
|
const STR: &str = "012345";
|
|
const COW: Cow<str> = Cow::Borrowed("abcdef");
|
|
//^ note: a const item of Cow is used in the `postgres` package.
|
|
|
|
const NO_ANN: &Display = &70;
|
|
|
|
static STATIC_TUPLE: (AtomicUsize, String) = (ATOMIC, STRING);
|
|
//^ there should be no lints on this line
|
|
|
|
#[allow(clippy::declare_interior_mutable_const)]
|
|
const ONCE_INIT: Once = Once::new();
|
|
|
|
trait Trait<T>: Copy {
|
|
type NonCopyType;
|
|
|
|
const ATOMIC: AtomicUsize; //~ ERROR interior mutable
|
|
const INTEGER: u64;
|
|
const STRING: String;
|
|
const SELF: Self; // (no error)
|
|
const INPUT: T;
|
|
//~^ ERROR interior mutable
|
|
//~| HELP consider requiring `T` to be `Copy`
|
|
const ASSOC: Self::NonCopyType;
|
|
//~^ ERROR interior mutable
|
|
//~| HELP consider requiring `<Self as Trait<T>>::NonCopyType` to be `Copy`
|
|
|
|
const AN_INPUT: T = Self::INPUT;
|
|
//~^ ERROR interior mutable
|
|
//~| ERROR consider requiring `T` to be `Copy`
|
|
declare_const!(ANOTHER_INPUT: T = Self::INPUT); //~ ERROR interior mutable
|
|
}
|
|
|
|
trait Trait2 {
|
|
type CopyType: Copy;
|
|
|
|
const SELF_2: Self;
|
|
//~^ ERROR interior mutable
|
|
//~| HELP consider requiring `Self` to be `Copy`
|
|
const ASSOC_2: Self::CopyType; // (no error)
|
|
}
|
|
|
|
// we don't lint impl of traits, because an impl has no power to change the interface.
|
|
impl Trait<u32> for u64 {
|
|
type NonCopyType = u16;
|
|
|
|
const ATOMIC: AtomicUsize = AtomicUsize::new(9);
|
|
const INTEGER: u64 = 10;
|
|
const STRING: String = String::new();
|
|
const SELF: Self = 11;
|
|
const INPUT: u32 = 12;
|
|
const ASSOC: Self::NonCopyType = 13;
|
|
}
|
|
|
|
struct Local<T, U>(T, U);
|
|
|
|
impl<T: Trait2 + Trait<u32>, U: Trait2> Local<T, U> {
|
|
const ASSOC_3: AtomicUsize = AtomicUsize::new(14); //~ ERROR interior mutable
|
|
const COW: Cow<'static, str> = Cow::Borrowed("tuvwxy");
|
|
const T_SELF: T = T::SELF_2;
|
|
const U_SELF: U = U::SELF_2;
|
|
//~^ ERROR interior mutable
|
|
//~| HELP consider requiring `U` to be `Copy`
|
|
const T_ASSOC: T::NonCopyType = T::ASSOC;
|
|
//~^ ERROR interior mutable
|
|
//~| HELP consider requiring `<T as Trait<u32>>::NonCopyType` to be `Copy`
|
|
const U_ASSOC: U::CopyType = U::ASSOC_2;
|
|
}
|
|
|
|
fn main() {
|
|
ATOMIC.store(1, Ordering::SeqCst); //~ ERROR interior mutability
|
|
assert_eq!(ATOMIC.load(Ordering::SeqCst), 5); //~ ERROR interior mutability
|
|
|
|
ATOMIC_USIZE_INIT.store(2, Ordering::SeqCst); //~ ERROR interior mutability
|
|
assert_eq!(ATOMIC_USIZE_INIT.load(Ordering::SeqCst), 0); //~ ERROR interior mutability
|
|
|
|
let _once = ONCE_INIT;
|
|
let _once_ref = &ONCE_INIT; //~ ERROR interior mutability
|
|
let _once_ref_2 = &&ONCE_INIT; //~ ERROR interior mutability
|
|
let _once_ref_4 = &&&&ONCE_INIT; //~ ERROR interior mutability
|
|
let _once_mut = &mut ONCE_INIT; //~ ERROR interior mutability
|
|
let _atomic_into_inner = ATOMIC.into_inner();
|
|
// these should be all fine.
|
|
let _twice = (ONCE_INIT, ONCE_INIT);
|
|
let _ref_twice = &(ONCE_INIT, ONCE_INIT);
|
|
let _ref_once = &(ONCE_INIT, ONCE_INIT).0;
|
|
let _array_twice = [ONCE_INIT, ONCE_INIT];
|
|
let _ref_array_twice = &[ONCE_INIT, ONCE_INIT];
|
|
let _ref_array_once = &[ONCE_INIT, ONCE_INIT][0];
|
|
|
|
// referencing projection is still bad.
|
|
let _ = &ATOMIC_TUPLE; //~ ERROR interior mutability
|
|
let _ = &ATOMIC_TUPLE.0; //~ ERROR interior mutability
|
|
let _ = &(&&&&ATOMIC_TUPLE).0; //~ ERROR interior mutability
|
|
let _ = &ATOMIC_TUPLE.0[0]; //~ ERROR interior mutability
|
|
let _ = ATOMIC_TUPLE.0[0].load(Ordering::SeqCst); //~ ERROR interior mutability
|
|
let _ = &*ATOMIC_TUPLE.1; //~ ERROR interior mutability
|
|
let _ = &ATOMIC_TUPLE.2;
|
|
let _ = (&&&&ATOMIC_TUPLE).0;
|
|
let _ = (&&&&ATOMIC_TUPLE).2;
|
|
let _ = ATOMIC_TUPLE.0;
|
|
let _ = ATOMIC_TUPLE.0[0]; //~ ERROR interior mutability
|
|
let _ = ATOMIC_TUPLE.1.into_iter();
|
|
let _ = ATOMIC_TUPLE.2;
|
|
let _ = &{ATOMIC_TUPLE};
|
|
|
|
CELL.set(2); //~ ERROR interior mutability
|
|
assert_eq!(CELL.get(), 6); //~ ERROR interior mutability
|
|
|
|
assert_eq!(INTEGER, 8);
|
|
assert!(STRING.is_empty());
|
|
|
|
let a = ATOMIC;
|
|
a.store(4, Ordering::SeqCst);
|
|
assert_eq!(a.load(Ordering::SeqCst), 4);
|
|
|
|
STATIC_TUPLE.0.store(3, Ordering::SeqCst);
|
|
assert_eq!(STATIC_TUPLE.0.load(Ordering::SeqCst), 3);
|
|
assert!(STATIC_TUPLE.1.is_empty());
|
|
|
|
u64::ATOMIC.store(5, Ordering::SeqCst); //~ ERROR interior mutability
|
|
assert_eq!(u64::ATOMIC.load(Ordering::SeqCst), 9); //~ ERROR interior mutability
|
|
|
|
assert_eq!(NO_ANN.to_string(), "70"); // should never lint this.
|
|
}
|