mirror of
https://github.com/rust-lang/rust-clippy
synced 2024-11-27 07:00:55 +00:00
205aa88921
When the iterator is one field within a local correctly check for usages of the field
132 lines
4.6 KiB
Text
132 lines
4.6 KiB
Text
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:8:5
|
|
|
|
|
LL | while let Option::Some(x) = iter.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in iter`
|
|
|
|
|
= note: `-D clippy::while-let-on-iterator` implied by `-D warnings`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:13:5
|
|
|
|
|
LL | while let Some(x) = iter.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in iter`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:18:5
|
|
|
|
|
LL | while let Some(_) = iter.next() {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in iter`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:94:9
|
|
|
|
|
LL | while let Some([..]) = it.next() {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for [..] in it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:101:9
|
|
|
|
|
LL | while let Some([_x]) = it.next() {}
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for [_x] in it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:114:9
|
|
|
|
|
LL | while let Some(x @ [_]) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x @ [_] in it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:134:9
|
|
|
|
|
LL | while let Some(_) = y.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in y`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:191:9
|
|
|
|
|
LL | while let Some(m) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in &mut it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:202:5
|
|
|
|
|
LL | while let Some(n) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for n in it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:204:9
|
|
|
|
|
LL | while let Some(m) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:213:9
|
|
|
|
|
LL | while let Some(m) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:222:9
|
|
|
|
|
LL | while let Some(m) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in &mut it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:239:9
|
|
|
|
|
LL | while let Some(m) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in &mut it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:254:13
|
|
|
|
|
LL | while let Some(i) = self.0.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for i in &mut self.0`
|
|
|
|
error: manual `!RangeInclusive::contains` implementation
|
|
--> $DIR/while_let_on_iterator.rs:255:20
|
|
|
|
|
LL | if i < 3 || i > 7 {
|
|
| ^^^^^^^^^^^^^^ help: use: `!(3..=7).contains(&i)`
|
|
|
|
|
= note: `-D clippy::manual-range-contains` implied by `-D warnings`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:286:13
|
|
|
|
|
LL | while let Some(i) = self.0.0.0.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for i in &mut self.0.0.0`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:315:5
|
|
|
|
|
LL | while let Some(n) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for n in &mut it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:327:9
|
|
|
|
|
LL | while let Some(x) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in &mut it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:341:5
|
|
|
|
|
LL | while let Some(x) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in &mut *it`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:352:5
|
|
|
|
|
LL | while let Some(x) = it.0.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in &mut *it.0`
|
|
|
|
error: this loop could be written as a `for` loop
|
|
--> $DIR/while_let_on_iterator.rs:371:5
|
|
|
|
|
LL | while let Some(..) = it.next() {
|
|
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in it`
|
|
|
|
error: aborting due to 21 previous errors
|
|
|