Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-27 07:00:55 +00:00
Code Issues Projects Releases Packages Wiki Activity
rust-clippy/tests/ui/while_let_on_iterator.stderr

133 lines
4.6 KiB
Text
Raw Normal View History

rustup and compile-fail -> ui test move
2017-02-07 20:05:30 +00:00
error: this loop could be written as a `for` loop
clippy: stabilize or_patterns lint
2020-11-21 21:22:32 +00:00
--> $DIR/while_let_on_iterator.rs:8:5
rustup and compile-fail -> ui test move
2017-02-07 20:05:30 +00:00
|
Update *.stderr files
2018-12-27 15:57:55 +00:00
LL | while let Option::Some(x) = iter.next() {
Update while_let_on_iterator tests
2020-04-25 18:01:22 +00:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in iter`
rustup and compile-fail -> ui test move
2017-02-07 20:05:30 +00:00
|
Adapt the *.stderr files of the ui-tests to the tool_lints
2018-08-01 14:30:44 +00:00
= note: `-D clippy::while-let-on-iterator` implied by `-D warnings`
rustup and compile-fail -> ui test move
2017-02-07 20:05:30 +00:00
error: this loop could be written as a `for` loop
clippy: stabilize or_patterns lint
2020-11-21 21:22:32 +00:00
--> $DIR/while_let_on_iterator.rs:13:5
rustup and compile-fail -> ui test move
2017-02-07 20:05:30 +00:00
|
Update *.stderr files
2018-12-27 15:57:55 +00:00
LL | while let Some(x) = iter.next() {
Update while_let_on_iterator tests
2020-04-25 18:01:22 +00:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in iter`
rustup and compile-fail -> ui test move
2017-02-07 20:05:30 +00:00
error: this loop could be written as a `for` loop
clippy: stabilize or_patterns lint
2020-11-21 21:22:32 +00:00
--> $DIR/while_let_on_iterator.rs:18:5
rustup and compile-fail -> ui test move
2017-02-07 20:05:30 +00:00
|
Update *.stderr files
2018-12-27 15:57:55 +00:00
LL | while let Some(_) = iter.next() {}
Update while_let_on_iterator tests
2020-04-25 18:01:22 +00:00
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in iter`
rustup and compile-fail -> ui test move
2017-02-07 20:05:30 +00:00
WIP: Find binding or assignment within outer loop
2017-07-31 22:58:26 +00:00
error: this loop could be written as a `for` loop
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
--> $DIR/while_let_on_iterator.rs:94:9
Merge commit '43a1777b89cf6791f9e20878b4e5e3ae907867a5' into clippyup
2020-05-11 18:23:47 +00:00
|
LL | while let Some([..]) = it.next() {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for [..] in it`
error: this loop could be written as a `for` loop
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
--> $DIR/while_let_on_iterator.rs:101:9
Merge commit '43a1777b89cf6791f9e20878b4e5e3ae907867a5' into clippyup
2020-05-11 18:23:47 +00:00
|
LL | while let Some([_x]) = it.next() {}
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for [_x] in it`
error: this loop could be written as a `for` loop
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
--> $DIR/while_let_on_iterator.rs:114:9
Merge commit '43a1777b89cf6791f9e20878b4e5e3ae907867a5' into clippyup
2020-05-11 18:23:47 +00:00
|
LL | while let Some(x @ [_]) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x @ [_] in it`
error: this loop could be written as a `for` loop
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
--> $DIR/while_let_on_iterator.rs:134:9
Update *.stderr files
2018-12-27 15:57:55 +00:00
|
Update while_let_on_iterator tests
2020-04-25 18:01:22 +00:00
LL | while let Some(_) = y.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in y`
WIP: Find binding or assignment within outer loop
2017-07-31 22:58:26 +00:00
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
error: this loop could be written as a `for` loop
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:191:9
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | while let Some(m) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in &mut it`
error: this loop could be written as a `for` loop
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:202:5
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | while let Some(n) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for n in it`
error: this loop could be written as a `for` loop
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:204:9
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | while let Some(m) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in it`
error: this loop could be written as a `for` loop
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:213:9
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | while let Some(m) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in it`
error: this loop could be written as a `for` loop
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:222:9
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | while let Some(m) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in &mut it`
error: this loop could be written as a `for` loop
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:239:9
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | while let Some(m) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for m in &mut it`
error: this loop could be written as a `for` loop
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:254:13
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | while let Some(i) = self.0.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for i in &mut self.0`
error: manual `!RangeInclusive::contains` implementation
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:255:20
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | if i < 3 || i > 7 {
| ^^^^^^^^^^^^^^ help: use: `!(3..=7).contains(&i)`
|
= note: `-D clippy::manual-range-contains` implied by `-D warnings`
error: this loop could be written as a `for` loop
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:286:13
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | while let Some(i) = self.0.0.0.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for i in &mut self.0.0.0`
error: this loop could be written as a `for` loop
Fix test comment for `while_let_on_iterator`
2021-05-13 01:41:59 +00:00
--> $DIR/while_let_on_iterator.rs:315:5
Improvements to `while_let_on_iterator` * Suggest `&mut iter` when the iterator is used after the loop. * Suggest `&mut iter` when the iterator is a field in a struct. * Don't lint when the iterator is a field in a struct, and the struct is used in the loop. * Lint when the loop is nested in another loop, but suggest `&mut iter` unless the iterator is from a local declared inside the loop.
2021-03-24 13:32:29 +00:00
|
LL | while let Some(n) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for n in &mut it`
Cleanup of `while_let_on_iterator`
2021-04-13 13:30:01 +00:00
error: this loop could be written as a `for` loop
Suggest `&mut iter` inside a closure for `while_let_on_iterator`
2021-05-21 16:27:40 +00:00
--> $DIR/while_let_on_iterator.rs:327:9
|
LL | while let Some(x) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in &mut it`
error: this loop could be written as a `for` loop
Fix `while_let_on_iterator` Reborrow mutable references rather then take a reference to them.
2021-07-31 02:59:20 +00:00
--> $DIR/while_let_on_iterator.rs:341:5
|
LL | while let Some(x) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in &mut *it`
error: this loop could be written as a `for` loop
--> $DIR/while_let_on_iterator.rs:352:5
|
LL | while let Some(x) = it.0.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for x in &mut *it.0`
error: this loop could be written as a `for` loop
Fix `while_let_on_iterator` When the iterator is one field within a local correctly check for usages of the field
2021-07-31 13:32:54 +00:00
--> $DIR/while_let_on_iterator.rs:371:5
Cleanup of `while_let_on_iterator`
2021-04-13 13:30:01 +00:00
|
LL | while let Some(..) = it.next() {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `for _ in it`
Fix `while_let_on_iterator` Reborrow mutable references rather then take a reference to them.
2021-07-31 02:59:20 +00:00
error: aborting due to 21 previous errors
Update changed ui tests
2018-01-16 16:06:27 +00:00
Reference in a new issue Copy permalink