Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-12-13 23:02:43 +00:00
Code Issues Projects Releases Packages Wiki Activity
7984 commits 4 branches 212 tags 130 MiB
Commit graph

7984 commits

This branch
This branch
All branches
Author SHA1 Message Date
bors
d8bcdac9de Auto merge of #5318 - matthiaskrgr:rustup_30, r=flip1995 
rustup https://github.com/rust-lang/rust/pull/69589/

changelog: none
 2020-03-15 20:57:14 +00:00
Matthias Krüger
4d8ed5a842 rustup https://github.com/rust-lang/rust/pull/69589/ 2020-03-15 18:23:43 +01:00
bors
c1a138cdd9 Auto merge of #5316 - lzutao:osstr, r=phansch 
Don't convert Path to lossy str

changelog: none
 2020-03-15 12:57:30 +00:00
bors
8fd7e31d1b Auto merge of #5317 - JohnTitor:rustup, r=matthiaskrgr 
Rustup to rust-lang/rust#69076

changelog: none
 2020-03-14 21:45:38 +00:00
Yuki Okushi
00861d100d
Rustup to rust-lang/rust#69076 2020-03-15 05:26:32 +09:00
Lzu Tao
9febcf5e8d Don't convert Path to lossy str 2020-03-14 22:20:16 +07:00
Lzu Tao
6be0220967 Use into_path 2020-03-14 22:20:16 +07:00
Lzu Tao
29df0139dc Use pattern matching instead of manually checking condition 2020-03-14 19:29:48 +07:00
bors
df64ea682c Auto merge of #5312 - joshtriplett:wildcard-prelude-documentation, r=flip1995 
Document that wildcard_imports doesn't warn about `use ...::prelude::*;`

changelog: Improve [`wildcard_imports`] documentation
 2020-03-14 12:17:09 +00:00
bors
ceb9b7d66d Auto merge of #5314 - ehuss:remove-git2, r=flip1995 
Remove git2 dependency.

This removes the `git2` dependency (used in the integration test).  Updating git2 is awkward because both cargo and clippy have to be updated in sync, so this removes that requirement. It didn't look like it was using the git2 library for any particular reason, so this just launches the `git` executable, which should be available more or less everywhere.

This unblocks updating Cargo.

changelog: none
 2020-03-14 09:23:16 +00:00
Philipp Krones
626f2fe1cb
Fix typo 
Co-Authored-By: Mateusz Mikuła <mati865@users.noreply.github.com>
 2020-03-14 10:22:49 +01:00
Eric Huss
34a00fe7f4 Remove git2 dependency. 2020-03-13 18:22:51 -07:00
Josh Triplett
f56b0a1b34 Document that wildcard_imports doesn't warn about use ...::prelude::*; 2020-03-13 17:07:11 +00:00
bors
2d8a362cbe Auto merge of #5308 - flip1995:changelog, r=Manishearth 
Update Changelog

I also changed the formatting of the changelog for the beta changelog. I can also do this for all the previous releases, if this formatting gets accepted.

[Rendered](https://github.com/flip1995/rust-clippy/blob/changelog/CHANGELOG.md)

r? @Manishearth

changelog: none
 2020-03-13 00:07:33 +00:00
bors
8485d40a32 Auto merge of #5304 - sinkuu:redundant_clone_not_consumed, r=flip1995 
Extend `redundant_clone` to the case that cloned value is not consumed

Fixes #5303.

---

changelog: Extend `redundant_clone` to the case that cloned value is not consumed
 2020-03-12 20:22:31 +00:00
bors
b064ea8096 Auto merge of #5307 - JohnTitor:rename-method, r=flip1995 
Rustup to rust-lang/rust#69674

changelog: none
 2020-03-12 20:05:38 +00:00
flip1995
7b08c7a36e
Change changelog formatting 2020-03-12 21:02:15 +01:00
flip1995
6525127c62
Update changelog_update doc to reflect the actual ordering of the changelog 2020-03-12 21:02:08 +01:00
flip1995
da29402d2e
Update CHANGELOG.md 2020-03-12 21:01:19 +01:00
Yuki Okushi
3e3776666e
Rustup to rust-lang/rust#69674 2020-03-13 04:56:55 +09:00
Shotaro Yamada
d9ad33852c Use visit_place 2020-03-13 02:06:47 +09:00
Shotaro Yamada
aca64b8df7 Check for mutation 2020-03-13 01:25:18 +09:00
Shotaro Yamada
a377378528 Only fires on temporaries 
`let y = x.clone()` cannot be turned into `let y = x` without moving x,
regardless of whether `y` is consumed or not.
 2020-03-13 00:54:40 +09:00
Shotaro Yamada
9de642190e Extend redundant_clone to the case that cloned value is not consumed 2020-03-13 00:31:09 +09:00
bors
fdce47ba7d Auto merge of #5272 - jmeyers35:file_read_lint, r=flip1995 
add lint on File::read_to_string and File::read_to_end

Adds lint `verbose_file_reads` which checks for use of File::read_to_end and File::read_to_string.

Closes https://github.com/rust-lang/rust-clippy/issues/4916

changelog: add lint on File::{read_to_end, read_to_string}
 2020-03-10 22:35:15 +00:00
bors
9d5ffe8105 Auto merge of #5300 - JohnTitor:edition-flag, r=flip1995 
Use `edition:2018` flag more widely

Now we recommend using `// edition:2018`, so let's use it more widely.
Also replace a too old example with new one in the docs.

changelog: none
 2020-03-10 22:02:41 +00:00
Jacob Meyers
a4ba1027fc add CR feedback 2020-03-10 18:00:37 -04:00
Yuki Okushi
d4eb496856
Improve documentation 2020-03-11 06:35:46 +09:00
Yuki Okushi
515847dad1
Use edition:2018 flag more widely 2020-03-11 06:35:07 +09:00
bors
23bd427f92 Auto merge of #5298 - rust-lang:needless_doc_main_code, r=flip1995,Manishearth 
needless_doc_main: only check rust code

This fixes #5280 by checking the language attribute on code blocks.

---

changelog: none
 2020-03-10 21:30:44 +00:00
Manish Goregaokar
d5c8b783b8
Update tests/ui/needless_doc_main.rs 
Co-Authored-By: Philipp Krones <hello@philkrones.com>
 2020-03-10 14:30:07 -07:00
bors
16b925b748 Auto merge of #5299 - JohnTitor:contrib, r=flip1995 
Clean-up docs

Fixes #5268

changelog: none
 2020-03-10 21:05:46 +00:00
Yuki Okushi
0de71b0e3a
Move links to the end of each chapter on adding_lints 2020-03-11 06:01:26 +09:00
Yuki Okushi
19e72a24ae
Move links to the end of each chapter on CONTRIBUTING 2020-03-11 05:41:11 +09:00
Yuki Okushi
459fb53f8d
Clean-up adding_lints.md 2020-03-11 05:21:40 +09:00
Yuki Okushi
8cdd75ca29
Clean-up CONTRIBUTING.md 2020-03-11 05:21:40 +09:00
Andre Bogus
2fa3da4869 needless_doc_main: only check rust code 2020-03-10 20:19:37 +01:00
bors
557f6848bd Auto merge of #5296 - sinkuu:fix_ice_trivial_bounds, r=flip1995 
Fix ICE with trivial_bounds feature

https://github.com/rust-lang/rust/issues/69874#issuecomment-596890446

changelog: Fix ICE with trivial_bounds feature
 2020-03-10 12:25:07 +00:00
bors
3aa8da3e07 Auto merge of #5297 - JohnTitor:shadow, r=phansch 
Use `node_type_opt` over `node_type`

Fix ICE reported in rust-lang/rust#69873.

changelog: Fix ICE in checking bindings
 2020-03-10 10:37:51 +00:00
Yuki Okushi
8d2a3e0a61
Use node_type_opt over node_type 2020-03-10 18:18:34 +09:00
Shotaro Yamada
227ef60a2b Fix doc 2020-03-10 13:28:45 +09:00
Shotaro Yamada
a3d9355bef Fix ICE with trivial_bounds feature 2020-03-10 13:17:35 +09:00
bors
187bbf0e7b Auto merge of #5295 - matthiaskrgr:lints_readme, r=flip1995 
clippy_lints: readme: don't mention crates.io since it is no longer used to publish clippy

changelog: none
 2020-03-10 00:09:26 +00:00
Matthias Krüger
5fd74a9a6a clippy_lints: readme: don't mention crates.io since it is no longer used to publish clippy. 2020-03-10 01:05:54 +01:00
bors
c3d3c50253 Auto merge of #5277 - chrissimpkins:rustc-dev-guide-transition, r=flip1995 
Update rustc-guide to rustc-dev-guide

The rustc-guide is being renamed to the rustc-dev-guide. The discussion is in rust-lang/rustc-guide#470.

This PR revises rustc-guide to rustc-dev-guide in the Readme Markdown file.

Transition tracker: rust-lang/rustc-guide#602

changelog: none
 2020-03-09 23:46:50 +00:00
Chris Simpkins
58dec1ca9c update rust-lang.github.io to rustc-dev-guide.rust-lang.org 2020-03-09 17:58:39 -04:00
bors
64b7624141 Auto merge of #5292 - jpospychala:map-placeholder, r=flip1995 
Improve placeholder in map_unit_fn

Instead of using `_` as a default placeholder use `a`.

fixes #5180
changelog: Improve default placeholder in map_unit_fn
 2020-03-09 19:51:13 +00:00
Jacek Pospychala
697e3c89a7 Improve placeholder in map_unit_fn 2020-03-09 20:37:06 +01:00
bors
d8f64b6eba Auto merge of #5287 - matthiaskrgr:pat_isref, r=flip1995 
redundant_pattern: take binding (ref, ref mut) into account in suggestion

fixes #5271

changelog: redundant_pattern: take binding (ref, ref mut) into account in suggestion (#5271)
 2020-03-09 17:25:09 +00:00
bors
92e25bb7e1 Auto merge of #5286 - matthiaskrgr:delay_vec_creation, r=flip1995 
check_pat: delay creation of the "normal" vec until we reach the branch where it is actually needed

changelog: none
 2020-03-09 17:09:38 +00:00