1075 commits

Author	SHA1	Message	Date
laurent	f8dbd32433	Add a couple small tests to the match-same-arm lint.	2017-11-29 20:42:37 +00:00
Oliver Schneider	273ddafac5	Fix #2188	2017-11-29 17:20:00 +01:00
Oliver Schneider	d5b73c184b	Fix placement of new_without_default suggestion	2017-11-29 17:10:53 +01:00
Oliver Schneider	317e97bae7	Fix #2196	2017-11-29 17:06:27 +01:00
Oliver Schneider	f65a022ace	Fix #2245	2017-11-29 16:03:05 +01:00
Oliver Schneider	0b0337d258	Fix #2247	2017-11-29 15:52:57 +01:00
Lukas Stevens	c22455cb9e	Check for word beginning in stutter lint	2017-11-26 18:36:12 +01:00
Oliver Schneider	af718413db	Rustup	2017-11-22 10:55:12 +01:00
Frederick Zhang	e91b01348e	fix usage of LayoutDetails	2017-11-21 16:51:36 +11:00
Oliver Schneider	c5fa86da04	Merge pull request #2203 from clippered/float_cmp_const ... Fix #1142 float constant comparison lint	2017-11-20 09:51:12 +01:00
laurent	ed202b6055	Bugfix + add test.	2017-11-19 11:29:25 +00:00
laurent	8e9d0c277c	Remove the brackets argument.	2017-11-19 11:29:25 +00:00
laurent	b74ed09d42	Use a struct to store most of the recurse parameters for boolean expr suggestion.	2017-11-19 11:29:25 +00:00
Oliver Schneider	acc81cf921	Merge pull request #2232 from rust-lang-nursery/fixup-const-static-lifetime ... Fixup "const static lifetime" lint for non-path types	2017-11-19 09:28:47 +01:00
Johannes Hofmann	3efa07f959	Ignore identifier 'OpenStreetMap' for DOC_MARKDOWN lint	2017-11-18 19:13:07 +01:00
Georg Brandl	296edda3a9	const_static_lifetime: this applies not only to path types ... For example, &'static [u8] or &'static (t1, t2).	2017-11-18 16:10:29 +01:00
Oliver Schneider	2d005b58c5	Merge pull request #2229 from LaurentMazare/master ... Simplify the boolean expression suggestion function	2017-11-17 09:29:09 +01:00
laurent	87f5b1f043	Remove the union type.	2017-11-16 21:20:17 +00:00
laurent	e44af6b14d	First attempt at simplifying boolean processing.	2017-11-16 21:08:08 +00:00
Christopher Vittal	0155ecf6b0	Split TyImplTrait into Universal and Existential ... This fixes build after the implementation of impl Trait in argument position lands in rustc	2017-11-15 17:52:25 -05:00
Oliver Schneider	f975fb54f8	Merge pull request #2216 from LaurentMazare/master ... Handle methods with an obvious negation in the non-minimal bool lint	2017-11-15 09:08:36 +01:00
Oliver Schneider	c6a4eaeb0d	Rustup	2017-11-15 08:38:43 +01:00
laurent	25783fa485	Raise a lint when suggest has simplified the expression.	2017-11-14 21:14:08 +00:00
Oliver Schneider	bdf3887d22	Move 'handle_method_call_in_not' code into 'suggest'	2017-11-14 17:07:04 +01:00
Oliver Schneider	561d47f338	Merge remote-tracking branch 'origin/master' into laurent_master	2017-11-14 16:46:56 +01:00
Oliver Schneider	b464432972	Merge branch 'master' of github.com:Manishearth/rust-clippy into rust-test	2017-11-14 16:31:52 +01:00
Oliver Schneider	127c41f700	Apply changes that were required for running in the rustc test suite	2017-11-14 14:56:00 +01:00
laurent	14d5013314	Use both pair orders.	2017-11-10 19:55:15 +00:00
Oliver Schneider	09d988521d	Merge pull request #2214 from rust-lang-nursery/nrlfp ... Improve `needless_range_loop`	2017-11-10 10:11:20 +01:00
Oliver Schneider	299f1270a6	Rustup	2017-11-10 08:58:54 +01:00
laurent	67aeb2eaeb	Only apply when there is a single argument.	2017-11-07 21:49:30 +00:00
laurent	82793768b7	Handle methods with an immediate negation in the non-minimal boolean lint, fixes #1930.	2017-11-07 21:43:24 +00:00
Oliver Schneider	1b323b9f35	Don't lint mixed slice indexing and usize indexing in needless_range_loop	2017-11-07 15:32:52 +01:00
Oliver Schneider	652df0fb79	Differentiate between mutable iteration and immutable iteration in needless_range_loop	2017-11-07 14:41:54 +01:00
Oliver Schneider	088555c4ea	Merge pull request #2209 from sinkuu/trait_methods ... Fix false positive in needless_pass_by_value trait methods	2017-11-07 08:26:32 +01:00
laurent	c9681905ba	Fix broken tests.	2017-11-06 23:26:44 +00:00
laurent	e2b9cf836a	Fix merge issues.	2017-11-06 23:22:19 +00:00
sinkuu	6fb736bd42	Fix false positive in needless_pass_by_value trait methods	2017-11-07 06:33:49 +09:00
sinkuu	00081be73d	Rustup	2017-11-07 06:32:12 +09:00
Oliver Schneider	9cd778ac9a	Version bump	2017-11-06 12:39:21 +01:00
Oliver Schneider	ed589761e6	Merge pull request #2202 from topecongiro/format ... Run `cargo fmt`	2017-11-06 08:35:52 +01:00
Oliver Schneider	fdeaf8002e	Merge pull request #2205 from kraai/2204 ... Fix compilation errors with rustc 1.23.0-nightly (d762b1d6c 2017-11-04)	2017-11-06 08:12:28 +01:00
Oliver Schneider	4018b0a495	Merge pull request #2197 from AlexEne/dissalow-underscores-and-numbrers ... Warns if variable name is composed only of underscores and digits.	2017-11-06 08:11:45 +01:00
laurent	af2c93eeb2	Clean the code a bit.	2017-11-05 15:45:23 +00:00
laurent	4fb1bb124e	Make the dogfood test happy.	2017-11-05 15:17:28 +00:00
laurent	42f44d5c78	Cosmetic change.	2017-11-05 15:04:01 +00:00
laurent	7624736961	Bugfix.	2017-11-05 14:56:15 +00:00
laurent	bcdf57e220	Refactor the never-loop detection, fixes #1991.	2017-11-05 14:43:28 +00:00
Matt Kraai	b778659c42	Fix compilation errors with rustc 1.23.0-nightly (d762b1d6c 2017-11-04) ... Fixes #2204	2017-11-05 04:19:11 -08:00
clippered	2787a60fc2	Fix #1142 float constant comparison lint	2017-11-05 09:37:17 +11:00
topecongiro	a6c71e9c0d	Fix lines that exceed max width manually	2017-11-05 04:59:21 +09:00
topecongiro	7a06d312fd	Cargo fmt	2017-11-05 04:55:56 +09:00
topecongiro	65e75c5647	Fix excessive indentation in if_chain!	2017-11-05 04:51:15 +09:00
Alexandru Ene	f92c91601e	Addressed PR comments	2017-11-03 20:54:33 +00:00
sinkuu	c102d50ece	&Self	2017-11-03 17:56:17 +09:00
sinkuu	be7c4b4862	Fix test	2017-11-03 17:36:38 +09:00
sinkuu	cad33c0306	Extend needless_pass_by_value to methods	2017-11-03 17:36:38 +09:00
cgm616	76e765aeda	Switch to new method of checking access	2017-11-02 23:53:48 -05:00
cgm616	ee289c9f88	Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy	2017-11-02 22:57:07 -05:00
Alexandru Ene	9d01468bc7	Warns if variable name is composed only of underscores and digits.	2017-11-03 01:01:41 +00:00
Oliver Schneider	47be692723	Merge pull request #2194 from martinlindhe/master ... fix some typos	2017-11-02 10:30:10 +01:00
Oliver Schneider	cabbc781ca	Merge pull request #2189 from gendx/pr-1590 ... Start working on #1590	2017-11-02 10:29:30 +01:00
sinkuu	0328d4c6e5	Known problems	2017-11-01 23:30:07 +09:00
sinkuu	b9f272cdc2	Known problems	2017-11-01 21:38:59 +09:00
sinkuu	7fa27d9387	Lint transmute::<&[u8], &str>	2017-11-01 18:05:46 +09:00
kennytm	44d3ea5308	Fix lint_without_lint_pass	2017-10-31 10:04:02 -07:00
Martin Lindhe	7bce43b66b	fix some typos	2017-10-31 08:34:27 +01:00
Manish Goregaokar	c526c51923	Update clippy for rustc 1.23.0-nightly (f0fe716db 2017-10-30)	2017-10-31 00:07:10 -07:00
G. Endignoux	87fd68731d	Update UI tests.	2017-10-30 14:10:38 +01:00
G. Endignoux	f0a1eff1c4	Start working on #1590	2017-10-30 13:08:09 +01:00
Manish Goregaokar	a69764d93d	Bump to 0.0.167 (rustup to rustc 1.23.0-nightly (90ef3372e 2017-10-29))	2017-10-29 20:46:25 -07:00
Manish Goregaokar	f76225e388	Handle TyForeign	2017-10-29 05:21:25 -04:00
Manish Goregaokar	09143cdaf0	Update tests; make it work with generics on context	2017-10-29 05:19:24 -04:00
cgm616	85683bf07c	Fix mistake in merging	2017-10-28 13:23:05 -05:00
Manish Goregaokar	b0616df931	Merge branch 'pr-2140'	2017-10-28 14:04:25 -04:00
cgm616	d094f98f0b	Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy	2017-10-28 12:55:16 -05:00
Oliver Schneider	e76eac4b18	Fix dogfood	2017-10-27 10:51:43 +02:00
Lukas Stevens	0ae2ece91e	Check for arrays with size > 32	2017-10-25 21:41:31 +02:00
Alex Burka	24a2c14733	remove if_let_chain	2017-10-23 17:53:30 -04:00
Alex Burka	2153d1e560	manual fixups if_let_chain -> if_chain	2017-10-23 17:53:30 -04:00
Alex Burka	41840ae3c4	mechanically swap if_let_chain -> if_chain	2017-10-23 15:18:02 -04:00
Oliver Schneider	2771378620	Merge pull request #2136 from ykrivopalov/identity_op_fixing ... Identity/erasing operation lints	2017-10-23 09:25:08 +02:00
Oliver Schneider	b96639f23a	Merge pull request #2143 from HMPerson1/master ... Add lint for fallible impls of `From`	2017-10-23 09:21:31 +02:00
Oliver Schneider	6d89798119	Merge pull request #2163 from HMPerson1/useless_asref ... Add lint for useless `as_ref` calls	2017-10-23 09:16:44 +02:00
cgm616	29626b883e	Merge branch 'master' of github.com:rust-lang-nursery/rust-clippy	2017-10-22 10:14:44 -04:00
cgm616	0b0eb8ead6	Undo rustfmt changes unrelated to issue	2017-10-22 09:59:19 -04:00
cgm616	60c7bd47a5	Prevent should_implement_trait on private method ... This should close #2159.	2017-10-21 07:53:57 -04:00
sinkuu	00d35eea26	Fix typo	2017-10-21 19:16:13 +09:00
HMPerson1	7206023b1b	Change to TryFrom	2017-10-20 20:47:51 -04:00
HMPerson1	e5076d06db	Add lint for From<String>	2017-10-20 20:47:30 -04:00
HMPerson1	ff4a850353	Add lint for useless as_ref calls	2017-10-20 20:33:19 -04:00
Oliver Schneider	0e489f3221	Merge pull request #2146 from MaloJaffre/println_empty_string ... Add PRINTLN_EMPTY_STRING lint.	2017-10-20 17:39:34 +02:00
Malo Jaffré	22f3ca0e2c	Add PRINTLN_EMPTY_STRING lint.	2017-10-20 16:45:32 +02:00
Paul Florence	625aae76de	Merge branch 'master' of https://github.com/rust-lang-nursery/rust-clippy	2017-10-20 10:18:54 -04:00
Paul Florence	0928168a79	Remove "#![feature(plugin)]" in the test".	2017-10-20 10:17:41 -04:00
Paul Florence	4bbda68d56	Better linting : use of span_lint_and_then.	2017-10-20 10:17:41 -04:00
Paul Florence	406931381b	Fixed some code in clippy to pass the new, removed formatting changes.	2017-10-20 10:17:41 -04:00
Paul Florence	322effe415	Implementation of the const_static_lifetime lint.	2017-10-20 10:17:41 -04:00
Oliver Schneider	ebdefff88a	Something went through the cracks of our CI	2017-10-20 16:13:50 +02:00
Oliver Schneider	9293188b65	Merge pull request #2156 from cgm616/master ... Deprecate should_assert_eq lint	2017-10-20 15:24:52 +02:00
Oliver Schneider	281bd790de	Merge pull request #2148 from sinkuu/proc_macro ... needless_pass_by_value false-positive in annotation	2017-10-20 11:12:21 +02:00
Oliver Schneider	327d995bb6	Merge pull request #2147 from clippered/fix-manual-memcpy-on-overlapping-slices ... Fix #2123 : check that the source and destination are different for m…	2017-10-20 09:27:15 +02:00
Oliver Schneider	e2429f023b	Version bump	2017-10-20 09:24:37 +02:00
Oliver Schneider	35b2669219	Check the map for promotable instead for existance of a node (which is always the case)	2017-10-20 09:02:32 +02:00
cgm616	4960d9de86	Deprecate should_assert_eq lint ... This should close #2090.	2017-10-19 23:42:04 -05:00
Manish Goregaokar	3e108b7190	Fix constant promotion stuff	2017-10-19 10:16:03 -07:00
Manish Goregaokar	1f81dcbebd	Pass null borrow context to EUV	2017-10-19 09:27:58 -07:00
sinkuu	b4ea47d23e	Detect proc-macro in needless_pass_by_value ... Fixes #1876	2017-10-18 07:33:22 +09:00
clippered	dfa4cb7ade	Fix #2123 : check that the source and destination are different for manual memcpy	2017-10-18 07:06:01 +11:00
Oliver Schneider	f01e45faa4	Merge pull request #2131 from devonhollowood/suggest-print ... Suggest print	2017-10-17 15:26:41 +02:00
Oliver Schneider	343e438f9d	Merge pull request #2120 from sinkuu/implicit_hasher ... Implicit hasher lint	2017-10-17 15:24:20 +02:00
sinkuu	eea30777dd	Type parameter change and type change are now in a multispan suggestion	2017-10-17 21:40:46 +09:00
sinkuu	a4f45e85b1	Use cx.access_levels.exported() instead of visibility	2017-10-17 21:13:17 +09:00
Sunjay Varma	da14435ed2	Updated clippy to account for changes from rust-lang/rust#44766	2017-10-15 15:39:47 -04:00
Yury Krivopalov	7b16f4d7ff	Clarify message for erasing_op lint	2017-10-15 10:32:47 +03:00
Yury Krivopalov	a5d2bfebc4	Simplify checking for all ones in int	2017-10-15 10:21:56 +03:00
Devon Hollowood	2842038627	Improve lint description	2017-10-14 21:46:19 -03:00
Devon Hollowood	eda013d3af	Change lint filename ... suggest_print.rs -> explicit_write.rs	2017-10-14 21:42:14 -03:00
Devon Hollowood	aeeb38dab1	Change lint name ... From `suggest_print` to `explicit_write`	2017-10-14 21:26:50 -03:00
Yury Krivopalov	033c99b1ba	Add erasing_op lint ... For expressions that can be replaced by a zero.	2017-10-14 12:34:37 +03:00
Yury Krivopalov	f68e408cb6	identity_op lint fix for '&' with unsigned types	2017-10-14 12:21:23 +03:00
sinkuu	c3332ca92e	Fix panic with fake Range type	2017-10-13 21:51:57 +09:00
Devon Hollowood	a46bf3f456	Clarify lint description	2017-10-12 05:54:33 -03:00
Devon Hollowood	e31a0941e2	Fix output for write macros	2017-10-12 05:53:20 -03:00
Devon Hollowood	4105593eee	Run rustfmt	2017-10-12 05:35:13 -03:00
Devon Hollowood	888076b698	Add suggest_print lint	2017-10-12 05:30:35 -03:00
sinkuu	31f16b87b7	Use rustc_typeck::hir_ty_to_ty	2017-10-11 23:08:36 +09:00
sinkuu	5a61d88fa1	Apply suggestions	2017-10-11 22:17:00 +09:00
Oliver Schneider	f0aa2c1587	Merge pull request #2127 from rust-lang-nursery/enum_variant_names_fp ... Don't lint accidental "prefixes" on enum variants	2017-10-11 13:16:59 +02:00
Oliver Schneider	58002b0e37	Merge pull request #2119 from camsteffen/never_loop ... Another never_loop fix	2017-10-11 08:21:28 +02:00
sinkuu	159cc8413c	Add implicit_hasher lint (#2101)	2017-10-11 12:10:26 +09:00
Cameron Steffen	752900ca3b	change expect message	2017-10-10 16:30:10 -05:00
Lukas Stevens	4438c41d14	Make suggested changes ... - Fix copy-paste error - Check for opt.map_or argument after ensuring that opt is an Option - Use span_lint_and_then and span_suggestion - Update reference	2017-10-10 15:35:24 +02:00
Lukas Stevens	c0fac7cf56	Remove unnecessary borrow	2017-10-10 14:04:41 +02:00
Lukas Stevens	eb53cca768	Add lint for opt.map_or(None, f) ... Change to Warn and add multiline support Fix typo Update reference	2017-10-10 13:37:45 +02:00
Oliver Schneider	af6e2a1e4e	Don't lint accidental "prefixes" on enum variants	2017-10-10 12:37:59 +02:00
Oliver Schneider	28c401f9db	Merge pull request #2118 from chyvonomys/relax-needless-loop ... relax `needless_range_loop` so that it reports only direct indexing	2017-10-10 09:37:51 +02:00
Cameron Steffen	9ccb7108b5	fix never_loop	2017-10-08 17:26:39 -05:00
Cameron Steffen	533a50547f	remove contains_continue functions	2017-10-08 17:24:32 -05:00
Oliver Schneider	73a1dd8e7f	Merge pull request #2117 from sinkuu/improve_take_by_value ... Improve needless_pass_by_value	2017-10-08 20:14:55 +02:00
Andriy S. from cobalt	52bd7bb662	relax needless_range_loop so that it reports only direct indexing	2017-10-08 18:34:31 +03:00
sinkuu	8ffec33fd3	Remove intermediate vec	2017-10-08 20:17:04 +09:00
Niklas Fiekas	e9be7530c6	Allow range_plus_one while ..= ranges are unstable	2017-10-08 12:51:00 +02:00
Niklas Fiekas	d8e01237e2	Lint range_plus_one and range_minus_one (closes #329)	2017-10-08 12:51:00 +02:00
Oliver Schneider	a54baad4fa	Merge pull request #2112 from topecongiro/issue-2109 ... Add a suggestion to replace `map(f).unwrap_or(None)` with `and_then(f)`.	2017-10-08 11:51:15 +02:00
sinkuu	fdc9a649ff	Exclude Fn traits	2017-10-08 18:04:45 +09:00
sinkuu	2be6245179	Duplicate ptr_arg's suggestion logic	2017-10-08 17:51:44 +09:00
sinkuu	bf97cd0338	Reduce false-positives for needless_pass_by_value lint ... Excluding a type whose reference also fulfills the trait bound.	2017-10-08 17:25:56 +09:00
Chris Emerson	fcdce8fc1d	Merge branch 'master' into no_effect_with_drop	2017-10-07 23:24:36 +01:00
Seiichi Uchida	63d6df2101	Add a comment that explains about comparing snippet to raw text	2017-10-07 00:12:30 +09:00