Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-10 07:04:18 +00:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #2127 from rust-lang-nursery/enum_variant_names_fp

Browse source 
Don't lint accidental "prefixes" on enum variants
This commit is contained in:
Oliver Schneider 2017-10-11 13:16:59 +02:00 committed by GitHub
commit f0aa2c1587
2 changed files with 16 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
clippy_lints/src/enum_variants.rs
View file

@ -159,7 +159,8 @@ fn check_variant(
}
for var in &def.variants {
let name = var2str(var);
if partial_match(item_name, &name) == item_name_chars {
if partial_match(item_name, &name) == item_name_chars &&
name.chars().nth(item_name_chars).map_or(false, |c| !c.is_lowercase()) {
span_lint(cx, lint, var.span, "Variant name starts with the enum's name");
}
if partial_rmatch(item_name, &name) == item_name_chars {

14
tests/ui/enum_variants.rs
View file

@ -102,4 +102,18 @@ mod allowed {
}
}
// should not lint
enum Pat {
Foo,
Bar,
Path,
}
// should not lint
enum N {
Pos,
Neg,
Float,
}
fn main() {}