Commit graph

5143 commits

Author SHA1 Message Date
Christian Duerr
13353111da
Add known problem to needless_borrow lint
The `needless_borrow` lint is temporarily disabled because of some false
positives it causes in combination with the `derive` macro.

However the documentation does not explain these issues, but instead
lists `Known problems: None`. To make it clear why this lint is
currently not enabled, a description of the false positives caused by
this lint has been added to the `Known problems` section.
2018-07-25 14:54:09 +02:00
Philipp Hansch
fde487c1dc
Merge pull request #2958 from phansch/small_text_change_for_update_lints
s/wiki/lint list/
2018-07-25 08:48:56 +02:00
Philipp Hansch
0961c692fa
s/wiki/lint list/ 2018-07-25 08:22:52 +02:00
Michael Wright
137f944315 Fix warnings 2018-07-25 06:34:29 +02:00
Michael Wright
5e23fcec0b Merge branch 'master' into issue2894 2018-07-25 06:27:36 +02:00
Manish Goregaokar
b2caf669a8
Merge pull request #2952 from dwijnand/upstream-in_external_macro
Switch to rustc's in_external_macro function
2018-07-24 08:27:38 -07:00
Dale Wijnand
a1cce2d06a
Inline utils::in_external_macro 2018-07-24 10:38:58 +01:00
Dale Wijnand
b1fa7b91ba
Delegate utils::in_external_macro to rustc::lint::in_external_macro 2018-07-24 10:34:18 +01:00
Philipp Krones
b02e53de34
Merge pull request #2951 from etaoins/allow-pass-by-ref-on-ref-return
Allow pass by reference if we return a reference
2018-07-24 11:23:01 +02:00
Philipp Krones
3f9b837ec8
Merge pull request #2953 from dwijnand/misrefactored_assign_op-known-problem-doc
Expand on misrefactored_assign_op known problems
2018-07-24 11:19:58 +02:00
Ryan Cumming
0afa5e1e21 Merge branch 'master' into allow-pass-by-ref-on-ref-return 2018-07-24 19:03:43 +10:00
Dale Wijnand
70f5bb1ff6
Tweak
misrefactored_assign_op's known problems wording
2018-07-24 09:26:28 +01:00
Oliver Schneider
25e0a08325
Merge pull request #2949 from rust-lang-nursery/preexpansion
Rewrite the print/write macro checks as a PreExpansionPass
2018-07-24 10:08:50 +02:00
Dale Wijnand
6ad7a92ff8
Expand on misrefactored_assign_op known problems 2018-07-24 08:39:18 +01:00
Oliver Schneider
afd91248ed Rustup 2018-07-23 13:01:12 +02:00
Ryan Cumming
7c74c3e508 Wrap comment at 80 columns 2018-07-23 19:37:41 +10:00
Ryan Cumming
89a4558056 Add Known Problem for multiple lifetimes 2018-07-23 19:33:52 +10:00
Ryan Cumming
58459abd0c Allow pass by reference if we return a reference
Currently this code will trigger `trivally_copy_pass_by_ref`:

```
struct OuterStruct {
    field: [u8; 8],
}

fn return_inner(outer: &OuterStruct) -> &[u8] {
    &outer.field
}
```

If we change the `outer` to be pass-by-value it will not live long
enough for us to return the reference. The above example is trivial but
I've hit this in real code that either returns a reference to either the
argument or in to `self`.

This suppresses the `trivally_copy_pass_by_ref` lint if we return a
reference and it has the same lifetime as the argument. This will likely
miss complex cases with multiple lifetimes bounded by each other but it
should cover the majority of cases with little effort.
2018-07-23 18:44:40 +10:00
Oliver Schneider
ff0e5f967f Rewrite the print/write macro checks as a PreExpansionPass 2018-07-23 00:19:07 +02:00
Wim
26eea10ec1
Add known problem for redundant_closure lint
Documenting https://github.com/rust-lang-nursery/rust-clippy/issues/1439 until it gets fixed.
2018-07-21 18:05:02 +02:00
Oliver Schneider
8085ed733f Don't invent new magic keywords 2018-07-21 12:36:01 +02:00
Oliver Schneider
2fa85d86e0 Rustup 2018-07-20 22:50:04 +02:00
Manish Goregaokar
1f65617372 Merge branch 'macro-use' into HEAD 2018-07-20 00:52:01 -07:00
Manish Goregaokar
77b0300a55 Merge branch 'pr-2939' into HEAD 2018-07-20 00:51:57 -07:00
Manish Goregaokar
2a37a62686 Update dependencies 2018-07-20 00:50:02 -07:00
Manish Goregaokar
3c2b54870e Remove warning 2018-07-20 00:50:02 -07:00
Manish Goregaokar
5918a3fc1e Remove import of if_chain 2018-07-20 00:50:02 -07:00
Alexander Regueiro
4d2c838a32 Update to nightly 2018-07-20 03:59:07 +01:00
Philipp Krones
0f49e8968d
Merge pull request #2936 from flip1995/useless_lint_attr
Fix useless_attribute lint for extern crate items with macro_use
2018-07-19 14:57:28 +02:00
Philipp Krones
7877730115
Merge pull request #2938 from flip1995/travis
Remove duplication of the cargo and rls repos from travis
2018-07-19 14:36:30 +02:00
flip1995
988b552337
Remove duplication of the cargo and rls repos from travis 2018-07-19 14:14:12 +02:00
flip1995
ac77a26b8a
Skip useless_attribute lint on allow(unused_imports) on extern crate items with macro_use 2018-07-19 13:59:25 +02:00
Manish Goregaokar
c7676356b8 Remove import of matches 2018-07-19 01:06:02 -07:00
Manish Goregaokar
5d74e2096b Remove import of rustc 2018-07-19 00:53:23 -07:00
Manish Goregaokar
00ba67a12b Remove import of lazy_static 2018-07-19 00:11:15 -07:00
Manish Goregaokar
c1745cde82 Remove import of serde 2018-07-19 00:02:08 -07:00
Manish Goregaokar
de13d5a5bd
Merge pull request #2934 from pickfire/patch-1
Improve website panel heading experience
2018-07-18 23:50:37 -07:00
Ivan Tham
2c65e7c835
Improve website panel heading experience 2018-07-19 14:12:47 +08:00
Manish Goregaokar
c05adc545c Temporarily allow macro_use_extern_crate 2018-07-18 20:24:37 -07:00
Michael Wright
a05c9b63ce use_self: Simplify spanning 2018-07-18 07:57:50 +02:00
Michael Wright
5bb52c4869 Fix use_self regressions 2018-07-17 08:20:49 +02:00
Michael Wright
847e4dcc0d Merge branch 'master' into issue2894 2018-07-17 06:32:39 +02:00
Manish Goregaokar
f27aaacb9b
Merge pull request #2923 from rust-lang-nursery/kind
Rustup to 1ecf6929dc3b309cdfcb7239260777dab38242b9
2018-07-16 16:41:50 -07:00
Manish Goregaokar
3246a1f5c0 Update mini-macro post proc macro stabilization
https://github.com/rust-lang/rust/pull/52081 stabilized proc macros, but
quote is still unstable, so you need to explicitly enable that feature.
2018-07-16 16:29:16 -07:00
Manish Goregaokar
196ffa8ad8
Merge pull request #2922 from rust-lang-nursery/rm-clip
Fix travis build by removing cargo-clippy
2018-07-16 15:32:19 -07:00
Manish Goregaokar
e58eb520a4 Fix travis build by removing cargo-clippy 2018-07-16 14:14:37 -07:00
Manish Goregaokar
a43f8cf819 some readme clarifications 2018-07-16 13:39:38 -07:00
Manish Goregaokar
e22928c23c
Merge pull request #2921 from yaahallo/master
Update readme for new clippy install method
2018-07-16 13:38:09 -07:00
Jane Lusby
29cae6263b Update readme for new clippy install method 2018-07-16 13:30:16 -07:00
Oliver Schneider
8f61a792f4 Update test output to changes in rustc 2018-07-16 15:43:30 +02:00