Brad Gibson
efdd00d2ae
Merge pull request #1 from humanenginuity/fix-strictly-aligned-types-cast-messages
...
Corrected messaging to warn against less- to more-strictly aligned
2018-04-23 11:03:27 -07:00
Brad Gibson
1969d423a7
Corrected messaging to warn against less- to more-strictly align types, rather than the other way around. No logic changes required.
2018-04-23 10:59:53 -07:00
Oliver Schneider
79e818267b
Merge pull request #2690 from mrecachinas/feature/print-string-literal
...
Fix alignment/precision/width false positives for print/write_literal
2018-04-23 10:36:48 +02:00
Michael Recachinas
a317bc9d23
Update stderrs for print and write_literal
2018-04-21 19:51:58 +01:00
Michael Recachinas
54c0edcfe8
Add smaller check_unformatted to write.rs and fix precision,width,align false positive
2018-04-21 19:51:58 +01:00
Michael Recachinas
8ccaa83e90
Add more tests to print_ and write_literal
...
Also, move precision, width, and debug fmt tests to 'should pass'
2018-04-21 19:51:35 +01:00
Philipp Hansch
5bfb306b4b
Explain how Clippy works
2018-04-21 11:53:15 +02:00
Oliver Schneider
c5b39a5917
Version bump
2018-04-19 08:36:22 +02:00
Oliver Schneider
475959d905
Merge pull request #2681 from phansch/fix_latest_nightly_breakage
...
Fix latest nightly breakage
2018-04-19 08:28:10 +02:00
Oliver Schneider
f84cc2cc36
Merge pull request #2683 from rust-lang-nursery/rustup
...
Rustup
2018-04-19 06:46:41 +02:00
Philipp Hansch
a854874e6a
Fix latest nightly breakage
...
I'm not sure if there are better ways to use the RwLock API, though. But
it seems to work.
2018-04-18 20:25:43 +02:00
Philipp Hansch
0c665f4a31
Merge pull request #2675 from phansch/mention_irc_in_contributing_md
...
Add intro and mention IRC in CONTRIBUTING.md
2018-04-17 22:26:01 +02:00
Oliver Schneider
f786a36949
Rustup
2018-04-17 10:52:25 +02:00
Philipp Hansch
fe426b7c51
Add intro and mention IRC in CONTRIBUTING.md
...
This is partly taken from the [rustfmt CONTRIBUTING.md][contrib].
[contrib]: https://github.com/rust-lang-nursery/rustfmt/blob/master/Contributing.md
2018-04-17 08:33:22 +02:00
Oliver Schneider
ae3213747d
Merge pull request #1467 from philipturnbull/option_map_nil_fn
...
Lint `Option.map(f)` where f returns unit
2018-04-15 16:14:25 +02:00
Philipp Hansch
26b9911e07
Refactor out enum and address nits
2018-04-15 15:37:11 +02:00
Oliver Schneider
9dc9487567
Version bump
2018-04-15 15:01:48 +02:00
Oliver Schneider
486dc5c070
Merge pull request #2650 from thekidxp/fixEmptyPrintln
...
fixEmptyPrintln
2018-04-15 14:30:45 +02:00
MSI\Stew's Laptop
d175c797e5
fixing error message for empty println macro
2018-04-15 14:00:28 +02:00
Philipp Hansch
4f4e20c561
Also lint Result.map for unit returns
2018-04-15 13:59:57 +02:00
Philipp Hansch
8307a899e9
Rename option_map_unit_fn to map_unit_fn
2018-04-15 13:01:10 +02:00
Philipp Hansch
d54f70f1f6
Generate let binding variable name for some cases
...
Given a map call like `x.field.map ...` the suggestion will contain:
`if let Some(x_field) ...`
Given a map call like `x.map ...` the suggestion will contain:
`if let Some(_x) ...`
Otherwise it will suggest: `if let Some(_) ...`
2018-04-15 13:01:10 +02:00
Philipp Hansch
d87385b406
Use approximate_suggestion for non-reducible closures
2018-04-15 13:01:10 +02:00
Philipp Hansch
7de707fdba
Remove further semicolon reduction
2018-04-15 13:01:10 +02:00
Philipp Hansch
db60c67c5b
Allow new lint in ui/eta.rs
2018-04-15 13:01:09 +02:00
Philipp Hansch
bcc335fc9c
Move test to new UI test system
2018-04-15 13:01:09 +02:00
Philipp Hansch
a3ff21f4d6
Rename lint to option_map_unit_fn
...
Rust does not have nil.
2018-04-15 13:01:09 +02:00
Philipp Hansch
fbd71f901f
Use declare_clippy_lint and 'complexity' category
2018-04-15 13:01:09 +02:00
Philipp Hansch
ca60e8a2a0
Cleanup misc::check_nan
...
This was a bit messed up after a bigger rebase.
2018-04-15 13:01:09 +02:00
Philipp Hansch
991a30237a
Make it compile again
2018-04-15 13:01:09 +02:00
Phil Turnbull
d0bdfe5ce3
Handle non-trivial nil closures
...
`reduce_nil_closure` mixed together a) 'is this a nil closure?' and b) 'can it
be reduced to a simple expression?'. Split the logic into two functions so we
can still generate a basic warning when the closure can't be simplified.
2018-04-15 13:01:09 +02:00
Phil Turnbull
2f52d1d568
Return Spans instead of Cow<&str>'s
2018-04-15 13:01:09 +02:00
Phil Turnbull
30f2480fd8
Lint closures that return nil
2018-04-15 13:01:09 +02:00
Phil Turnbull
302f5d05f5
Lint Option.map(f) where f never returns
2018-04-15 13:01:09 +02:00
Phil Turnbull
e5ecbb55ee
Lint Option.map(f) where f returns nil
2018-04-15 13:01:09 +02:00
Oliver Schneider
b2e4b88d18
Merge pull request #2662 from mikerite/issue_2546
...
Fix useless_format false negative
2018-04-15 11:57:57 +02:00
Oliver Schneider
cefb7b0f58
Merge pull request #2670 from mikerite/fix_compilation_20180415
...
Fix compilation for nightly 2018-04-15
2018-04-15 11:57:01 +02:00
Michael Wright
d171e8987e
Fix clippy error
2018-04-15 05:20:30 +02:00
Michael Wright
a9c8d1bd90
Fix compilation for nightly 2018-04-15
...
This only fixes compilation and the build. It's possible that the `author`
and `inspector` lints are broken but there are no failing tests.
Closes #2667
2018-04-15 05:01:43 +02:00
Oliver Schneider
fc8e35884b
Merge pull request #2669 from senden9/patch-1
...
Fix Markdown link syntax in lint doc
2018-04-14 12:18:18 +02:00
Stefano Probst
01faa906d2
Fix Markdown link syntax in lint doc
...
Currently this link is wrong rendered. See https://rust-lang-nursery.github.io/rust-clippy/v0.0.193/index.html#iter_next_loop
2018-04-14 11:35:52 +02:00
Philipp Hansch
8c9ed704c6
Merge pull request #2668 from phansch/run_remark_on_all_markdown_files
...
Run remark-lint on all markdown files in root
2018-04-13 21:09:07 +02:00
Philipp Hansch
0995e923f0
Run remark-lint on all markdown files in root
2018-04-13 20:54:42 +02:00
Philipp Hansch
a936b6d95d
Merge pull request #2664 from phansch/move_unnecessary_fold_ui_tests
...
Move unnecessary_fold UI tests to separate file
2018-04-12 22:32:45 +02:00
Philipp Hansch
dfde407f0d
Move unnecessary_fold UI tests to separate file
2018-04-12 22:16:43 +02:00
Michael Wright
c7ad71ccf2
Fix clippy warnings
2018-04-12 08:50:42 +02:00
Michael Wright
6ae617b313
Fix useless_format false negative
...
Closes #2546
2018-04-12 08:21:03 +02:00
Oliver Schneider
8ec61a613a
Merge pull request #2661 from devonhollowood/ptr-ptr-casts
...
Replace `misaligned_transmute` lint
2018-04-11 13:23:15 +02:00
Devon Hollowood
b77d74030b
Deprecate misaligned_transmute
2018-04-11 02:50:04 -07:00
Devon Hollowood
c6bc682325
Fix misaligned_transmute lint
...
This is done by adding two new lints: cast_ptr_alignment and
transmute_ptr_to_ptr. These will replace misaligned_transmute.
2018-04-11 02:17:59 -07:00
