Commit graph

3701 commits

Author SHA1 Message Date
Philipp Hansch
90e7d93d6c
Fix nonminimal_bool false positive
It was checking any is_ok, is_err, is_some, is_none method for negation
but it should only perform the check for the built-in types, not custom
types.
2018-04-07 12:52:59 +02:00
Oliver Schneider
fbb5050d82
Merge pull request #2641 from rcoh/patch-2
Update hash_xor_eq docs to match behavior
2018-04-07 09:42:54 +02:00
Oliver Schneider
a863ba16e1
Merge pull request #2640 from mikerite/fix_compilation_20180406
Fix compilation for nightly 2018-04-06
2018-04-07 09:42:26 +02:00
Russell Cohen
4b3326efd0
Fix docs to match behavior 2018-04-06 22:44:25 -07:00
Michael Wright
fe8068c41b Fix compilation for nightly 2018-04-06
Breakages for introduced by rust pull request
'AST: Give spans to all identifies' - rust-lang/rust/pull#49154

Closes #2639
2018-04-07 07:32:30 +02:00
Oliver Schneider
044b3d90c3
Merge pull request #2633 from mikerite/ref_cow_tests
Move ref cow tests
2018-04-06 12:15:33 +02:00
Oliver Schneider
71a15bf264
Merge pull request #2635 from phansch/split_up_some_match_ui_tests
Split up some single_match UI tests
2018-04-06 12:13:38 +02:00
Philipp Hansch
641f0685d0
Split up some single_match UI tests
This moves only the single_match tests over to the new file.
2018-04-05 22:45:36 +02:00
Michael Wright
2fd671e4bd Move ref cow tests
This commit moves the ref cow tests from needless_borrow.rs to ptr_arg.rs
where all the other PTR_ARG tests are.
2018-04-05 18:13:39 +02:00
Oliver Schneider
62d595b3dc
Merge pull request #2632 from phansch/fix_useless_format_false_positive
Fix useless_format false positive with macros
2018-04-05 09:59:12 +02:00
Philipp Hansch
ff98e3f9f5
Fix useless_format false positive with macros
Clippy was issuing a warning when `format!` was used inside a macro.
That's a problem because macros have different syntax and can be outside
the control of the user.

This skips the `useless_format` check if the `format!` call is inside a
macro.
2018-04-05 07:52:26 +02:00
Manish Goregaokar
399488079b argh 2018-04-04 19:15:22 -07:00
Manish Goregaokar
a514058e13
Merge pull request #2629 from memoryleak47/typo
typo
2018-04-04 19:14:29 -07:00
memoryleak47
d9508ba99d typo 2018-04-05 04:13:14 +02:00
Manish Goregaokar
ab28118449 Fix driver dogfood bug 2018-04-04 18:56:21 -07:00
Manish Goregaokar
2046694029 Bump version to 0.0.192 2018-04-04 18:00:21 -07:00
Manish Goregaokar
d71f918616 Update changelog 2018-04-04 17:59:54 -07:00
Manish Goregaokar
51336711d3 Remove uses of ExprKind::Inplace 2018-04-04 17:56:44 -07:00
Manish Goregaokar
386897b44a
Merge pull request #2628 from TimNN/patch-2
Add missing `clippy_` prefix to lint groups in Readme
2018-04-04 10:57:11 -07:00
Tim Neumann
c7aa8b0458
Add missing clippy_ prefix to lint groups in Readme 2018-04-04 19:49:55 +02:00
Manish Goregaokar
976bbe822a
Merge pull request #2625 from mikerite/clippy_warning
Fix clippy warning
2018-04-03 22:48:11 -07:00
Manish Goregaokar
1c73db172a
fix other instance of internals docs 2018-04-03 22:47:27 -07:00
Michael Wright
a8bb8925cb Fix clippy warning 2018-04-04 07:08:35 +02:00
Manish Goregaokar
c170e86403
new internals docs 2018-04-03 19:05:33 -07:00
Oliver Schneider
a3cdcf142a
Merge pull request #2622 from flip1995/imm_while_fields
Don't trigger while_immutable_condition for mutable fields
2018-04-03 22:30:14 +02:00
flip1995
cecfdeab19
Don't trigger while_immutable_condition for mutable fields of tuples/structs 2018-04-03 16:41:30 +02:00
Oliver Schneider
b7f5871aa0
Merge pull request #2616 from mikerite/reenable_win_dogfood
Re-enable dogfood test on Windows
2018-04-03 08:49:29 +02:00
Oliver Schneider
c012fecce6
Merge pull request #2618 from rcoh/patch-1
Move `set -e` to before the deploy
2018-04-03 08:49:19 +02:00
Russell Cohen
35125d370f
Move set -e to before the deploy
I _think_ this might be why the deploy script crashing isn't causing the release to fail (see #2600)
2018-04-02 23:11:47 -07:00
Michael Wright
6fc9d90b60 Re-enable dogfood test on Windows
This should work now that dogfood uses a separate output directory.
2018-04-03 06:22:42 +02:00
Oliver Schneider
90fcdafb79
Merge pull request #2608 from mrecachinas/feature/print-string-literal
Check for literals as println! args
2018-04-02 23:34:17 +02:00
Michael Recachinas
fa8161ba2e Revert adding env! to tests 2018-04-02 21:34:04 +01:00
Michael Recachinas
d504290839 Add edge case with env! arg to test and known problems 2018-04-02 21:14:29 +01:00
Oliver Schneider
76d1e26fe2
Merge pull request #2612 from phansch/document_how_to_use_the_author_lint
Document the author lint
2018-04-02 17:05:11 +02:00
Philipp Hansch
b1b0b36cc0
Document the author lint 2018-04-02 14:55:00 +02:00
Oliver Schneider
fef7fb3473
Merge pull request #2611 from phansch/improve_readme
Readme: Explain nightly install and clippy update
2018-04-02 12:12:02 +02:00
Oliver Schneider
c5559c1648
Merge pull request #2605 from mikerite/dogfood_target_dir
Make dogfood test output to seperate directory
2018-04-02 12:10:43 +02:00
Philipp Hansch
fe8ba21962
Readme: Explain nightly install and clippy update 2018-04-02 11:25:04 +02:00
Michael Wright
add4434ee3 Support non-unicode paths for dogfood test 2018-04-02 09:28:08 +02:00
Michael Wright
e91404bcc3 Fix clippy warning 2018-04-02 07:35:13 +02:00
Michael Wright
0fbcb30303 Merge branch 'master' into dogfood_target_dir 2018-04-02 07:28:10 +02:00
Michael Wright
fcabbeb251 Fix clippy warning
Fix too_many_arguments on `check_general_case` by allowing it. I can't
see a sensible way of grouping the parameters.
2018-04-02 07:04:43 +02:00
Michael Wright
89cb053146 Fix clippy warning
Fix cyclomatic_complexity warning on `check_expr` by allowing it. This
is preferable to increasing the threshold every time the method changes.
2018-04-02 07:04:39 +02:00
Michael Wright
57af95b6f5 Fix clippy warning
Fix `option_option` warning on `to_const_range` by taking the entire range
as an parameter instead of the start and end.
2018-04-02 07:04:25 +02:00
Michael Wright
6397131f8a Fix clippy warning
Allow `many_single_char_names` on `SpanlessHash::hash_expr`. Each
variable has a small scope and the method is readable.
2018-04-02 07:04:06 +02:00
Michael Recachinas
511aa654d7 Change declare_lint! to declare_clippy_lint! 2018-04-02 00:25:57 +01:00
Michael Recachinas
ddd75fbfec Add #![allow(print_literal)] to other test/ui/print_*.rs tests 2018-04-02 00:24:40 +01:00
Michael Recachinas
62220abfa6 Add implementation and tests for literal checking in print/println format args 2018-04-01 23:19:53 +01:00
Martin Carton
83e210935d
Merge pull request #2606 from phansch/improve_contributing_instructions
Improve CONTRIBUTING.md
2018-04-01 16:32:44 +02:00
Philipp Hansch
872db029cf
Improve CONTRIBUTING.md
* Incremental compilation is on by default
* Restructured the label overview to go from easy to more difficult labels.
2018-04-01 15:31:25 +02:00