Shotaro Yamada
20b7351439
Workaround cargo bug on Windows
2019-10-04 10:38:52 +09:00
Shotaro Yamada
555f5a49a2
Test fixes
2019-10-03 08:10:29 +09:00
Andre Bogus
e3f143ff0a
account for doc visibility
2019-10-02 21:15:28 +02:00
Lzu Tao
7065239da5
Add option_and_then_some lint
2019-08-19 03:54:40 +00:00
Philipp Hansch
5114050839
Update lint deprecation for tool lints
...
Our lint deprecation previously didn't work for tool lints, because
`register_removed` was registering lints to be removed _without_ the
`clippy` prefix.
2019-08-12 19:20:36 +02:00
Michael Wright
fd9c5a3c71
Merge branch 'master' into dev-fmt-20190728
2019-08-01 07:02:48 +02:00
Jakub Wieczorek
2a13e83f2b
Update all the code to pass the updated use_self lint.
...
One struct required a temporary `#[allow(dead_code)]` annotation due to
a bug in the Rust compiler: https://github.com/rust-lang/rust/issues/63151 .
2019-07-31 08:50:43 +00:00
Michael Wright
cc779c8050
dev-fmt: better error handling
...
Check if rustfmt is installed at the start and exit if it isn't.
2019-07-28 06:41:13 +02:00
Philipp Hansch
35b7a98f4f
Decrease maximum length for stderr files
...
Now at 275.
2019-07-17 21:13:33 +02:00
Michael Wright
2c90083f62
Avoid rustfmt bug on Windows
2019-07-11 05:21:44 +00:00
Michael Wright
11707f3443
Fix crash on dev --limit-stderr-length
2019-07-07 15:11:37 +02:00
Michael Wright
4c771c3478
Add dev fmt subcommand
2019-07-07 15:11:33 +02:00
flip1995
0e480ca4bc
Use replace_region_in_file for creating the lint list
2019-06-14 13:07:33 +02:00
Jane Lusby
a2bf96f1c6
make it pass dogfood
2019-06-12 12:29:37 -07:00
Jane Lusby
113ae891d9
run rustfmt
2019-06-12 12:29:37 -07:00
Jane Lusby
73259d68db
fix padding and put clippy someplaces
2019-06-12 12:29:37 -07:00
Jane Lusby
cfd7e0d5fd
show default lint levels
2019-06-12 12:29:37 -07:00
Jane Lusby
296794dec5
prelim arg parse
2019-06-12 12:29:37 -07:00
Jane Lusby
5abcff2be5
move Lint static def into its own module
2019-06-12 12:29:37 -07:00
Jane Lusby
f6367c41dc
switch to sorted usable lints
2019-06-12 12:29:37 -07:00
Jane Lusby
44b849521e
Update clippy_dev/src/main.rs
...
Co-Authored-By: Philipp Krones <hello@philkrones.com>
2019-06-12 12:29:37 -07:00
Jane Lusby
cf88c8487a
initial commit for help improvements on clippy-driver
2019-06-12 12:29:37 -07:00
Philipp Hansch
619a2906f8
Collect at callsite, use eprintln instead of println
2019-05-17 07:41:25 +02:00
Philipp Hansch
d9a8a8a778
Add a stderr file length check to clippy_dev
...
This adds a check to `clippy_dev` that enforces a maximum line count for
`stderr` files. CI will fail if the line count is exceeded. It's
currently set to `320` lines.
Ideally this would be implemented in `compiletest-rs` but there are
plans to move Rust's `compiletest` into the `compiletest-rs` repository
and I don't want to do the work in `compiletest` twice. However, I also
don't want to wait until the move is done, so I added the check to
`clippy_dev` until it makes sense to add it to compiletest-rs.
cc #2038
2019-05-16 21:18:32 +02:00
flip1995
5361b842d1
Remove clippy::default_hash_types internal lint
2019-04-15 13:21:52 +02:00
Alexander Regueiro
d43966a176
Various cosmetic improvements.
2019-03-10 18:06:28 +00:00
Michael Wright
acd6d4d094
Improve Clippy dev help
...
+ Print help if no subcommand is supplied
+ Make a short version of `update_lints` help for the subcommand listing
2019-03-08 07:45:31 +02:00
Andy Russell
fe96ffeac9
move lint documentation into macro invocations
2019-03-05 18:45:08 -05:00
Grzegorz
16881390e1
removing redundant closures in the whole project
2019-02-10 13:35:44 +01:00
Matthias Krüger
873fe11ca5
dependencies: update itertools from 0.7 to 0.8
2019-01-25 20:25:14 +01:00
Philipp Hansch
38d4ac7cea
Remove all copyright license headers
...
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
2019-01-08 21:46:39 +01:00
Matthias Krüger
7f5e17f3f1
fix a couple of ftrivial typos (NFC).
2018-12-25 18:22:34 +01:00
flip1995
f9c0e2a4cb
Run rustfmt on clippy_dev
2018-11-27 21:13:08 +01:00
Matthias Krüger
f5929e0797
rust-lang-nursery/rust-clippy => rust-lang/rust-clippy
2018-11-22 04:40:09 +01:00
Philipp Hansch
745a619657
Fix dogfood
2018-11-05 07:18:47 +01:00
Philipp Krones
5b24f23020
Update println! formatting
...
Co-Authored-By: phansch <dev@phansch.net>
2018-11-05 07:18:47 +01:00
Philipp Hansch
f6194f33d2
Fix false positive in check mode caused by gen_deprecated
...
`gen_deprecated` should never have created the string with linebreaks.
Using a single string broke the check because the changed lines were
different.
2018-11-05 07:18:47 +01:00
Philipp Hansch
90f31e21ab
RIIR update lints: Add check mode (update_lints.py rewrite complete)
...
This finishes up the rewrite of `update_lints.py` in Rust. More
specifically, this
* adds the `--check` flag and handling to clippy_dev
* tracks file changes over the different calls to `replace_region_in_file`
* only writes changes to files if the `--check` flag is *not* used
* runs `./util/dev update_lints --check` on CI instead of the old script
* replaces usage of the `update_lints.py` script with an error
`./util/dev update_lints` behaves 99% the same as the python script.
The only difference that I'm aware of is an ordering change to
`clippy_lints/src/lib.rs` because underscores seem to be sorted
differently in Rust and in Python.
🏁
2018-11-05 07:18:47 +01:00
bors[bot]
a07c271559
Merge #3399
...
3399: RIIR update lints: Generate modules section and lint group sections r=flip1995 a=phansch
This adds the last missing parts of the generating code.
cc #2882
Co-authored-by: Philipp Hansch <dev@phansch.net>
2018-11-03 19:11:35 +00:00
Philipp Hansch
facfb5a7a9
Fix typo
2018-11-03 18:48:39 +01:00
Philipp Hansch
cca50701d9
Improve clippy_dev help text
2018-11-03 13:43:35 +01:00
Philipp Hansch
4f38538d75
RIIR update lints: Generate lint group registrations
2018-11-03 13:43:35 +01:00
Philipp Hansch
6e3320c7ef
Test clippy_dev on CI and fix test
2018-11-03 10:58:45 +01:00
Philipp Hansch
5fc25d30e2
RIIR update lints: Generate modules section
2018-11-03 09:09:34 +01:00
Matthias Krüger
df7cff31dc
clippy: fix pedantic warnings and run clippy::pedantic lints on the codebase.
...
Turn on pedantic lints in dogfood and base tests.
needless_bool: fix clippy::items-after-statements
redundant_pattern_matching: fix clippy::similar-names
mods.rs: fix clippy::explicit-iter-loop
returns.rs: allow clippy::cast-possible-wrap
Fixes #3172
2018-11-02 12:16:43 +01:00
Philipp Hansch
7e027217f1
Fix dogfood and pedantic lints
2018-10-31 21:54:30 +01:00
Philipp Hansch
64bd658516
RIIR update lints: Generate deprecated lints
...
The update script now also generates the 'register_removed' section in
`clippy_lints/src/lib.rs`.
Also, instead of using `let mut store ...`, I added a new identifier
line so that the replacement will continue to work in case `let mut
store ...` ever changes.
2018-10-31 08:03:50 +01:00
Philipp Hansch
9f3ac4e5a3
RIIR update_lints: Update changelog links
...
This now also updates the link list at the bottom of the changelog.
2018-10-17 08:18:05 +02:00
Philipp Hansch
05ffc2d057
Fix dogfood
...
`expect_fun_call` causes a false-positive, so I disabled it for now.
2018-10-16 20:58:00 +02:00
Philipp Hansch
956987f43e
RIIR update_lints: Replace lint count in README.md
...
This allows the usage of `util/dev update_lints` which will write the
new lint_count to the `README.md`.
2018-10-16 08:14:32 +02:00
Philipp Hansch
af441b5b07
Rename active_lints to usable_lints
...
Because now `usable_lints` will also exclude internal lints.
2018-10-16 08:09:32 +02:00
Philipp Hansch
b5dd8f17d1
Add comment on WalkDir vs. fs::read_dir
2018-10-15 21:10:22 +02:00
Philipp Hansch
b61ca63c5e
sort_by -> sort_by_key
2018-10-15 21:02:38 +02:00
Philipp Hansch
fb830c53db
Some more documentation for clippy_dev
2018-10-15 20:47:19 +02:00
Philipp Hansch
7da97a94df
Use WalkDir to also gather from subdirectories
...
`fs::read_dir` does not recurse into subdirectories.
2018-10-15 20:44:22 +02:00
Oliver Scherer
b8654eaa6c
Stabilize tool lints
2018-10-11 12:16:22 +02:00
Philipp Hansch
759ceb9840
Use impl Iterator in arg position in clippy_dev
...
Small refactoring pulled out of work on #3266 .
This should make the methods a bit more flexible.
2018-10-11 08:34:51 +02:00
Manish Goregaokar
e9c025ea70
Add license header to Rust files
2018-10-06 09:43:08 -07:00
Matthias Krüger
2a31937cc9
fix all clippy::use_self pedantic warnings found in the codebase.
...
cc #3172
2018-09-26 22:24:18 +02:00
Matthias Krüger
f2ecee3638
clippy_dev: port to edition 2018
2018-09-23 14:44:06 +02:00
flip1995
e28440d2e0
Change Hash{Map, Set} to FxHash{Map, Set}
2018-09-12 01:34:52 +02:00
Philipp Hansch
3bdc691a91
Pass by ref instead of value
2018-09-06 08:19:09 +02:00
Philipp Hansch
de36d42e80
More refactoring
2018-09-06 07:15:31 +02:00
Philipp Hansch
79bec036f8
Return impl Iterator instead of Vec<Lint>
...
This makes the API of `lib.rs` a bit more flexible.
2018-09-05 13:34:28 +02:00
Philipp Hansch
586ef4ed72
Refactor to use into_group_map from Itertools
2018-09-03 22:18:53 +02:00
Philipp Hansch
78d358b861
s/direntry/dir_entry
2018-09-03 22:18:53 +02:00
Philipp Hansch
70312430dd
Use insignificant whitespace mode for nice regex
2018-09-03 22:18:53 +02:00
Philipp Hansch
35f100b4f9
update_lints rewrite: Add structure and --print-only
2018-09-03 22:18:51 +02:00
