bors
406e89a00c
Auto merge of #4601 - lzutao:clean-up-unused-vars, r=phansch
...
Clean up some unused vars
changelog: none
2019-09-29 17:05:36 +00:00
Lzu Tao
aa4f3fb537
Clean up some unused vars
2019-09-29 23:46:32 +07:00
bors
b292183c68
Auto merge of #4600 - lzutao:rustup-63492, r=oli-obk
...
Rustup rust-lang/rust#63492
changelog: none
2019-09-29 16:06:56 +00:00
Lzu Tao
6e3a0ea6b3
Rustup rust-lang/rust#63492
2019-09-29 22:58:17 +07:00
bors
fe920ebf8b
Auto merge of #4593 - james9909:fix-multiple-inherent-impls, r=llogiq
...
Fix false positive in `multiple_inherent_impl`
changelog: Fix false positive in `multiple_inherent_impl` by ignoring impls derived from macros.
Closes #4578 .
2019-09-29 06:21:55 +00:00
bors
5f058d80fc
Auto merge of #4594 - matthiaskrgr:rustup_18, r=phansch
...
rustup https://github.com/rust-lang/rust/pull/64781/
cc https://github.com/rust-lang/rust/issues/64867
changelog: none
2019-09-28 09:51:08 +00:00
Matthias Krüger
5f6e3f35b5
rustup https://github.com/rust-lang/rust/pull/64781/
...
cc https://github.com/rust-lang/rust/issues/64867
2019-09-28 10:42:41 +02:00
James Wang
189eaa54c6
Ignore impls derived from macros
2019-09-27 20:47:00 -05:00
bors
edd90473ec
Auto merge of #4591 - flip1995:rustup, r=flip1995
...
Rustup to rust-lang/rust#64813
cc rust-lang/rust#64843
changelog: none
2019-09-27 16:19:14 +00:00
flip1995
fff6b0e17c
Remove clippy::author attribute from trailing_zeroes test
2019-09-27 18:10:18 +02:00
flip1995
b67dfb4896
Move author issue test to author subdir
2019-09-27 18:07:07 +02:00
flip1995
8d8ba14371
Fix author lint
2019-09-27 18:01:04 +02:00
flip1995
4bbd10a585
Rustup to rust-lang/rust#64813
2019-09-27 17:21:20 +02:00
bors
bca08a65df
Auto merge of #4589 - mikerite:booleans-refactor-20190925, r=phansch
...
Refactor `booleans`
Remove unused output from `suggest(..)`
changelog: none
2019-09-27 06:16:55 +00:00
Michael Wright
8b9415cd88
Refactor booleans
...
Remove unused output from `suggest(..)`
2019-09-27 07:59:34 +02:00
bors
f7d7456303
Auto merge of #4585 - michaelsproul:arith-assign-op, r=llogiq
...
Detect mutating arithmetic in integer_arithmetic restriction lint
changelog: detect mutating arithmetic (like +=) in `integer_arithmetic` restriction lint
2019-09-27 04:46:06 +00:00
Michael Sproul
4f9d6eea5c
Detect assignment ops in integer_arithmetic
2019-09-27 11:55:42 +10:00
bors
68ff8b19bc
Auto merge of #4582 - matthiaskrgr:rustup_17, r=Manishearth
...
rustup https://github.com/rust-lang/rust/pull/64515
changelog: none
2019-09-26 17:32:24 +00:00
Matthias Krüger
e59d619981
rustup https://github.com/rust-lang/rust/pull/64515
...
changelog: none
2019-09-26 18:34:43 +02:00
bors
b5600c9852
Auto merge of #4581 - Manishearth:osx-enable, r=matthiaskrgr
...
Re enable OSX builders
Fixes #4576
changelog: none
2019-09-26 10:33:44 +00:00
Manish Goregaokar
70f03dd41f
Re enable OSX builders
...
Fixes #4576
2019-09-26 03:31:08 -07:00
bors
3335209059
Auto merge of #4580 - lzutao:rustup, r=flip1995
...
Rustup rust-lang/rust#64513
changelog: none
2019-09-26 09:13:59 +00:00
Lzu Tao
54371929d2
Remove unused import
2019-09-26 16:08:30 +07:00
Lzu Tao
a7b7e19f49
Rustup https://github.com/rust-lang/rust/pull/64513
2019-09-26 16:03:36 +07:00
bors
adc1df11b4
Auto merge of #4568 - mikerite:fix-4548, r=flip1995
...
Fix `nonminimal-bool` false positive
Closes #4548
Closes #3847
changelog: Fix `nonminimal-bool` false positive
2019-09-26 08:06:16 +00:00
bors
4d30b08027
Auto merge of #4569 - james9909:add-comparison-chain, r=oli-obk
...
Add a new lint for comparison chains
changelog: Adds a new lint: `comparison_chain`.
`comparison_chain` lints all `if` conditional chains where all the conditions are binary comparisons on the same two operands and will suggest a rewrite with `match`.
Closes #4531 .
2019-09-26 07:38:08 +00:00
bors
bc1b04ba85
Auto merge of #4570 - lzutao:call_site_toplevel_ref_arg, r=phansch
...
Fix macro expansion in toplevel_ref_arg lint
changelog: Fix macro expansion in toplevel_ref_arg lint
2019-09-26 06:02:21 +00:00
Lzu Tao
5639639d35
Remove unused attribute in test
2019-09-26 01:53:39 +00:00
Lzu Tao
08ce6bc6d9
Fix macro expansion in toplevel_ref_arg lint
2019-09-26 08:46:51 +07:00
Lzu Tao
3b9e5dfda5
Add regression test for macro expansion
2019-09-26 08:14:58 +07:00
bors
1366629262
Auto merge of #4575 - Manishearth:suggestions, r=oli-obk
...
Make more tests rustfixable
Fixes https://github.com/rust-lang/rust-clippy/issues/3630
changelog: Improve suggestions for many lints in preparation for `cargo fix --clippy`
r? @phansch @yaahc
2019-09-25 21:54:14 +00:00
Manish Goregaokar
49374a4380
Downgrade op_ref to a MaybeIncorrect suggestion
2019-09-25 14:53:48 -07:00
Manish Goregaokar
b94f2e89fd
unnecessary_operation: make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
04dd580f37
unnecessary_clone: split rustfixable lint out into separate test
2019-09-25 14:45:18 -07:00
Manish Goregaokar
363e382f5b
string_add, string_add_assign: split tests, make one rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
1a4dcfca35
redundant_static_lifetimes: split test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
ea16ab56d5
renamed_builtin_attr: make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
d28dacb33a
redundant_pattern_matching: make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
a83a8dccba
redundant_closure_call: split tests into fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
e4ff86dcd4
map_unit_fn: make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
ad0e7c8e7f
map_unit_fn: fix applicability
2019-09-25 14:45:18 -07:00
Manish Goregaokar
24c283ea12
option_map_unit_fn: Split into fixable/unfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
38a0785436
map_unit_fn: rename tests to fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
1090509564
non_copy_const: remove incorrect suggestion
2019-09-25 14:45:18 -07:00
Manish Goregaokar
a9a3350455
needless_return: add allow()s to test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
980650eec2
needless_collect: fix suggestion, make test rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
7f822e742d
needless_borrowed_ref: fix false positive, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
622b167eb8
needless_borrow: allow other lints, make fixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
0d8e4d7c37
mem_discriminant: split test, make rustfixable
2019-09-25 14:45:18 -07:00
Manish Goregaokar
483e140bce
map_flatten: make it a rustfix test
2019-09-25 14:45:18 -07:00
