3524 commits

This branch

This branch

All branches

Author	SHA1	Message	Date
Guillem Nieto	3ac84b2542	Remove explicit visit_qpath method ... Instead of replacing the default behaviour of the visit_qpath method, I've moved the printing code to private method of PrintVisitor (print_qpath).	2018-02-24 19:34:51 +01:00
Guillem Nieto	8494f57c82	Fix author lint ... The author lint was generating invalid code as shown on issue: https://github.com/rust-lang-nursery/rust-clippy/issues/2442 I've changed the generated code to properly track cast expressions. Unfortunatelly, I've had to rewrite the `visit_decl` method, to avoid that last if of the chain will be added. After looking at the code, this last line was being added because of the `let x: char` part, but not because of the `0x45df as char` expression. It seems that let statements should not generate code on the author lint, but I'm not sure that this is true or if I'm breaking something on other code generation parts. Finally, I've added a test for the author lint, but I'm not sure that this needs to be added to the testsuite.	2018-02-24 02:19:47 +01:00
Oliver Schneider	575c3c4b54	Merge pull request #2471 from bootandy/fix_span2 ... Fix: point to correct problem part of code, update test	2018-02-23 08:31:57 +01:00
bootandy	aef07e3392	Do not pass Span by reference	2018-02-22 10:11:20 -05:00
Oliver Schneider	5e6342d4ae	Merge pull request #2473 from phansch/handle_multiline_attributes ... Lint multiline attributes properly	2018-02-21 21:44:04 +01:00
Philipp Hansch	d3d3d7d7be	Lint multiline attributes properly ... This makes it so that the `empty_line_after_outer_attribute` lint only checks for newlines between the end of the attribute and the beginning of the following item. We need to check for the empty line count being bigger than 2 because now the snippet of valid code contains only `\n` and splitting it produces `["", ""]` Invalid code will contain more than 2 empty strings.	2018-02-21 21:29:05 +01:00
bootandy	a7c97256dc	Stop unwanted newlines being applied on unwrap_or	2018-02-21 11:29:08 -05:00
bootandy	c708154c16	Simplify creation of span_replace_word ... Part of unwrap_or test	2018-02-20 12:38:20 -05:00
bootandy	f3d1a0cec2	Add newlines in unwrap_or ui test	2018-02-20 12:37:30 -05:00
Oliver Schneider	a7407f9acc	Merge pull request #2459 from phansch/mention_how_to_run_single_test ... Explain how to execute a single UI test	2018-02-20 08:33:47 +01:00
Oliver Schneider	a149ec4b3c	Merge pull request #2458 from flip1995/suspicious_impl ... Lint for suspicious implementations of arithmetic std::ops traits	2018-02-20 08:32:01 +01:00
Oliver Schneider	e061261c48	Merge pull request #2470 from flip1995/doc_conf ... Fix name of configuration parameters in documentation	2018-02-20 08:26:22 +01:00
bootandy	941e062fd4	Fix: point to correct problem part of code ... Fix span so it no longer contains the whole train-wreck of code and only points to the problem function (for the unwrap_or lint). https://github.com/rust-lang-nursery/rust-clippy/issues/2422 Update ui test methods - it had several cases where the error message span is now shorter	2018-02-19 12:14:53 -05:00
flip1995	339d2d5be0	Fix name of configuration parameters in documentation	2018-02-19 16:30:19 +01:00
Philipp Krones	c43e053f3f	Merge branch 'master' into suspicious_impl	2018-02-19 13:04:14 +01:00
Oliver Schneider	038b17f3a6	Merge pull request #2451 from TomasKralCZ/rdn-fields ... Implement redundant field names lint #2244	2018-02-19 09:56:55 +01:00
Philipp Hansch	0b4e0b82a9	Explain how to execute a single UI test	2018-02-13 22:33:42 +01:00
flip1995	aa20277a17	Lint for suspicious implementations of arithmetic std::ops traits	2018-02-13 15:40:17 +01:00
TomasKralCZ	42120141bd	Suggestion fixed, simplified lint logic.	2018-02-12 11:26:00 +01:00
TomasKralCZ	85642ddd23	Implement redundant field names lint #2244	2018-02-10 22:52:31 +01:00
Oliver Schneider	6b3487a916	Merge pull request #2448 from rust-lang-nursery/fixes ... Fixes	2018-02-09 18:32:23 +01:00
Oliver Schneider	6feb0dd982	Fixes #2426 (if_same_then_else false positive)	2018-02-09 15:31:55 +01:00
Oliver Schneider	ff32d5f734	Fix #2427	2018-02-09 15:25:12 +01:00
Oliver Schneider	88970ec8cf	Remove rarely used type_size helper function	2018-02-09 15:24:31 +01:00
Oliver Schneider	fc7b3955f8	Merge pull request #2446 from goodmanjonathan/fix-copies-test ... Make several tests actually test the correct lints	2018-02-09 12:41:08 +01:00
Oliver Schneider	ffb3a56c41	Merge pull request #2445 from guido4000/patch-1 ... Simplify recommended command	2018-02-09 08:06:51 +01:00
Jonathan Goodman	44780aca5d	make the copies.rs test actually test the correct lints	2018-02-08 13:26:50 -06:00
Guido	b52f46d1d1	Change command to run clippy without installation	2018-02-08 12:37:56 +01:00
Guido	45e4f3aac7	Simplify recommended command	2018-02-07 19:24:38 +01:00
Oliver Schneider	6f48e37d22	Merge pull request #2444 from phansch/fix_incorrect_useless_attribute_suggestion ... Partly fix incorrect useless_attribute suggestion	2018-02-07 09:07:46 +01:00
Philipp Hansch	81f5969704	Partly fix incorrect useless_attribute suggestion ... This fixes an incorrect suggestion from the `useless_attribute` lint when using `cfg_attr`. Additionally, it will not show a suggestion anymore, if the attribute begins on a previous line, because it is much harder to construct the span of multi-line `cfg_attr` attributes as they don't appear in the AST. To fix it completely, one would have to parse upwards into the file, and find the beginning of the `cfg_attr` attribute.	2018-02-06 22:35:11 +01:00
Oliver Schneider	81b2565246	Merge pull request #2443 from goodmanjonathan/fix-2438 ... Don't suggest eliding 'static on associated consts	2018-02-06 19:35:26 +01:00
Jonathan Goodman	73f2ba5ded	don't suggest eliding 'static on associated consts	2018-02-06 12:22:34 -06:00
Oliver Schneider	b835877d2e	Merge pull request #2441 from flip1995/literal_rep ... Make decimal_literal_representation a restriction lint	2018-02-06 13:47:28 +01:00
flip1995	63a7daf78c	Make decimal_literal_representation a restriction lint	2018-02-06 13:05:20 +01:00
Oliver Schneider	c322a74980	Merge pull request #2439 from gnieto/fix/cterror ... Fix ICE comparing `ExprRange` equality	2018-02-06 09:19:51 +01:00
Guillem Nieto	bcf2e41421	Fix ICE comparing ExprRange ... `eq_expr` on hir::utils was throwing an ICE due to an invalid LateContext being used. Due to this missusage, it was generating an ICE with the code on the following issue: https://github.com/rust-lang-nursery/rust-clippy/issues/2423	2018-02-06 01:06:32 +01:00
Oliver Schneider	503a63390d	Cleanup calls to layout_of	2018-02-05 11:28:09 +01:00
Oliver Schneider	ce47e529d2	Version Bump	2018-02-05 08:48:40 +01:00
Oliver Schneider	30a37efaac	Merge pull request #2433 from kimsnj/matches_sugg ... Fix suggestions for ref matches	2018-02-05 08:21:21 +01:00
Oliver Schneider	7fddc6116e	Merge pull request #2415 from HMPerson1/fix-2356 ... Fix `ImplItem`s being ignored	2018-02-05 08:19:11 +01:00
Oliver Schneider	02ee62533d	Merge pull request #2428 from phansch/fix_lint_list_issues ... Allow empty lines in lint doc examples	2018-02-05 08:18:20 +01:00
Oliver Schneider	bef22006b4	Merge pull request #2419 from phansch/fix_doc_comment_false_positive ... Fix false positive in empty_line_after_outer_attr	2018-02-05 08:17:29 +01:00
Oliver Schneider	02830187cc	Merge pull request #2436 from messense/rustup ... Rustup to rustc 1.25.0-nightly (0c6091fbd 2018-02-04)	2018-02-05 08:08:15 +01:00
messense	5226b664a1	Rustup to rustc 1.25.0-nightly (0c6091fbd 2018-02-04)	2018-02-05 12:16:17 +08:00
Karim Snj	21f606bd68	Removing extra newline	2018-02-04 13:55:37 +01:00
Karim Snj	9575dac491	Fix suggestions for ref matches	2018-02-04 13:41:54 +01:00
Manish Goregaokar	8e8cf2feb1	Bump to 0.0.185	2018-02-02 13:23:32 +05:30
HMPerson1	10d2feddba	Fix const_static_lifetime	2018-02-02 02:03:21 -05:00
Manish Goregaokar	c26be4c05c	Merge pull request #2430 from Frederick888/fix-2429 ... set CodeSuggestion approximate to false. fixes #2429	2018-02-02 12:30:46 +05:30