Marcel Hellwig
ead2c4f122
fix incorrect suggestion for maybe trait bounds
2022-07-07 12:43:16 +02:00
Marcel Hellwig
f2bef55389
trait_bounds: rework two loops into one
...
the two loops did practically the same, only the type were different (&&
vs &), so I used `copied` to convert `&&` and chained them together.
Instead of parsing the trait info manually, I use the already provided
method `get_trait_info_from_bound`.
Also, instead of using manual string writing, I used `join` by
`itertools`.
2022-07-07 12:43:16 +02:00
Camille GILLOT
347d999b97
Shorten span for closures.
2022-07-07 09:27:42 +02:00
Tomasz Miąsko
cac25cde18
Move predecessors from Body to BasicBlocks
2022-07-07 08:11:49 +02:00
bors
5483a7dd44
Auto merge of #98827 - aDotInTheVoid:suggest-extern-block, r=nagisa
...
Suggest using block for `extern "abi" fn` with no body
`@rustbot` modify labels: +A-diagnostics
2022-07-07 04:18:47 +00:00
bors
afb34eb261
Auto merge of #9096 - Jarcho:needless_borrow_subs, r=Manishearth
...
Fix `needless_borrow` 9095
fixes #9095
changelog: Don't lint `needless_borrow` on method receivers when it would change which trait impl is called
2022-07-06 21:26:46 +00:00
xFrednet
0d443d17eb
Fix #[expect] and #[allow] for clippy::duplicate_mod
2022-07-06 22:01:40 +02:00
Takayuki Maeda
e34ee2484b
fix miri-opt tests
2022-07-06 19:09:50 +09:00
bors
f93d418f17
Auto merge of #9099 - joshtriplett:unnecessary-lazy-eval-then-some, r=flip1995
...
Extend unnecessary_lazy_eval to cover `bool::then` -> `bool::then_some`
fixes #9097
changelog: Extend `unnecessary_lazy_eval` to convert `bool::then` to `bool::then_some`
2022-07-06 09:20:55 +00:00
Josh Triplett
b7230d4f44
Dogfood fixes to use bool::then_some
2022-07-06 02:03:56 -07:00
flip1995
f84d9bcbb1
Build the Clippy book as part of x.py doc
2022-07-06 10:01:27 +02:00
Josh Triplett
ebff7206bc
Add MSRV check for bool::then_some
2022-07-06 01:00:19 -07:00
Josh Triplett
528308b5aa
Extend unnecessary_lazy_eval to cover bool::then -> bool::then_some
2022-07-06 00:48:51 -07:00
Alan Egerton
490c773e66
Update TypeVisitor paths
2022-07-06 06:41:53 +01:00
Alan Egerton
5c35569ff7
Relax constrained generics to TypeVisitable
2022-07-05 22:25:43 +01:00
bors
fd605ab7e4
Auto merge of #9124 - Jarcho:shadow_ice, r=Alexendoo
...
Lint `shadow_*` lints in anon const blocks
changelog: Lint `shadow_*` lints in anon const blocks
2022-07-05 20:04:14 +00:00
Jason Newcomb
3db0e00bdc
Lint shadow_* lints in anon const blocks
2022-07-05 15:21:27 -04:00
bors
462136ac68
Auto merge of #9121 - alex-semenyuk:fix_ui_test_cast_32_bits, r=flip1995
...
Fix stderr for cast_size_32bit
changelog: fix stderr for cast_size_32bit
2022-07-05 08:57:12 +00:00
alexey semenyuk
2ccb05487c
Fix stderr for cast_size_32bit
2022-07-05 09:43:29 +03:00
bors
48e527e4bd
Auto merge of #9117 - Jarcho:unsafe_block_closure, r=giraffate
...
Fix `undocumented_unsafe_blocks` in closures
fixes #9114
changelog: Fix `undocumented_unsafe_blocks` not checking for comments before the start of a closure
2022-07-05 00:20:33 +00:00
bors
c257f098a8
Auto merge of #9115 - Alexendoo:new-with-const-generics, r=llogiq
...
`new_without_default`: ignore const generics/lifetime params on `fn new`
Fixes #9113
No longer lints if `fn new` has any params
changelog: [`new_without_default`]: no longer lints const generics and lifetime params on `fn new`
2022-07-04 18:19:37 +00:00
Jason Newcomb
975667945c
Fix undocumented_unsafe_blocks in closures
2022-07-04 13:53:42 -04:00
Alex Macleod
fec4593082
new_without_default: ignore const generics/lifetime params on fn new
2022-07-04 14:03:11 +00:00
bors
b15f06e74f
Auto merge of #9093 - Jarcho:deref_ice, r=giraffate
...
Fix ICE in `dereference.rs`
fixes #9089
changelog: Fix ICE when dereferencing or borrowing on explicit returns from closures
2022-07-04 00:22:17 +00:00
bors
8c8987749b
Auto merge of #9105 - Serial-ATA:lint-invalid-utf8, r=Jarcho
...
Add `invalid_utf8_in_unchecked`
changelog: Add [`invalid_utf8_in_unchecked`]
closes : #629
Don't know how useful of a lint this is, just saw this was a really old issue 😄 .
2022-07-03 20:02:38 +00:00
Serial
de646e10db
Add invalid_utf8_in_unchecked
2022-07-03 15:37:30 -04:00
bors
be9e35f6b2
Auto merge of #9110 - alex-semenyuk:fix_trailling_commas, r=xFrednet
...
Remove trailing spaces
Closes #9108
changelog: remove trailing spaces, which are not allowed by the JSON standard.
2022-07-03 19:33:01 +00:00
alexey semenyuk
9ef76e051b
Fixed comment
2022-07-03 19:03:51 +00:00
bors
0fd4f1c75b
Auto merge of #9112 - xFrednet:9088-fix-lint-versions, r=Jarcho
...
Correct `[clippy::version]` for 1.62 lints and add note to docs
closes: https://github.com/rust-lang/rust-clippy/issues/9088
changelog: none
---
It feels weird to have such a short PR description. So, what should I add to this one... Yes, art:
```txt
,-----.,--.,--.
' .--./| |`--' ,---. ,---.,--. ,--.
| | | |,--.| .-. || .-. |\ ' /
' '--'\| || || '-' '| '-' ' \ '
`-----'`--'`--'| |-' | |-'.-' /
`--' `--' `---'
```
```txt
,-----.,--. ,--.,------. ,------.,--. ,--.
' .--./| | | || .--. '| .--. '\ `.' /
| | | | | || '--' || '--' | '. /
' '--'\| '--.| || | --' | | --' | |
`-----'`-----'`--'`--' `--' `--'
```
```txt
_____ _ _____ _____ _______ __
/ ____| | |_ _| __ \| __ \ \ / /
| | | | | | | |__) | |__) \ \_/ /
| | | | | | | ___/| ___/ \ /
| |____| |____ _| |_| | | | | |
\_____|______|_____|_| |_| |_|
```
2022-07-03 18:41:54 +00:00
xFrednet
2dd5fc14da
Correct [clippy::version] for 1.62 lints and add note to docs
2022-07-03 17:02:48 +02:00
alexey semenyuk
65655d1e1e
Remove trailing spaces
2022-07-03 17:44:09 +03:00
bors
b8bdbb7a00
Auto merge of #9106 - usefulmove:master, r=flip1995
...
corrected README.md book link
This change corrects the book link on the Clippy Book README.md.
changelog: none
2022-07-03 13:10:07 +00:00
Duane
815a3ccd79
corrected README.md book link
2022-07-02 20:41:58 -07:00
Nixon Enraght-Moony
ab23b3aa8a
ast: Add span to Extern
2022-07-02 23:30:03 +01:00
Jason Newcomb
988b813649
Use correct substitutions when checking if needless_borrow can apply to a method receiver
2022-07-02 15:48:46 -04:00
Dylan DPC
053caf8885
Rollup merge of #98639 - camsteffen:no-node-binding, r=compiler-errors
...
Factor out `hir::Node::Binding`
2022-07-02 12:23:38 +05:30
Jason Newcomb
3e80d3988d
Fix ICE in dereference.rs
2022-07-02 00:59:58 -04:00
bors
8c341d66a1
Auto merge of #9087 - alex-semenyuk:fix_link, r=llogiq
...
Fix broken link
changelog: none
2022-07-01 18:39:54 +00:00
alexey semenyuk
7350525ffb
Fix link
2022-07-01 18:31:57 +00:00
bors
f30b68d9d6
Auto merge of #9085 - xFrednet:9081-update-format-push-version, r=Manishearth,flip1995
...
Correct lint version for `format_push_string`
Closes #9081
changelog: none
IDK what else to say. Look I can draw an ascii penguin =D:
```
(^v^)
<( )>
w w
```
2022-07-01 16:51:34 +00:00
xFrednet
a86bf81e44
Correct lint version for format_push_string
2022-07-01 18:05:45 +02:00
bors
097f7654b5
Auto merge of #9082 - Alexendoo:let_unit_allow, r=xFrednet
...
Fix direct `#[allow]` attributes in `let_unit_value`
Fixes part of #9080
Not sure why it doesn't work when the lint is emitted at the statement, but switching it to the local works fine
changelog: Fix direct `#[allow]` attributes in [`let_unit_value`]
2022-07-01 15:51:41 +00:00
Camille GILLOT
d5e33d3ded
Shorten def_span for more items.
2022-07-01 17:39:19 +02:00
Cameron Steffen
5de85902fa
Factor out hir::Node::Binding
2022-07-01 10:04:19 -05:00
bors
d8970bfa08
Auto merge of #9083 - giraffate:fix_link_in_changelog, r=flip1995
...
Fix some links
changelog: none
2022-07-01 12:55:38 +00:00
Takayuki Nakata
1988375a25
Fix some links
2022-07-01 21:30:59 +09:00
Alex Macleod
a5b70a4c1d
Fix allow attributes in let_unit_value
2022-07-01 12:14:28 +00:00
bors
d4488a520a
Auto merge of #9039 - Serial-ATA:dev-dogfood, r=giraffate
...
Add `cargo dev dogfood`
changelog: Add `cargo dev dogfood`
Part of #5394
2022-07-01 01:07:25 +00:00
bors
23db5ce261
Auto merge of #9075 - Serial-ATA:update-docs, r=flip1995
...
Add `dev deprecate` to the development basics
changelog: none
2022-06-30 20:55:04 +00:00
bors
6177a4f593
Auto merge of #9078 - hamza1311:patch-1, r=xFrednet
...
Fix broken hyperlink in documentation
changelog: none
The hyperlinks in [`is_digit_ascii_radix`](https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix )'s docs are broken. This PR fixes those.
2022-06-30 19:24:50 +00:00
