Mirrors/rust-clippy
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-clippy synced 2024-11-14 17:07:17 +00:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #9115 - Alexendoo:new-with-const-generics, r=llogiq

Browse source 
`new_without_default`: ignore const generics/lifetime params on `fn new`

Fixes #9113

No longer lints if `fn new` has any params

changelog: [`new_without_default`]: no longer lints const generics and lifetime params on `fn new`
This commit is contained in:
bors 2022-07-04 18:19:37 +00:00
commit c257f098a8
2 changed files with 17 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
clippy_lints/src/new_without_default.rs
View file

@ -88,15 +88,9 @@ impl<'tcx> LateLintPass<'tcx> for NewWithoutDefault {
// shouldn't be implemented when it is hidden in docs
return;
}
if impl_item
.generics
.params
.iter()
.any(|gen| matches!(gen.kind, hir::GenericParamKind::Type { .. }))
{
// when the result of `new()` depends on a type parameter we should not require
// an
// impl of `Default`
if !impl_item.generics.params.is_empty() {
// when the result of `new()` depends on a parameter we should not require
// an impl of `Default`
return;
}
if_chain! {

14
tests/ui/new_without_default.rs
View file

@ -212,3 +212,17 @@ impl DocHidden {
}
fn main() {}
pub struct IgnoreConstGenericNew(usize);
impl IgnoreConstGenericNew {
pub fn new<const N: usize>() -> Self {
Self(N)
}
}
pub struct IgnoreLifetimeNew;
impl IgnoreLifetimeNew {
pub fn new<'a>() -> Self {
Self
}
}