Oliver Schneider
19929790aa
Merge pull request #1561 from Manishearth/zero_ptr
...
New zero_ptr lint.
2017-02-22 13:34:28 +01:00
Oliver Schneider
e494a69452
Merge pull request #1571 from sinkuu/assert_ne
...
Suggest `assert_ne` for `assert!(x != y)`
2017-02-22 09:31:19 +01:00
sinkuu
1e26c44010
Suggest assert_ne
for assert!(x != y)
2017-02-22 16:47:18 +09:00
Andre Bogus
3c04109fcc
fix German keyboard fail
2017-02-21 17:28:17 +01:00
Oliver Schneider
a7c049df28
Merge pull request #1564 from Manishearth/cleanup
...
Cleanup test suite
2017-02-21 15:30:39 +01:00
Oliver Schneider
d032b8967c
Merge pull request #1491 from Manishearth/into_iter_on_ref
...
fix explicit_into_iter_loop on references
2017-02-21 14:55:52 +01:00
Oliver Schneider
27aa309b3d
Merge pull request #1556 from sinkuu/take_by_value
...
Lint needless take-by-value
2017-02-21 13:07:25 +01:00
Oliver Schneider
25e230419c
Merge system independent ui-tests back into tests/ui
2017-02-21 12:19:55 +01:00
Oliver Schneider
f10128369b
fix ui-posix test paths
2017-02-21 12:16:57 +01:00
Oliver Schneider
f2ff5e2133
Update ui test output
2017-02-21 12:13:44 +01:00
Oliver Schneider
0996f8bb00
Fix more wrong windows ui test paths
2017-02-21 12:12:45 +01:00
Oliver Schneider
ff655a7dbc
Ui windows test paths are wrong
2017-02-21 12:12:08 +01:00
Oliver Schneider
42c451c122
update help message to match the suggestion
2017-02-21 12:04:48 +01:00
Oliver Schneider
21a0b16aee
adjust messages in tests
2017-02-21 12:04:29 +01:00
Oliver Schneider
c46178c518
rustfmt
2017-02-21 12:01:41 +01:00
Oliver Schneider
c1cf5a2cde
cleanup and create another helper function that we should use more often
2017-02-21 12:01:41 +01:00
Oliver Schneider
0bea3e76d4
fix explicit_into_iter_loop on references
...
fixes #1398
2017-02-21 12:01:41 +01:00
sinkuu
bf21c84629
Ensure deref_span is empty for Vec and String
2017-02-21 19:45:45 +09:00
Oliver Schneider
89d98a8732
Simplify calling update-all-references.sh
2017-02-21 11:18:05 +01:00
Oliver Schneider
3af04c7816
Cleanup test suite
2017-02-21 11:11:33 +01:00
sinkuu
cb86c57c5f
Integrate suggestion spans
2017-02-21 19:03:50 +09:00
sinkuu
3516d45d7c
Use multispan_sugg
2017-02-21 18:44:31 +09:00
Oliver Schneider
55ea08102a
Merge pull request #1543 from Manishearth/fix-windows-tests
...
fix windows tests
2017-02-21 10:34:49 +01:00
Oliver Schneider
3fa1cd9411
Don't run cargo clippy on 64 bit
2017-02-21 09:38:33 +01:00
Oliver Schneider
f07f793fa8
Merge pull request #1544 from bood/master
...
Add lint for unnecessary casts (cast to same type)
2017-02-21 09:16:07 +01:00
Oliver Schneider
3900223762
Merge pull request #1559 from theotherphil/master
...
Use span of impl/trait in len_without_is_empty error message, rather …
2017-02-21 09:13:11 +01:00
Oliver Schneider
7c1efc6570
Merge pull request #1538 from Manishearth/publish
...
only require rustfmt and update_lints for version bumps
2017-02-21 08:30:53 +01:00
Andre Bogus
2f7babba82
New zero_ptr lint.
...
This fixes #1047 . I did not bother to add a full suggestion,
because replacing with `std::ptr::null()` may still lead to
inference failures.
2017-02-21 04:36:59 +01:00
sinkuu
627d24c80f
Fix suggestion for let <pat>
2017-02-21 00:27:12 +09:00
sinkuu
263e60ce0b
Run update_lints.py
2017-02-20 16:55:52 +09:00
sinkuu
f1b0b774e7
Support non-moving usages at match
...
This `match` is not moving the `String`:
```rust
fn foo(x: Option<String>) -> i32 {
match x {
Some(_) => 1,
None => 2,
}
}
```
With this change, it will be linted and suggested to add `*` to deref it.
```rust
fn foo(x: &Option<String>) -> i32 {
match *x {
Some(_) => 1,
None => 2,
}
}
```
2017-02-20 16:45:37 +09:00
sinkuu
0a6bc6031a
Rename lint to needless_take_by_value
...
And fixes false-positives for generics and `match`
2017-02-20 16:02:48 +09:00
Phil Ellison
d6a4d2cb18
Fix typo
2017-02-19 15:39:40 +00:00
Phil Ellison
0396756098
Add test that adding allow attribute on impl block containing len silences len_without_is_empty. Add extra impl block to PubOne to check that this doesn't get flagged@
2017-02-19 15:36:17 +00:00
Phil Ellison
2dd45b7317
Use span of impl/trait in len_without_is_empty error message, rather than the span of the len method
2017-02-19 15:14:30 +00:00
sinkuu
d2f73e7818
Add explanation
2017-02-19 18:07:37 +09:00
sinkuu
d81d961ba7
Lint needless take-by-value
2017-02-19 07:59:44 +09:00
Oliver Schneider
8a227c7577
Merge pull request #1550 from sinkuu/should_assert_eq
...
Lint `assert!(x == y)`
2017-02-18 08:23:11 +01:00
Bood Qian
ee86d46cd1
Update README
2017-02-18 11:13:38 +08:00
Bood Qian
97d46232b4
Merge branch 'master' of github.com:Manishearth/rust-clippy
2017-02-18 11:12:13 +08:00
sinkuu
d2b9b7ece2
Fix language & if_let_chain usage
2017-02-18 10:14:25 +09:00
sinkuu
8cb2ec804d
Support generic type
2017-02-18 10:14:25 +09:00
sinkuu
16e53c9868
Run update_lints.py
2017-02-18 10:14:20 +09:00
sinkuu
6bb426b0e3
Add should_assert_eq
lint ( fixes #641 )
2017-02-18 10:13:56 +09:00
Oliver Schneider
9d8dc689c7
rustfmt again
2017-02-17 13:41:59 +01:00
Oliver Schneider
0682c950bc
Merge pull request #1548 from mathstuf/missing-eol
...
main: end error messages with a newline
2017-02-17 13:40:51 +01:00
Oliver Schneider
96c93036af
Merge pull request #1549 from Manishearth/never_loop
...
New never loop lint
2017-02-17 13:40:05 +01:00
Oliver Schneider
5aa41ffd06
Choose a better commit message
2017-02-17 13:27:57 +01:00
Oliver Schneider
b1f766b37b
fix dogfood tests
2017-02-17 13:23:19 +01:00
Andre Bogus
6c8a6c18ab
deal with binary op short-circuit
2017-02-17 08:49:34 +01:00