Commit graph

531 commits

Author SHA1 Message Date
Ravi Shankar
185da55263 extending while_let to warn for more statements 2015-09-29 20:26:34 +05:30
llogiq
b749d832cc Merge pull request #349 from Manishearth/rustup
rustup 2015-09-24
2015-09-25 15:29:32 +02:00
Manish Goregaokar
cd11488080 rustup 2015-09-24 2015-09-25 18:52:36 +05:30
Manish Goregaokar
294d7d8586 Merge branch 'pr-347' 2015-09-24 12:01:18 +05:30
Pietro Monteiro
b2c66d1a0e Upgrade Rust to rustc 1.5.0-nightly (b2f379cdc 2015-09-23)
Ident was removed in many HIR structures in favor of Name.
2015-09-23 17:30:39 -07:00
llogiq
4838e8a3b4 Merge pull request #344 from Manishearth/reflet
Handle let ref in toplevel_ref_arg as well
2015-09-22 09:18:45 +02:00
Manish Goregaokar
3609a2211a Handle let ref in toplevel_ref_arg as well 2015-09-22 12:46:51 +05:30
llogiq
cf4e48d148 update lints 2015-09-21 06:24:46 +02:00
llogiq
3277e76a40 Merge pull request #341 from Manishearth/issue340
generalize let_and_return for any block (closes #340)
2015-09-20 15:37:35 +02:00
Georg Brandl
7cc291d02e generalize let_and_return for any block (closes #340) 2015-09-20 13:57:31 +02:00
Manish Goregaokar
56b9682624 Update README.md 2015-09-19 19:16:59 +05:30
Georg Brandl
7fdf52270b Fix stray backquote. 2015-09-19 08:49:01 +02:00
Manish Goregaokar
b56ff4319e fix dogfood 2015-09-19 08:33:04 +05:30
Manish Goregaokar
f4da7d09d2 Upgrade Rust to rustc 1.5.0-nightly (cff041170 2015-09-17)
LintPass was split and ExprParen was removed from the HIR

Fixes #338
2015-09-19 08:23:04 +05:30
llogiq
862c195fa1 Merge pull request #337 from Manishearth/indentfix
fix indentation
2015-09-17 07:44:39 +02:00
llogiq
acc83c0b02 Merge pull request #336 from Manishearth/issue335
ref matches: false positive with only wildcard pattern match
2015-09-17 07:43:26 +02:00
Georg Brandl
58fee220a9 fix indentation 2015-09-17 07:27:23 +02:00
Georg Brandl
e3ee87965e ref matches: false positive with only wildcard pattern match (fixes #335) 2015-09-17 07:25:08 +02:00
Manish Goregaokar
3124d2b8df Rustup to rustc 1.5.0-nightly (fc4d566b4 2015-09-16)
fixes #334
2015-09-17 05:32:29 +05:30
Manish Goregaokar
68d4b3af12 Merge pull request #314 from nweston/loop-counter
Lint for loops with explicit counter variable (#159)
2015-09-15 21:37:37 +05:30
Nathan Weston
8a5b4f19fd Check for mutable borrow of counter variable 2015-09-15 09:41:25 -04:00
Nathan Weston
6b57924e81 Improve lint message
Remove trailing period and include snippet of loop argument.
2015-09-15 09:41:25 -04:00
Nathan Weston
1e320b38c1 Add is_integer_literal utility function
Replaces is_lit_zero and is_lit_one which were used in a couple of
places.
2015-09-15 09:41:25 -04:00
Nathan Weston
f87dd31f30 New lint: loop with explicit counter variable (fixes #159)
Avoiding false positives here turns out to be fairly complicated.
2015-09-15 09:41:25 -04:00
llogiq
d2a10db7bc Merge pull request #332 from Manishearth/step_by
added fp test against negative .step_by(_)
2015-09-15 09:16:49 +02:00
llogiq
5c5d103405 added fp test against negative .step_by(_) 2015-09-15 09:12:58 +02:00
Manish Goregaokar
29904b9810 Merge pull request #331 from swgillespie/empty-range
implement iterating over an empty range lint as described in #330
2015-09-15 11:06:30 +05:30
swgillespie
bc7d252856 use the constant folder to generalize the lint a little bit and clean up the code. Add additional tests for things that should not be linted 2015-09-14 22:20:56 -07:00
swgillespie
82c524b774 implement empty range lint as described in #330 2015-09-14 17:19:05 -07:00
Manish Goregaokar
b86ebad0e7 Merge pull request #328 from Manishearth/falsepositives
less false positives for approx_const and float_cmp
2015-09-11 19:31:36 +05:30
llogiq
03af82afd1 removed expensive crate check from approx_const 2015-09-11 15:59:19 +02:00
llogiq
681bce925f less false positives for approx_const and float_cmp 2015-09-11 15:30:08 +02:00
llogiq
aefad45ee7 Merge pull request #326 from Manishearth/fix-323
additional macro check + more tests
2015-09-10 08:55:14 +02:00
llogiq
0e1bc74683 additional macro check + more tests 2015-09-10 08:51:14 +02:00
llogiq
d82c13d92b Merge pull request #325 from durka/patch-1
add warning about different rustc versions
2015-09-10 08:44:45 +02:00
Alex Burka
7b13a7b5e6 link to wiki 2015-09-10 02:26:15 -04:00
Alex Burka
f7ec0ef16c add warning about different rustc versions
Ref #322.
2015-09-10 02:06:52 -04:00
Manish Goregaokar
ce6ea58de0 add cargo clippy link 2015-09-10 07:01:28 +05:30
llogiq
6d58e36995 Merge pull request #321 from Manishearth/fix-319
made shadow_unrelated allow, added previous binding span note,
2015-09-08 13:33:24 +02:00
llogiq
4835372df5 made shadow_unrelated allow, added previous binding span note, fixed #319 2015-09-08 11:50:04 +02:00
llogiq
b5d953bf7d Merge pull request #316 from Manishearth/mutmut
Fix mut_mut false positive, make Allow (fixes #309)
2015-09-07 23:22:30 +02:00
Manish Goregaokar
0e658afc1b Fix mut_mut false positive, make Allow (fixes #309) 2015-09-08 02:29:13 +05:30
llogiq
54932dee1c Merge pull request #312 from Manishearth/pub_convention
split wrong_self_convention in pub/default visibility part
2015-09-07 11:54:47 +02:00
llogiq
e43f2d7e54 damn autocorrect 2015-09-07 11:49:35 +02:00
llogiq
c79d884450 replace if let by equality check 2015-09-07 11:46:04 +02:00
llogiq
92b04cd75d split wrong_self_convention in pub/default visibility part 2015-09-07 09:17:45 +02:00
Manish Goregaokar
f4c28f8521 Merge pull request #310 from Manishearth/len_zero
fix false positive len_zero in is_empty()
2015-09-07 00:39:24 +05:30
Andre Bogus
468b410d04 de-closured the item name getter 2015-09-06 21:03:09 +02:00
Andre Bogus
87e6099ad7 fix false positive len_zero in is_empty() 2015-09-06 20:57:06 +02:00
llogiq
1569fd8c55 Merge pull request #308 from Manishearth/unit_cmp
macro check for unit_cmp
2015-09-06 19:46:21 +02:00