Oli Scherer
def1705a27
Update to a compiletest-rs version that requires //@ for commands
2023-04-20 14:44:03 +00:00
Matthew Ingwersen
329dc4715b
Fix redundant_closure_for_method_calls suggestion
...
Certain types must be enclosed in angle brackets and must have generic
arguments substituted to create a working suggestion. For example, if
`s` has type `&[u8]`, then `|s| s.len()` may be replaced with
`<[u8]>::len`. Previously, Clippy erroneously suggested `[T]::len`.
2022-10-28 16:25:51 -04:00
Yuri Astrakhan
eb3970285b
fallout: fix tests to allow uninlined_format_args
...
In order to switch `clippy::uninlined_format_args` from pedantic to
style, all existing tests must not raise a warning. I did not want to
change the actual tests, so this is a relatively minor change that:
* add `#![allow(clippy::uninlined_format_args)]` where needed
* normalizes all allow/deny/warn attributes
* all allow attributes are grouped together
* sorted alphabetically
* the `clippy::*` attributes are listed separate from the other ones.
* deny and warn attributes are listed before the allowed ones
changelog: none
2022-10-02 15:13:22 -04:00
Evan Typanski
dbadf37336
Add test case where FnMut used once needs &mut
2022-09-30 11:38:12 -04:00
Evan Typanski
416da1264c
[redundant_closure] Add &mut to more cases
2022-09-29 19:35:04 -04:00
Alex Macleod
eae9c56aab
Add tests for some fixed redundant_closure issues
2022-06-10 13:25:22 +00:00
dswij
33bf9e9a54
redundant_closure ignore coerced closure
2022-04-27 13:05:01 +08:00
Alex Macleod
5e335a52bc
Check for loops/closures in local_used_after_expr
2022-04-10 14:26:44 +01:00
tamaron
db62821c03
fix
2022-02-24 00:16:24 +09:00
Jason Newcomb
9e9110e4f3
Remove final reference on fields and method calls in needless_borrow
2022-01-22 20:35:32 -05:00
Elliot Bobrow
828ddbe414
fix [redundant_closure] fp with Arc
2021-12-29 09:05:04 -08:00
David Tolnay
c2783c1dcb
Downgrade many_single_char_names to pedantic
2021-09-14 09:59:06 -07:00
Cameron Steffen
5782dc0eb9
Fix redundant closure bugs
2021-09-09 17:10:59 -05:00
Elliot Bobrow
4c398e07e0
suggest &mut for redundant FnMut closures
2021-07-14 07:56:27 -07:00
Jason Newcomb
60dd2b65dc
Fix redundant_closure for vec![] macro in a closure with arguments
2021-05-21 15:48:29 -04:00
Cameron Steffen
bf98aa6fb8
Fix redundant closure with macros
2021-03-08 13:15:13 -06:00
David Tolnay
94154cad20
Downgrade trivially_copy_pass_by_ref to pedantic
2020-04-02 18:56:10 -07:00
Grzegorz
d4ad23bb3f
redundant_closure_for_method_calls fixes:
...
lint does not trigger when there is a difference in mutability
lint does not trigger when the method belongs to a trait which is not implemebted directly (Deref)
2019-06-12 13:43:36 +02:00
Alexander Shabalin
41a4ce52dd
Workaround for rust-lang/rustfmt#3615
2019-06-10 20:19:29 +03:00
Alexander Shabalin
86bab94631
Fixing eta with respect to lazy evaluation.
2019-06-10 13:58:40 +03:00
Philipp Hansch
2c72026fcb
Rustup to https://github.com/rust-lang/rust/pull/61203
...
Migrates all trait objects to use `dyn`
2019-05-30 08:31:09 +02:00
flip1995
08d2a0d6b2
Also rename the lint in test files
2019-05-16 20:18:07 +02:00
Michael Wright
4fcaab3d62
Split redundant_closure lint
...
Move the method checking into a new lint called
`redundant_closures_for_method_calls` and put it in the pedantic group.
This aspect of the lint seems more controversial than the rest.
cc #3942
2019-05-16 08:25:39 +02:00
Philipp Hansch
3f637cb369
Add two more tests for redundant_closure
...
These two cases were fixed by #4008 .
Closes #1439
changelog: none
2019-04-26 06:48:27 +02:00
Grzegorz
4f801a278d
redundant closure triggers for fnptrs and closures
2019-04-20 22:20:14 +02:00
Grzegorz
aa9cf07d56
redundant closure for functions restricted to FnDefs
2019-04-19 15:14:49 +02:00
Philipp Hansch
9e4e1302a6
Add // run-rustfix for eta.rs test
...
cc #3071 , #3630
2019-04-10 08:16:07 +02:00
Grzegorz
a7f4d41a7d
do not trigger redundant_closure when there is a difference in borrow level between closure parameter and "self"
2019-02-26 12:12:27 +01:00
Grzegorz
f7c0df9183
test formatting
2019-02-10 21:23:04 +01:00
Grzegorz
b38c587b98
redundant closure implemented for closures containing method calls
2019-02-10 12:58:51 +01:00
Philipp Hansch
38d4ac7cea
Remove all copyright license headers
...
Discussion previously happened in https://github.com/rust-lang/rust/pull/43498
2019-01-08 21:46:39 +01:00
Matthias Krüger
435299be30
rustfmt tests
2018-12-09 23:26:16 +01:00
Oliver Scherer
9d3373137b
Remove now-useless allow(unknown_lints)
2018-10-11 12:18:27 +02:00
Oliver Scherer
b8654eaa6c
Stabilize tool lints
2018-10-11 12:16:22 +02:00
Manish Goregaokar
e9c025ea70
Add license header to Rust files
2018-10-06 09:43:08 -07:00
flip1995
1b6f6051a8
Adapt ui-tests to the tool_lints
2018-08-29 11:08:29 -07:00
Wim Looman
7547a4ddef
New Lint: Pass small trivially copyable objects by value
...
Fixes #1680
Hardcoded for 64-bit "trivial" size for now
2018-06-15 16:53:34 +02:00
Philipp Hansch
db60c67c5b
Allow new lint in ui/eta.rs
2018-04-15 13:01:09 +02:00
Oliver Schneider
0692b2bb92
Temporarily disable the needless_borrow lint
2018-04-08 11:13:46 +02:00
Oliver Schneider
50ffaca4c9
Reduce the hackiness of cargo-clippy
2017-10-03 12:07:24 +02:00
Oliver Schneider
74c776585c
Move all our tests back to ui tests
2017-08-01 17:54:21 +02:00
Oliver Schneider
4465bc3e3f
Make most tests an example so we can run them one by one
2017-05-17 14:19:44 +02:00
Luis de Bethencourt
fbc6b26592
clean tests/ui/eta.rs
...
Cleaning the empty lines for clarity.
2017-05-11 16:22:32 +01:00
sinkuu
0a6bc6031a
Rename lint to needless_take_by_value
...
And fixes false-positives for generics and `match`
2017-02-20 16:02:48 +09:00
sinkuu
d81d961ba7
Lint needless take-by-value
2017-02-19 07:59:44 +09:00
Oliver Schneider
1f2c97a291
remove all //~ from tests
2017-02-08 14:58:07 +01:00
Oliver Schneider
fd1351f6e3
rustup and compile-fail -> ui test move
2017-02-07 21:05:30 +01:00
