while_let_loop uses placeholders in suggestions

Due to that we can't make the lint MachineApplicable anymore.
This commit is contained in:
Philipp Hansch 2019-04-16 20:05:16 +02:00
parent d516925ec8
commit e974d84d03
No known key found for this signature in database
GPG key ID: 82AA61CAA11397E6

View file

@ -530,12 +530,12 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
return; return;
} }
// NOTE: we used to make build a body here instead of using // NOTE: we used to build a body here instead of using
// ellipsis, this was removed because: // ellipsis, this was removed because:
// 1) it was ugly with big bodies; // 1) it was ugly with big bodies;
// 2) it was not indented properly; // 2) it was not indented properly;
// 3) it wasnt very smart (see #675). // 3) it wasnt very smart (see #675).
let mut applicability = Applicability::MachineApplicable; let mut applicability = Applicability::HasPlaceholders;
span_lint_and_sugg( span_lint_and_sugg(
cx, cx,
WHILE_LET_LOOP, WHILE_LET_LOOP,