From e974d84d03a631c164e13e69ef96e2f598c0283e Mon Sep 17 00:00:00 2001 From: Philipp Hansch Date: Tue, 16 Apr 2019 20:05:16 +0200 Subject: [PATCH] while_let_loop uses placeholders in suggestions Due to that we can't make the lint MachineApplicable anymore. --- clippy_lints/src/loops.rs | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clippy_lints/src/loops.rs b/clippy_lints/src/loops.rs index 11b4d237c..90e2abea6 100644 --- a/clippy_lints/src/loops.rs +++ b/clippy_lints/src/loops.rs @@ -530,12 +530,12 @@ impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass { return; } - // NOTE: we used to make build a body here instead of using + // NOTE: we used to build a body here instead of using // ellipsis, this was removed because: // 1) it was ugly with big bodies; // 2) it was not indented properly; // 3) it wasn’t very smart (see #675). - let mut applicability = Applicability::MachineApplicable; + let mut applicability = Applicability::HasPlaceholders; span_lint_and_sugg( cx, WHILE_LET_LOOP,