2021-03-16 00:55:45 +00:00
|
|
|
use clippy_utils::diagnostics::span_lint;
|
2021-03-16 16:06:34 +00:00
|
|
|
use clippy_utils::is_adjusted;
|
2020-01-06 16:39:50 +00:00
|
|
|
use rustc_hir::{Expr, ExprKind};
|
2020-01-12 06:08:41 +00:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2020-01-11 11:37:08 +00:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2015-11-04 09:55:14 +00:00
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for construction of a structure or tuple just to
|
2019-03-05 16:50:33 +00:00
|
|
|
/// assign a value in it.
|
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// Readability. If the structure is only created to be
|
2019-03-05 16:50:33 +00:00
|
|
|
/// updated, why not write the structure you want in the first place?
|
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Example
|
2019-03-05 16:50:33 +00:00
|
|
|
/// ```rust
|
|
|
|
/// (0, 0).0 = 1
|
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 19:06:26 +00:00
|
|
|
#[clippy::version = "pre 1.29.0"]
|
2015-11-04 09:55:14 +00:00
|
|
|
pub TEMPORARY_ASSIGNMENT,
|
2018-03-28 13:24:26 +00:00
|
|
|
complexity,
|
2015-11-04 09:55:14 +00:00
|
|
|
"assignments to temporaries"
|
|
|
|
}
|
|
|
|
|
2020-09-10 12:18:05 +00:00
|
|
|
fn is_temporary(expr: &Expr<'_>) -> bool {
|
|
|
|
matches!(&expr.kind, ExprKind::Struct(..) | ExprKind::Tup(..))
|
2015-11-04 09:55:14 +00:00
|
|
|
}
|
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
declare_lint_pass!(TemporaryAssignment => [TEMPORARY_ASSIGNMENT]);
|
2015-11-04 09:55:14 +00:00
|
|
|
|
2020-06-25 20:41:36 +00:00
|
|
|
impl<'tcx> LateLintPass<'tcx> for TemporaryAssignment {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, expr: &'tcx Expr<'_>) {
|
2019-12-24 04:16:04 +00:00
|
|
|
if let ExprKind::Assign(target, ..) = &expr.kind {
|
2018-12-29 23:18:55 +00:00
|
|
|
let mut base = target;
|
2019-09-27 15:16:06 +00:00
|
|
|
while let ExprKind::Field(f, _) | ExprKind::Index(f, _) = &base.kind {
|
2018-12-29 23:18:55 +00:00
|
|
|
base = f;
|
|
|
|
}
|
2020-09-10 12:18:05 +00:00
|
|
|
if is_temporary(base) && !is_adjusted(cx, base) {
|
2018-12-29 23:18:55 +00:00
|
|
|
span_lint(cx, TEMPORARY_ASSIGNMENT, expr.span, "assignment to temporary");
|
2015-11-04 09:55:14 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|