2018-05-30 08:15:50 +00:00
|
|
|
use crate::utils::is_adjusted;
|
|
|
|
use crate::utils::span_lint;
|
2018-12-29 23:18:55 +00:00
|
|
|
use rustc::hir::def::Def;
|
2018-12-29 15:04:45 +00:00
|
|
|
use rustc::hir::{Expr, ExprKind};
|
|
|
|
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
|
|
|
use rustc::{declare_tool_lint, lint_array};
|
2015-11-04 09:55:14 +00:00
|
|
|
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **What it does:** Checks for construction of a structure or tuple just to
|
|
|
|
/// assign a value in it.
|
2015-12-14 21:16:56 +00:00
|
|
|
///
|
2016-08-06 07:55:04 +00:00
|
|
|
/// **Why is this bad?** Readability. If the structure is only created to be
|
|
|
|
/// updated, why not write the structure you want in the first place?
|
2015-12-14 21:16:56 +00:00
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
2016-07-15 22:25:44 +00:00
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// (0, 0).0 = 1
|
|
|
|
/// ```
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2015-11-04 09:55:14 +00:00
|
|
|
pub TEMPORARY_ASSIGNMENT,
|
2018-03-28 13:24:26 +00:00
|
|
|
complexity,
|
2015-11-04 09:55:14 +00:00
|
|
|
"assignments to temporaries"
|
|
|
|
}
|
|
|
|
|
2018-12-29 23:18:55 +00:00
|
|
|
fn is_temporary(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
|
|
|
|
match &expr.node {
|
2018-07-12 07:30:57 +00:00
|
|
|
ExprKind::Struct(..) | ExprKind::Tup(..) => true,
|
2018-12-29 23:18:55 +00:00
|
|
|
ExprKind::Path(qpath) => {
|
|
|
|
if let Def::Const(..) = cx.tables.qpath_def(qpath, expr.hir_id) {
|
|
|
|
true
|
|
|
|
} else {
|
|
|
|
false
|
|
|
|
}
|
|
|
|
},
|
2015-11-04 09:55:14 +00:00
|
|
|
_ => false,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
#[derive(Copy, Clone)]
|
2016-06-10 14:17:20 +00:00
|
|
|
pub struct Pass;
|
2015-11-04 09:55:14 +00:00
|
|
|
|
2016-06-10 14:17:20 +00:00
|
|
|
impl LintPass for Pass {
|
2015-11-04 09:55:14 +00:00
|
|
|
fn get_lints(&self) -> LintArray {
|
|
|
|
lint_array!(TEMPORARY_ASSIGNMENT)
|
|
|
|
}
|
2019-01-26 19:40:55 +00:00
|
|
|
|
|
|
|
fn name(&self) -> &'static str {
|
|
|
|
"TemporaryAssignment"
|
|
|
|
}
|
2015-11-04 09:55:14 +00:00
|
|
|
}
|
|
|
|
|
2016-12-07 12:13:40 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Pass {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
2018-12-29 23:18:55 +00:00
|
|
|
if let ExprKind::Assign(target, _) = &expr.node {
|
|
|
|
let mut base = target;
|
|
|
|
while let ExprKind::Field(f, _) | ExprKind::Index(f, _) = &base.node {
|
|
|
|
base = f;
|
|
|
|
}
|
|
|
|
if is_temporary(cx, base) && !is_adjusted(cx, base) {
|
|
|
|
span_lint(cx, TEMPORARY_ASSIGNMENT, expr.span, "assignment to temporary");
|
2015-11-04 09:55:14 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|