2021-03-16 00:55:45 +00:00
|
|
|
use clippy_utils::diagnostics::span_lint;
|
2021-03-16 16:06:34 +00:00
|
|
|
use clippy_utils::{is_entrypoint_fn, match_def_path, paths};
|
2019-10-18 19:09:42 +00:00
|
|
|
use if_chain::if_chain;
|
2020-01-06 16:39:50 +00:00
|
|
|
use rustc_hir::{Expr, ExprKind, Item, ItemKind, Node};
|
2020-01-12 06:08:41 +00:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2020-01-11 11:37:08 +00:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2019-10-18 19:09:42 +00:00
|
|
|
|
|
|
|
declare_clippy_lint! {
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### What it does
|
|
|
|
/// `exit()` terminates the program and doesn't provide a
|
2019-10-18 19:09:42 +00:00
|
|
|
/// stack trace.
|
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// Ideally a program is terminated by finishing
|
2019-10-18 19:09:42 +00:00
|
|
|
/// the main function.
|
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Example
|
2019-10-18 19:09:42 +00:00
|
|
|
/// ```ignore
|
|
|
|
/// std::process::exit(0)
|
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 19:06:26 +00:00
|
|
|
#[clippy::version = "1.41.0"]
|
2019-10-18 19:09:42 +00:00
|
|
|
pub EXIT,
|
|
|
|
restriction,
|
|
|
|
"`std::process::exit` is called, terminating the program"
|
|
|
|
}
|
|
|
|
|
|
|
|
declare_lint_pass!(Exit => [EXIT]);
|
|
|
|
|
2020-06-25 20:41:36 +00:00
|
|
|
impl<'tcx> LateLintPass<'tcx> for Exit {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
|
2019-10-18 19:09:42 +00:00
|
|
|
if_chain! {
|
2021-04-02 21:35:32 +00:00
|
|
|
if let ExprKind::Call(path_expr, _args) = e.kind;
|
2019-10-18 19:09:42 +00:00
|
|
|
if let ExprKind::Path(ref path) = path_expr.kind;
|
2021-01-18 19:36:32 +00:00
|
|
|
if let Some(def_id) = cx.qpath_res(path, path_expr.hir_id).opt_def_id();
|
2019-10-18 19:09:42 +00:00
|
|
|
if match_def_path(cx, def_id, &paths::EXIT);
|
2021-03-30 19:59:59 +00:00
|
|
|
let parent = cx.tcx.hir().get_parent_item(e.hir_id);
|
|
|
|
if let Some(Node::Item(Item{kind: ItemKind::Fn(..), ..})) = cx.tcx.hir().find(parent);
|
|
|
|
// If the next item up is a function we check if it is an entry point
|
|
|
|
// and only then emit a linter warning
|
|
|
|
let def_id = cx.tcx.hir().local_def_id(parent);
|
|
|
|
if !is_entrypoint_fn(cx, def_id.to_def_id());
|
2019-10-18 19:09:42 +00:00
|
|
|
then {
|
2021-03-30 19:59:59 +00:00
|
|
|
span_lint(cx, EXIT, e.span, "usage of `process::exit`");
|
2019-10-18 19:09:42 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|