2021-03-16 00:55:45 +00:00
|
|
|
use crate::utils::{is_entrypoint_fn, match_def_path, paths};
|
|
|
|
use clippy_utils::diagnostics::span_lint;
|
2019-10-18 19:09:42 +00:00
|
|
|
use if_chain::if_chain;
|
2020-01-06 16:39:50 +00:00
|
|
|
use rustc_hir::{Expr, ExprKind, Item, ItemKind, Node};
|
2020-01-12 06:08:41 +00:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2020-01-11 11:37:08 +00:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2019-10-18 19:09:42 +00:00
|
|
|
|
|
|
|
declare_clippy_lint! {
|
|
|
|
/// **What it does:** `exit()` terminates the program and doesn't provide a
|
|
|
|
/// stack trace.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** Ideally a program is terminated by finishing
|
|
|
|
/// the main function.
|
|
|
|
///
|
2019-10-19 12:31:02 +00:00
|
|
|
/// **Known problems:** None.
|
2019-10-18 19:09:42 +00:00
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```ignore
|
|
|
|
/// std::process::exit(0)
|
|
|
|
/// ```
|
|
|
|
pub EXIT,
|
|
|
|
restriction,
|
|
|
|
"`std::process::exit` is called, terminating the program"
|
|
|
|
}
|
|
|
|
|
|
|
|
declare_lint_pass!(Exit => [EXIT]);
|
|
|
|
|
2020-06-25 20:41:36 +00:00
|
|
|
impl<'tcx> LateLintPass<'tcx> for Exit {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
|
2019-10-18 19:09:42 +00:00
|
|
|
if_chain! {
|
|
|
|
if let ExprKind::Call(ref path_expr, ref _args) = e.kind;
|
|
|
|
if let ExprKind::Path(ref path) = path_expr.kind;
|
2021-01-18 19:36:32 +00:00
|
|
|
if let Some(def_id) = cx.qpath_res(path, path_expr.hir_id).opt_def_id();
|
2019-10-18 19:09:42 +00:00
|
|
|
if match_def_path(cx, def_id, &paths::EXIT);
|
|
|
|
then {
|
2019-11-08 03:16:43 +00:00
|
|
|
let parent = cx.tcx.hir().get_parent_item(e.hir_id);
|
|
|
|
if let Some(Node::Item(Item{kind: ItemKind::Fn(..), ..})) = cx.tcx.hir().find(parent) {
|
2019-10-24 19:17:21 +00:00
|
|
|
// If the next item up is a function we check if it is an entry point
|
|
|
|
// and only then emit a linter warning
|
|
|
|
let def_id = cx.tcx.hir().local_def_id(parent);
|
2020-04-24 09:57:34 +00:00
|
|
|
if !is_entrypoint_fn(cx, def_id.to_def_id()) {
|
2019-10-24 19:17:21 +00:00
|
|
|
span_lint(cx, EXIT, e.span, "usage of `process::exit`");
|
2019-10-19 12:31:02 +00:00
|
|
|
}
|
|
|
|
}
|
2019-10-18 19:09:42 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|