rust-clippy/tests/ui/matches.rs

179 lines
3.8 KiB
Rust
Raw Normal View History

#![feature(exclusive_range_pattern)]
2018-07-28 15:34:52 +00:00
#![warn(clippy::all)]
2019-01-13 15:19:02 +00:00
#![allow(unused, clippy::redundant_pattern_matching, clippy::too_many_lines)]
#![warn(clippy::match_same_arms)]
2015-04-13 17:58:18 +00:00
2018-12-09 22:26:16 +00:00
fn dummy() {}
2016-06-22 00:17:26 +00:00
fn ref_pats() {
2015-09-02 06:19:47 +00:00
{
let v = &Some(0);
2016-03-09 15:22:31 +00:00
match v {
2015-09-02 06:19:47 +00:00
&Some(v) => println!("{:?}", v),
&None => println!("none"),
}
2018-12-09 22:26:16 +00:00
match v {
2019-01-31 01:15:29 +00:00
// This doesn't trigger; we have a different pattern.
2015-09-02 06:19:47 +00:00
&Some(v) => println!("some"),
other => println!("other"),
}
}
2018-12-09 22:26:16 +00:00
let tup = &(1, 2);
2016-03-09 15:22:31 +00:00
match tup {
&(v, 1) => println!("{}", v),
_ => println!("none"),
}
2019-01-31 01:15:29 +00:00
// Special case: using `&` both in expr and pats.
let w = Some(0);
2016-03-09 15:22:31 +00:00
match &w {
&Some(v) => println!("{:?}", v),
&None => println!("none"),
}
2019-01-31 01:15:29 +00:00
// False positive: only wildcard pattern.
let w = Some(0);
match w {
_ => println!("none"),
}
let a = &Some(0);
2016-03-09 15:22:31 +00:00
if let &None = a {
println!("none");
}
let b = Some(0);
2016-03-09 15:22:31 +00:00
if let &None = &b {
println!("none");
}
}
2017-02-11 06:57:50 +00:00
fn match_wild_err_arm() {
let x: Result<i32, &str> = Ok(3);
match x {
Ok(3) => println!("ok"),
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => panic!("err"),
2017-02-11 06:57:50 +00:00
}
match x {
Ok(3) => println!("ok"),
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => panic!(),
2017-02-11 06:57:50 +00:00
}
match x {
Ok(3) => println!("ok"),
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => {
panic!();
},
2017-02-11 06:57:50 +00:00
}
2019-01-31 01:15:29 +00:00
// Allowed when not with `panic!` block.
2017-02-11 13:42:42 +00:00
match x {
Ok(3) => println!("ok"),
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => println!("err"),
2017-02-11 13:42:42 +00:00
}
2019-01-31 01:15:29 +00:00
// Allowed when used with `unreachable!`.
2017-02-11 06:57:50 +00:00
match x {
Ok(3) => println!("ok"),
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => unreachable!(),
2017-02-11 06:57:50 +00:00
}
2017-02-11 13:42:42 +00:00
match x {
Ok(3) => println!("ok"),
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => unreachable!(),
2017-02-11 13:42:42 +00:00
}
2017-02-11 06:57:50 +00:00
match x {
Ok(3) => println!("ok"),
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => {
unreachable!();
},
2017-02-11 06:57:50 +00:00
}
2019-01-31 01:15:29 +00:00
// No warning because of the guard.
match x {
2018-12-09 22:26:16 +00:00
Ok(x) if x * x == 64 => println!("ok"),
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => println!("err"),
}
2019-01-31 01:15:29 +00:00
// This used to be a false positive; see issue #1996.
2017-11-29 20:52:49 +00:00
match x {
Ok(3) => println!("ok"),
2018-12-09 22:26:16 +00:00
Ok(x) if x * x == 64 => println!("ok 64"),
2017-11-29 20:52:49 +00:00
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => println!("err"),
2017-11-29 20:52:49 +00:00
}
match (x, Some(1i32)) {
(Ok(x), Some(_)) => println!("ok {}", x),
(Ok(_), Some(x)) => println!("ok {}", x),
2018-12-09 22:26:16 +00:00
_ => println!("err"),
}
2019-01-31 01:15:29 +00:00
// No warning; different types for `x`.
match (x, Some(1.0f64)) {
(Ok(x), Some(_)) => println!("ok {}", x),
(Ok(_), Some(x)) => println!("ok {}", x),
2018-12-09 22:26:16 +00:00
_ => println!("err"),
}
2019-01-31 01:15:29 +00:00
// Because of a bug, no warning was generated for this case before #2251.
match x {
Ok(_tmp) => println!("ok"),
Ok(3) => println!("ok"),
Ok(_) => println!("ok"),
2018-12-09 22:26:16 +00:00
Err(_) => {
unreachable!();
},
}
2017-02-11 06:57:50 +00:00
}
2017-12-19 22:22:16 +00:00
fn match_as_ref() {
2017-12-20 09:39:48 +00:00
let owned: Option<()> = None;
let borrowed: Option<&()> = match owned {
2017-12-19 22:22:16 +00:00
None => None,
Some(ref v) => Some(v),
};
2017-12-20 09:39:48 +00:00
let mut mut_owned: Option<()> = None;
let borrow_mut: Option<&mut ()> = match mut_owned {
2017-12-19 22:22:16 +00:00
None => None,
Some(ref mut v) => Some(v),
};
}
macro_rules! foo_variant(
($idx:expr) => (Foo::get($idx).unwrap())
);
enum Foo {
A,
B,
}
impl Foo {
fn get(idx: u8) -> Option<&'static Self> {
match idx {
0 => Some(&Foo::A),
1 => Some(&Foo::B),
_ => None,
}
}
}
fn main() {
// ICE #3719
match foo_variant!(0) {
&Foo::A => println!("A"),
_ => println!("Wild"),
}
}