rust-clippy/tests/ui/matches.rs

288 lines
4.3 KiB
Rust
Raw Normal View History

2015-04-13 17:58:18 +00:00
#![feature(plugin)]
#![feature(exclusive_range_pattern)]
2015-04-13 17:58:18 +00:00
#![plugin(clippy)]
#![deny(clippy)]
#![allow(unused, if_let_redundant_pattern_matching)]
#![deny(single_match_else)]
2015-04-13 17:58:18 +00:00
2016-01-13 00:19:27 +00:00
use std::borrow::Cow;
enum Foo { Bar, Baz(u8) }
use Foo::*;
enum ExprNode {
ExprAddrOf,
Butterflies,
Unicorns,
}
static NODE: ExprNode = ExprNode::Unicorns;
2016-06-22 00:17:26 +00:00
fn dummy() {
}
fn unwrap_addr() -> Option<&'static ExprNode> {
2016-06-22 00:17:26 +00:00
match ExprNode::Butterflies {
2017-02-08 13:58:07 +00:00
ExprNode::ExprAddrOf => Some(&NODE),
2016-06-22 00:17:26 +00:00
_ => { let x = 5; None },
}
}
fn single_match(){
2015-04-13 17:58:18 +00:00
let x = Some(1u8);
2016-01-13 00:19:27 +00:00
2016-06-22 00:17:26 +00:00
match x {
2017-02-08 13:58:07 +00:00
2016-06-22 00:17:26 +00:00
Some(y) => { println!("{:?}", y); }
2015-04-13 17:58:18 +00:00
_ => ()
2016-06-22 00:17:26 +00:00
};
2016-01-13 00:19:27 +00:00
2015-04-13 17:58:18 +00:00
let z = (1u8,1u8);
2016-06-22 00:17:26 +00:00
match z {
2017-02-08 13:58:07 +00:00
2016-06-22 00:17:26 +00:00
(2...3, 7...9) => dummy(),
2015-04-13 17:58:18 +00:00
_ => {}
2016-06-22 00:17:26 +00:00
};
// Not linted (pattern guards used)
match x {
Some(y) if y == 0 => println!("{:?}", y),
_ => ()
}
// Not linted (no block with statements in the single arm)
match z {
(2...3, 7...9) => println!("{:?}", z),
_ => println!("nope"),
}
2015-04-13 17:58:18 +00:00
}
2016-01-13 00:19:27 +00:00
fn single_match_know_enum() {
let x = Some(1u8);
let y : Result<_, i8> = Ok(1i8);
2016-06-22 00:17:26 +00:00
match x {
2017-02-08 13:58:07 +00:00
2016-06-22 00:17:26 +00:00
Some(y) => dummy(),
2016-01-13 00:19:27 +00:00
None => ()
2016-06-22 00:17:26 +00:00
};
2016-01-13 00:19:27 +00:00
2016-06-22 00:17:26 +00:00
match y {
2017-02-08 13:58:07 +00:00
2016-06-22 00:17:26 +00:00
Ok(y) => dummy(),
2016-01-13 00:19:27 +00:00
Err(..) => ()
2016-06-22 00:17:26 +00:00
};
2016-01-13 00:19:27 +00:00
let c = Cow::Borrowed("");
2016-06-22 00:17:26 +00:00
match c {
2017-02-08 13:58:07 +00:00
2016-06-22 00:17:26 +00:00
Cow::Borrowed(..) => dummy(),
2016-01-13 00:19:27 +00:00
Cow::Owned(..) => (),
2016-06-22 00:17:26 +00:00
};
2016-01-13 00:19:27 +00:00
let z = Foo::Bar;
// no warning
match z {
Bar => println!("42"),
Baz(_) => (),
}
match z {
Baz(_) => println!("42"),
Bar => (),
}
}
fn match_bool() {
let test: bool = true;
match test {
2017-02-08 13:58:07 +00:00
true => 0,
false => 42,
};
let option = 1;
match option == 1 {
2017-02-08 13:58:07 +00:00
2015-10-21 06:24:56 +00:00
true => 1,
false => 0,
};
2015-12-23 00:14:10 +00:00
match test {
2017-02-08 13:58:07 +00:00
true => (),
false => { println!("Noooo!"); }
2015-10-21 06:24:56 +00:00
};
2015-12-23 00:14:10 +00:00
match test {
2017-02-08 13:58:07 +00:00
2016-06-29 19:50:21 +00:00
false => { println!("Noooo!"); }
_ => (),
};
match test && test {
2017-02-08 13:58:07 +00:00
false => { println!("Noooo!"); }
2015-10-21 06:24:56 +00:00
_ => (),
};
2015-12-23 00:14:10 +00:00
match test {
2017-02-08 13:58:07 +00:00
false => { println!("Noooo!"); }
true => { println!("Yes!"); }
};
// Not linted
match option {
1 ... 10 => 1,
11 ... 20 => 2,
_ => 3,
};
}
fn ref_pats() {
2015-09-02 06:19:47 +00:00
{
let v = &Some(0);
2016-03-09 15:22:31 +00:00
match v {
2017-02-08 13:58:07 +00:00
2015-09-02 06:19:47 +00:00
&Some(v) => println!("{:?}", v),
&None => println!("none"),
}
match v { // this doesn't trigger, we have a different pattern
&Some(v) => println!("some"),
other => println!("other"),
}
}
let tup =& (1, 2);
2016-03-09 15:22:31 +00:00
match tup {
2017-02-08 13:58:07 +00:00
&(v, 1) => println!("{}", v),
_ => println!("none"),
}
// special case: using & both in expr and pats
let w = Some(0);
2016-03-09 15:22:31 +00:00
match &w {
2017-02-08 13:58:07 +00:00
&Some(v) => println!("{:?}", v),
&None => println!("none"),
}
// false positive: only wildcard pattern
let w = Some(0);
match w {
_ => println!("none"),
}
let a = &Some(0);
2016-03-09 15:22:31 +00:00
if let &None = a {
2017-02-08 13:58:07 +00:00
println!("none");
}
let b = Some(0);
2016-03-09 15:22:31 +00:00
if let &None = &b {
2017-02-08 13:58:07 +00:00
println!("none");
}
}
2015-12-23 00:14:10 +00:00
fn overlapping() {
const FOO : u64 = 2;
match 42 {
2017-02-08 13:58:07 +00:00
0 ... 10 => println!("0 ... 10"),
0 ... 11 => println!("0 ... 11"),
2015-12-23 00:14:10 +00:00
_ => (),
}
match 42 {
2017-02-08 13:58:07 +00:00
0 ... 5 => println!("0 ... 5"),
2015-12-23 00:14:10 +00:00
6 ... 7 => println!("6 ... 7"),
2017-02-08 13:58:07 +00:00
FOO ... 11 => println!("0 ... 11"),
2015-12-23 00:14:10 +00:00
_ => (),
}
match 42 {
2017-02-08 13:58:07 +00:00
2 => println!("2"),
0 ... 5 => println!("0 ... 5"),
_ => (),
}
match 42 {
2017-02-08 13:58:07 +00:00
2 => println!("2"),
0 ... 2 => println!("0 ... 2"),
_ => (),
}
2015-12-23 00:14:10 +00:00
match 42 {
0 ... 10 => println!("0 ... 10"),
2017-01-31 07:08:54 +00:00
11 ... 50 => println!("11 ... 50"),
2015-12-23 00:14:10 +00:00
_ => (),
}
match 42 {
2 => println!("2"),
0 .. 2 => println!("0 .. 2"),
_ => (),
}
match 42 {
2017-01-31 07:08:54 +00:00
0 .. 10 => println!("0 .. 10"),
10 .. 50 => println!("10 .. 50"),
_ => (),
}
match 42 {
2017-02-08 13:58:07 +00:00
0 .. 11 => println!("0 .. 11"),
0 ... 11 => println!("0 ... 11"),
_ => (),
}
2016-05-31 20:01:56 +00:00
if let None = Some(42) {
// nothing
} else if let None = Some(42) {
// another nothing :-)
}
2015-12-23 00:14:10 +00:00
}
fn main() {
}