2021-03-16 00:55:45 +00:00
|
|
|
use clippy_utils::diagnostics::span_lint;
|
2020-01-06 16:39:50 +00:00
|
|
|
use rustc_hir::{Expr, ExprKind};
|
2020-01-12 06:08:41 +00:00
|
|
|
use rustc_lint::{LateContext, LateLintPass};
|
2020-01-11 11:37:08 +00:00
|
|
|
use rustc_session::{declare_lint_pass, declare_tool_lint};
|
2022-02-25 15:38:06 +00:00
|
|
|
use rustc_span::sym;
|
2016-04-20 20:10:23 +00:00
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### What it does
|
|
|
|
/// Checks for usage of `std::mem::forget(t)` where `t` is
|
2019-03-05 16:50:33 +00:00
|
|
|
/// `Drop`.
|
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Why is this bad?
|
|
|
|
/// `std::mem::forget(t)` prevents `t` from running its
|
2019-03-05 16:50:33 +00:00
|
|
|
/// destructor, possibly causing leaks.
|
|
|
|
///
|
2021-07-02 18:37:11 +00:00
|
|
|
/// ### Example
|
2019-03-05 16:50:33 +00:00
|
|
|
/// ```rust
|
2019-08-03 19:24:50 +00:00
|
|
|
/// # use std::mem;
|
|
|
|
/// # use std::rc::Rc;
|
2019-03-05 16:50:33 +00:00
|
|
|
/// mem::forget(Rc::new(55))
|
|
|
|
/// ```
|
Added `clippy::version` attribute to all normal lints
So, some context for this, well, more a story. I'm not used to scripting, I've never really scripted anything, even if it's a valuable skill. I just never really needed it. Now, `@flip1995` correctly suggested using a script for this in `rust-clippy#7813`...
And I decided to write a script using nushell because why not? This was a mistake... I spend way more time on this than I would like to admit. It has definitely been more than 4 hours. It shouldn't take that long, but me being new to scripting and nushell just wasn't a good mixture... Anyway, here is the script that creates another script which adds the versions. Fun...
Just execute this on the `gh-pages` branch and the resulting `replacer.sh` in `clippy_lints` and it should all work.
```nu
mv v0.0.212 rust-1.00.0;
mv beta rust-1.57.0;
mv master rust-1.58.0;
let paths = (open ./rust-1.58.0/lints.json | select id id_span | flatten | select id path);
let versions = (
ls | where name =~ "rust-" | select name | format {name}/lints.json |
each { open $it | select id | insert version $it | str substring "5,11" version} |
group-by id | rotate counter-clockwise id version |
update version {get version | first 1} | flatten | select id version);
$paths | each { |row|
let version = ($versions | where id == ($row.id) | format {version})
let idu = ($row.id | str upcase)
$"sed -i '0,/($idu),/{s/pub ($idu),/#[clippy::version = "($version)"]\n pub ($idu),/}' ($row.path)"
} | str collect ";" | str find-replace --all '1.00.0' 'pre 1.29.0' | save "replacer.sh";
```
And this still has some problems, but at this point I just want to be done -.-
2021-10-21 19:06:26 +00:00
|
|
|
#[clippy::version = "pre 1.29.0"]
|
2016-04-20 20:10:23 +00:00
|
|
|
pub MEM_FORGET,
|
2018-03-28 13:24:26 +00:00
|
|
|
restriction,
|
2016-08-06 08:18:36 +00:00
|
|
|
"`mem::forget` usage on `Drop` types, likely to cause memory leaks"
|
2016-04-20 20:10:23 +00:00
|
|
|
}
|
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
declare_lint_pass!(MemForget => [MEM_FORGET]);
|
2016-04-20 20:10:23 +00:00
|
|
|
|
2020-06-25 20:41:36 +00:00
|
|
|
impl<'tcx> LateLintPass<'tcx> for MemForget {
|
|
|
|
fn check_expr(&mut self, cx: &LateContext<'tcx>, e: &'tcx Expr<'_>) {
|
2021-09-04 16:21:49 +00:00
|
|
|
if let ExprKind::Call(path_expr, [ref first_arg, ..]) = e.kind {
|
2019-09-27 15:16:06 +00:00
|
|
|
if let ExprKind::Path(ref qpath) = path_expr.kind {
|
2021-01-18 19:36:32 +00:00
|
|
|
if let Some(def_id) = cx.qpath_res(qpath, path_expr.hir_id).opt_def_id() {
|
2022-02-25 15:38:06 +00:00
|
|
|
if cx.tcx.is_diagnostic_item(sym::mem_forget, def_id) {
|
2021-09-04 16:21:49 +00:00
|
|
|
let forgot_ty = cx.typeck_results().expr_ty(first_arg);
|
2016-04-21 02:24:31 +00:00
|
|
|
|
2018-08-06 13:42:08 +00:00
|
|
|
if forgot_ty.ty_adt_def().map_or(false, |def| def.has_dtor(cx.tcx)) {
|
2020-01-06 06:30:43 +00:00
|
|
|
span_lint(cx, MEM_FORGET, e.span, "usage of `mem::forget` on `Drop` type");
|
2017-09-12 12:26:40 +00:00
|
|
|
}
|
2016-04-21 02:24:31 +00:00
|
|
|
}
|
2016-04-20 20:10:23 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|