rust-clippy/clippy_lints/src/mem_forget.rs

50 lines
1.5 KiB
Rust
Raw Normal View History

2016-04-20 20:10:23 +00:00
use rustc::lint::*;
use rustc::hir::{Expr, ExprCall, ExprPath};
use utils::{match_def_path, paths, span_lint};
2016-04-20 20:10:23 +00:00
2017-08-09 07:30:56 +00:00
/// **What it does:** Checks for usage of `std::mem::forget(t)` where `t` is
/// `Drop`.
2016-04-20 20:10:23 +00:00
///
/// **Why is this bad?** `std::mem::forget(t)` prevents `t` from running its
/// destructor, possibly causing leaks.
2016-04-20 20:10:23 +00:00
///
/// **Known problems:** None.
///
2016-07-15 22:25:44 +00:00
/// **Example:**
/// ```rust
/// mem::forget(Rc::new(55)))
/// ```
2016-04-20 20:10:23 +00:00
declare_lint! {
pub MEM_FORGET,
Allow,
"`mem::forget` usage on `Drop` types, likely to cause memory leaks"
2016-04-20 20:10:23 +00:00
}
pub struct MemForget;
impl LintPass for MemForget {
fn get_lints(&self) -> LintArray {
lint_array![MEM_FORGET]
}
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MemForget {
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
if let ExprCall(ref path_expr, ref args) = e.node {
if let ExprPath(ref qpath) = path_expr.node {
2017-08-15 09:10:49 +00:00
let def_id = cx.tables.qpath_def(qpath, path_expr.hir_id).def_id();
2017-01-13 16:04:56 +00:00
if match_def_path(cx.tcx, def_id, &paths::MEM_FORGET) {
let forgot_ty = cx.tables.expr_ty(&args[0]);
if match forgot_ty.ty_adt_def() {
Some(def) => def.has_dtor(cx.tcx),
_ => false,
2017-09-05 09:33:04 +00:00
} {
span_lint(cx, MEM_FORGET, e.span, "usage of mem::forget on Drop type");
}
2016-04-20 20:10:23 +00:00
}
}
}
}
}