rust-clippy/clippy_lints/src/enum_clike.rs

89 lines
3.5 KiB
Rust
Raw Normal View History

2017-08-09 07:30:56 +00:00
//! lint on C-like enums that are `repr(isize/usize)` and have values that
//! don't fit into an `i32`
2018-11-27 20:14:15 +00:00
use crate::consts::{miri_to_const, Constant};
2018-05-30 08:15:50 +00:00
use crate::utils::span_lint;
2019-12-03 23:16:03 +00:00
use rustc::declare_lint_pass;
use rustc::hir::*;
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
use rustc::mir::interpret::GlobalId;
use rustc::ty;
use rustc::ty::subst::InternalSubsts;
use rustc::ty::util::IntTypeExt;
2019-12-03 23:16:03 +00:00
use rustc_session::declare_tool_lint;
2019-05-12 19:53:28 +00:00
use std::convert::TryFrom;
use syntax::ast::{IntTy, UintTy};
2018-03-28 13:24:26 +00:00
declare_clippy_lint! {
/// **What it does:** Checks for C-like enumerations that are
/// `repr(isize/usize)` and have values that don't fit into an `i32`.
///
/// **Why is this bad?** This will truncate the variant value on 32 bit
/// architectures, but works fine on 64 bit.
///
/// **Known problems:** None.
///
/// **Example:**
/// ```rust
/// # #[cfg(target_pointer_width = "64")]
/// #[repr(usize)]
/// enum NonPortable {
/// X = 0x1_0000_0000,
/// Y = 0,
/// }
/// ```
pub ENUM_CLIKE_UNPORTABLE_VARIANT,
2018-03-28 13:24:26 +00:00
correctness,
"C-like enums that are `repr(isize/usize)` and have values that don't fit into an `i32`"
}
2019-04-08 20:43:55 +00:00
declare_lint_pass!(UnportableVariant => [ENUM_CLIKE_UNPORTABLE_VARIANT]);
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnportableVariant {
#[allow(clippy::cast_possible_truncation, clippy::cast_possible_wrap, clippy::cast_sign_loss)]
fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
2018-03-13 10:38:11 +00:00
if cx.tcx.data_layout.pointer_size.bits() != 64 {
return;
}
2019-09-27 15:16:06 +00:00
if let ItemKind::Enum(def, _) = &item.kind {
for var in &def.variants {
2019-08-15 07:59:08 +00:00
if let Some(anon_const) = &var.disr_expr {
let param_env = ty::ParamEnv::empty();
let def_id = cx.tcx.hir().body_owner_def_id(anon_const.body);
let substs = InternalSubsts::identity_for_item(cx.tcx, def_id);
let instance = ty::Instance::new(def_id, substs);
let c_id = GlobalId {
2018-03-13 10:38:11 +00:00
instance,
2018-11-27 20:14:15 +00:00
promoted: None,
};
let constant = cx.tcx.const_eval(param_env.and(c_id)).ok();
if let Some(Constant::Int(val)) = constant.and_then(miri_to_const) {
let mut ty = cx.tcx.type_of(def_id);
if let ty::Adt(adt, _) = ty.kind {
2018-03-13 10:38:11 +00:00
if adt.is_enum() {
ty = adt.repr.discr_type().to_ty(cx.tcx);
}
}
match ty.kind {
ty::Int(IntTy::Isize) => {
2018-03-13 10:38:11 +00:00
let val = ((val as i128) << 64) >> 64;
2019-05-12 19:53:28 +00:00
if i32::try_from(val).is_ok() {
2018-03-13 10:38:11 +00:00
continue;
}
2018-11-27 20:14:15 +00:00
},
ty::Uint(UintTy::Usize) if val > u128::from(u32::max_value()) => {},
2018-03-13 10:38:11 +00:00
_ => continue,
}
2017-08-09 07:30:56 +00:00
span_lint(
cx,
ENUM_CLIKE_UNPORTABLE_VARIANT,
var.span,
"Clike enum variant discriminant is not portable to 32-bit targets",
);
2018-03-13 10:38:11 +00:00
};
}
}
}
}
}