2017-08-09 07:30:56 +00:00
|
|
|
//! lint on C-like enums that are `repr(isize/usize)` and have values that
|
|
|
|
//! don't fit into an `i32`
|
2016-02-29 08:36:13 +00:00
|
|
|
|
2018-11-27 20:14:15 +00:00
|
|
|
use crate::consts::{miri_to_const, Constant};
|
2018-05-30 08:15:50 +00:00
|
|
|
use crate::utils::span_lint;
|
2018-12-29 15:04:45 +00:00
|
|
|
use rustc::hir::*;
|
|
|
|
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
|
|
|
use rustc::mir::interpret::GlobalId;
|
|
|
|
use rustc::ty;
|
2019-02-27 06:20:49 +00:00
|
|
|
use rustc::ty::subst::InternalSubsts;
|
2018-12-29 15:04:45 +00:00
|
|
|
use rustc::ty::util::IntTypeExt;
|
2019-04-08 20:43:55 +00:00
|
|
|
use rustc::{declare_lint_pass, declare_tool_lint};
|
2019-05-12 19:53:28 +00:00
|
|
|
use std::convert::TryFrom;
|
2018-12-29 15:04:45 +00:00
|
|
|
use syntax::ast::{IntTy, UintTy};
|
2016-02-29 08:36:13 +00:00
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 16:50:33 +00:00
|
|
|
/// **What it does:** Checks for C-like enumerations that are
|
|
|
|
/// `repr(isize/usize)` and have values that don't fit into an `i32`.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** This will truncate the variant value on 32 bit
|
|
|
|
/// architectures, but works fine on 64 bit.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// #[repr(usize)]
|
|
|
|
/// enum NonPortable {
|
|
|
|
/// X = 0x1_0000_0000,
|
|
|
|
/// Y = 0,
|
|
|
|
/// }
|
|
|
|
/// ```
|
2016-08-06 08:18:36 +00:00
|
|
|
pub ENUM_CLIKE_UNPORTABLE_VARIANT,
|
2018-03-28 13:24:26 +00:00
|
|
|
correctness,
|
2016-08-06 08:18:36 +00:00
|
|
|
"C-like enums that are `repr(isize/usize)` and have values that don't fit into an `i32`"
|
2016-02-29 08:36:13 +00:00
|
|
|
}
|
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
declare_lint_pass!(UnportableVariant => [ENUM_CLIKE_UNPORTABLE_VARIANT]);
|
2016-02-29 08:36:13 +00:00
|
|
|
|
2016-12-07 12:13:40 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for UnportableVariant {
|
2018-10-09 05:34:10 +00:00
|
|
|
#[allow(clippy::cast_possible_truncation, clippy::cast_possible_wrap, clippy::cast_sign_loss)]
|
2016-12-07 12:13:40 +00:00
|
|
|
fn check_item(&mut self, cx: &LateContext<'a, 'tcx>, item: &'tcx Item) {
|
2018-03-13 10:38:11 +00:00
|
|
|
if cx.tcx.data_layout.pointer_size.bits() != 64 {
|
|
|
|
return;
|
|
|
|
}
|
2019-08-15 07:59:08 +00:00
|
|
|
if let ItemKind::Enum(def, _) = &item.node {
|
2016-02-29 08:36:13 +00:00
|
|
|
for var in &def.variants {
|
2019-08-15 07:59:08 +00:00
|
|
|
if let Some(anon_const) = &var.disr_expr {
|
2018-03-15 09:25:40 +00:00
|
|
|
let param_env = ty::ParamEnv::empty();
|
2018-12-08 00:56:03 +00:00
|
|
|
let def_id = cx.tcx.hir().body_owner_def_id(anon_const.body);
|
2019-02-27 06:20:49 +00:00
|
|
|
let substs = InternalSubsts::identity_for_item(cx.tcx.global_tcx(), def_id);
|
2018-10-11 22:18:58 +00:00
|
|
|
let instance = ty::Instance::new(def_id, substs);
|
|
|
|
let c_id = GlobalId {
|
2018-03-13 10:38:11 +00:00
|
|
|
instance,
|
2018-11-27 20:14:15 +00:00
|
|
|
promoted: None,
|
2016-02-29 08:36:13 +00:00
|
|
|
};
|
2018-10-11 22:18:58 +00:00
|
|
|
let constant = cx.tcx.const_eval(param_env.and(c_id)).ok();
|
2019-05-26 14:47:26 +00:00
|
|
|
if let Some(Constant::Int(val)) = constant.and_then(miri_to_const) {
|
2018-10-11 22:18:58 +00:00
|
|
|
let mut ty = cx.tcx.type_of(def_id);
|
2018-08-22 21:34:52 +00:00
|
|
|
if let ty::Adt(adt, _) = ty.sty {
|
2018-03-13 10:38:11 +00:00
|
|
|
if adt.is_enum() {
|
|
|
|
ty = adt.repr.discr_type().to_ty(cx.tcx);
|
|
|
|
}
|
|
|
|
}
|
|
|
|
match ty.sty {
|
2018-08-22 21:34:52 +00:00
|
|
|
ty::Int(IntTy::Isize) => {
|
2018-03-13 10:38:11 +00:00
|
|
|
let val = ((val as i128) << 64) >> 64;
|
2019-05-12 19:53:28 +00:00
|
|
|
if i32::try_from(val).is_ok() {
|
2018-03-13 10:38:11 +00:00
|
|
|
continue;
|
|
|
|
}
|
2018-11-27 20:14:15 +00:00
|
|
|
},
|
2018-08-22 21:34:52 +00:00
|
|
|
ty::Uint(UintTy::Usize) if val > u128::from(u32::max_value()) => {},
|
2018-03-13 10:38:11 +00:00
|
|
|
_ => continue,
|
|
|
|
}
|
2017-08-09 07:30:56 +00:00
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
ENUM_CLIKE_UNPORTABLE_VARIANT,
|
|
|
|
var.span,
|
|
|
|
"Clike enum variant discriminant is not portable to 32-bit targets",
|
|
|
|
);
|
2018-03-13 10:38:11 +00:00
|
|
|
};
|
2016-02-29 08:36:13 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|