rust-clippy/src/lib.rs

367 lines
14 KiB
Rust
Raw Normal View History

2016-02-22 13:25:51 +00:00
#![feature(type_macros)]
2015-01-10 06:26:58 +00:00
#![feature(plugin_registrar, box_syntax)]
#![feature(rustc_private, collections)]
#![feature(iter_arith)]
#![feature(custom_attribute)]
#![feature(slice_patterns)]
2016-03-11 21:10:40 +00:00
#![allow(indexing_slicing, shadow_reuse, unknown_lints)]
2014-11-19 08:57:34 +00:00
2015-11-18 16:09:48 +00:00
// this only exists to allow the "dogfood" integration test to work
#[allow(dead_code)]
#[allow(print_stdout)]
2016-01-04 04:26:12 +00:00
fn main() {
println!("What are you doing? Don't run clippy as an executable");
}
2015-11-18 16:09:48 +00:00
2015-01-10 06:26:58 +00:00
#[macro_use]
2014-11-19 08:57:34 +00:00
extern crate syntax;
2015-01-10 06:26:58 +00:00
#[macro_use]
2014-11-19 08:57:34 +00:00
extern crate rustc;
#[macro_use]
extern crate rustc_front;
2014-11-19 08:57:34 +00:00
extern crate toml;
2014-11-20 07:07:37 +00:00
// Only for the compile time checking of paths
extern crate core;
2014-11-20 07:07:37 +00:00
extern crate collections;
2014-11-19 08:57:34 +00:00
// for unicode nfc normalization
extern crate unicode_normalization;
2016-01-09 01:05:43 +00:00
// for semver check in attrs.rs
extern crate semver;
2016-02-04 23:36:06 +00:00
// for regex checking
extern crate regex_syntax;
extern crate rustc_plugin;
extern crate rustc_const_eval;
use rustc_plugin::Registry;
2014-11-19 08:57:34 +00:00
pub mod consts;
#[macro_use]
pub mod utils;
// begin lints modules, do not remove this comment, its used in `update_lints`
pub mod approx_const;
pub mod array_indexing;
pub mod attrs;
pub mod bit_mask;
2016-02-22 14:42:24 +00:00
pub mod blacklisted_name;
pub mod block_in_if_condition;
pub mod collapsible_if;
pub mod copies;
pub mod cyclomatic_complexity;
pub mod derive;
pub mod drop_ref;
pub mod entry;
pub mod enum_clike;
pub mod enum_glob_use;
pub mod enum_variants;
pub mod eq_op;
pub mod escape;
2015-05-10 05:09:04 +00:00
pub mod eta_reduction;
2016-02-20 20:15:05 +00:00
pub mod format;
pub mod formatting;
2016-03-08 23:48:10 +00:00
pub mod functions;
pub mod identity_op;
pub mod if_not_else;
2016-01-24 09:16:56 +00:00
pub mod items_after_statements;
pub mod len_zero;
pub mod lifetimes;
pub mod loops;
2015-10-31 04:58:37 +00:00
pub mod map_clone;
pub mod matches;
pub mod methods;
pub mod minmax;
pub mod misc;
pub mod misc_early;
pub mod mut_mut;
pub mod mut_reference;
pub mod mutex_atomic;
pub mod needless_bool;
pub mod needless_update;
pub mod new_without_default;
2015-10-28 16:50:00 +00:00
pub mod no_effect;
pub mod non_expressive_names;
pub mod open_options;
2016-03-06 15:01:17 +00:00
pub mod overflow_check_conditional;
2015-12-23 21:37:52 +00:00
pub mod panic;
pub mod precedence;
pub mod print;
pub mod ptr_arg;
pub mod ranges;
2016-02-04 23:36:06 +00:00
pub mod regex;
pub mod returns;
pub mod shadow;
pub mod strings;
2016-02-27 23:01:15 +00:00
pub mod swap;
pub mod temporary_assignment;
pub mod transmute;
pub mod types;
pub mod unicode;
2016-03-01 14:15:39 +00:00
pub mod unused_label;
pub mod vec;
pub mod zero_div_zero;
// end lints modules, do not remove this comment, its used in `update_lints`
2014-11-19 08:57:34 +00:00
mod reexport {
pub use syntax::ast::{Name, NodeId};
}
2014-11-19 08:57:34 +00:00
#[plugin_registrar]
#[cfg_attr(rustfmt, rustfmt_skip)]
2014-11-19 08:57:34 +00:00
pub fn plugin_registrar(reg: &mut Registry) {
2016-03-06 14:48:56 +00:00
let conf = match utils::conf::conf_file(reg.args()) {
Ok(file_name) => {
2016-03-09 10:48:55 +00:00
// if the user specified a file, it must exist, otherwise default to `clippy.toml` but
2016-03-06 14:48:56 +00:00
// do not require the file to exist
let (ref file_name, must_exist) = if let Some(ref file_name) = file_name {
(&**file_name, true)
} else {
2016-03-09 10:48:55 +00:00
("clippy.toml", false)
2016-03-06 14:48:56 +00:00
};
let (conf, errors) = utils::conf::read_conf(&file_name, must_exist);
// all conf errors are non-fatal, we just use the default conf in case of error
for error in errors {
reg.sess.struct_err(&format!("error reading Clippy's configuration file: {}", error)).emit();
}
conf
}
Err((err, span)) => {
2016-03-06 14:48:56 +00:00
reg.sess.struct_span_err(span, err)
.span_note(span, "Clippy will use defaulf configuration")
.emit();
utils::conf::Conf::default()
}
};
let mut store = reg.sess.lint_store.borrow_mut();
store.register_removed("unstable_as_slice", "`Vec::as_slice` has been stabilized in 1.7");
store.register_removed("unstable_as_mut_slice", "`Vec::as_mut_slice` has been stabilized in 1.7");
store.register_removed("str_to_string", "using `str::to_string` is common even today and specialization will likely happen soon");
store.register_removed("string_to_string", "using `string::to_string` is common even today and specialization will likely happen soon");
// end deprecated lints, do not remove this comment, its used in `update_lints`
reg.register_late_lint_pass(box types::TypePass);
reg.register_late_lint_pass(box misc::TopLevelRefPass);
reg.register_late_lint_pass(box misc::CmpNan);
reg.register_late_lint_pass(box eq_op::EqOp);
reg.register_early_lint_pass(box enum_variants::EnumVariantNames);
reg.register_late_lint_pass(box enum_glob_use::EnumGlobUse);
reg.register_late_lint_pass(box enum_clike::EnumClikeUnportableVariant);
reg.register_late_lint_pass(box bit_mask::BitMask);
reg.register_late_lint_pass(box ptr_arg::PtrArg);
reg.register_late_lint_pass(box needless_bool::NeedlessBool);
reg.register_late_lint_pass(box needless_bool::BoolComparison);
reg.register_late_lint_pass(box approx_const::ApproxConstant);
reg.register_late_lint_pass(box misc::FloatCmp);
reg.register_early_lint_pass(box precedence::Precedence);
reg.register_late_lint_pass(box eta_reduction::EtaPass);
reg.register_late_lint_pass(box identity_op::IdentityOp);
2016-01-24 09:16:56 +00:00
reg.register_early_lint_pass(box items_after_statements::ItemsAfterStatemets);
reg.register_late_lint_pass(box mut_mut::MutMut);
2015-09-29 11:11:19 +00:00
reg.register_late_lint_pass(box mut_reference::UnnecessaryMutPassed);
reg.register_late_lint_pass(box len_zero::LenZero);
reg.register_late_lint_pass(box misc::CmpOwned);
reg.register_late_lint_pass(box attrs::AttrPass);
reg.register_late_lint_pass(box collapsible_if::CollapsibleIf);
2015-11-20 05:22:52 +00:00
reg.register_late_lint_pass(box block_in_if_condition::BlockInIfCondition);
reg.register_late_lint_pass(box misc::ModuloOne);
reg.register_late_lint_pass(box unicode::Unicode);
reg.register_late_lint_pass(box strings::StringAdd);
reg.register_early_lint_pass(box returns::ReturnPass);
reg.register_late_lint_pass(box methods::MethodsPass);
reg.register_late_lint_pass(box shadow::ShadowPass);
reg.register_late_lint_pass(box types::LetPass);
reg.register_late_lint_pass(box types::UnitCmp);
reg.register_late_lint_pass(box loops::LoopsPass);
reg.register_late_lint_pass(box lifetimes::LifetimePass);
reg.register_late_lint_pass(box entry::HashMapLint);
reg.register_late_lint_pass(box ranges::StepByZero);
reg.register_late_lint_pass(box types::CastPass);
reg.register_late_lint_pass(box types::TypeComplexityPass::new(conf.type_complexity_threshold));
reg.register_late_lint_pass(box matches::MatchPass);
reg.register_late_lint_pass(box misc::PatternPass);
reg.register_late_lint_pass(box minmax::MinMaxPass);
2015-10-07 11:15:14 +00:00
reg.register_late_lint_pass(box open_options::NonSensicalOpenOptions);
reg.register_late_lint_pass(box zero_div_zero::ZeroDivZeroPass);
reg.register_late_lint_pass(box mutex_atomic::MutexAtomic);
reg.register_late_lint_pass(box needless_update::NeedlessUpdatePass);
2015-10-28 16:50:00 +00:00
reg.register_late_lint_pass(box no_effect::NoEffectPass);
2015-10-31 04:58:37 +00:00
reg.register_late_lint_pass(box map_clone::MapClonePass);
2015-11-04 09:55:14 +00:00
reg.register_late_lint_pass(box temporary_assignment::TemporaryAssignmentPass);
reg.register_late_lint_pass(box transmute::UselessTransmute);
reg.register_late_lint_pass(box cyclomatic_complexity::CyclomaticComplexity::new(conf.cyclomatic_complexity_threshold));
2015-12-04 10:12:53 +00:00
reg.register_late_lint_pass(box escape::EscapePass);
reg.register_early_lint_pass(box misc_early::MiscEarly);
2015-12-11 23:08:59 +00:00
reg.register_late_lint_pass(box misc::UsedUnderscoreBinding);
2015-12-21 18:22:29 +00:00
reg.register_late_lint_pass(box array_indexing::ArrayIndexing);
2015-12-23 21:37:52 +00:00
reg.register_late_lint_pass(box panic::PanicPass);
reg.register_late_lint_pass(box strings::StringLitAsBytes);
reg.register_late_lint_pass(box derive::Derive);
reg.register_late_lint_pass(box types::CharLitAsU8);
reg.register_late_lint_pass(box print::PrintLint);
reg.register_late_lint_pass(box vec::UselessVec);
reg.register_early_lint_pass(box non_expressive_names::NonExpressiveNames {
max_single_char_names: conf.max_single_char_names,
});
reg.register_late_lint_pass(box drop_ref::DropRefPass);
reg.register_late_lint_pass(box types::AbsurdExtremeComparisons);
2016-02-14 15:55:02 +00:00
reg.register_late_lint_pass(box regex::RegexPass::default());
reg.register_late_lint_pass(box copies::CopyAndPaste);
reg.register_late_lint_pass(box format::FormatMacLint);
reg.register_early_lint_pass(box formatting::Formatting);
2016-02-27 23:01:15 +00:00
reg.register_late_lint_pass(box swap::Swap);
reg.register_early_lint_pass(box if_not_else::IfNotElse);
2016-03-06 15:01:17 +00:00
reg.register_late_lint_pass(box overflow_check_conditional::OverflowCheckConditional);
2016-03-01 14:15:39 +00:00
reg.register_late_lint_pass(box unused_label::UnusedLabel);
reg.register_late_lint_pass(box new_without_default::NewWithoutDefault);
2016-02-22 14:42:24 +00:00
reg.register_late_lint_pass(box blacklisted_name::BlackListedName::new(conf.blacklisted_names));
2016-03-08 23:48:10 +00:00
reg.register_late_lint_pass(box functions::Functions::new(conf.too_many_arguments_threshold));
reg.register_lint_group("clippy_pedantic", vec![
array_indexing::INDEXING_SLICING,
enum_glob_use::ENUM_GLOB_USE,
matches::SINGLE_MATCH_ELSE,
methods::OPTION_UNWRAP_USED,
methods::RESULT_UNWRAP_USED,
methods::WRONG_PUB_SELF_CONVENTION,
mut_mut::MUT_MUT,
mutex_atomic::MUTEX_INTEGER,
print::PRINT_STDOUT,
2016-02-07 17:30:57 +00:00
print::USE_DEBUG,
2015-08-21 15:11:34 +00:00
shadow::SHADOW_REUSE,
shadow::SHADOW_SAME,
shadow::SHADOW_UNRELATED,
2016-02-05 15:48:35 +00:00
strings::STRING_ADD,
strings::STRING_ADD_ASSIGN,
types::CAST_POSSIBLE_TRUNCATION,
types::CAST_POSSIBLE_WRAP,
types::CAST_PRECISION_LOSS,
types::CAST_SIGN_LOSS,
unicode::NON_ASCII_LITERAL,
unicode::UNICODE_NOT_NFC,
2015-08-21 15:11:34 +00:00
]);
reg.register_lint_group("clippy", vec![
approx_const::APPROX_CONSTANT,
2015-12-21 18:22:29 +00:00
array_indexing::OUT_OF_BOUNDS_INDEXING,
2016-01-09 01:05:43 +00:00
attrs::DEPRECATED_SEMVER,
attrs::INLINE_ALWAYS,
bit_mask::BAD_BIT_MASK,
bit_mask::INEFFECTIVE_BIT_MASK,
2016-02-22 14:42:24 +00:00
blacklisted_name::BLACKLISTED_NAME,
2015-11-20 05:22:52 +00:00
block_in_if_condition::BLOCK_IN_IF_CONDITION_EXPR,
block_in_if_condition::BLOCK_IN_IF_CONDITION_STMT,
collapsible_if::COLLAPSIBLE_IF,
copies::IF_SAME_THEN_ELSE,
copies::IFS_SAME_COND,
2016-02-10 00:22:53 +00:00
copies::MATCH_SAME_ARMS,
cyclomatic_complexity::CYCLOMATIC_COMPLEXITY,
2016-02-15 22:38:09 +00:00
derive::DERIVE_HASH_XOR_EQ,
derive::EXPL_IMPL_CLONE_ON_COPY,
drop_ref::DROP_REF,
entry::MAP_ENTRY,
enum_clike::ENUM_CLIKE_UNPORTABLE_VARIANT,
enum_variants::ENUM_VARIANT_NAMES,
eq_op::EQ_OP,
2015-12-04 10:12:53 +00:00
escape::BOXED_LOCAL,
eta_reduction::REDUNDANT_CLOSURE,
format::USELESS_FORMAT,
formatting::SUSPICIOUS_ASSIGNMENT_FORMATTING,
formatting::SUSPICIOUS_ELSE_FORMATTING,
2016-03-08 23:48:10 +00:00
functions::TOO_MANY_ARGUMENTS,
identity_op::IDENTITY_OP,
if_not_else::IF_NOT_ELSE,
2016-01-24 09:16:56 +00:00
items_after_statements::ITEMS_AFTER_STATEMENTS,
len_zero::LEN_WITHOUT_IS_EMPTY,
len_zero::LEN_ZERO,
lifetimes::NEEDLESS_LIFETIMES,
lifetimes::UNUSED_LIFETIMES,
2015-10-12 11:38:18 +00:00
loops::EMPTY_LOOP,
loops::EXPLICIT_COUNTER_LOOP,
loops::EXPLICIT_ITER_LOOP,
loops::FOR_KV_MAP,
2016-01-29 07:34:09 +00:00
loops::FOR_LOOP_OVER_OPTION,
2016-01-29 23:15:57 +00:00
loops::FOR_LOOP_OVER_RESULT,
loops::ITER_NEXT_LOOP,
loops::NEEDLESS_RANGE_LOOP,
loops::REVERSE_RANGE_LOOP,
loops::UNUSED_COLLECT,
loops::WHILE_LET_LOOP,
loops::WHILE_LET_ON_ITERATOR,
2015-10-31 04:58:37 +00:00
map_clone::MAP_CLONE,
matches::MATCH_BOOL,
2015-12-23 00:14:10 +00:00
matches::MATCH_OVERLAPPING_ARM,
matches::MATCH_REF_PATS,
matches::SINGLE_MATCH,
2016-01-20 01:23:39 +00:00
methods::CHARS_NEXT_CMP,
methods::CLONE_DOUBLE_REF,
methods::CLONE_ON_COPY,
2016-01-25 13:02:47 +00:00
methods::EXTEND_FROM_SLICE,
2015-12-29 00:56:58 +00:00
methods::FILTER_NEXT,
methods::NEW_RET_NO_SELF,
2015-11-19 13:39:27 +00:00
methods::OK_EXPECT,
methods::OPTION_MAP_UNWRAP_OR,
methods::OPTION_MAP_UNWRAP_OR_ELSE,
methods::OR_FUN_CALL,
2015-12-30 08:38:03 +00:00
methods::SEARCH_IS_SOME,
methods::SHOULD_IMPLEMENT_TRAIT,
methods::SINGLE_CHAR_PATTERN,
methods::WRONG_SELF_CONVENTION,
2015-09-05 10:46:34 +00:00
minmax::MIN_MAX,
misc::CMP_NAN,
misc::CMP_OWNED,
misc::FLOAT_CMP,
misc::MODULO_ONE,
misc::REDUNDANT_PATTERN,
misc::TOPLEVEL_REF_ARG,
2015-12-11 23:08:59 +00:00
misc::USED_UNDERSCORE_BINDING,
misc_early::DUPLICATE_UNDERSCORE_ARGUMENT,
misc_early::REDUNDANT_CLOSURE_CALL,
2015-12-07 12:23:52 +00:00
misc_early::UNNEEDED_FIELD_PATTERN,
2015-09-29 11:11:19 +00:00
mut_reference::UNNECESSARY_MUT_PASSED,
mutex_atomic::MUTEX_ATOMIC,
needless_bool::BOOL_COMPARISON,
needless_bool::NEEDLESS_BOOL,
needless_update::NEEDLESS_UPDATE,
new_without_default::NEW_WITHOUT_DEFAULT,
2015-10-28 16:50:00 +00:00
no_effect::NO_EFFECT,
non_expressive_names::MANY_SINGLE_CHAR_NAMES,
non_expressive_names::SIMILAR_NAMES,
2015-10-07 11:15:14 +00:00
open_options::NONSENSICAL_OPEN_OPTIONS,
2016-03-06 15:01:17 +00:00
overflow_check_conditional::OVERFLOW_CHECK_CONDITIONAL,
2015-12-23 21:37:52 +00:00
panic::PANIC_PARAMS,
2015-08-30 15:32:35 +00:00
precedence::PRECEDENCE,
2015-10-14 17:51:54 +00:00
ptr_arg::PTR_ARG,
ranges::RANGE_STEP_BY_ZERO,
ranges::RANGE_ZIP_WITH_LEN,
2016-02-04 23:36:06 +00:00
regex::INVALID_REGEX,
2016-02-08 22:48:04 +00:00
regex::REGEX_MACRO,
2016-02-05 22:10:48 +00:00
regex::TRIVIAL_REGEX,
returns::LET_AND_RETURN,
returns::NEEDLESS_RETURN,
strings::STRING_LIT_AS_BYTES,
2016-02-27 23:46:02 +00:00
swap::ALMOST_SWAPPED,
swap::MANUAL_SWAP,
2015-11-04 09:55:14 +00:00
temporary_assignment::TEMPORARY_ASSIGNMENT,
transmute::USELESS_TRANSMUTE,
types::ABSURD_EXTREME_COMPARISONS,
types::BOX_VEC,
types::CHAR_LIT_AS_U8,
types::LET_UNIT_VALUE,
types::LINKEDLIST,
types::TYPE_COMPLEXITY,
types::UNIT_CMP,
unicode::ZERO_WIDTH_SPACE,
2016-03-01 14:15:39 +00:00
unused_label::UNUSED_LABEL,
vec::USELESS_VEC,
zero_div_zero::ZERO_DIVIDED_BY_ZERO,
]);
2014-12-10 21:34:58 +00:00
}