rust-clippy/clippy_lints/src/mem_forget.rs

59 lines
2 KiB
Rust
Raw Normal View History

2018-10-06 16:18:06 +00:00
// Copyright 2014-2018 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.
use crate::rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
use crate::rustc::{declare_tool_lint, lint_array};
use crate::rustc::hir::{Expr, ExprKind};
2018-05-30 08:15:50 +00:00
use crate::utils::{match_def_path, opt_def_id, paths, span_lint};
2016-04-20 20:10:23 +00:00
2017-08-09 07:30:56 +00:00
/// **What it does:** Checks for usage of `std::mem::forget(t)` where `t` is
/// `Drop`.
2016-04-20 20:10:23 +00:00
///
/// **Why is this bad?** `std::mem::forget(t)` prevents `t` from running its
/// destructor, possibly causing leaks.
2016-04-20 20:10:23 +00:00
///
/// **Known problems:** None.
///
2016-07-15 22:25:44 +00:00
/// **Example:**
/// ```rust
/// mem::forget(Rc::new(55)))
/// ```
2018-03-28 13:24:26 +00:00
declare_clippy_lint! {
2016-04-20 20:10:23 +00:00
pub MEM_FORGET,
2018-03-28 13:24:26 +00:00
restriction,
"`mem::forget` usage on `Drop` types, likely to cause memory leaks"
2016-04-20 20:10:23 +00:00
}
pub struct MemForget;
impl LintPass for MemForget {
fn get_lints(&self) -> LintArray {
lint_array![MEM_FORGET]
}
}
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for MemForget {
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, e: &'tcx Expr) {
2018-07-12 07:30:57 +00:00
if let ExprKind::Call(ref path_expr, ref args) = e.node {
if let ExprKind::Path(ref qpath) = path_expr.node {
2017-09-12 12:26:40 +00:00
if let Some(def_id) = opt_def_id(cx.tables.qpath_def(qpath, path_expr.hir_id)) {
if match_def_path(cx.tcx, def_id, &paths::MEM_FORGET) {
let forgot_ty = cx.tables.expr_ty(&args[0]);
2018-08-06 13:42:08 +00:00
if forgot_ty.ty_adt_def().map_or(false, |def| def.has_dtor(cx.tcx)) {
2017-09-12 12:26:40 +00:00
span_lint(cx, MEM_FORGET, e.span, "usage of mem::forget on Drop type");
}
}
2016-04-20 20:10:23 +00:00
}
}
}
}
}