2019-05-17 21:53:54 +00:00
|
|
|
|
#[macro_use]
|
|
|
|
|
pub mod sym;
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
pub mod attrs;
|
|
|
|
|
pub mod author;
|
|
|
|
|
pub mod camel_case;
|
|
|
|
|
pub mod comparisons;
|
|
|
|
|
pub mod conf;
|
|
|
|
|
pub mod constants;
|
|
|
|
|
mod diagnostics;
|
|
|
|
|
pub mod higher;
|
|
|
|
|
mod hir_utils;
|
|
|
|
|
pub mod inspector;
|
|
|
|
|
pub mod internal_lints;
|
|
|
|
|
pub mod paths;
|
|
|
|
|
pub mod ptr;
|
|
|
|
|
pub mod sugg;
|
|
|
|
|
pub mod usage;
|
|
|
|
|
pub use self::attrs::*;
|
|
|
|
|
pub use self::diagnostics::*;
|
|
|
|
|
pub use self::hir_utils::{SpanlessEq, SpanlessHash};
|
|
|
|
|
|
|
|
|
|
use std::borrow::Cow;
|
|
|
|
|
use std::mem;
|
|
|
|
|
|
2018-12-29 15:04:45 +00:00
|
|
|
|
use if_chain::if_chain;
|
|
|
|
|
use matches::matches;
|
|
|
|
|
use rustc::hir;
|
2019-05-04 00:03:12 +00:00
|
|
|
|
use rustc::hir::def::{DefKind, Res};
|
2019-01-23 06:32:58 +00:00
|
|
|
|
use rustc::hir::def_id::{DefId, CRATE_DEF_INDEX, LOCAL_CRATE};
|
2018-12-29 15:04:45 +00:00
|
|
|
|
use rustc::hir::intravisit::{NestedVisitorMap, Visitor};
|
|
|
|
|
use rustc::hir::Node;
|
|
|
|
|
use rustc::hir::*;
|
|
|
|
|
use rustc::lint::{LateContext, Level, Lint, LintContext};
|
|
|
|
|
use rustc::traits;
|
|
|
|
|
use rustc::ty::{
|
2018-11-20 09:33:40 +00:00
|
|
|
|
self,
|
|
|
|
|
layout::{self, IntegerExt},
|
|
|
|
|
subst::Kind,
|
|
|
|
|
Binder, Ty, TyCtxt,
|
|
|
|
|
};
|
2019-02-24 13:11:05 +00:00
|
|
|
|
use rustc_errors::Applicability;
|
2019-05-24 06:19:51 +00:00
|
|
|
|
use smallvec::SmallVec;
|
2018-12-29 15:04:45 +00:00
|
|
|
|
use syntax::ast::{self, LitKind};
|
|
|
|
|
use syntax::attr;
|
2019-05-11 06:19:35 +00:00
|
|
|
|
use syntax::ext::hygiene::ExpnFormat;
|
2018-12-29 15:04:45 +00:00
|
|
|
|
use syntax::source_map::{Span, DUMMY_SP};
|
2019-05-23 05:19:25 +00:00
|
|
|
|
use syntax::symbol::{kw, Symbol};
|
2015-11-18 11:35:18 +00:00
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
use crate::reexport::*;
|
2015-12-27 22:15:09 +00:00
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns `true` if the two spans come from differing expansions (i.e., one is
|
|
|
|
|
/// from a macro and one isn't).
|
2016-03-01 09:13:54 +00:00
|
|
|
|
pub fn differing_macro_contexts(lhs: Span, rhs: Span) -> bool {
|
2017-08-31 12:47:45 +00:00
|
|
|
|
rhs.ctxt() != lhs.ctxt()
|
2016-01-02 16:11:48 +00:00
|
|
|
|
}
|
2017-03-07 11:58:07 +00:00
|
|
|
|
|
2018-12-31 11:12:50 +00:00
|
|
|
|
/// Returns `true` if the given `NodeId` is inside a constant context
|
|
|
|
|
///
|
|
|
|
|
/// # Example
|
|
|
|
|
///
|
|
|
|
|
/// ```rust,ignore
|
|
|
|
|
/// if in_constant(cx, expr.id) {
|
|
|
|
|
/// // Do something
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
2019-02-24 18:43:15 +00:00
|
|
|
|
pub fn in_constant(cx: &LateContext<'_, '_>, id: HirId) -> bool {
|
|
|
|
|
let parent_id = cx.tcx.hir().get_parent_item(id);
|
2019-06-22 06:41:16 +00:00
|
|
|
|
match cx.tcx.hir().get(parent_id) {
|
2019-01-22 15:27:42 +00:00
|
|
|
|
Node::Item(&Item {
|
|
|
|
|
node: ItemKind::Const(..),
|
|
|
|
|
..
|
|
|
|
|
})
|
|
|
|
|
| Node::TraitItem(&TraitItem {
|
|
|
|
|
node: TraitItemKind::Const(..),
|
|
|
|
|
..
|
|
|
|
|
})
|
|
|
|
|
| Node::ImplItem(&ImplItem {
|
|
|
|
|
node: ImplItemKind::Const(..),
|
|
|
|
|
..
|
|
|
|
|
})
|
2019-01-22 14:28:51 +00:00
|
|
|
|
| Node::AnonConst(_)
|
2019-01-22 15:27:42 +00:00
|
|
|
|
| Node::Item(&Item {
|
|
|
|
|
node: ItemKind::Static(..),
|
|
|
|
|
..
|
|
|
|
|
}) => true,
|
2019-01-26 08:49:55 +00:00
|
|
|
|
Node::Item(&Item {
|
|
|
|
|
node: ItemKind::Fn(_, header, ..),
|
|
|
|
|
..
|
|
|
|
|
}) => header.constness == Constness::Const,
|
2019-01-22 14:28:51 +00:00
|
|
|
|
_ => false,
|
2017-03-07 11:58:07 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-05-12 03:41:30 +00:00
|
|
|
|
/// Returns `true` if this `expn_info` was expanded by any macro or desugaring
|
2019-05-12 03:40:05 +00:00
|
|
|
|
pub fn in_macro_or_desugar(span: Span) -> bool {
|
2019-06-01 09:25:51 +00:00
|
|
|
|
span.ctxt().outer_expn_info().is_some()
|
2019-05-12 03:41:30 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Returns `true` if this `expn_info` was expanded by any macro.
|
|
|
|
|
pub fn in_macro(span: Span) -> bool {
|
2019-06-01 09:25:51 +00:00
|
|
|
|
if let Some(info) = span.ctxt().outer_expn_info() {
|
2019-05-11 06:19:35 +00:00
|
|
|
|
if let ExpnFormat::CompilerDesugaring(..) = info.format {
|
|
|
|
|
false
|
|
|
|
|
} else {
|
|
|
|
|
true
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
false
|
|
|
|
|
}
|
2018-03-05 08:30:07 +00:00
|
|
|
|
}
|
2019-04-19 10:53:03 +00:00
|
|
|
|
// If the snippet is empty, it's an attribute that was inserted during macro
|
|
|
|
|
// expansion and we want to ignore those, because they could come from external
|
|
|
|
|
// sources that the user has no control over.
|
|
|
|
|
// For some reason these attributes don't have any expansion info on them, so
|
|
|
|
|
// we have to check it this way until there is a better way.
|
2019-06-12 03:07:48 +00:00
|
|
|
|
pub fn is_present_in_source<T: LintContext>(cx: &T, span: Span) -> bool {
|
2019-04-19 10:53:03 +00:00
|
|
|
|
if let Some(snippet) = snippet_opt(cx, span) {
|
|
|
|
|
if snippet.is_empty() {
|
|
|
|
|
return false;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
true
|
|
|
|
|
}
|
|
|
|
|
|
2019-03-10 17:19:47 +00:00
|
|
|
|
/// Checks if type is struct, enum or union type with the given def path.
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn match_type(cx: &LateContext<'_, '_>, ty: Ty<'_>, path: &[&str]) -> bool {
|
2015-08-21 17:00:33 +00:00
|
|
|
|
match ty.sty {
|
2019-05-13 23:34:08 +00:00
|
|
|
|
ty::Adt(adt, _) => match_def_path(cx, adt.did, path),
|
2016-01-04 04:26:12 +00:00
|
|
|
|
_ => false,
|
2015-08-21 17:00:33 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-03-10 17:19:47 +00:00
|
|
|
|
/// Checks if the method call given in `expr` belongs to the given trait.
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn match_trait_method(cx: &LateContext<'_, '_>, expr: &Expr, path: &[&str]) -> bool {
|
2019-04-10 14:18:02 +00:00
|
|
|
|
let def_id = cx.tables.type_dependent_def_id(expr.hir_id).unwrap();
|
|
|
|
|
let trt_id = cx.tcx.trait_of_item(def_id);
|
2015-08-23 14:32:50 +00:00
|
|
|
|
if let Some(trt_id) = trt_id {
|
2019-05-13 23:34:08 +00:00
|
|
|
|
match_def_path(cx, trt_id, path)
|
2015-08-23 14:32:50 +00:00
|
|
|
|
} else {
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Checks if an expression references a variable of the given name.
|
2017-09-16 07:10:26 +00:00
|
|
|
|
pub fn match_var(expr: &Expr, var: Name) -> bool {
|
2018-07-12 07:30:57 +00:00
|
|
|
|
if let ExprKind::Path(QPath::Resolved(None, ref path)) = expr.node {
|
2018-06-28 13:46:58 +00:00
|
|
|
|
if path.segments.len() == 1 && path.segments[0].ident.name == var {
|
2017-09-16 07:10:26 +00:00
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
|
2016-12-02 16:38:31 +00:00
|
|
|
|
pub fn last_path_segment(path: &QPath) -> &PathSegment {
|
|
|
|
|
match *path {
|
2018-11-20 09:33:40 +00:00
|
|
|
|
QPath::Resolved(_, ref path) => path.segments.last().expect("A path must have at least one segment"),
|
2016-12-02 21:33:16 +00:00
|
|
|
|
QPath::TypeRelative(_, ref seg) => seg,
|
2016-12-02 16:38:31 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
pub fn single_segment_path(path: &QPath) -> Option<&PathSegment> {
|
|
|
|
|
match *path {
|
|
|
|
|
QPath::Resolved(_, ref path) if path.segments.len() == 1 => Some(&path.segments[0]),
|
|
|
|
|
QPath::Resolved(..) => None,
|
2016-12-02 21:33:16 +00:00
|
|
|
|
QPath::TypeRelative(_, ref seg) => Some(seg),
|
2016-12-02 16:38:31 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Matches a `QPath` against a slice of segment string literals.
|
2019-03-08 08:50:20 +00:00
|
|
|
|
///
|
|
|
|
|
/// There is also `match_path` if you are dealing with a `rustc::hir::Path` instead of a
|
|
|
|
|
/// `rustc::hir::QPath`.
|
2016-01-12 22:17:54 +00:00
|
|
|
|
///
|
|
|
|
|
/// # Examples
|
2016-12-21 09:00:13 +00:00
|
|
|
|
/// ```rust,ignore
|
2017-08-24 22:21:46 +00:00
|
|
|
|
/// match_qpath(path, &["std", "rt", "begin_unwind"])
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// ```
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn match_qpath(path: &QPath, segments: &[&str]) -> bool {
|
2016-12-02 16:38:31 +00:00
|
|
|
|
match *path {
|
2017-08-24 22:21:46 +00:00
|
|
|
|
QPath::Resolved(_, ref path) => match_path(path, segments),
|
2017-09-05 09:33:04 +00:00
|
|
|
|
QPath::TypeRelative(ref ty, ref segment) => match ty.node {
|
2018-07-12 08:03:06 +00:00
|
|
|
|
TyKind::Path(ref inner_path) => {
|
2018-11-20 09:33:40 +00:00
|
|
|
|
!segments.is_empty()
|
|
|
|
|
&& match_qpath(inner_path, &segments[..(segments.len() - 1)])
|
2019-05-17 21:53:54 +00:00
|
|
|
|
&& segment.ident.name.as_str() == segments[segments.len() - 1]
|
2017-09-05 09:33:04 +00:00
|
|
|
|
},
|
|
|
|
|
_ => false,
|
2016-12-02 16:38:31 +00:00
|
|
|
|
},
|
2016-12-01 21:31:56 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Matches a `Path` against a slice of segment string literals.
|
2019-03-08 08:50:20 +00:00
|
|
|
|
///
|
|
|
|
|
/// There is also `match_qpath` if you are dealing with a `rustc::hir::QPath` instead of a
|
|
|
|
|
/// `rustc::hir::Path`.
|
|
|
|
|
///
|
|
|
|
|
/// # Examples
|
|
|
|
|
///
|
|
|
|
|
/// ```rust,ignore
|
2019-05-17 21:53:54 +00:00
|
|
|
|
/// if match_path(&trait_ref.path, &paths::HASH) {
|
2019-03-08 08:50:20 +00:00
|
|
|
|
/// // This is the `std::hash::Hash` trait.
|
|
|
|
|
/// }
|
|
|
|
|
///
|
|
|
|
|
/// if match_path(ty_path, &["rustc", "lint", "Lint"]) {
|
|
|
|
|
/// // This is a `rustc::lint::Lint`.
|
|
|
|
|
/// }
|
|
|
|
|
/// ```
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn match_path(path: &Path, segments: &[&str]) -> bool {
|
2017-09-05 09:33:04 +00:00
|
|
|
|
path.segments
|
|
|
|
|
.iter()
|
|
|
|
|
.rev()
|
|
|
|
|
.zip(segments.iter().rev())
|
2019-05-17 21:53:54 +00:00
|
|
|
|
.all(|(a, b)| a.ident.name.as_str() == *b)
|
2015-06-07 10:05:14 +00:00
|
|
|
|
}
|
2015-07-09 15:02:21 +00:00
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Matches a `Path` against a slice of segment string literals, e.g.
|
2016-01-12 22:17:54 +00:00
|
|
|
|
///
|
|
|
|
|
/// # Examples
|
2016-12-21 09:00:13 +00:00
|
|
|
|
/// ```rust,ignore
|
2017-08-24 22:21:46 +00:00
|
|
|
|
/// match_qpath(path, &["std", "rt", "begin_unwind"])
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// ```
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn match_path_ast(path: &ast::Path, segments: &[&str]) -> bool {
|
2017-09-05 09:33:04 +00:00
|
|
|
|
path.segments
|
|
|
|
|
.iter()
|
|
|
|
|
.rev()
|
|
|
|
|
.zip(segments.iter().rev())
|
2019-05-17 21:53:54 +00:00
|
|
|
|
.all(|(a, b)| a.ident.name.as_str() == *b)
|
2015-10-11 21:12:21 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Gets the definition associated to a path.
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn path_to_res(cx: &LateContext<'_, '_>, path: &[&str]) -> Option<(def::Res)> {
|
2017-09-09 05:23:08 +00:00
|
|
|
|
let crates = cx.tcx.crates();
|
2019-05-17 22:58:25 +00:00
|
|
|
|
let krate = crates
|
|
|
|
|
.iter()
|
|
|
|
|
.find(|&&krate| cx.tcx.crate_name(krate).as_str() == path[0]);
|
2016-01-18 12:10:13 +00:00
|
|
|
|
if let Some(krate) = krate {
|
2016-12-20 17:21:30 +00:00
|
|
|
|
let krate = DefId {
|
|
|
|
|
krate: *krate,
|
|
|
|
|
index: CRATE_DEF_INDEX,
|
|
|
|
|
};
|
2017-09-09 05:23:08 +00:00
|
|
|
|
let mut items = cx.tcx.item_children(krate);
|
2016-01-18 12:10:13 +00:00
|
|
|
|
let mut path_it = path.iter().skip(1).peekable();
|
|
|
|
|
|
|
|
|
|
loop {
|
|
|
|
|
let segment = match path_it.next() {
|
|
|
|
|
Some(segment) => segment,
|
2016-01-30 12:48:39 +00:00
|
|
|
|
None => return None,
|
2016-01-18 12:10:13 +00:00
|
|
|
|
};
|
|
|
|
|
|
2019-05-24 06:19:51 +00:00
|
|
|
|
let result = SmallVec::<[_; 8]>::new();
|
|
|
|
|
for item in mem::replace(&mut items, cx.tcx.arena.alloc_slice(&result)).iter() {
|
2019-05-17 21:53:54 +00:00
|
|
|
|
if item.ident.name.as_str() == *segment {
|
2016-01-18 12:10:13 +00:00
|
|
|
|
if path_it.peek().is_none() {
|
2019-05-04 00:03:12 +00:00
|
|
|
|
return Some(item.res);
|
2016-01-18 12:10:13 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-05-04 00:03:12 +00:00
|
|
|
|
items = cx.tcx.item_children(item.res.def_id());
|
2016-01-18 12:10:13 +00:00
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-01-30 12:48:39 +00:00
|
|
|
|
} else {
|
2016-01-18 12:10:13 +00:00
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// Convenience function to get the `DefId` of a trait by path.
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn get_trait_def_id(cx: &LateContext<'_, '_>, path: &[&str]) -> Option<DefId> {
|
2019-05-04 00:03:12 +00:00
|
|
|
|
let res = match path_to_res(cx, path) {
|
|
|
|
|
Some(res) => res,
|
2016-01-18 12:10:13 +00:00
|
|
|
|
None => return None,
|
|
|
|
|
};
|
|
|
|
|
|
2019-05-04 00:03:12 +00:00
|
|
|
|
match res {
|
|
|
|
|
def::Res::Def(DefKind::Trait, trait_id) => Some(trait_id),
|
2016-01-18 12:10:13 +00:00
|
|
|
|
_ => None,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Checks whether a type implements a trait.
|
2016-01-18 12:10:13 +00:00
|
|
|
|
/// See also `get_trait_def_id`.
|
2016-12-21 11:14:54 +00:00
|
|
|
|
pub fn implements_trait<'a, 'tcx>(
|
|
|
|
|
cx: &LateContext<'a, 'tcx>,
|
2017-06-11 02:57:25 +00:00
|
|
|
|
ty: Ty<'tcx>,
|
2016-12-21 11:14:54 +00:00
|
|
|
|
trait_id: DefId,
|
2018-05-22 13:45:14 +00:00
|
|
|
|
ty_params: &[Kind<'tcx>],
|
2016-12-21 11:14:54 +00:00
|
|
|
|
) -> bool {
|
2016-03-18 18:12:32 +00:00
|
|
|
|
let ty = cx.tcx.erase_regions(&ty);
|
2018-11-20 09:33:40 +00:00
|
|
|
|
let obligation = cx.tcx.predicate_for_trait_def(
|
|
|
|
|
cx.param_env,
|
|
|
|
|
traits::ObligationCause::dummy(),
|
|
|
|
|
trait_id,
|
|
|
|
|
0,
|
|
|
|
|
ty,
|
|
|
|
|
ty_params,
|
|
|
|
|
);
|
|
|
|
|
cx.tcx
|
|
|
|
|
.infer_ctxt()
|
2019-01-03 20:54:57 +00:00
|
|
|
|
.enter(|infcx| infcx.predicate_must_hold_modulo_regions(&obligation))
|
2016-01-18 12:10:13 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Gets the `hir::TraitRef` of the trait the given method is implemented for.
|
2019-03-07 06:42:38 +00:00
|
|
|
|
///
|
2019-03-08 08:40:12 +00:00
|
|
|
|
/// Use this if you want to find the `TraitRef` of the `Add` trait in this example:
|
2019-03-07 06:42:38 +00:00
|
|
|
|
///
|
|
|
|
|
/// ```rust
|
2019-03-08 08:10:41 +00:00
|
|
|
|
/// struct Point(isize, isize);
|
2019-03-07 06:42:38 +00:00
|
|
|
|
///
|
2019-03-08 08:10:41 +00:00
|
|
|
|
/// impl std::ops::Add for Point {
|
|
|
|
|
/// type Output = Self;
|
|
|
|
|
///
|
|
|
|
|
/// fn add(self, other: Self) -> Self {
|
|
|
|
|
/// Point(0, 0)
|
|
|
|
|
/// }
|
|
|
|
|
/// }
|
2019-03-07 06:42:38 +00:00
|
|
|
|
/// ```
|
2019-06-21 10:32:39 +00:00
|
|
|
|
pub fn trait_ref_of_method<'tcx>(cx: &LateContext<'_, 'tcx>, hir_id: HirId) -> Option<&'tcx TraitRef> {
|
2019-03-07 06:42:38 +00:00
|
|
|
|
// Get the implemented trait for the current function
|
|
|
|
|
let parent_impl = cx.tcx.hir().get_parent_item(hir_id);
|
|
|
|
|
if_chain! {
|
|
|
|
|
if parent_impl != hir::CRATE_HIR_ID;
|
2019-06-22 06:41:16 +00:00
|
|
|
|
if let hir::Node::Item(item) = cx.tcx.hir().get(parent_impl);
|
2019-03-07 06:42:38 +00:00
|
|
|
|
if let hir::ItemKind::Impl(_, _, _, _, trait_ref, _, _) = &item.node;
|
2019-06-21 06:14:07 +00:00
|
|
|
|
then { return trait_ref.as_ref(); }
|
2019-03-07 06:42:38 +00:00
|
|
|
|
}
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Checks whether this type implements `Drop`.
|
2018-12-09 11:19:21 +00:00
|
|
|
|
pub fn has_drop<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, ty: Ty<'tcx>) -> bool {
|
|
|
|
|
match ty.ty_adt_def() {
|
2017-09-19 20:38:35 +00:00
|
|
|
|
Some(def) => def.has_dtor(cx.tcx),
|
|
|
|
|
_ => false,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Resolves the definition of a node from its `HirId`.
|
2019-05-04 00:03:12 +00:00
|
|
|
|
pub fn resolve_node(cx: &LateContext<'_, '_>, qpath: &QPath, id: HirId) -> Res {
|
|
|
|
|
cx.tables.qpath_res(qpath, id)
|
2016-10-22 13:57:19 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns the method names and argument list of nested method call expressions that make up
|
2018-10-31 04:26:29 +00:00
|
|
|
|
/// `expr`.
|
2019-06-21 11:31:20 +00:00
|
|
|
|
pub fn method_calls(expr: &Expr, max_depth: usize) -> (Vec<Symbol>, Vec<&[Expr]>) {
|
2018-10-31 04:26:29 +00:00
|
|
|
|
let mut method_names = Vec::with_capacity(max_depth);
|
|
|
|
|
let mut arg_lists = Vec::with_capacity(max_depth);
|
|
|
|
|
|
|
|
|
|
let mut current = expr;
|
|
|
|
|
for _ in 0..max_depth {
|
|
|
|
|
if let ExprKind::MethodCall(path, _, args) = ¤t.node {
|
2019-05-12 03:40:05 +00:00
|
|
|
|
if args.iter().any(|e| in_macro_or_desugar(e.span)) {
|
2018-10-31 04:26:29 +00:00
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
method_names.push(path.ident.name);
|
|
|
|
|
arg_lists.push(&**args);
|
|
|
|
|
current = &args[0];
|
|
|
|
|
} else {
|
|
|
|
|
break;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
(method_names, arg_lists)
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Matches an `Expr` against a chain of methods, and return the matched `Expr`s.
|
2016-01-12 22:17:54 +00:00
|
|
|
|
///
|
|
|
|
|
/// For example, if `expr` represents the `.baz()` in `foo.bar().baz()`,
|
2017-08-09 07:30:56 +00:00
|
|
|
|
/// `matched_method_chain(expr, &["bar", "baz"])` will return a `Vec`
|
|
|
|
|
/// containing the `Expr`s for
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// `.bar()` and `.baz()`
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn method_chain_args<'a>(expr: &'a Expr, methods: &[&str]) -> Option<Vec<&'a [Expr]>> {
|
2015-12-27 22:15:09 +00:00
|
|
|
|
let mut current = expr;
|
|
|
|
|
let mut matched = Vec::with_capacity(methods.len());
|
2016-01-04 04:26:12 +00:00
|
|
|
|
for method_name in methods.iter().rev() {
|
|
|
|
|
// method chains are stored last -> first
|
2018-07-12 07:30:57 +00:00
|
|
|
|
if let ExprKind::MethodCall(ref path, _, ref args) = current.node {
|
2019-05-17 21:53:54 +00:00
|
|
|
|
if path.ident.name.as_str() == *method_name {
|
2019-05-12 03:40:05 +00:00
|
|
|
|
if args.iter().any(|e| in_macro_or_desugar(e.span)) {
|
2017-04-06 14:48:48 +00:00
|
|
|
|
return None;
|
|
|
|
|
}
|
2016-11-23 21:44:00 +00:00
|
|
|
|
matched.push(&**args); // build up `matched` backwards
|
2015-12-27 22:15:09 +00:00
|
|
|
|
current = &args[0] // go to parent expression
|
2016-01-04 04:26:12 +00:00
|
|
|
|
} else {
|
2015-12-27 22:15:09 +00:00
|
|
|
|
return None;
|
2015-12-27 09:22:53 +00:00
|
|
|
|
}
|
2016-01-04 04:26:12 +00:00
|
|
|
|
} else {
|
2015-12-27 22:15:09 +00:00
|
|
|
|
return None;
|
2015-12-27 09:22:53 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2019-01-31 01:15:29 +00:00
|
|
|
|
// Reverse `matched` so that it is in the same order as `methods`.
|
|
|
|
|
matched.reverse();
|
2015-12-27 22:15:09 +00:00
|
|
|
|
Some(matched)
|
2015-12-27 09:22:53 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns `true` if the provided `def_id` is an entrypoint to a program.
|
2019-01-22 06:36:15 +00:00
|
|
|
|
pub fn is_entrypoint_fn(cx: &LateContext<'_, '_>, def_id: DefId) -> bool {
|
|
|
|
|
if let Some((entry_fn_def_id, _)) = cx.tcx.entry_fn(LOCAL_CRATE) {
|
2019-01-23 06:32:58 +00:00
|
|
|
|
return def_id == entry_fn_def_id;
|
2019-01-22 06:36:15 +00:00
|
|
|
|
}
|
|
|
|
|
false
|
2019-01-09 19:11:37 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Gets the name of the item the expression is in, if available.
|
2018-07-23 11:01:12 +00:00
|
|
|
|
pub fn get_item_name(cx: &LateContext<'_, '_>, expr: &Expr) -> Option<Name> {
|
2019-02-24 18:43:15 +00:00
|
|
|
|
let parent_id = cx.tcx.hir().get_parent_item(expr.hir_id);
|
2019-06-25 21:34:07 +00:00
|
|
|
|
match cx.tcx.hir().find(parent_id) {
|
2018-12-30 00:09:24 +00:00
|
|
|
|
Some(Node::Item(&Item { ref ident, .. })) => Some(ident.name),
|
2018-11-20 09:33:40 +00:00
|
|
|
|
Some(Node::TraitItem(&TraitItem { ident, .. })) | Some(Node::ImplItem(&ImplItem { ident, .. })) => {
|
|
|
|
|
Some(ident.name)
|
|
|
|
|
},
|
2015-09-06 18:57:06 +00:00
|
|
|
|
_ => None,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-03-10 17:19:47 +00:00
|
|
|
|
/// Gets the name of a `Pat`, if any.
|
2017-09-16 07:10:26 +00:00
|
|
|
|
pub fn get_pat_name(pat: &Pat) -> Option<Name> {
|
|
|
|
|
match pat.node {
|
2019-02-03 07:12:07 +00:00
|
|
|
|
PatKind::Binding(.., ref spname, _) => Some(spname.name),
|
2018-06-28 13:46:58 +00:00
|
|
|
|
PatKind::Path(ref qpath) => single_segment_path(qpath).map(|ps| ps.ident.name),
|
2017-09-16 07:10:26 +00:00
|
|
|
|
PatKind::Box(ref p) | PatKind::Ref(ref p, _) => get_pat_name(&*p),
|
|
|
|
|
_ => None,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2017-08-23 15:54:35 +00:00
|
|
|
|
struct ContainsName {
|
|
|
|
|
name: Name,
|
|
|
|
|
result: bool,
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
impl<'tcx> Visitor<'tcx> for ContainsName {
|
|
|
|
|
fn visit_name(&mut self, _: Span, name: Name) {
|
|
|
|
|
if self.name == name {
|
|
|
|
|
self.result = true;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
fn nested_visit_map<'this>(&'this mut self) -> NestedVisitorMap<'this, 'tcx> {
|
|
|
|
|
NestedVisitorMap::None
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Checks if an `Expr` contains a certain name.
|
2017-08-23 15:54:35 +00:00
|
|
|
|
pub fn contains_name(name: Name, expr: &Expr) -> bool {
|
2018-11-20 09:33:40 +00:00
|
|
|
|
let mut cn = ContainsName { name, result: false };
|
2017-08-23 15:54:35 +00:00
|
|
|
|
cn.visit_expr(expr);
|
|
|
|
|
cn.result
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Converts a span to a code snippet if available, otherwise use default.
|
2016-01-12 22:17:54 +00:00
|
|
|
|
///
|
2018-12-31 11:12:50 +00:00
|
|
|
|
/// This is useful if you want to provide suggestions for your lint or more generally, if you want
|
|
|
|
|
/// to convert a given `Span` to a `str`.
|
|
|
|
|
///
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// # Example
|
2016-12-21 09:00:13 +00:00
|
|
|
|
/// ```rust,ignore
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// snippet(cx, expr.span, "..")
|
|
|
|
|
/// ```
|
2019-06-12 03:07:48 +00:00
|
|
|
|
pub fn snippet<'a, T: LintContext>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
|
2017-03-03 15:56:35 +00:00
|
|
|
|
snippet_opt(cx, span).map_or_else(|| Cow::Borrowed(default), From::from)
|
2015-08-11 13:07:21 +00:00
|
|
|
|
}
|
|
|
|
|
|
2018-11-27 14:11:13 +00:00
|
|
|
|
/// Same as `snippet`, but it adapts the applicability level by following rules:
|
|
|
|
|
///
|
|
|
|
|
/// - Applicability level `Unspecified` will never be changed.
|
|
|
|
|
/// - If the span is inside a macro, change the applicability level to `MaybeIncorrect`.
|
|
|
|
|
/// - If the default value is used and the applicability level is `MachineApplicable`, change it to
|
|
|
|
|
/// `HasPlaceholders`
|
2019-06-12 03:07:48 +00:00
|
|
|
|
pub fn snippet_with_applicability<'a, T: LintContext>(
|
2018-11-20 09:33:40 +00:00
|
|
|
|
cx: &T,
|
|
|
|
|
span: Span,
|
|
|
|
|
default: &'a str,
|
|
|
|
|
applicability: &mut Applicability,
|
|
|
|
|
) -> Cow<'a, str> {
|
2019-05-12 03:40:05 +00:00
|
|
|
|
if *applicability != Applicability::Unspecified && in_macro_or_desugar(span) {
|
2018-11-27 14:11:13 +00:00
|
|
|
|
*applicability = Applicability::MaybeIncorrect;
|
|
|
|
|
}
|
2018-11-20 09:33:40 +00:00
|
|
|
|
snippet_opt(cx, span).map_or_else(
|
|
|
|
|
|| {
|
|
|
|
|
if *applicability == Applicability::MachineApplicable {
|
2018-11-27 14:11:13 +00:00
|
|
|
|
*applicability = Applicability::HasPlaceholders;
|
2018-11-20 09:33:40 +00:00
|
|
|
|
}
|
|
|
|
|
Cow::Borrowed(default)
|
|
|
|
|
},
|
|
|
|
|
From::from,
|
|
|
|
|
)
|
|
|
|
|
}
|
|
|
|
|
|
2018-10-27 09:01:27 +00:00
|
|
|
|
/// Same as `snippet`, but should only be used when it's clear that the input span is
|
|
|
|
|
/// not a macro argument.
|
2019-06-12 03:07:48 +00:00
|
|
|
|
pub fn snippet_with_macro_callsite<'a, T: LintContext>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
|
2018-10-27 09:01:27 +00:00
|
|
|
|
snippet(cx, span.source_callsite(), default)
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Converts a span to a code snippet. Returns `None` if not available.
|
2019-06-12 03:07:48 +00:00
|
|
|
|
pub fn snippet_opt<T: LintContext>(cx: &T, span: Span) -> Option<String> {
|
2018-08-20 02:06:53 +00:00
|
|
|
|
cx.sess().source_map().span_to_snippet(span).ok()
|
2015-12-08 06:03:01 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Converts a span (from a block) to a code snippet if available, otherwise use
|
2017-08-09 07:30:56 +00:00
|
|
|
|
/// default.
|
|
|
|
|
/// This trims the code of indentation, except for the first line. Use it for
|
|
|
|
|
/// blocks or block-like
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// things which need to be printed as such.
|
|
|
|
|
///
|
|
|
|
|
/// # Example
|
2016-12-21 09:00:13 +00:00
|
|
|
|
/// ```rust,ignore
|
2018-12-31 11:12:50 +00:00
|
|
|
|
/// snippet_block(cx, expr.span, "..")
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// ```
|
2019-06-12 03:07:48 +00:00
|
|
|
|
pub fn snippet_block<'a, T: LintContext>(cx: &T, span: Span, default: &'a str) -> Cow<'a, str> {
|
2015-08-12 11:14:14 +00:00
|
|
|
|
let snip = snippet(cx, span, default);
|
|
|
|
|
trim_multiline(snip, true)
|
|
|
|
|
}
|
|
|
|
|
|
2018-11-27 14:11:13 +00:00
|
|
|
|
/// Same as `snippet_block`, but adapts the applicability level by the rules of
|
|
|
|
|
/// `snippet_with_applicabiliy`.
|
2019-06-12 03:07:48 +00:00
|
|
|
|
pub fn snippet_block_with_applicability<'a, T: LintContext>(
|
2018-11-27 14:11:13 +00:00
|
|
|
|
cx: &T,
|
|
|
|
|
span: Span,
|
|
|
|
|
default: &'a str,
|
|
|
|
|
applicability: &mut Applicability,
|
|
|
|
|
) -> Cow<'a, str> {
|
|
|
|
|
let snip = snippet_with_applicability(cx, span, default, applicability);
|
|
|
|
|
trim_multiline(snip, true)
|
|
|
|
|
}
|
|
|
|
|
|
2018-02-06 21:14:23 +00:00
|
|
|
|
/// Returns a new Span that covers the full last line of the given Span
|
2019-06-12 03:07:48 +00:00
|
|
|
|
pub fn last_line_of_span<T: LintContext>(cx: &T, span: Span) -> Span {
|
2018-11-22 06:53:59 +00:00
|
|
|
|
let source_map_and_line = cx.sess().source_map().lookup_line(span.lo()).unwrap();
|
|
|
|
|
let line_no = source_map_and_line.line;
|
|
|
|
|
let line_start = &source_map_and_line.sf.lines[line_no];
|
2018-02-06 21:14:23 +00:00
|
|
|
|
Span::new(*line_start, span.hi(), span.ctxt())
|
|
|
|
|
}
|
|
|
|
|
|
2018-07-12 07:30:57 +00:00
|
|
|
|
/// Like `snippet_block`, but add braces if the expr is not an `ExprKind::Block`.
|
2016-01-12 22:17:54 +00:00
|
|
|
|
/// Also takes an `Option<String>` which can be put inside the braces.
|
2019-06-12 03:07:48 +00:00
|
|
|
|
pub fn expr_block<'a, T: LintContext>(cx: &T, expr: &Expr, option: Option<String>, default: &'a str) -> Cow<'a, str> {
|
2015-08-29 09:41:06 +00:00
|
|
|
|
let code = snippet_block(cx, expr.span, default);
|
2016-01-12 22:17:54 +00:00
|
|
|
|
let string = option.unwrap_or_default();
|
2019-05-12 03:40:05 +00:00
|
|
|
|
if in_macro_or_desugar(expr.span) {
|
2018-10-27 12:45:02 +00:00
|
|
|
|
Cow::Owned(format!("{{ {} }}", snippet_with_macro_callsite(cx, expr.span, default)))
|
2018-11-20 09:33:40 +00:00
|
|
|
|
} else if let ExprKind::Block(_, _) = expr.node {
|
2015-09-27 07:39:42 +00:00
|
|
|
|
Cow::Owned(format!("{}{}", code, string))
|
|
|
|
|
} else if string.is_empty() {
|
2015-08-29 09:41:06 +00:00
|
|
|
|
Cow::Owned(format!("{{ {} }}", code))
|
2015-09-27 07:39:42 +00:00
|
|
|
|
} else {
|
|
|
|
|
Cow::Owned(format!("{{\n{};\n{}\n}}", code, string))
|
2015-08-29 09:41:06 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2017-08-09 07:30:56 +00:00
|
|
|
|
/// Trim indentation from a multiline string with possibility of ignoring the
|
|
|
|
|
/// first line.
|
2018-07-23 11:01:12 +00:00
|
|
|
|
pub fn trim_multiline(s: Cow<'_, str>, ignore_first: bool) -> Cow<'_, str> {
|
2015-08-21 15:11:34 +00:00
|
|
|
|
let s_space = trim_multiline_inner(s, ignore_first, ' ');
|
|
|
|
|
let s_tab = trim_multiline_inner(s_space, ignore_first, '\t');
|
|
|
|
|
trim_multiline_inner(s_tab, ignore_first, ' ')
|
2015-08-13 07:57:30 +00:00
|
|
|
|
}
|
|
|
|
|
|
2018-07-23 11:01:12 +00:00
|
|
|
|
fn trim_multiline_inner(s: Cow<'_, str>, ignore_first: bool, ch: char) -> Cow<'_, str> {
|
2018-11-20 09:33:40 +00:00
|
|
|
|
let x = s
|
|
|
|
|
.lines()
|
2016-12-20 17:21:30 +00:00
|
|
|
|
.skip(ignore_first as usize)
|
|
|
|
|
.filter_map(|l| {
|
|
|
|
|
if l.is_empty() {
|
|
|
|
|
None
|
|
|
|
|
} else {
|
|
|
|
|
// ignore empty lines
|
2018-11-20 09:33:40 +00:00
|
|
|
|
Some(l.char_indices().find(|&(_, x)| x != ch).unwrap_or((l.len(), ch)).0)
|
2016-12-20 17:21:30 +00:00
|
|
|
|
}
|
|
|
|
|
})
|
|
|
|
|
.min()
|
|
|
|
|
.unwrap_or(0);
|
2015-08-12 11:14:14 +00:00
|
|
|
|
if x > 0 {
|
2017-08-09 07:30:56 +00:00
|
|
|
|
Cow::Owned(
|
|
|
|
|
s.lines()
|
|
|
|
|
.enumerate()
|
2017-11-04 19:55:56 +00:00
|
|
|
|
.map(|(i, l)| {
|
|
|
|
|
if (ignore_first && i == 0) || l.is_empty() {
|
|
|
|
|
l
|
|
|
|
|
} else {
|
|
|
|
|
l.split_at(x).1
|
|
|
|
|
}
|
2017-08-09 07:30:56 +00:00
|
|
|
|
})
|
|
|
|
|
.collect::<Vec<_>>()
|
|
|
|
|
.join("\n"),
|
|
|
|
|
)
|
2015-08-12 11:14:14 +00:00
|
|
|
|
} else {
|
|
|
|
|
s
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-03-10 17:19:47 +00:00
|
|
|
|
/// Gets the parent expression, if any –- this is useful to constrain a lint.
|
2018-07-23 11:01:12 +00:00
|
|
|
|
pub fn get_parent_expr<'c>(cx: &'c LateContext<'_, '_>, e: &Expr) -> Option<&'c Expr> {
|
2018-12-08 00:56:03 +00:00
|
|
|
|
let map = &cx.tcx.hir();
|
2019-02-24 18:43:15 +00:00
|
|
|
|
let hir_id = e.hir_id;
|
2019-06-25 21:33:51 +00:00
|
|
|
|
let parent_id = map.get_parent_node(hir_id);
|
2019-02-24 18:43:15 +00:00
|
|
|
|
if hir_id == parent_id {
|
2016-01-04 04:26:12 +00:00
|
|
|
|
return None;
|
|
|
|
|
}
|
2019-06-25 21:34:07 +00:00
|
|
|
|
map.find(parent_id).and_then(|node| {
|
2018-08-28 11:13:42 +00:00
|
|
|
|
if let Node::Expr(parent) = node {
|
2017-08-09 07:30:56 +00:00
|
|
|
|
Some(parent)
|
|
|
|
|
} else {
|
|
|
|
|
None
|
2017-11-04 19:55:56 +00:00
|
|
|
|
}
|
|
|
|
|
})
|
2015-07-09 15:02:21 +00:00
|
|
|
|
}
|
2015-07-16 06:53:02 +00:00
|
|
|
|
|
2019-06-19 18:36:23 +00:00
|
|
|
|
pub fn get_enclosing_block<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, hir_id: HirId) -> Option<&'tcx Block> {
|
2018-12-08 00:56:03 +00:00
|
|
|
|
let map = &cx.tcx.hir();
|
2018-11-20 09:33:40 +00:00
|
|
|
|
let enclosing_node = map
|
2019-04-25 05:29:23 +00:00
|
|
|
|
.get_enclosing_scope(hir_id)
|
2019-06-25 21:34:07 +00:00
|
|
|
|
.and_then(|enclosing_id| map.find(enclosing_id));
|
2015-10-26 22:49:37 +00:00
|
|
|
|
if let Some(node) = enclosing_node {
|
|
|
|
|
match node {
|
2018-08-28 11:13:42 +00:00
|
|
|
|
Node::Block(block) => Some(block),
|
|
|
|
|
Node::Item(&Item {
|
2018-07-16 13:07:39 +00:00
|
|
|
|
node: ItemKind::Fn(_, _, _, eid),
|
2017-09-05 09:33:04 +00:00
|
|
|
|
..
|
2018-11-20 09:33:40 +00:00
|
|
|
|
})
|
|
|
|
|
| Node::ImplItem(&ImplItem {
|
2018-01-30 19:52:45 +00:00
|
|
|
|
node: ImplItemKind::Method(_, eid),
|
|
|
|
|
..
|
2018-12-08 00:56:03 +00:00
|
|
|
|
}) => match cx.tcx.hir().body(eid).value.node {
|
2018-07-12 07:30:57 +00:00
|
|
|
|
ExprKind::Block(ref block, _) => Some(block),
|
2017-09-05 09:33:04 +00:00
|
|
|
|
_ => None,
|
2016-12-20 17:21:30 +00:00
|
|
|
|
},
|
2016-01-04 04:26:12 +00:00
|
|
|
|
_ => None,
|
2015-10-26 22:49:37 +00:00
|
|
|
|
}
|
2016-01-04 04:26:12 +00:00
|
|
|
|
} else {
|
|
|
|
|
None
|
|
|
|
|
}
|
2015-10-26 22:49:37 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns the base type for HIR references and pointers.
|
2017-09-10 17:32:24 +00:00
|
|
|
|
pub fn walk_ptrs_hir_ty(ty: &hir::Ty) -> &hir::Ty {
|
|
|
|
|
match ty.node {
|
2018-07-12 08:03:06 +00:00
|
|
|
|
TyKind::Ptr(ref mut_ty) | TyKind::Rptr(_, ref mut_ty) => walk_ptrs_hir_ty(&mut_ty.ty),
|
2017-11-04 19:55:56 +00:00
|
|
|
|
_ => ty,
|
2017-09-10 17:32:24 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns the base type for references and raw pointers.
|
2018-07-23 11:01:12 +00:00
|
|
|
|
pub fn walk_ptrs_ty(ty: Ty<'_>) -> Ty<'_> {
|
2015-08-11 18:57:21 +00:00
|
|
|
|
match ty.sty {
|
2018-08-22 21:34:52 +00:00
|
|
|
|
ty::Ref(_, ty, _) => walk_ptrs_ty(ty),
|
2016-01-04 04:26:12 +00:00
|
|
|
|
_ => ty,
|
2015-08-11 18:57:21 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2015-08-12 05:48:00 +00:00
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns the base type for references and raw pointers, and count reference
|
2017-08-09 07:30:56 +00:00
|
|
|
|
/// depth.
|
2018-07-23 11:01:12 +00:00
|
|
|
|
pub fn walk_ptrs_ty_depth(ty: Ty<'_>) -> (Ty<'_>, usize) {
|
|
|
|
|
fn inner(ty: Ty<'_>, depth: usize) -> (Ty<'_>, usize) {
|
2015-08-25 16:38:08 +00:00
|
|
|
|
match ty.sty {
|
2018-08-22 21:34:52 +00:00
|
|
|
|
ty::Ref(_, ty, _) => inner(ty, depth + 1),
|
2016-01-04 04:26:12 +00:00
|
|
|
|
_ => (ty, depth),
|
2015-08-25 16:38:08 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
inner(ty, 0)
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Checks whether the given expression is a constant literal of the given value.
|
2017-01-04 17:05:33 +00:00
|
|
|
|
pub fn is_integer_literal(expr: &Expr, value: u128) -> bool {
|
2015-09-04 13:26:58 +00:00
|
|
|
|
// FIXME: use constant folding
|
2018-07-12 07:30:57 +00:00
|
|
|
|
if let ExprKind::Lit(ref spanned) = expr.node {
|
2016-02-12 17:35:44 +00:00
|
|
|
|
if let LitKind::Int(v, _) = spanned.node {
|
2015-09-04 13:26:58 +00:00
|
|
|
|
return v == value;
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
|
2018-12-31 11:12:50 +00:00
|
|
|
|
/// Returns `true` if the given `Expr` has been coerced before.
|
|
|
|
|
///
|
|
|
|
|
/// Examples of coercions can be found in the Nomicon at
|
|
|
|
|
/// <https://doc.rust-lang.org/nomicon/coercions.html>.
|
|
|
|
|
///
|
|
|
|
|
/// See `rustc::ty::adjustment::Adjustment` and `rustc_typeck::check::coercion` for more
|
|
|
|
|
/// information on adjustments and coercions.
|
2018-07-23 11:01:12 +00:00
|
|
|
|
pub fn is_adjusted(cx: &LateContext<'_, '_>, e: &Expr) -> bool {
|
2017-08-15 09:10:49 +00:00
|
|
|
|
cx.tables.adjustments().get(e.hir_id).is_some()
|
2015-11-04 03:11:40 +00:00
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns the pre-expansion span if is this comes from an expansion of the
|
2017-08-09 07:30:56 +00:00
|
|
|
|
/// macro `name`.
|
2016-03-15 20:02:08 +00:00
|
|
|
|
/// See also `is_direct_expn_of`.
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn is_expn_of(mut span: Span, name: &str) -> Option<Span> {
|
2016-01-28 18:29:59 +00:00
|
|
|
|
loop {
|
2019-06-01 09:25:51 +00:00
|
|
|
|
let span_name_span = span.ctxt().outer_expn_info().map(|ei| (ei.format.name(), ei.call_site));
|
2016-01-30 12:48:39 +00:00
|
|
|
|
|
2016-02-01 10:28:39 +00:00
|
|
|
|
match span_name_span {
|
2019-05-17 21:53:54 +00:00
|
|
|
|
Some((mac_name, new_span)) if mac_name.as_str() == name => return Some(new_span),
|
2016-02-01 10:28:39 +00:00
|
|
|
|
None => return None,
|
|
|
|
|
Some((_, new_span)) => span = new_span,
|
|
|
|
|
}
|
2016-01-28 18:29:59 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2016-02-15 15:59:56 +00:00
|
|
|
|
|
2019-03-10 17:19:47 +00:00
|
|
|
|
/// Returns the pre-expansion span if the span directly comes from an expansion
|
2017-08-09 07:30:56 +00:00
|
|
|
|
/// of the macro `name`.
|
2016-03-15 20:02:08 +00:00
|
|
|
|
/// The difference with `is_expn_of` is that in
|
|
|
|
|
/// ```rust,ignore
|
|
|
|
|
/// foo!(bar!(42));
|
|
|
|
|
/// ```
|
2017-08-09 07:30:56 +00:00
|
|
|
|
/// `42` is considered expanded from `foo!` and `bar!` by `is_expn_of` but only
|
|
|
|
|
/// `bar!` by
|
2016-03-15 20:02:08 +00:00
|
|
|
|
/// `is_direct_expn_of`.
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn is_direct_expn_of(span: Span, name: &str) -> Option<Span> {
|
2019-06-01 09:25:51 +00:00
|
|
|
|
let span_name_span = span.ctxt().outer_expn_info().map(|ei| (ei.format.name(), ei.call_site));
|
2016-03-15 20:02:08 +00:00
|
|
|
|
|
|
|
|
|
match span_name_span {
|
2019-05-17 21:53:54 +00:00
|
|
|
|
Some((mac_name, new_span)) if mac_name.as_str() == name => Some(new_span),
|
2016-03-15 20:02:08 +00:00
|
|
|
|
_ => None,
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2019-03-10 17:19:47 +00:00
|
|
|
|
/// Convenience function to get the return type of a function.
|
2019-02-27 09:39:33 +00:00
|
|
|
|
pub fn return_ty<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, fn_item: hir::HirId) -> Ty<'tcx> {
|
2019-07-06 03:52:51 +00:00
|
|
|
|
let fn_def_id = cx.tcx.hir().local_def_id(fn_item);
|
2017-06-29 13:38:25 +00:00
|
|
|
|
let ret_ty = cx.tcx.fn_sig(fn_def_id).output();
|
2017-05-14 07:56:10 +00:00
|
|
|
|
cx.tcx.erase_late_bound_regions(&ret_ty)
|
2016-03-01 15:25:15 +00:00
|
|
|
|
}
|
2016-03-03 18:46:10 +00:00
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Checks if two types are the same.
|
2018-05-18 20:56:25 +00:00
|
|
|
|
///
|
|
|
|
|
/// This discards any lifetime annotations, too.
|
2019-03-10 17:19:47 +00:00
|
|
|
|
//
|
|
|
|
|
// FIXME: this works correctly for lifetimes bounds (`for <'a> Foo<'a>` ==
|
|
|
|
|
// `for <'b> Foo<'b>`, but not for type parameters).
|
2017-06-11 04:46:26 +00:00
|
|
|
|
pub fn same_tys<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, a: Ty<'tcx>, b: Ty<'tcx>) -> bool {
|
2018-05-18 20:56:25 +00:00
|
|
|
|
let a = cx.tcx.erase_late_bound_regions(&Binder::bind(a));
|
|
|
|
|
let b = cx.tcx.erase_late_bound_regions(&Binder::bind(b));
|
2017-09-05 09:33:04 +00:00
|
|
|
|
cx.tcx
|
|
|
|
|
.infer_ctxt()
|
|
|
|
|
.enter(|infcx| infcx.can_eq(cx.param_env, a, b).is_ok())
|
2016-03-03 18:46:10 +00:00
|
|
|
|
}
|
2016-03-28 21:32:55 +00:00
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns `true` if the given type is an `unsafe` function.
|
2017-06-29 13:38:25 +00:00
|
|
|
|
pub fn type_is_unsafe_function<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, ty: Ty<'tcx>) -> bool {
|
2016-06-07 14:55:55 +00:00
|
|
|
|
match ty.sty {
|
2018-08-22 21:34:52 +00:00
|
|
|
|
ty::FnDef(..) | ty::FnPtr(_) => ty.fn_sig(cx.tcx).unsafety() == Unsafety::Unsafe,
|
2016-06-07 14:55:55 +00:00
|
|
|
|
_ => false,
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-07-14 17:31:17 +00:00
|
|
|
|
|
2017-06-11 02:57:25 +00:00
|
|
|
|
pub fn is_copy<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, ty: Ty<'tcx>) -> bool {
|
2019-01-03 20:54:57 +00:00
|
|
|
|
ty.is_copy_modulo_regions(cx.tcx.global_tcx(), cx.param_env, DUMMY_SP)
|
2016-07-14 17:31:17 +00:00
|
|
|
|
}
|
2016-09-16 13:45:44 +00:00
|
|
|
|
|
2019-04-22 22:31:22 +00:00
|
|
|
|
/// Checks if an expression is constructing a tuple-like enum variant or struct
|
|
|
|
|
pub fn is_ctor_function(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
|
|
|
|
|
if let ExprKind::Call(ref fun, _) = expr.node {
|
|
|
|
|
if let ExprKind::Path(ref qp) = fun.node {
|
|
|
|
|
return matches!(
|
2019-05-04 00:03:12 +00:00
|
|
|
|
cx.tables.qpath_res(qp, fun.hir_id),
|
|
|
|
|
def::Res::Def(DefKind::Variant, ..) | Res::Def(DefKind::Ctor(..), _)
|
2019-04-22 22:31:22 +00:00
|
|
|
|
);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns `true` if a pattern is refutable.
|
2018-07-23 11:01:12 +00:00
|
|
|
|
pub fn is_refutable(cx: &LateContext<'_, '_>, pat: &Pat) -> bool {
|
|
|
|
|
fn is_enum_variant(cx: &LateContext<'_, '_>, qpath: &QPath, id: HirId) -> bool {
|
2017-08-09 07:30:56 +00:00
|
|
|
|
matches!(
|
2019-05-04 00:03:12 +00:00
|
|
|
|
cx.tables.qpath_res(qpath, id),
|
|
|
|
|
def::Res::Def(DefKind::Variant, ..) | Res::Def(DefKind::Ctor(def::CtorOf::Variant, _), _)
|
2017-08-09 07:30:56 +00:00
|
|
|
|
)
|
2016-09-16 13:45:44 +00:00
|
|
|
|
}
|
|
|
|
|
|
2018-07-23 11:01:12 +00:00
|
|
|
|
fn are_refutable<'a, I: Iterator<Item = &'a Pat>>(cx: &LateContext<'_, '_>, mut i: I) -> bool {
|
2016-09-16 13:45:44 +00:00
|
|
|
|
i.any(|pat| is_refutable(cx, pat))
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
match pat.node {
|
2017-09-05 09:33:04 +00:00
|
|
|
|
PatKind::Binding(..) | PatKind::Wild => false,
|
|
|
|
|
PatKind::Box(ref pat) | PatKind::Ref(ref pat, _) => is_refutable(cx, pat),
|
|
|
|
|
PatKind::Lit(..) | PatKind::Range(..) => true,
|
2017-08-15 09:10:49 +00:00
|
|
|
|
PatKind::Path(ref qpath) => is_enum_variant(cx, qpath, pat.hir_id),
|
2016-09-16 13:45:44 +00:00
|
|
|
|
PatKind::Tuple(ref pats, _) => are_refutable(cx, pats.iter().map(|pat| &**pat)),
|
2018-11-20 09:33:40 +00:00
|
|
|
|
PatKind::Struct(ref qpath, ref fields, _) => {
|
|
|
|
|
if is_enum_variant(cx, qpath, pat.hir_id) {
|
|
|
|
|
true
|
|
|
|
|
} else {
|
|
|
|
|
are_refutable(cx, fields.iter().map(|field| &*field.node.pat))
|
|
|
|
|
}
|
2016-12-20 17:21:30 +00:00
|
|
|
|
},
|
2018-11-20 09:33:40 +00:00
|
|
|
|
PatKind::TupleStruct(ref qpath, ref pats, _) => {
|
|
|
|
|
if is_enum_variant(cx, qpath, pat.hir_id) {
|
|
|
|
|
true
|
|
|
|
|
} else {
|
|
|
|
|
are_refutable(cx, pats.iter().map(|pat| &**pat))
|
|
|
|
|
}
|
|
|
|
|
},
|
|
|
|
|
PatKind::Slice(ref head, ref middle, ref tail) => {
|
|
|
|
|
are_refutable(cx, head.iter().chain(middle).chain(tail.iter()).map(|pat| &**pat))
|
2016-12-20 17:21:30 +00:00
|
|
|
|
},
|
2016-09-16 13:45:44 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
2016-10-30 01:13:41 +00:00
|
|
|
|
|
2017-08-09 07:30:56 +00:00
|
|
|
|
/// Checks for the `#[automatically_derived]` attribute all `#[derive]`d
|
|
|
|
|
/// implementations have.
|
2016-10-30 01:13:41 +00:00
|
|
|
|
pub fn is_automatically_derived(attrs: &[ast::Attribute]) -> bool {
|
2019-05-17 21:53:54 +00:00
|
|
|
|
attr::contains_name(attrs, sym!(automatically_derived))
|
2016-10-30 01:13:41 +00:00
|
|
|
|
}
|
2016-11-17 18:44:18 +00:00
|
|
|
|
|
|
|
|
|
/// Remove blocks around an expression.
|
|
|
|
|
///
|
2017-08-09 07:30:56 +00:00
|
|
|
|
/// Ie. `x`, `{ x }` and `{{{{ x }}}}` all give `x`. `{ x; y }` and `{}` return
|
|
|
|
|
/// themselves.
|
2016-11-17 18:44:18 +00:00
|
|
|
|
pub fn remove_blocks(expr: &Expr) -> &Expr {
|
2018-07-12 07:30:57 +00:00
|
|
|
|
if let ExprKind::Block(ref block, _) = expr.node {
|
2016-11-17 18:44:18 +00:00
|
|
|
|
if block.stmts.is_empty() {
|
|
|
|
|
if let Some(ref expr) = block.expr {
|
|
|
|
|
remove_blocks(expr)
|
|
|
|
|
} else {
|
|
|
|
|
expr
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
expr
|
|
|
|
|
}
|
|
|
|
|
} else {
|
|
|
|
|
expr
|
|
|
|
|
}
|
|
|
|
|
}
|
2016-12-01 21:31:56 +00:00
|
|
|
|
|
2017-01-04 04:40:42 +00:00
|
|
|
|
pub fn is_self(slf: &Arg) -> bool {
|
2019-02-03 07:12:07 +00:00
|
|
|
|
if let PatKind::Binding(.., name, _) = slf.pat.node {
|
2019-05-23 05:19:25 +00:00
|
|
|
|
name.name == kw::SelfLower
|
2017-01-04 04:40:42 +00:00
|
|
|
|
} else {
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2017-06-11 02:57:25 +00:00
|
|
|
|
pub fn is_self_ty(slf: &hir::Ty) -> bool {
|
2017-10-23 19:18:02 +00:00
|
|
|
|
if_chain! {
|
2018-07-12 08:03:06 +00:00
|
|
|
|
if let TyKind::Path(ref qp) = slf.node;
|
2017-10-23 19:18:02 +00:00
|
|
|
|
if let QPath::Resolved(None, ref path) = *qp;
|
2019-05-04 00:03:12 +00:00
|
|
|
|
if let Res::SelfTy(..) = path.res;
|
2017-10-23 19:18:02 +00:00
|
|
|
|
then {
|
|
|
|
|
return true
|
|
|
|
|
}
|
|
|
|
|
}
|
2017-01-04 23:32:57 +00:00
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
|
2017-01-04 23:53:16 +00:00
|
|
|
|
pub fn iter_input_pats<'tcx>(decl: &FnDecl, body: &'tcx Body) -> impl Iterator<Item = &'tcx Arg> {
|
2017-01-04 21:46:41 +00:00
|
|
|
|
(0..decl.inputs.len()).map(move |i| &body.arguments[i])
|
2017-01-04 23:53:16 +00:00
|
|
|
|
}
|
2017-01-07 14:39:50 +00:00
|
|
|
|
|
2019-03-10 17:19:47 +00:00
|
|
|
|
/// Checks if a given expression is a match expression expanded from the `?`
|
|
|
|
|
/// operator or the `try` macro.
|
2019-04-14 20:19:33 +00:00
|
|
|
|
pub fn is_try(expr: &Expr) -> Option<&Expr> {
|
|
|
|
|
fn is_ok(arm: &Arm) -> bool {
|
2017-10-23 19:18:02 +00:00
|
|
|
|
if_chain! {
|
|
|
|
|
if let PatKind::TupleStruct(ref path, ref pat, None) = arm.pats[0].node;
|
|
|
|
|
if match_qpath(path, &paths::RESULT_OK[1..]);
|
2019-03-07 20:51:05 +00:00
|
|
|
|
if let PatKind::Binding(_, hir_id, _, None) = pat[0].node;
|
2018-07-12 07:30:57 +00:00
|
|
|
|
if let ExprKind::Path(QPath::Resolved(None, ref path)) = arm.body.node;
|
2019-05-04 00:03:12 +00:00
|
|
|
|
if let Res::Local(lid) = path.res;
|
2019-04-14 20:09:17 +00:00
|
|
|
|
if lid == hir_id;
|
2017-10-23 19:18:02 +00:00
|
|
|
|
then {
|
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
}
|
2017-01-07 14:39:50 +00:00
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
fn is_err(arm: &Arm) -> bool {
|
|
|
|
|
if let PatKind::TupleStruct(ref path, _, _) = arm.pats[0].node {
|
2017-08-24 22:21:46 +00:00
|
|
|
|
match_qpath(path, &paths::RESULT_ERR[1..])
|
2017-01-07 14:39:50 +00:00
|
|
|
|
} else {
|
|
|
|
|
false
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
2018-07-12 07:30:57 +00:00
|
|
|
|
if let ExprKind::Match(_, ref arms, ref source) = expr.node {
|
2017-01-07 14:39:50 +00:00
|
|
|
|
// desugared from a `?` operator
|
|
|
|
|
if let MatchSource::TryDesugar = *source {
|
|
|
|
|
return Some(expr);
|
|
|
|
|
}
|
|
|
|
|
|
2017-10-23 19:18:02 +00:00
|
|
|
|
if_chain! {
|
|
|
|
|
if arms.len() == 2;
|
|
|
|
|
if arms[0].pats.len() == 1 && arms[0].guard.is_none();
|
|
|
|
|
if arms[1].pats.len() == 1 && arms[1].guard.is_none();
|
2019-04-14 20:19:33 +00:00
|
|
|
|
if (is_ok(&arms[0]) && is_err(&arms[1])) ||
|
|
|
|
|
(is_ok(&arms[1]) && is_err(&arms[0]));
|
2017-10-23 19:18:02 +00:00
|
|
|
|
then {
|
|
|
|
|
return Some(expr);
|
|
|
|
|
}
|
|
|
|
|
}
|
2017-01-07 14:39:50 +00:00
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
None
|
|
|
|
|
}
|
2017-03-02 09:41:20 +00:00
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Returns `true` if the lint is allowed in the current context
|
2017-08-11 12:11:46 +00:00
|
|
|
|
///
|
|
|
|
|
/// Useful for skipping long running code when it's unnecessary
|
2019-02-24 18:43:15 +00:00
|
|
|
|
pub fn is_allowed(cx: &LateContext<'_, '_>, lint: &'static Lint, id: HirId) -> bool {
|
2019-02-27 09:39:33 +00:00
|
|
|
|
cx.tcx.lint_level_at_node(lint, id).0 == Level::Allow
|
2017-08-11 12:11:46 +00:00
|
|
|
|
}
|
2018-01-14 10:05:01 +00:00
|
|
|
|
|
|
|
|
|
pub fn get_arg_name(pat: &Pat) -> Option<ast::Name> {
|
|
|
|
|
match pat.node {
|
2019-02-03 07:12:07 +00:00
|
|
|
|
PatKind::Binding(.., ident, None) => Some(ident.name),
|
2018-01-14 10:05:01 +00:00
|
|
|
|
PatKind::Ref(ref subpat, _) => get_arg_name(subpat),
|
|
|
|
|
_ => None,
|
|
|
|
|
}
|
2018-01-16 21:20:55 +00:00
|
|
|
|
}
|
2018-03-13 10:38:11 +00:00
|
|
|
|
|
2019-06-14 16:47:48 +00:00
|
|
|
|
pub fn int_bits(tcx: TyCtxt<'_>, ity: ast::IntTy) -> u64 {
|
2018-11-20 09:33:40 +00:00
|
|
|
|
layout::Integer::from_attr(&tcx, attr::IntType::SignedInt(ity))
|
|
|
|
|
.size()
|
|
|
|
|
.bits()
|
2018-03-13 10:38:11 +00:00
|
|
|
|
}
|
|
|
|
|
|
2018-10-09 05:34:10 +00:00
|
|
|
|
#[allow(clippy::cast_possible_wrap)]
|
2018-03-13 10:38:11 +00:00
|
|
|
|
/// Turn a constant int byte representation into an i128
|
2019-06-14 16:47:48 +00:00
|
|
|
|
pub fn sext(tcx: TyCtxt<'_>, u: u128, ity: ast::IntTy) -> i128 {
|
2018-03-13 10:38:11 +00:00
|
|
|
|
let amt = 128 - int_bits(tcx, ity);
|
|
|
|
|
((u as i128) << amt) >> amt
|
|
|
|
|
}
|
|
|
|
|
|
2018-10-09 05:34:10 +00:00
|
|
|
|
#[allow(clippy::cast_sign_loss)]
|
2018-03-13 10:38:11 +00:00
|
|
|
|
/// clip unused bytes
|
2019-06-14 16:47:48 +00:00
|
|
|
|
pub fn unsext(tcx: TyCtxt<'_>, u: i128, ity: ast::IntTy) -> u128 {
|
2018-03-13 10:38:11 +00:00
|
|
|
|
let amt = 128 - int_bits(tcx, ity);
|
|
|
|
|
((u as u128) << amt) >> amt
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
/// clip unused bytes
|
2019-06-14 16:47:48 +00:00
|
|
|
|
pub fn clip(tcx: TyCtxt<'_>, u: u128, ity: ast::UintTy) -> u128 {
|
2018-11-20 09:33:40 +00:00
|
|
|
|
let bits = layout::Integer::from_attr(&tcx, attr::IntType::UnsignedInt(ity))
|
|
|
|
|
.size()
|
|
|
|
|
.bits();
|
2018-03-13 10:38:11 +00:00
|
|
|
|
let amt = 128 - bits;
|
|
|
|
|
(u << amt) >> amt
|
|
|
|
|
}
|
2018-03-29 19:14:53 +00:00
|
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
|
/// Removes block comments from the given `Vec` of lines.
|
2018-03-29 19:14:53 +00:00
|
|
|
|
///
|
|
|
|
|
/// # Examples
|
|
|
|
|
///
|
|
|
|
|
/// ```rust,ignore
|
|
|
|
|
/// without_block_comments(vec!["/*", "foo", "*/"]);
|
|
|
|
|
/// // => vec![]
|
|
|
|
|
///
|
|
|
|
|
/// without_block_comments(vec!["bar", "/*", "foo", "*/"]);
|
|
|
|
|
/// // => vec!["bar"]
|
|
|
|
|
/// ```
|
|
|
|
|
pub fn without_block_comments(lines: Vec<&str>) -> Vec<&str> {
|
|
|
|
|
let mut without = vec![];
|
|
|
|
|
|
2018-03-30 10:36:30 +00:00
|
|
|
|
let mut nest_level = 0;
|
2018-03-29 19:14:53 +00:00
|
|
|
|
|
2018-04-02 05:35:13 +00:00
|
|
|
|
for line in lines {
|
2018-03-29 19:14:53 +00:00
|
|
|
|
if line.contains("/*") {
|
2018-03-30 10:36:30 +00:00
|
|
|
|
nest_level += 1;
|
2018-03-29 19:14:53 +00:00
|
|
|
|
continue;
|
|
|
|
|
} else if line.contains("*/") {
|
2018-03-30 10:36:30 +00:00
|
|
|
|
nest_level -= 1;
|
2018-03-29 19:14:53 +00:00
|
|
|
|
continue;
|
|
|
|
|
}
|
|
|
|
|
|
2018-03-30 10:36:30 +00:00
|
|
|
|
if nest_level == 0 {
|
2018-03-29 19:14:53 +00:00
|
|
|
|
without.push(line);
|
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
without
|
|
|
|
|
}
|
2018-06-17 21:58:08 +00:00
|
|
|
|
|
2019-06-14 16:47:48 +00:00
|
|
|
|
pub fn any_parent_is_automatically_derived(tcx: TyCtxt<'_>, node: HirId) -> bool {
|
2018-12-08 00:56:03 +00:00
|
|
|
|
let map = &tcx.hir();
|
2018-06-17 21:58:08 +00:00
|
|
|
|
let mut prev_enclosing_node = None;
|
|
|
|
|
let mut enclosing_node = node;
|
|
|
|
|
while Some(enclosing_node) != prev_enclosing_node {
|
2019-06-18 09:15:47 +00:00
|
|
|
|
if is_automatically_derived(map.attrs(enclosing_node)) {
|
2018-06-17 21:58:08 +00:00
|
|
|
|
return true;
|
|
|
|
|
}
|
|
|
|
|
prev_enclosing_node = Some(enclosing_node);
|
2019-02-24 18:43:15 +00:00
|
|
|
|
enclosing_node = map.get_parent_item(enclosing_node);
|
2018-06-17 21:58:08 +00:00
|
|
|
|
}
|
|
|
|
|
false
|
|
|
|
|
}
|
2018-08-29 02:32:20 +00:00
|
|
|
|
|
2019-02-20 08:10:25 +00:00
|
|
|
|
/// Returns true if ty has `iter` or `iter_mut` methods
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn has_iter_method(cx: &LateContext<'_, '_>, probably_ref_ty: Ty<'_>) -> Option<&'static str> {
|
2019-02-20 08:10:25 +00:00
|
|
|
|
// FIXME: instead of this hard-coded list, we should check if `<adt>::iter`
|
|
|
|
|
// exists and has the desired signature. Unfortunately FnCtxt is not exported
|
|
|
|
|
// so we can't use its `lookup_method` method.
|
2019-05-17 21:53:54 +00:00
|
|
|
|
let into_iter_collections: [&[&str]; 13] = [
|
|
|
|
|
&paths::VEC,
|
|
|
|
|
&paths::OPTION,
|
|
|
|
|
&paths::RESULT,
|
|
|
|
|
&paths::BTREESET,
|
|
|
|
|
&paths::BTREEMAP,
|
|
|
|
|
&paths::VEC_DEQUE,
|
|
|
|
|
&paths::LINKED_LIST,
|
|
|
|
|
&paths::BINARY_HEAP,
|
|
|
|
|
&paths::HASHSET,
|
|
|
|
|
&paths::HASHMAP,
|
|
|
|
|
&paths::PATH_BUF,
|
|
|
|
|
&paths::PATH,
|
|
|
|
|
&paths::RECEIVER,
|
2019-02-20 08:10:25 +00:00
|
|
|
|
];
|
|
|
|
|
|
|
|
|
|
let ty_to_check = match probably_ref_ty.sty {
|
|
|
|
|
ty::Ref(_, ty_to_check, _) => ty_to_check,
|
|
|
|
|
_ => probably_ref_ty,
|
|
|
|
|
};
|
|
|
|
|
|
|
|
|
|
let def_id = match ty_to_check.sty {
|
2019-05-17 21:53:54 +00:00
|
|
|
|
ty::Array(..) => return Some("array"),
|
|
|
|
|
ty::Slice(..) => return Some("slice"),
|
2019-02-20 08:10:25 +00:00
|
|
|
|
ty::Adt(adt, _) => adt.did,
|
|
|
|
|
_ => return None,
|
|
|
|
|
};
|
|
|
|
|
|
2019-05-14 08:03:16 +00:00
|
|
|
|
for path in &into_iter_collections {
|
2019-05-13 23:34:08 +00:00
|
|
|
|
if match_def_path(cx, def_id, path) {
|
|
|
|
|
return Some(*path.last().unwrap());
|
2019-02-20 08:10:25 +00:00
|
|
|
|
}
|
|
|
|
|
}
|
|
|
|
|
None
|
|
|
|
|
}
|
|
|
|
|
|
2018-08-29 02:32:20 +00:00
|
|
|
|
#[cfg(test)]
|
|
|
|
|
mod test {
|
|
|
|
|
use super::{trim_multiline, without_block_comments};
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn test_trim_multiline_single_line() {
|
|
|
|
|
assert_eq!("", trim_multiline("".into(), false));
|
|
|
|
|
assert_eq!("...", trim_multiline("...".into(), false));
|
|
|
|
|
assert_eq!("...", trim_multiline(" ...".into(), false));
|
|
|
|
|
assert_eq!("...", trim_multiline("\t...".into(), false));
|
|
|
|
|
assert_eq!("...", trim_multiline("\t\t...".into(), false));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
#[rustfmt::skip]
|
|
|
|
|
fn test_trim_multiline_block() {
|
|
|
|
|
assert_eq!("\
|
|
|
|
|
if x {
|
|
|
|
|
y
|
|
|
|
|
} else {
|
|
|
|
|
z
|
|
|
|
|
}", trim_multiline(" if x {
|
|
|
|
|
y
|
|
|
|
|
} else {
|
|
|
|
|
z
|
|
|
|
|
}".into(), false));
|
|
|
|
|
assert_eq!("\
|
|
|
|
|
if x {
|
|
|
|
|
\ty
|
|
|
|
|
} else {
|
|
|
|
|
\tz
|
|
|
|
|
}", trim_multiline(" if x {
|
|
|
|
|
\ty
|
|
|
|
|
} else {
|
|
|
|
|
\tz
|
|
|
|
|
}".into(), false));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
#[rustfmt::skip]
|
|
|
|
|
fn test_trim_multiline_empty_line() {
|
|
|
|
|
assert_eq!("\
|
|
|
|
|
if x {
|
|
|
|
|
y
|
|
|
|
|
|
|
|
|
|
} else {
|
|
|
|
|
z
|
|
|
|
|
}", trim_multiline(" if x {
|
|
|
|
|
y
|
|
|
|
|
|
|
|
|
|
} else {
|
|
|
|
|
z
|
|
|
|
|
}".into(), false));
|
|
|
|
|
}
|
|
|
|
|
|
|
|
|
|
#[test]
|
|
|
|
|
fn test_without_block_comments_lines_without_block_comments() {
|
|
|
|
|
let result = without_block_comments(vec!["/*", "", "*/"]);
|
|
|
|
|
println!("result: {:?}", result);
|
|
|
|
|
assert!(result.is_empty());
|
|
|
|
|
|
|
|
|
|
let result = without_block_comments(vec!["", "/*", "", "*/", "#[crate_type = \"lib\"]", "/*", "", "*/", ""]);
|
|
|
|
|
assert_eq!(result, vec!["", "#[crate_type = \"lib\"]", ""]);
|
|
|
|
|
|
|
|
|
|
let result = without_block_comments(vec!["/* rust", "", "*/"]);
|
|
|
|
|
assert!(result.is_empty());
|
|
|
|
|
|
|
|
|
|
let result = without_block_comments(vec!["/* one-line comment */"]);
|
|
|
|
|
assert!(result.is_empty());
|
|
|
|
|
|
|
|
|
|
let result = without_block_comments(vec!["/* nested", "/* multi-line", "comment", "*/", "test", "*/"]);
|
|
|
|
|
assert!(result.is_empty());
|
|
|
|
|
|
|
|
|
|
let result = without_block_comments(vec!["/* nested /* inline /* comment */ test */ */"]);
|
|
|
|
|
assert!(result.is_empty());
|
|
|
|
|
|
|
|
|
|
let result = without_block_comments(vec!["foo", "bar", "baz"]);
|
|
|
|
|
assert_eq!(result, vec!["foo", "bar", "baz"]);
|
|
|
|
|
}
|
2018-09-05 22:45:57 +00:00
|
|
|
|
}
|
2019-05-13 23:34:08 +00:00
|
|
|
|
|
2019-05-17 21:53:54 +00:00
|
|
|
|
pub fn match_def_path<'a, 'tcx>(cx: &LateContext<'a, 'tcx>, did: DefId, syms: &[&str]) -> bool {
|
2019-05-27 19:58:54 +00:00
|
|
|
|
// HACK: find a way to use symbols from clippy or just go fully to diagnostic items
|
|
|
|
|
let syms: Vec<_> = syms.iter().map(|sym| Symbol::intern(sym)).collect();
|
2019-05-13 23:34:08 +00:00
|
|
|
|
cx.match_def_path(did, &syms)
|
|
|
|
|
}
|