2018-11-27 20:14:15 +00:00
|
|
|
use if_chain::if_chain;
|
2018-12-29 15:04:45 +00:00
|
|
|
use rustc::hir::*;
|
|
|
|
use rustc::lint::{LateContext, LateLintPass, LintArray, LintPass};
|
2019-04-08 20:43:55 +00:00
|
|
|
use rustc::{declare_lint_pass, declare_tool_lint};
|
2018-12-29 15:04:45 +00:00
|
|
|
use rustc_errors::Applicability;
|
|
|
|
use syntax::ast::RangeLimits;
|
|
|
|
use syntax::source_map::Spanned;
|
2015-08-15 16:55:25 +00:00
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
use crate::utils::sugg::Sugg;
|
|
|
|
use crate::utils::{get_trait_def_id, higher, implements_trait, SpanlessEq};
|
|
|
|
use crate::utils::{is_integer_literal, paths, snippet, snippet_opt, span_lint, span_lint_and_then};
|
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 16:50:33 +00:00
|
|
|
/// **What it does:** Checks for calling `.step_by(0)` on iterators,
|
|
|
|
/// which never terminates.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** This very much looks like an oversight, since with
|
|
|
|
/// `loop { .. }` there is an obvious better way to endlessly loop.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
2019-03-05 22:23:50 +00:00
|
|
|
/// ```ignore
|
2019-03-05 16:50:33 +00:00
|
|
|
/// for x in (5..5).step_by(0) {
|
|
|
|
/// ..
|
|
|
|
/// }
|
|
|
|
/// ```
|
2017-06-18 13:14:46 +00:00
|
|
|
pub ITERATOR_STEP_BY_ZERO,
|
2018-03-28 13:24:26 +00:00
|
|
|
correctness,
|
2017-06-18 13:14:46 +00:00
|
|
|
"using `Iterator::step_by(0)`, which produces an infinite iterator"
|
2015-08-15 16:55:25 +00:00
|
|
|
}
|
2017-06-18 13:14:46 +00:00
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 16:50:33 +00:00
|
|
|
/// **What it does:** Checks for zipping a collection with the range of
|
|
|
|
/// `0.._.len()`.
|
|
|
|
///
|
|
|
|
/// **Why is this bad?** The code is better expressed with `.enumerate()`.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// x.iter().zip(0..x.len())
|
|
|
|
/// ```
|
2016-08-06 08:18:36 +00:00
|
|
|
pub RANGE_ZIP_WITH_LEN,
|
2018-03-28 13:24:26 +00:00
|
|
|
complexity,
|
2016-08-06 08:18:36 +00:00
|
|
|
"zipping iterator with a range when `enumerate()` would do"
|
2015-11-03 14:42:52 +00:00
|
|
|
}
|
2015-08-15 16:55:25 +00:00
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 16:50:33 +00:00
|
|
|
/// **What it does:** Checks for exclusive ranges where 1 is added to the
|
2019-01-31 01:15:29 +00:00
|
|
|
/// upper bound, e.g., `x..(y+1)`.
|
2019-03-05 16:50:33 +00:00
|
|
|
///
|
|
|
|
/// **Why is this bad?** The code is more readable with an inclusive range
|
|
|
|
/// like `x..=y`.
|
|
|
|
///
|
|
|
|
/// **Known problems:** Will add unnecessary pair of parentheses when the
|
|
|
|
/// expression is not wrapped in a pair but starts with a opening parenthesis
|
|
|
|
/// and ends with a closing one.
|
2019-01-31 01:15:29 +00:00
|
|
|
/// I.e., `let _ = (f()+1)..(f()+1)` results in `let _ = ((f()+1)..=f())`.
|
2019-03-05 16:50:33 +00:00
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// for x..(y+1) { .. }
|
|
|
|
/// ```
|
2017-10-07 14:56:45 +00:00
|
|
|
pub RANGE_PLUS_ONE,
|
2018-08-26 08:57:04 +00:00
|
|
|
complexity,
|
2017-10-07 14:56:45 +00:00
|
|
|
"`x..(y+1)` reads better as `x..=y`"
|
|
|
|
}
|
|
|
|
|
2018-03-28 13:24:26 +00:00
|
|
|
declare_clippy_lint! {
|
2019-03-05 16:50:33 +00:00
|
|
|
/// **What it does:** Checks for inclusive ranges where 1 is subtracted from
|
2019-01-31 01:15:29 +00:00
|
|
|
/// the upper bound, e.g., `x..=(y-1)`.
|
2019-03-05 16:50:33 +00:00
|
|
|
///
|
|
|
|
/// **Why is this bad?** The code is more readable with an exclusive range
|
|
|
|
/// like `x..y`.
|
|
|
|
///
|
|
|
|
/// **Known problems:** None.
|
|
|
|
///
|
|
|
|
/// **Example:**
|
|
|
|
/// ```rust
|
|
|
|
/// for x..=(y-1) { .. }
|
|
|
|
/// ```
|
2017-10-07 14:56:45 +00:00
|
|
|
pub RANGE_MINUS_ONE,
|
2018-08-26 08:57:04 +00:00
|
|
|
complexity,
|
2017-10-07 14:56:45 +00:00
|
|
|
"`x..=(y-1)` reads better as `x..y`"
|
|
|
|
}
|
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
declare_lint_pass!(Ranges => [
|
|
|
|
ITERATOR_STEP_BY_ZERO,
|
|
|
|
RANGE_ZIP_WITH_LEN,
|
|
|
|
RANGE_PLUS_ONE,
|
|
|
|
RANGE_MINUS_ONE
|
|
|
|
]);
|
2015-08-15 16:55:25 +00:00
|
|
|
|
2019-04-08 20:43:55 +00:00
|
|
|
impl<'a, 'tcx> LateLintPass<'a, 'tcx> for Ranges {
|
2016-12-07 12:13:40 +00:00
|
|
|
fn check_expr(&mut self, cx: &LateContext<'a, 'tcx>, expr: &'tcx Expr) {
|
2018-07-12 07:30:57 +00:00
|
|
|
if let ExprKind::MethodCall(ref path, _, ref args) = expr.node {
|
2018-06-28 13:46:58 +00:00
|
|
|
let name = path.ident.as_str();
|
2016-11-23 20:19:03 +00:00
|
|
|
|
2015-11-03 14:42:52 +00:00
|
|
|
// Range with step_by(0).
|
2017-06-18 13:14:46 +00:00
|
|
|
if name == "step_by" && args.len() == 2 && has_step_by(cx, &args[0]) {
|
2018-05-30 08:15:50 +00:00
|
|
|
use crate::consts::{constant, Constant};
|
2018-05-13 11:16:31 +00:00
|
|
|
if let Some((Constant::Int(0), _)) = constant(cx, cx.tables, &args[1]) {
|
2018-03-13 10:38:11 +00:00
|
|
|
span_lint(
|
|
|
|
cx,
|
|
|
|
ITERATOR_STEP_BY_ZERO,
|
|
|
|
expr.span,
|
|
|
|
"Iterator::step_by(0) will panic at runtime",
|
|
|
|
);
|
2017-06-18 13:14:46 +00:00
|
|
|
}
|
2016-11-23 20:19:03 +00:00
|
|
|
} else if name == "zip" && args.len() == 2 {
|
2015-11-03 14:42:52 +00:00
|
|
|
let iter = &args[0].node;
|
2016-03-07 15:31:38 +00:00
|
|
|
let zip_arg = &args[1];
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
2019-01-31 01:15:29 +00:00
|
|
|
// `.iter()` call
|
2018-07-12 07:30:57 +00:00
|
|
|
if let ExprKind::MethodCall(ref iter_path, _, ref iter_args ) = *iter;
|
2019-05-17 21:53:54 +00:00
|
|
|
if iter_path.ident.name == sym!(iter);
|
2019-01-31 01:15:29 +00:00
|
|
|
// range expression in `.zip()` call: `0..x.len()`
|
2018-05-08 15:16:01 +00:00
|
|
|
if let Some(higher::Range { start: Some(start), end: Some(end), .. }) = higher::range(cx, zip_arg);
|
2017-10-23 19:18:02 +00:00
|
|
|
if is_integer_literal(start, 0);
|
2019-01-31 01:15:29 +00:00
|
|
|
// `.len()` call
|
2018-07-12 07:30:57 +00:00
|
|
|
if let ExprKind::MethodCall(ref len_path, _, ref len_args) = end.node;
|
2019-05-17 21:53:54 +00:00
|
|
|
if len_path.ident.name == sym!(len) && len_args.len() == 1;
|
2019-01-31 01:15:29 +00:00
|
|
|
// `.iter()` and `.len()` called on same `Path`
|
2018-07-12 07:30:57 +00:00
|
|
|
if let ExprKind::Path(QPath::Resolved(_, ref iter_path)) = iter_args[0].node;
|
|
|
|
if let ExprKind::Path(QPath::Resolved(_, ref len_path)) = len_args[0].node;
|
2018-07-14 22:00:27 +00:00
|
|
|
if SpanlessEq::new(cx).eq_path_segments(&iter_path.segments, &len_path.segments);
|
2017-10-23 19:18:02 +00:00
|
|
|
then {
|
|
|
|
span_lint(cx,
|
|
|
|
RANGE_ZIP_WITH_LEN,
|
|
|
|
expr.span,
|
|
|
|
&format!("It is more idiomatic to use {}.iter().enumerate()",
|
|
|
|
snippet(cx, iter_args[0].span, "_")));
|
|
|
|
}
|
|
|
|
}
|
2015-11-03 14:42:52 +00:00
|
|
|
}
|
2015-08-15 16:55:25 +00:00
|
|
|
}
|
2017-10-07 14:56:45 +00:00
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
// exclusive range plus one: `x..(y+1)`
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
2018-11-27 20:14:15 +00:00
|
|
|
if let Some(higher::Range {
|
|
|
|
start,
|
|
|
|
end: Some(end),
|
|
|
|
limits: RangeLimits::HalfOpen
|
|
|
|
}) = higher::range(cx, expr);
|
2017-10-23 19:18:02 +00:00
|
|
|
if let Some(y) = y_plus_one(end);
|
|
|
|
then {
|
2019-03-26 09:55:03 +00:00
|
|
|
let span = expr.span
|
|
|
|
.ctxt()
|
2019-06-01 09:25:51 +00:00
|
|
|
.outer_expn_info()
|
2019-03-26 16:57:03 +00:00
|
|
|
.map_or(expr.span, |info| info.call_site);
|
2017-10-23 19:18:02 +00:00
|
|
|
span_lint_and_then(
|
|
|
|
cx,
|
|
|
|
RANGE_PLUS_ONE,
|
2019-03-26 09:55:03 +00:00
|
|
|
span,
|
2017-10-23 19:18:02 +00:00
|
|
|
"an inclusive range would be more readable",
|
|
|
|
|db| {
|
2018-08-21 10:46:18 +00:00
|
|
|
let start = start.map_or(String::new(), |x| Sugg::hir(cx, x, "x").to_string());
|
2017-10-23 19:18:02 +00:00
|
|
|
let end = Sugg::hir(cx, y, "y");
|
2019-03-26 09:55:03 +00:00
|
|
|
if let Some(is_wrapped) = &snippet_opt(cx, span) {
|
2018-09-04 15:56:48 +00:00
|
|
|
if is_wrapped.starts_with('(') && is_wrapped.ends_with(')') {
|
2019-01-27 12:33:56 +00:00
|
|
|
db.span_suggestion(
|
2019-03-26 09:55:03 +00:00
|
|
|
span,
|
2018-09-18 15:07:54 +00:00
|
|
|
"use",
|
|
|
|
format!("({}..={})", start, end),
|
2018-09-18 17:01:17 +00:00
|
|
|
Applicability::MaybeIncorrect,
|
2018-09-18 15:07:54 +00:00
|
|
|
);
|
2018-08-30 17:06:13 +00:00
|
|
|
} else {
|
2019-01-27 12:33:56 +00:00
|
|
|
db.span_suggestion(
|
2019-03-26 09:55:03 +00:00
|
|
|
span,
|
2018-09-18 15:07:54 +00:00
|
|
|
"use",
|
|
|
|
format!("{}..={}", start, end),
|
2018-09-18 17:01:17 +00:00
|
|
|
Applicability::MachineApplicable, // snippet
|
2018-09-18 15:07:54 +00:00
|
|
|
);
|
2018-08-30 17:06:13 +00:00
|
|
|
}
|
|
|
|
}
|
2017-10-23 19:18:02 +00:00
|
|
|
},
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
2017-10-07 14:56:45 +00:00
|
|
|
|
2019-01-31 01:15:29 +00:00
|
|
|
// inclusive range minus one: `x..=(y-1)`
|
2017-10-23 19:18:02 +00:00
|
|
|
if_chain! {
|
2018-05-08 15:16:01 +00:00
|
|
|
if let Some(higher::Range { start, end: Some(end), limits: RangeLimits::Closed }) = higher::range(cx, expr);
|
2017-10-23 19:18:02 +00:00
|
|
|
if let Some(y) = y_minus_one(end);
|
|
|
|
then {
|
|
|
|
span_lint_and_then(
|
|
|
|
cx,
|
|
|
|
RANGE_MINUS_ONE,
|
|
|
|
expr.span,
|
|
|
|
"an exclusive range would be more readable",
|
|
|
|
|db| {
|
2018-08-21 10:46:18 +00:00
|
|
|
let start = start.map_or(String::new(), |x| Sugg::hir(cx, x, "x").to_string());
|
2017-10-23 19:18:02 +00:00
|
|
|
let end = Sugg::hir(cx, y, "y");
|
2019-01-27 12:33:56 +00:00
|
|
|
db.span_suggestion(
|
2018-09-18 15:07:54 +00:00
|
|
|
expr.span,
|
|
|
|
"use",
|
|
|
|
format!("{}..{}", start, end),
|
2018-09-18 17:01:17 +00:00
|
|
|
Applicability::MachineApplicable, // snippet
|
2018-09-18 15:07:54 +00:00
|
|
|
);
|
2017-10-23 19:18:02 +00:00
|
|
|
},
|
|
|
|
);
|
|
|
|
}
|
|
|
|
}
|
2015-08-15 16:55:25 +00:00
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2018-07-23 11:01:12 +00:00
|
|
|
fn has_step_by(cx: &LateContext<'_, '_>, expr: &Expr) -> bool {
|
2019-01-31 01:15:29 +00:00
|
|
|
// No need for `walk_ptrs_ty` here because `step_by` moves `self`, so it
|
2015-08-15 16:55:25 +00:00
|
|
|
// can't be called on a borrowed range.
|
2017-06-18 13:14:46 +00:00
|
|
|
let ty = cx.tables.expr_ty_adjusted(expr);
|
2016-04-26 11:31:52 +00:00
|
|
|
|
2019-05-17 22:58:25 +00:00
|
|
|
get_trait_def_id(cx, &paths::ITERATOR).map_or(false, |iterator_trait| implements_trait(cx, ty, iterator_trait, &[]))
|
2015-08-15 16:55:25 +00:00
|
|
|
}
|
2017-10-07 14:56:45 +00:00
|
|
|
|
|
|
|
fn y_plus_one(expr: &Expr) -> Option<&Expr> {
|
|
|
|
match expr.node {
|
2018-11-27 20:14:15 +00:00
|
|
|
ExprKind::Binary(
|
|
|
|
Spanned {
|
|
|
|
node: BinOpKind::Add, ..
|
|
|
|
},
|
|
|
|
ref lhs,
|
|
|
|
ref rhs,
|
|
|
|
) => {
|
|
|
|
if is_integer_literal(lhs, 1) {
|
|
|
|
Some(rhs)
|
|
|
|
} else if is_integer_literal(rhs, 1) {
|
|
|
|
Some(lhs)
|
|
|
|
} else {
|
|
|
|
None
|
|
|
|
}
|
2017-10-07 14:56:45 +00:00
|
|
|
},
|
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
fn y_minus_one(expr: &Expr) -> Option<&Expr> {
|
|
|
|
match expr.node {
|
2018-11-27 20:14:15 +00:00
|
|
|
ExprKind::Binary(
|
|
|
|
Spanned {
|
|
|
|
node: BinOpKind::Sub, ..
|
|
|
|
},
|
|
|
|
ref lhs,
|
|
|
|
ref rhs,
|
|
|
|
) if is_integer_literal(rhs, 1) => Some(lhs),
|
2017-10-07 14:56:45 +00:00
|
|
|
_ => None,
|
|
|
|
}
|
|
|
|
}
|