Veetaha
be244ab2fb
docs: minor fixes in wordings and punctuation
2020-02-09 15:54:54 +02:00
Veetaha
6a367886ec
vscode: updated docs on prebuilt binaries
2020-02-09 15:51:28 +02:00
Veetaha
7cba77ed4e
vscode: added logging when donloading binaries
2020-02-09 15:01:00 +02:00
Veetaha
f3240e22c6
vscode: move throtting of download progress to call site
2020-02-09 14:18:05 +02:00
Veetaha
a63659badb
vscode: replaced unwrapNotNil() with ! as per @matklad
2020-02-09 13:59:27 +02:00
Veetaha
7a09274e52
vscode: refactor inverted ternaries to if statements as per @matklad
2020-02-09 13:45:06 +02:00
Veetaha
34241b9af9
vscode: remove noise data fields declarations as per @matklad
2020-02-09 13:39:54 +02:00
Veetaha
3159e87c49
vscode: refactor levels of code nesting and string literals quotes
2020-02-09 13:36:36 +02:00
Veetaha
a3e3fba7bf
vscode: fix chmod to octal literal
...
Co-Authored-By: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-09 12:54:51 +02:00
Veetaha
d08ae7e82f
vscode: minor names and message contents changes
2020-02-09 00:58:53 +02:00
Veetaha
fd6a98ef6e
vscode: rename raLspServer variable to langServer
2020-02-09 00:42:51 +02:00
Veetaha
8f291c0089
vscode: refactor comment
2020-02-09 00:28:32 +02:00
Veetaha
539daf4454
vscode: refactor platform artifact name query to switch statement, move BinarySource union variants into a namespace
2020-02-09 00:27:04 +02:00
Veetaha
bdd88c2fad
vscode: reduce throttle latency of downloadFile() progress callback for smoother UX
2020-02-08 21:25:03 +02:00
Veetaha
9791b6a8de
vscode: add name to the second unused argument of withProgress() callback
2020-02-08 21:24:29 +02:00
Veetaha
4e85254444
vscode: add docs to installation module interfaces and sanity check to donloadFile()
2020-02-08 21:03:27 +02:00
Veetaha
6ef912f925
vscode: converted fetchLatestArtifactMetadata params to positional, added docs
2020-02-08 20:18:33 +02:00
Veetaha
f7ef72db64
vscode: changed chmod value to 755 as per @lnicola
2020-02-08 20:07:00 +02:00
Veetaha
5d88c1db38
vscode: amended config to use binary from globalStoragePath, added ui for downloading
2020-02-08 04:34:11 +02:00
Veetaha
3e0e4e90ae
added fetchLatestArtifactMetadata() and downloadFile() functions
2020-02-08 04:34:11 +02:00
Veetaha
1bdb78a89f
vscode: add FIXME about language client shared resource protection
2020-02-08 04:34:11 +02:00
bors[bot]
5397f05bfe
Merge #3049
...
3049: Introduce assists utils r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-07 16:28:33 +00:00
Aleksey Kladov
d00add1f1f
Introduce assists utils
2020-02-07 17:28:02 +01:00
Aleksey Kladov
561b4b11ff
Name assist handlers
2020-02-07 17:28:02 +01:00
Aleksey Kladov
aa64a84b49
Cleanups
2020-02-07 15:12:51 +01:00
Aleksey Kladov
ce44547cfb
Cleanup imports
2020-02-07 15:10:19 +01:00
Aleksey Kladov
6ac9c4ad6a
Cleanup
2020-02-07 15:04:50 +01:00
Aleksey Kladov
2d95047f7c
Cleanup
2020-02-07 14:55:47 +01:00
Aleksey Kladov
b831b17b3d
Simplify
2020-02-07 14:53:50 +01:00
bors[bot]
1996762b1f
Merge #3048
...
3048: Remove irrelevant distinction r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-07 13:35:02 +00:00
Aleksey Kladov
ae70d07237
Rename
2020-02-07 14:26:59 +01:00
Aleksey Kladov
f55be75a17
Remove irrelevant distinction
2020-02-07 14:25:16 +01:00
bors[bot]
8337dcd9e2
Merge #3047
...
3047: Update async unsafe fn ordering in parser r=matklad a=kiljacken
As of rust-lang/rust#61319 the correct order for functions that are both unsafe and async is: `async unsafe fn` and not `unsafe async fn`.
This commit updates the parser tests to reflect this, and corrects parsing behavior to accept the correct ordering.
Fixes #3025
Co-authored-by: Emil Lauridsen <mine809@gmail.com>
2020-02-07 13:21:02 +00:00
bors[bot]
6d6a995e09
Merge #3040
...
3040: Rework value parameter parsing r=matklad a=tobz1000
Fixes #2847 .
- `Fn__(...)` parameters with idents/patterns no longer parse
- Trait function parameters with arbitrary patterns parse
- Trait function parameters without idents/patterns no longer parse
- `fn(...)` parameters no longer parse with patterns other than a single ident
__Question__: The pre-existing test `param_list_opt_patterns` has been kept as-is, although the name no longer makes sense (it's testing `Fn__(...)` params, which aren't allowed patterns any more). What would be best to do about this?
Co-authored-by: Toby Dimmick <tobydimmick@pm.me>
2020-02-07 13:13:36 +00:00
Emil Lauridsen
73ec2ab184
Update async unsafe fn ordering.
...
As of rust-lang/rust#61319 the correct order for functions that are both
unsafe and async is: `async unsafe fn` and not `unsafe async fn`.
This commit updates the parser tests to reflect this, and corrects
parsing behavior to accept the correct ordering.
Fixes #3025
2020-02-07 13:51:51 +01:00
Toby Dimmick
90ff2be4e8
PR tweaks
2020-02-07 12:36:33 +00:00
bors[bot]
4d0d113c7d
Merge #3044
...
3044: Don't crash when recieving unkown file for cargo diagnostic. r=matklad a=kiljacken
Fixes #3014
Co-authored-by: Emil Lauridsen <mine809@gmail.com>
2020-02-07 11:41:25 +00:00
Emil Lauridsen
137a878461
to_string_lossy() -> display()
2020-02-07 12:35:36 +01:00
bors[bot]
1479dd6f2d
Merge #3045
...
3045: Cleanup early return assist r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-07 11:34:31 +00:00
Aleksey Kladov
36ee9ecb67
Cleanup early return assist
2020-02-07 12:30:39 +01:00
Emil Lauridsen
5db7c8642b
Don't crash when recieving unkown file for cargo diagnostic.
2020-02-07 12:30:29 +01:00
Aleksey Kladov
aa1234e02b
Generalize invert_if to just always work
2020-02-07 12:14:33 +01:00
bors[bot]
5aba5a756a
Merge #3042
...
3042: A tiny bit more consistent API r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-06 23:00:07 +00:00
Aleksey Kladov
56e3fbe588
A tiny bit more consistent API
2020-02-06 23:59:27 +01:00
Toby Dimmick
0183952d2e
Closure params test
2020-02-06 20:39:27 +00:00
Toby Dimmick
e1921ea59c
rustfmt
2020-02-06 20:04:35 +00:00
Toby Dimmick
7e66785859
Rework value parameter parsing
...
- `Fn__(...)` parameters with idents/patterns no longer parse
- Trait function parameters with arbitrary patterns parse
- Trait function parameters without idents/patterns no longer parse
- `fn(...)` parameters no longer parse with patterns other than a single ident
2020-02-06 19:45:51 +00:00
bors[bot]
a4431e8302
Merge #3038
...
3038: Minor rename r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-06 17:50:11 +00:00
Aleksey Kladov
7e73b7a5f8
Minor rename
2020-02-06 18:47:26 +01:00
bors[bot]
918115c32e
Merge #3036
...
3036: Remove the leftovers after ImportLocator removal r=matklad a=SomeoneToIgnore
Follow the FIXME's suggestion (https://github.com/rust-analyzer/rust-analyzer/pull/3034/files#diff-001b3b1412c33fee802c22b0f848dcd7L237 ) and remove the `ModuleDefId` reexport.
Also rename `ImportsLocatorIde` into plain `ImportsLocator`
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-02-06 17:30:57 +00:00