bors
b7972e5102
Auto merge of #16533 - Nadrieril:update-pat-ana, r=HKalbasi
...
Update to latest `rustc_pattern_analysis`
Here I go again. Two improvements this time.
1. I've removed the need for an arena for patterns. Turns out this wasn't gaining any performance on the rustc side so may as well allocate normally.
2. I've added a clean error path when types don't match, so rustc_pattern_analysis should never panic except internal logic errors. For now `cx.bug()` calls `never!()` but I'm not sure what `never!()` does. Does it display anything to the user? Otherwise a `debug!()` should be sufficient.
Point 2 should fix https://github.com/rust-lang/rust-analyzer/issues/15883 but I haven't tested it because I'm not sure how to reproduce. Could someone give me pointers as to how to write a test for the pattern code?
2024-02-12 07:36:51 +00:00
Nadrieril
43caf8323a
Prefer debug! to never! and add regression test
2024-02-11 23:46:05 +01:00
Nadrieril
b04e0df1ce
pattern_analysis doesn't need an arena anymore
2024-02-11 22:30:14 +01:00
Nadrieril
3356ebd255
Update to latest rustc_pattern_analysis
2024-02-11 22:30:14 +01:00
bors
c06ca6cff5
Auto merge of #16532 - lnicola:sync-from-rust, r=lnicola
...
internal: sync from downstream
2024-02-11 18:05:10 +00:00
Laurențiu Nicola
10d6a67755
Merge branch 'master' into sync-from-rust
2024-02-11 20:02:48 +02:00
Laurențiu Nicola
e41ab350d6
Merge commit 'ddf105b646c6749a2de2451c9a499a354eec79c2' into sync-from-ra
2024-02-11 08:40:19 +02:00
bors
ddf105b646
Auto merge of #16527 - Veykril:salsa-no-self-ref, r=Veykril
...
internal: Remove SELF_REF hack for self referential SyntaxContexts
This should reduce the amount of SyntaxContexts we allocate
2024-02-10 18:58:43 +00:00
Lukas Wirth
5136705fad
internal: Remove SELF_REF hack for self referential SyntaxContexts
2024-02-10 16:20:02 +01:00
bors
1c32387ce2
Auto merge of #16526 - Veykril:item-loc, r=Veykril
...
internal: Cleanup 🧹
2024-02-10 14:38:15 +00:00
Lukas Wirth
36fb1409ed
Cleanup visibility.rs
2024-02-10 13:50:45 +01:00
Lukas Wirth
dc69255b83
Re-organize hir-def/lib.rs
2024-02-10 12:40:23 +01:00
Lukas Wirth
74eb3ecbc1
Move ChildbySource and HasSource impls to their corresponding modules
2024-02-10 12:09:12 +01:00
bors
0878cdef2a
Auto merge of #16524 - evertedsphere:swann/trait-bound-dyn, r=Veykril
...
minor: test that flip_trait_bound works with trait objects
Closes https://github.com/rust-lang/rust-analyzer/issues/16522 .
2024-02-10 10:59:46 +00:00
bors
1ef7a2329b
Auto merge of #16525 - Veykril:item-loc, r=Veykril
...
Abstract more over ItemTreeLoc-like structs
Allows reducing some code duplication by using functions generic over said structs. The diff isn't negative due to me adding some additional impls for completeness.
2024-02-10 10:47:37 +00:00
Lukas Wirth
00303c3b67
Abstract over ItemTreeLoc
2024-02-10 11:37:59 +01:00
Soham Chowdhury
dcdfc35fce
test that flip_trait_bound works with trait objects
2024-02-10 11:06:07 +01:00
bors
aa97edb214
Auto merge of #16497 - evertedsphere:swann/fix-inline-for-macro-generated-method, r=Veykril
...
Fix incorrect inlining of functions that come from MBE macros
Partial fix for https://github.com/rust-lang/rust-analyzer/issues/16471 .
As a reminder, there are two issues there:
1. missing whitespace in parameter types (the first test)
2. the `self` parameter not being replaced by `this` in the function body (the second test)
The first part is fixed in this PR. See [this comment](https://github.com/rust-lang/rust-analyzer/pull/16497#issuecomment-1934243409 ) for the second.
2024-02-10 08:59:51 +00:00
bors
7e9265506d
Auto merge of #16521 - tetsuharuohzeki:experiment-enable-str_to_string, r=lnicola
...
internal: Enable str_to_string Clippy rule
This fix [the FIXME comment](bb0de88f24/Cargo.toml (L183-L184)
2024-02-10 08:15:39 +00:00
Lukas Wirth
2ebf0c87c2
Deduplicate some code
2024-02-10 01:51:22 +01:00
Soham Chowdhury
18be556b37
inline_call: remove macro self->this test
...
To be added back later once we have a fix.
See #16471 and https://github.com/rust-lang/rust-analyzer/pull/16497#issuecomment-1934243409 .
2024-02-09 22:02:51 +01:00
Tetsuharu Ohzeki
71ea70ebf6
clippy: Enable str_to_string rule
2024-02-10 01:00:41 +09:00
Tetsuharu Ohzeki
88f088c4a0
text-edit: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:41 +09:00
Tetsuharu Ohzeki
a897566515
test-fixture: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
1915d9abb7
tt: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
bffb8880d5
lsp-server: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
c3699b9f32
test-utils: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
0a879f7da4
sourcegen: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
06f3995ca9
xtask: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
283b140321
salsa: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
cee3c22ae8
vfs: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
81c35d1f56
syntax: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
f474bd77be
parser: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
edda6b8a1f
mbe: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
80713250c5
load-cargo: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
ae78dcae75
ide-ssr: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
fb8c0f514e
ide-db: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
f4a4b6681b
ide-completion: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
395708d5e0
rust-analyzer: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
80e684254d
ide-assists: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
b89a4038c9
proc-macro-api: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
5d1f2835af
project-model: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
d00f1c1b16
ide-diagnostics: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
eba1b13295
hir: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
d580b2c7bc
hir-ty: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
cb95ee3bc0
hir-def: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
99f5d7ca4c
hir-def: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
a9a315fd73
base-db: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
Tetsuharu Ohzeki
8c2f301a41
ide: Fix warnings about clippy str_to_string rule
2024-02-10 01:00:40 +09:00
bors
bb0de88f24
Auto merge of #16519 - tetsuharuohzeki:more-lint, r=lnicola
...
Enable some minor lints that we should tackles (take2)
This enables these lints:
- borrowed_box
- derived_hash_with_manual_eq
- forget_non_drop
- needless_doctest_main
2024-02-09 15:17:29 +00:00
