Mirrors/rust-analyzer
2
0
Fork 0
mirror of https://github.com/rust-lang/rust-analyzer synced 2024-11-16 17:58:16 +00:00
Code Issues Projects Releases Packages Wiki Activity
15211 commits 3 branches 264 tags 157 MiB
Commit graph

15211 commits

This branch
This branch
All branches
Author SHA1 Message Date
Lukas Wirth
a3f5491a1a Inline TypeCtor into Ty 2021-02-28 19:13:37 +01:00
Lukas Wirth
7c2dd85a32 Use chalk_ir::Scalar directly 2021-02-28 11:06:37 +01:00
Lukas Wirth
5183c9f083 Introduce TypeCtor::Scalar 2021-02-28 01:20:04 +01:00
bors[bot]
2a4076c14d
Merge #7794 
7794: Disable "Flip comma" assist inside a macro call r=Veykril a=greenhat

Fix #7693 

Disables "Flip comma" assist if called inside a macro call.

Co-authored-by: Denys Zadorozhnyi <denys@zadorozhnyi.com>
 2021-02-26 18:10:07 +00:00
Denys Zadorozhnyi
eb3c23588d
Disable "Flip comma" assist inside a macro call 2021-02-26 19:12:53 +02:00
bors[bot]
d5b8a401f3
Merge #7792 
7792: docs(ide_assists): Change remaining occurrences of importMergeBehaviour to importMergeBehavior r=lnicola a=SanchithHegde



Co-authored-by: Sanchith Hegde <sanchith.hegde01@gmail.com>
 2021-02-26 07:29:05 +00:00
Sanchith Hegde
3eaec3cd33
docs(ide_assists): Change importMergeBehaviour to importMergeBehavior 2021-02-26 12:54:50 +05:30
bors[bot]
6ed49683e3
Merge #7786 
7786: bump crates r=kjeremy a=kjeremy



Co-authored-by: kjeremy <kjeremy@gmail.com>
 2021-02-25 15:35:37 +00:00
kjeremy
d42730b76e bump crates 2021-02-25 10:34:48 -05:00
bors[bot]
06a0ab71c7
Merge #7785 
7785: ⬆️ crates r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-02-25 14:56:29 +00:00
Aleksey Kladov
eb7333f0a9 ⬆️ crates 2021-02-25 17:55:50 +03:00
bors[bot]
dc14c432f5
Merge #7741 
7741: Add convert_for_to_iter_for_each assist r=mattyhall a=mattyhall

Implements one direction of #7681 

I wonder if this tries to guess too much at the right thing here. A common pattern is:

```rust
let col = vec![1, 2, 3];
for v in &mut col {
  *v *= 2;
}
// equivalent to:
col.iter_mut().for_each(|v| *v *= 2);
```

I've tried to detect this case by checking if the expression after the `in` is a (mutable) reference and if not inserting iter()/iter_mut(). This is just a convention used in the stdlib however, so could sometimes be wrong. I'd be happy to make an improvement for this, but not sure what would be best. A few options spring to mind:
1. Only allow this for types that are known to have iter/iter_mut (ie stdlib types)
2. Try to check if iter/iter_mut exists and they return the right iterator type
3. Don't try to do this and just add `.into_iter()` to whatever is after `in`

Co-authored-by: Matt Hall <matthew@quickbeam.me.uk>
 2021-02-24 19:24:22 +00:00
Matt Hall
a28e862825 Address further review comments 
* Use known names for iter/iter_mut method (simplifies checking if the
  method exists
* Extract code to check assist with fixtures to function
 2021-02-24 19:23:12 +00:00
bors[bot]
0537510aef
Merge #7719 
7719: De Morgan's Law assist now correctly parenthesizes binary expressions. r=Veykril a=lbrande

Closes #7694 by parenthesizing binary expressions that are negated.

Co-authored-by: lbrande <lovbra00@gmail.com>
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
 2021-02-24 12:19:22 +00:00
bors[bot]
18ac02ba41
Merge #7775 
7775: Fix typo. r=Veykril a=boxdot



Co-authored-by: boxdot <d@zerovolt.org>
 2021-02-24 11:03:39 +00:00
Lukas Wirth
694f7a7e9f Add tests for apply_demorgan 2021-02-24 11:58:37 +01:00
lbrande
9db970ee08 De Morgan's Law assist now correctly inverts <, <=, >, >=. 2021-02-24 11:58:37 +01:00
lbrande
f7a4a87de2 De Morgan's Law assist now correctly parenthesizes binary expressions. 2021-02-24 11:58:37 +01:00
boxdot
9b78a6f6d2
Fix typo. 2021-02-24 11:56:48 +01:00
bors[bot]
aa38fa1c72
Merge #7772 
7772: Pickup ConstReference patterns in FindUsages r=Veykril a=Veykril

bors r+

Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
 2021-02-23 22:32:47 +00:00
Lukas Wirth
9e8f4d31a4 Pickup ConstReference patterns in FindUsages 2021-02-23 23:31:53 +01:00
Matt Hall
98a626450d Address review comments 
* Move code to build replacement into closure
* Look for iter/iter_mut methods on types behind reference
 2021-02-23 19:19:48 +00:00
Matt Hall
506293ca43 Add convert_for_to_iter_for_each assist 2021-02-23 18:10:01 +00:00
bors[bot]
a307e4f31f
Merge #7770 
7770: reliable memory usage during benchmarking r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-02-23 18:02:40 +00:00
Aleksey Kladov
68a9411845 reliable memory usage during benchmarking 2021-02-23 21:02:17 +03:00
bors[bot]
0892ccd090
Merge #7769 
7769: Update mio r=kjeremy a=kjeremy



Co-authored-by: kjeremy <kjeremy@gmail.com>
 2021-02-23 17:18:58 +00:00
kjeremy
722d071dbf Update mio 2021-02-23 12:16:56 -05:00
bors[bot]
0d5a9e4104
Merge #7768 
7768: Fix visibility computation when inside a block expression r=jonas-schievink a=jonas-schievink

fixes https://github.com/rust-analyzer/rust-analyzer/issues/7728

bors r+

Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
 2021-02-23 17:06:57 +00:00
bors[bot]
e837fb245a
Merge #7766 
7766: Update our vscode npm packages r=kjeremy a=kjeremy



Co-authored-by: kjeremy <kjeremy@gmail.com>
 2021-02-23 16:56:21 +00:00
Jonas Schievink
338823f73a is_visible_from_def_map: handle block expressions 2021-02-23 17:56:16 +01:00
kjeremy
c3ab200114 Update our vscode npm packages 2021-02-23 11:39:19 -05:00
Jonas Schievink
cf456d72db Add test 2021-02-23 14:54:01 +01:00
bors[bot]
27ed1ebf89
Merge #7759 
7759: 7526: Rename ide related crates r=Veykril a=chetankhilosiya

renamed assists -> ide_assists and ssr -> ide_ssr.
the completion crate is already renamed.

Co-authored-by: Chetan Khilosiya <chetan.khilosiya@gmail.com>
 2021-02-22 20:28:17 +00:00
Chetan Khilosiya
eb6cfa7f15 7526: Renamed create ssr to ide_ssr. 2021-02-23 00:59:16 +05:30
Chetan Khilosiya
e4756cb4f6 7526: Rename crate assists to ide_assists. 2021-02-23 00:59:16 +05:30
bors[bot]
8687053b11
Merge #7756 
7756: update tracing-tree r=kjeremy a=kjeremy

Removes some dependencies

Co-authored-by: kjeremy <kjeremy@gmail.com>
 2021-02-22 18:23:33 +00:00
kjeremy
11a65c64d0 update tidy 2021-02-22 12:25:02 -05:00
kjeremy
e103ca7d8d update tracing-tree 2021-02-22 12:03:34 -05:00
bors[bot]
77d861a93a
Merge #7753 
7753: Add isize to the list of suffixed integers in typed_integer r=kjeremy a=jonasbb

The missing `isize` in `typed_integers` seems to just be an oversight.

Might fix: #7751

Co-authored-by: Jonas Bushart <jonas@bushart.org>
 2021-02-22 13:54:53 +00:00
Jonas Bushart
bd525c9d20 Add isize to the list of suffixed integers in typed_integer 
The missing `isize` in `typed_integers` seems to just be an oversight.

Might fix: #7751
 2021-02-22 14:48:56 +01:00
bors[bot]
63d61c0c98
Merge #7752 
7752: up once_cell r=kjeremy a=kjeremy



Co-authored-by: kjeremy <kjeremy@gmail.com>
 2021-02-22 13:32:40 +00:00
kjeremy
d51c58e14e up once_cell 2021-02-22 08:31:33 -05:00
bors[bot]
7775d92b47
Merge #7749 
7749: Make more common assist easier to ues r=matklad a=matklad

bors r+
🤖

Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
 2021-02-22 13:15:04 +00:00
Aleksey Kladov
58be1edfbb Make more common assist easier to ues 2021-02-22 16:07:08 +03:00
bors[bot]
14de9e54a6
Merge #7739 
7739: Bump deps r=lnicola a=lnicola

Closes #7273

bors r+

Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
 2021-02-21 17:34:54 +00:00
Laurențiu Nicola
6c0f7a2f56 Pin ungrammar 2021-02-21 19:33:55 +02:00
Laurențiu Nicola
d03cfe141c Add test from #7273 2021-02-21 19:22:14 +02:00
Laurențiu Nicola
48ae948b22 Bump deps 2021-02-21 19:13:11 +02:00
bors[bot]
238f3a5173
Merge #7735 
7735: Stop mixing Result and Option with ? in inline_local_variable r=Veykril a=scottmcm

Depending on the discussion in https://github.com/rust-lang/rfcs/pull/3058 this might not end up being necessary, but I think it's a reasonable change regardless.

Co-authored-by: Scott McMurray <scottmcm@users.noreply.github.com>
 2021-02-21 00:18:49 +00:00
Scott McMurray
0fe44d099a Stop mixing Result and Option with ? in inline_local_variable 
Depending on the discussion in RFC#3058 this might not end up being necessary, but I think it's a reasonable change regardless.
 2021-02-20 14:45:30 -08:00