davidsemakula
a250c2dde0
refactor remove trailing return diagnostic
2024-02-08 19:32:53 +03:00
davidsemakula
98e6f43a2f
remove trailing return in trailing match expression
2024-02-08 19:32:53 +03:00
davidsemakula
cad222ff1b
remove trailing return in trailing if expression
2024-02-08 19:32:53 +03:00
davidsemakula
2987fac76f
diagnostic to remove trailing return
2024-02-08 19:32:53 +03:00
bors
e07183461f
Auto merge of #16487 - ShoyuVanilla:deref-generate-getter, r=Veykril
...
Remove unnecessary `.as_ref()` in generate getter assist
Resolves #12389
2024-02-08 15:15:52 +00:00
bors
5812b693c3
Auto merge of #16484 - Austaras:master, r=Veykril
...
fix: preserve where clause when builtin derive
Closes #16432 .
2024-02-08 15:03:55 +00:00
austaras
dad0fdb13f
fix: preserve where clause when builtin derive
2024-02-08 22:44:39 +08:00
bors
0e5766b0d8
Auto merge of #16477 - davidsemakula:trait-incorrect-case-diagnostic, r=Veykril
...
feat: Add incorrect case diagnostics for traits and their associated items
Updates incorrect case diagnostic to:
- Check traits and their associated items
- Ignore trait implementations except for patterns in associated function bodies
Also cleans up `hir-ty::diagnostics::decl_check` a bit (mostly to make it a bit more DRY and easier to maintain)
Also fixes : #8675 and fixes : #8225
2024-02-08 14:40:16 +00:00
bors
e9d3565cd1
Auto merge of #16502 - davidsemakula:unnecessary-else-diagnostic, r=Veykril
...
feat: Add "unnecessary else" diagnostic and fix
Fixes #9457
2024-02-08 14:25:00 +00:00
bors
82674e21be
Auto merge of #16454 - Veykril:break-return-postfix, r=Veykril
...
feat: Add break and return postfix keyword completions
2024-02-08 14:09:04 +00:00
Lukas Wirth
ddddc9c0e2
Update test outputs
2024-02-08 14:57:21 +01:00
bors
ddf26113fc
Auto merge of #16462 - Veykril:proc-error, r=Veykril
...
Better error message for when proc-macros have not yet been built
Closes https://github.com/rust-lang/rust-analyzer/issues/16331
2024-02-08 13:56:58 +00:00
Lukas Wirth
15bffe25bd
feat: Add break and return postfix keyword completions
2024-02-08 14:56:10 +01:00
Lukas Wirth
545382db25
Fix warnings
2024-02-08 14:54:52 +01:00
Lukas Wirth
91dab4d720
Better error message for when proc-macros have not yet been built
2024-02-08 14:53:12 +01:00
Lukas Wirth
4bf6b160a9
Fix incorrect range uses in missing_fields quick fixes
2024-02-08 14:53:11 +01:00
bors
6655960186
Auto merge of #16134 - tvallotton:master, r=Veykril
...
fix: waker_getters tracking issue from 87021 for 96992.
I was directed to make the fix here by this comment https://github.com/rust-lang/rust/pull/118960#issuecomment-1857888974 .
2024-02-08 10:28:45 +00:00
bors
5c80ad05ae
Auto merge of #16124 - ohno418:call-expr-missing-arg, r=Veykril
...
fix: Recover from missing argument in call expressions
Previously, when parsing an argument list with a missing argument (e.g., `(a, , b)` in `foo(a, , b)`), the parser would stop upon an unexpected token (at the second comma in the example), resulting in an incorrect parse tree.
This commit improves error handling in such cases, ensuring a more accurate parse tree is built.
---
Fixes https://github.com/rust-lang/rust-analyzer/issues/15683 .
2024-02-08 10:16:36 +00:00
Lukas Wirth
974e69b0c5
Recover from missing slots in delimited parsing
2024-02-08 11:14:37 +01:00
Yutaro Ohno
e865d45904
fix: Recover from missing argument in call expressions
...
Previously, when parsing an argument list with a missing argument (e.g.,
`(a, , b)` in `foo(a, , b)`), the parser would stop upon an unexpected
token (at the second comma in the example), resulting in an incorrect
parse tree.
This commit improves error handling in such cases, ensuring a more
accurate parse tree is built.
2024-02-08 10:54:04 +01:00
bors
ae89522928
Auto merge of #16510 - Veykril:single-package-check, r=Veykril
...
feat: Allow cargo check to run on only the current package
cc https://github.com/rust-lang/rust-analyzer/pull/13336 , https://github.com/rust-lang/rust-analyzer/issues/12882
2024-02-08 09:43:16 +00:00
Lukas Wirth
0258f60cfe
feat: Allow cargo check to run on only the current package
2024-02-08 10:40:42 +01:00
bors
bcc8a09a0d
Auto merge of #16509 - Veykril:hover-tuple-struct, r=Veykril
...
fix: Fix tuple structs not rendering visibility in their fields
Fixes https://github.com/rust-lang/rust-analyzer/issues/16508
2024-02-08 09:06:53 +00:00
Lukas Wirth
81ea48a573
fix: Fix tuple structs not rendering visibility in their fields
2024-02-08 10:05:28 +01:00
bors
c48f145535
Auto merge of #16507 - clubby789:remove-ffi_returns_twice, r=lnicola
...
Remove `ffi_returns_twice` references
This feature has just been [removed](https://github.com/rust-lang/rust/pull/120502 )
2024-02-07 19:47:45 +00:00
clubby789
79e4111442
Remove ffi_returns_twice references
2024-02-07 19:42:07 +00:00
bors
ca44e1ee9f
Auto merge of #16506 - lnicola:bump-paths-filter, r=lnicola
...
minor: bump `paths-filter`
Fixes a Node version warning.
2024-02-07 17:26:44 +00:00
Laurențiu Nicola
aa9bc01824
Bump paths-filter
2024-02-07 19:24:35 +02:00
bors
8628352214
Auto merge of #16505 - Veykril:unit-salsa, r=Veykril
...
Optimize input queries that take no arguments
There is no point in having a hashmap and extra lock for this, it is always only a single value. This might speed up some things by a tiny bit for our crate graph query.
2024-02-07 17:08:48 +00:00
Lukas Wirth
97cd68097a
Optimize input queries that take no arguments
2024-02-07 18:04:02 +01:00
bors
2d2ddd318b
Auto merge of #16503 - Veykril:salsa, r=Veykril
...
Move salsa fork in-tree
No one else is supposed to rely on it anyways, this makes it easier to edit.
2024-02-07 16:20:53 +00:00
Lukas Wirth
3688064ff5
Clippy
2024-02-07 17:08:38 +01:00
Lukas Wirth
731b159f10
Remove dev-dependency diff
2024-02-07 16:34:21 +01:00
Lukas Wirth
e339c65a1a
Remove dev-dependency insta
2024-02-07 16:30:20 +01:00
Lukas Wirth
def5a1d0c4
unreachable-pub
2024-02-07 16:30:13 +01:00
Lukas Wirth
bc5823d5bb
Bump salsa dev-deps
2024-02-07 16:30:07 +01:00
Lukas Wirth
0a6197df97
rustfmt
2024-02-07 16:30:00 +01:00
Lukas Wirth
159a03ad7b
Move salsa fork in-tree
2024-02-07 16:29:46 +01:00
davidsemakula
d7a03022f7
handle divergence in child if expr for unnecessary else diagnostic fix
2024-02-06 19:00:10 +03:00
davidsemakula
62cc4f9c46
add unnecessary else diagnostic
2024-02-06 19:00:10 +03:00
bors
1974e7490d
Auto merge of #16501 - lnicola:lete-snippet-docs, r=lnicola
...
minor: Add `lete` to postfix completion list
2024-02-06 11:15:27 +00:00
Laurențiu Nicola
2c4152847a
Add lete to postfix completion list
2024-02-06 13:13:51 +02:00
bors
0dd62c0d59
Auto merge of #16500 - lnicola:clippy-windows, r=lnicola
...
internal: run Clippy on Windows
CC https://github.com/rust-lang/rust-analyzer/pull/16413#issuecomment-1927592897
2024-02-06 10:08:45 +00:00
Laurențiu Nicola
32f0a2fc39
Run Clippy on Windows
2024-02-06 11:22:26 +02:00
bors
6671d3c9a3
Auto merge of #16499 - Nadrieril:update-pat-ana, r=lnicola
...
internal: Update rustc_pattern_analysis dependency
Just bumping the dependency, as I've been making API changes over on the rustc side. More API changes incoming in the coming weeks.
One benefit of this: we no longer abort in the `DeconstructedPat: Debug` impl, which means we can use `tracing` to investigate issues.
2024-02-06 07:04:33 +00:00
bors
64411a4ea3
Auto merge of #16496 - matthiaskrgr:c, r=lnicola
...
minor: remove clones
2024-02-06 06:47:13 +00:00
Nadrieril
d2d4119d24
Don't need an arena for types anymore
2024-02-06 05:09:30 +01:00
Nadrieril
ba7b12e062
Update rustc_pattern_analysis dependency
2024-02-06 05:08:19 +01:00
Nadrieril
c2d21242aa
Tweak variant_id_for_adt
2024-02-06 05:01:05 +01:00
Matthias Krüger
ac9d1a03a7
remove clones
2024-02-05 23:15:47 +01:00
