2795: Use dummy value for macro file in bulitin macros r=matklad a=edwin0cheng
This PR skip the actual line and column computation for `MacroFile` and return a dummy value instead.
Related to #2794
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2796: Fix lruCapacity config key in VSCode r=kjeremy a=marcogroppo
Closes#2789.
This simply adds `null` as a valid value for the configuration key.
We could use the server-side default value (128) instead, but in that case every time we change its value on the server side we would have to update it on the client side too.
Co-authored-by: Marco Groppo <marco.groppo@gmail.com>
2790: Add test for macro expansion in various expressions r=edwin0cheng a=flodiebold
cc @edwin0cheng
Co-authored-by: Florian Diebold <flodiebold@gmail.com>
2749: Basic DocumentHighlightKind support for assignments r=matklad a=kjeremy
Wraps references per #2738 and adds limited support for DocumentHighlightKind Read/Write for simple binops assignments.
I think I need some help with determining reads/writes.
Towards #2560
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
Co-authored-by: kjeremy <kjeremy@gmail.com>
2787: Add missing expr cases for expand macro r=flodiebold a=edwin0cheng
I will open another issues for tracking adding back the cases implemented in the PR.
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2786: Proper handling local in hover r=flodiebold a=edwin0cheng
This PR implement back the `Local` hover information generation, which is fall back to a general case catch previously :
9a44f627be/crates/ra_ide/src/hover.rs (L173-L182)
Co-authored-by: Edwin Cheng <edwin0cheng@gmail.com>
2779: Parse trait aliases r=matklad a=kiljacken
Implements the needed changes to correctly parse trait aliases.
This is my first change in the parser code, so would appreciate a comment on whether this is the right way to go about it.
Co-authored-by: Emil Lauridsen <mine809@gmail.com>
2772: Actually test references r=kjeremy a=kjeremy
This will be a little more work when `ReferenceSearchResults` change but I think it's easier to maintain in the end. It also follows a similar pattern to navigation targets and call hierarchy.
Co-authored-by: kjeremy <kjeremy@gmail.com>
Co-authored-by: Jeremy Kolb <kjeremy@gmail.com>
2771: Remove the Default impl for SourceRoot r=matklad a=michalt
Let's be always explicit whether we create a library (i.e., an immutable
dependency) or a local `SourceRoot`, since it can have a large impact on
the validation performance in salsa. (we found it the hard way recently,
where the `Default` instance made it quite tricky to spot a bug)
Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
Co-authored-by: Michal Terepeta <michal.terepeta@gmail.com>
Let's be always explicit whether we create a library (i.e., an immutable
dependency) or a local `SourceRoot`, since it can have a large impact on
the validation performance in salsa. (we found it the hard way recently,
where the `Default` instance made it quite tricky to spot a bug)
Signed-off-by: Michal Terepeta <michal.terepeta@gmail.com>
