James Leitch
72718bc2d7
Code review feedback.
2021-04-21 15:10:53 -07:00
James Leitch
9fcad82980
Diagnostic Remap Path Prefixes added.
2021-04-21 15:10:53 -07:00
James Leitch
60841f4276
Diagnostic paths attempt to use VSCode's path join behavior before defaulting to Rust's path join behavior.
2021-04-21 15:10:53 -07:00
bors[bot]
32491c0978
Merge #8570
...
8570: Flycheck tries to parse both Cargo and Rustc messages. r=rickvanprim a=rickvanprim
This change allows non-Cargo build systems to be used for Flycheck provided they call `rustc` with `--error-format=json` and emit those JSON messages to `stdout`.
Co-authored-by: James Leitch <rickvanprim@gmail.com>
2021-04-21 21:56:54 +00:00
bors[bot]
b21701c5ee
Merge #8616
...
8616: minor: Bump deps r=lnicola a=lnicola
bors r+
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-04-21 16:20:56 +00:00
Laurențiu Nicola
81054a2581
Bump other deps
2021-04-21 19:20:18 +03:00
Laurențiu Nicola
27c5e2da48
Bump chalk
2021-04-21 19:20:01 +03:00
Laurențiu Nicola
e50ca6b067
Bump rustc_lexer
2021-04-21 19:19:27 +03:00
bors[bot]
163d9d31a4
Merge #8615
...
8615: skip: Remove `ItemTree::all_inner_items` r=jonas-schievink a=jonas-schievink
It's unused.
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-04-21 16:10:55 +00:00
Jonas Schievink
0414b65319
Remove ItemTree::all_inner_items
2021-04-21 18:10:25 +02:00
bors[bot]
e9fea823a0
Merge #8613
...
8613: skip: Add failing local items test r=jonas-schievink a=jonas-schievink
This is currently broken due to the way ItemTree stores inner items. This test serves as a reminder until this gets fixed.
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-04-21 15:58:57 +00:00
Jonas Schievink
7b7d051e81
Add failing local items test
2021-04-21 17:57:45 +02:00
bors[bot]
c7ae16e872
Merge #8611
...
8611: Add support for fill match arms of boolean values r=flodiebold a=komonad
- Add support for boolean inside tuple
closes #8593
Co-authored-by: Comonad <comonad@foxmail.com>
2021-04-21 14:48:03 +00:00
Comonad
09147c3303
Add support for fill match arms of boolean values
...
- Add support for boolean inside tuple
2021-04-21 19:33:45 +08:00
bors[bot]
7ae0bc1bd4
Merge #8609
...
8609: Parse outer atttributes for RecordPatField r=Veykril a=Veykril
Fixes #8608
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-04-21 09:12:08 +00:00
Lukas Wirth
3f7a086b4f
Parse outer atttributes for RecordPatField
2021-04-21 11:08:15 +02:00
bors[bot]
70fe7a4515
Merge #8606
...
8606: fix: no more Registering progress handler for token rustAnalyzer/Ind… r=jonas-schievink a=matklad
…exing failed.
closes #8509
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-04-20 21:25:27 +00:00
Aleksey Kladov
cdfe5a8be0
fix: no more Registering progress handler for token rustAnalyzer/Indexing failed.
2021-04-20 22:54:05 +03:00
bors[bot]
ad131049c4
Merge #8600
...
8600: fix: no longer get stuck on windows r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-04-20 15:05:33 +00:00
Aleksey Kladov
1772eb0f1a
fix: no longer get stuck on windows
...
reading both stdout & stderr is a common gotcha, you need to drain them
concurrently to avoid deadlocks. Not sure why I didn't do the right
thing from the start. Seems like I assumed the stderr is short? That's
not the case when cargo spams `compiling xyz` messages
2021-04-20 18:02:54 +03:00
bors[bot]
86c2bb3c5b
Merge #8602
...
8602: Fix panic in `replace_derive_with_manual_impl` r=jonas-schievink a=jonas-schievink
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-04-20 14:27:08 +00:00
Jonas Schievink
c0ad9b3581
Follow testing style guide
2021-04-20 16:26:07 +02:00
Jonas Schievink
6624158969
Fix panic in replace_derive_with_manual_impl
2021-04-20 16:25:24 +02:00
bors[bot]
da6902d159
Merge #8601
...
8601: Trigger "Inline variable" assist when on a use of the variable r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8530
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-04-20 14:18:51 +00:00
Jonas Schievink
d699371f5f
"Inline variable" when on a use of the variable
2021-04-20 16:16:23 +02:00
bors[bot]
1834938d6f
Merge #8598
...
8598: minor: fix ugly line wrapping in the rendered manual r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-04-20 07:45:04 +00:00
Aleksey Kladov
0ce591d33d
minor: fix ugly line wrapping in the rendered manual
2021-04-20 10:44:06 +03:00
James Leitch
b3a7953cae
Code review feedback.
2021-04-19 12:26:04 -07:00
bors[bot]
15b34667c5
Merge #8588
...
8588: internal: Add guidelines for release notes PR descriptions r=matklad a=lnicola
Co-authored-by: Laurențiu Nicola <lnicola@dend.ro>
2021-04-19 18:38:34 +00:00
Laurențiu Nicola
bb4952da04
internal: Add guidelines for release notes PR descriptions
2021-04-19 21:30:44 +03:00
bors[bot]
b6a7276c54
Merge #8586
...
8586: Replace SyntaxRewriter usage with ted in eager::eager_macro_recur r=Veykril a=Veykril
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-04-19 18:03:56 +00:00
bors[bot]
9cfbb56afa
Merge #8587
...
8587: Fix some find_path bugs around inner items r=jonas-schievink a=jonas-schievink
Fixes https://github.com/rust-analyzer/rust-analyzer/issues/8519
bors r+
Co-authored-by: Jonas Schievink <jonasschievink@gmail.com>
2021-04-19 17:54:34 +00:00
Jonas Schievink
ec05186378
Add autoimport test with inner items
2021-04-19 19:53:29 +02:00
Jonas Schievink
59630977a5
Fix some find_path bugs around inner items
2021-04-19 19:50:11 +02:00
Lukas Wirth
952fc23694
Replace SyntaxRewriter with ted in exppand_macro::expand_macro_recur
2021-04-19 19:43:26 +02:00
Lukas Wirth
617cd7231c
Remove SyntaxRewriter usage in eager::eager_macro_recur
2021-04-19 19:28:41 +02:00
bors[bot]
0741de87e7
Merge #8584
...
8584: internal: fix slightly broken test r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-04-19 16:04:44 +00:00
Aleksey Kladov
21f4588fc8
internal: fix slightly broken test
2021-04-19 18:57:47 +03:00
bors[bot]
fc709c8b21
Merge #8583
...
8583: Simplify r=Veykril a=Veykril
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-04-19 15:55:29 +00:00
bors[bot]
2b5f35ca4b
Merge #8582
...
8582: Fix typo: comparision -> comparison r=kjeremy a=stanciuadrian
Closes #8576
Co-authored-by: Adrian Stanciu <stanciu.adrian@gmail.com>
2021-04-19 15:47:18 +00:00
Adrian Stanciu
1c75d8975c
Fix typo: comparision -> comparison
2021-04-19 18:44:38 +03:00
bors[bot]
9b853435d3
Merge #8580
...
8580: Remove confusion around serverStatusNotification r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-04-19 15:12:49 +00:00
Aleksey Kladov
dcb759b727
Remove confusion around serverStatusNotification
2021-04-19 18:12:25 +03:00
Lukas Wirth
c96c38edd3
Simplify
2021-04-19 17:11:30 +02:00
bors[bot]
2cdc83af93
Merge #8579
...
8579: Fix spec bug r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-04-19 14:56:39 +00:00
Aleksey Kladov
e5d91e8992
Fix spec bug
2021-04-19 17:55:51 +03:00
bors[bot]
6877e6e4da
Merge #8578
...
8578: fix: false positive about inner attrs in docs r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2021-04-19 14:37:54 +00:00
Aleksey Kladov
5f89a60f1a
fix: false positive about inner attrs in docs
...
closes #8541
2021-04-19 17:11:49 +03:00
bors[bot]
6991b517f2
Merge #8577
...
8577: Support crates/module roots in external_docs r=Veykril a=Veykril
Fixes #8575
bors r+
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
2021-04-19 13:51:57 +00:00
Lukas Wirth
6142afeafd
Support crates/module roots in external_docs
2021-04-19 15:50:04 +02:00