bors[bot]
5397f05bfe
Merge #3049
...
3049: Introduce assists utils r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-07 16:28:33 +00:00
Aleksey Kladov
d00add1f1f
Introduce assists utils
2020-02-07 17:28:02 +01:00
Aleksey Kladov
561b4b11ff
Name assist handlers
2020-02-07 17:28:02 +01:00
Aleksey Kladov
aa64a84b49
Cleanups
2020-02-07 15:12:51 +01:00
Aleksey Kladov
ce44547cfb
Cleanup imports
2020-02-07 15:10:19 +01:00
Aleksey Kladov
6ac9c4ad6a
Cleanup
2020-02-07 15:04:50 +01:00
Aleksey Kladov
2d95047f7c
Cleanup
2020-02-07 14:55:47 +01:00
Aleksey Kladov
b831b17b3d
Simplify
2020-02-07 14:53:50 +01:00
bors[bot]
1996762b1f
Merge #3048
...
3048: Remove irrelevant distinction r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-07 13:35:02 +00:00
Aleksey Kladov
ae70d07237
Rename
2020-02-07 14:26:59 +01:00
Aleksey Kladov
f55be75a17
Remove irrelevant distinction
2020-02-07 14:25:16 +01:00
bors[bot]
8337dcd9e2
Merge #3047
...
3047: Update async unsafe fn ordering in parser r=matklad a=kiljacken
As of rust-lang/rust#61319 the correct order for functions that are both unsafe and async is: `async unsafe fn` and not `unsafe async fn`.
This commit updates the parser tests to reflect this, and corrects parsing behavior to accept the correct ordering.
Fixes #3025
Co-authored-by: Emil Lauridsen <mine809@gmail.com>
2020-02-07 13:21:02 +00:00
bors[bot]
6d6a995e09
Merge #3040
...
3040: Rework value parameter parsing r=matklad a=tobz1000
Fixes #2847 .
- `Fn__(...)` parameters with idents/patterns no longer parse
- Trait function parameters with arbitrary patterns parse
- Trait function parameters without idents/patterns no longer parse
- `fn(...)` parameters no longer parse with patterns other than a single ident
__Question__: The pre-existing test `param_list_opt_patterns` has been kept as-is, although the name no longer makes sense (it's testing `Fn__(...)` params, which aren't allowed patterns any more). What would be best to do about this?
Co-authored-by: Toby Dimmick <tobydimmick@pm.me>
2020-02-07 13:13:36 +00:00
Emil Lauridsen
73ec2ab184
Update async unsafe fn ordering.
...
As of rust-lang/rust#61319 the correct order for functions that are both
unsafe and async is: `async unsafe fn` and not `unsafe async fn`.
This commit updates the parser tests to reflect this, and corrects
parsing behavior to accept the correct ordering.
Fixes #3025
2020-02-07 13:51:51 +01:00
Toby Dimmick
90ff2be4e8
PR tweaks
2020-02-07 12:36:33 +00:00
bors[bot]
4d0d113c7d
Merge #3044
...
3044: Don't crash when recieving unkown file for cargo diagnostic. r=matklad a=kiljacken
Fixes #3014
Co-authored-by: Emil Lauridsen <mine809@gmail.com>
2020-02-07 11:41:25 +00:00
Emil Lauridsen
137a878461
to_string_lossy() -> display()
2020-02-07 12:35:36 +01:00
bors[bot]
1479dd6f2d
Merge #3045
...
3045: Cleanup early return assist r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-07 11:34:31 +00:00
Aleksey Kladov
36ee9ecb67
Cleanup early return assist
2020-02-07 12:30:39 +01:00
Emil Lauridsen
5db7c8642b
Don't crash when recieving unkown file for cargo diagnostic.
2020-02-07 12:30:29 +01:00
Aleksey Kladov
aa1234e02b
Generalize invert_if to just always work
2020-02-07 12:14:33 +01:00
bors[bot]
5aba5a756a
Merge #3042
...
3042: A tiny bit more consistent API r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-06 23:00:07 +00:00
Aleksey Kladov
56e3fbe588
A tiny bit more consistent API
2020-02-06 23:59:27 +01:00
Toby Dimmick
0183952d2e
Closure params test
2020-02-06 20:39:27 +00:00
Toby Dimmick
e1921ea59c
rustfmt
2020-02-06 20:04:35 +00:00
Toby Dimmick
7e66785859
Rework value parameter parsing
...
- `Fn__(...)` parameters with idents/patterns no longer parse
- Trait function parameters with arbitrary patterns parse
- Trait function parameters without idents/patterns no longer parse
- `fn(...)` parameters no longer parse with patterns other than a single ident
2020-02-06 19:45:51 +00:00
bors[bot]
a4431e8302
Merge #3038
...
3038: Minor rename r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-06 17:50:11 +00:00
Aleksey Kladov
7e73b7a5f8
Minor rename
2020-02-06 18:47:26 +01:00
bors[bot]
918115c32e
Merge #3036
...
3036: Remove the leftovers after ImportLocator removal r=matklad a=SomeoneToIgnore
Follow the FIXME's suggestion (https://github.com/rust-analyzer/rust-analyzer/pull/3034/files#diff-001b3b1412c33fee802c22b0f848dcd7L237 ) and remove the `ModuleDefId` reexport.
Also rename `ImportsLocatorIde` into plain `ImportsLocator`
Co-authored-by: Kirill Bulatov <mail4score@gmail.com>
2020-02-06 17:30:57 +00:00
Kirill Bulatov
f4a4fcf275
Remove the leftovers after ImportLocator removal
2020-02-06 19:27:48 +02:00
bors[bot]
46027e10be
Merge #3035
...
3035: Doctest autoimport r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-06 17:17:22 +00:00
Aleksey Kladov
755077e372
Doctest autoimport
2020-02-06 18:14:44 +01:00
bors[bot]
895cdb5883
Merge #3034
...
3034: Remove ImportLocator hack r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-06 16:50:01 +00:00
Aleksey Kladov
d1e8b8d134
Fix tests
2020-02-06 17:42:17 +01:00
Aleksey Kladov
ad204f7562
Mostly remove ImoportLocator infra
2020-02-06 17:17:51 +01:00
bors[bot]
8b957caf83
Merge #3033
...
3033: Update indexmap and bstr r=kjeremy a=kjeremy
Co-authored-by: kjeremy <kjeremy@gmail.com>
2020-02-06 16:13:14 +00:00
Aleksey Kladov
cf812c12d1
Assists are not generic
2020-02-06 17:12:02 +01:00
Aleksey Kladov
f8965ffafd
Remove assists TestDB
2020-02-06 16:56:42 +01:00
Aleksey Kladov
2c922ef549
Start switching assists to a root database
2020-02-06 16:56:42 +01:00
kjeremy
6fdbf9038f
Update indexmap and bstr
2020-02-06 10:44:43 -05:00
Aleksey Kladov
a173e31890
Make assists use ImportsLocator directly
2020-02-06 16:40:28 +01:00
bors[bot]
ff0f0fc31e
Merge #3031
...
3031: Move imports locator to ide_db r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-06 15:27:23 +00:00
Aleksey Kladov
dfbe96750b
Move imports locator to ide_db
2020-02-06 16:26:43 +01:00
Aleksey Kladov
ec23030e16
Add a fixme note
2020-02-06 16:24:14 +01:00
Aleksey Kladov
271017e6bf
Move NameKind up
2020-02-06 16:23:28 +01:00
Aleksey Kladov
f8dde21fe9
Simplify
2020-02-06 16:00:39 +01:00
bors[bot]
aa571e378b
Merge #3030
...
3030: Tweak goto parent module r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-06 14:48:05 +00:00
Aleksey Kladov
832dfae250
Tweak goto parent module
2020-02-06 15:47:33 +01:00
bors[bot]
ff2d77bde6
Merge #3029
...
3029: Docs r=matklad a=matklad
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
2020-02-06 14:14:47 +00:00
Aleksey Kladov
355c98fd08
Docs
2020-02-06 15:10:17 +01:00