mirror of
https://github.com/rust-lang/rust-analyzer
synced 2025-01-13 05:38:46 +00:00
Merge #7858
7858: Clarify comparison rule r=matklad a=matklad
bors r+
🤖
Co-authored-by: Aleksey Kladov <aleksey.kladov@gmail.com>
This commit is contained in:
commit
2b22fc929a
1 changed files with 7 additions and 1 deletions
|
@ -769,14 +769,20 @@ fn foo() -> Option<Bar> {
|
|||
|
||||
## Comparisons
|
||||
|
||||
Use `<`/`<=`, avoid `>`/`>=`.
|
||||
When doing multiple comparisons use `<`/`<=`, avoid `>`/`>=`.
|
||||
|
||||
```rust
|
||||
// GOOD
|
||||
assert!(lo <= x && x <= hi);
|
||||
assert!(r1 < l2 || r2 < l1);
|
||||
assert!(x < y);
|
||||
assert!(x > 0);
|
||||
|
||||
// BAD
|
||||
assert!(x >= lo && x <= hi>);
|
||||
assert!(r1 < l2 || l1 > r2);
|
||||
assert!(y > x);
|
||||
assert!(0 > x);
|
||||
```
|
||||
|
||||
**Rationale:** Less-then comparisons are more intuitive, they correspond spatially to [real line](https://en.wikipedia.org/wiki/Real_line).
|
||||
|
|
Loading…
Reference in a new issue