Commit graph

1740 commits

Author SHA1 Message Date
Dave Davenport
8ea484349b Remove unused variable. 2018-12-15 21:22:53 +01:00
Till Hofmann
b77a48c628 tests: initialize char* in mode test (#875)
* tests: initialize char* in mode test

Currently, test_mode_result relies on undefined behavior.
The test calls mode_result, which checks whether the pointer is NULL.
However, the pointer was never initialized, so it may or may not be
NULL, depending on the compiler.

This caused a test failure on ppc64 and Fedora 28, apparently because in
this setting, gcc sets uninitialized pointers to NULL.

By initializing the pointer to the empty string, the behavior is defined
and the test passes on all architectures.

* mode: fix input pointer check in mode_result

Do not check whether *input (i.e., the char* the input points to) is
NULL, as this is valid. Instead, check whether the input itself is NULL.

* tests: make char* input arg in test_mode_result modifiable

The function mode_result expects a modifiable char*, initialize the
argument properly so it can be modified.
2018-12-14 17:05:07 +01:00
Dave Davenport
6b96ae123b Add an option to change the matching negation character.
Fixes: #877
2018-12-14 16:58:26 +01:00
Dave Davenport
76ceac1f20 [DRUN] Add drun-display-format. 2018-10-17 23:02:50 +02:00
Dave Davenport
f80e7d52bc [Helper] Remove fixed key/values and accept keys with NULL as values. 2018-10-17 22:41:20 +02:00
Dave Davenport
e8edc42f9d [Helper] Quick and dirty string replacer with optional keys block.
First (quick and dirty) version of a more advanced key replacer where
sets of text are only outputted if the contained key matches.
2018-10-16 21:01:45 +02:00
Lukas Alexandre
6830e5d117 Fixing typos in docs and error messages, "numger" -> "number" (#867) 2018-10-14 16:57:52 +02:00
Dave Davenport
11afb8e678 [Icon] Fix loading icons that are already in cache.
fixes: #860
2018-10-05 11:01:48 +02:00
Dave Davenport
114b2cf2fd [SSH] Improve parser for known_hosts a bit.
Issue: #820
2018-09-22 16:16:25 +02:00
Dave Davenport
a99cfa56c4 [Script] Add initial support for icons.
Issue: #840
2018-09-09 17:53:56 +02:00
Dave Davenport
859a9c79d6 Indent the code. 2018-08-08 15:55:13 +02:00
Dave Davenport
4538303be6 [DRUN] Add option to show actions in drun.
Fixes: #836
2018-07-28 11:12:11 +02:00
Dave Davenport
e4d823774c Export icon fetcher header, remove nxd from icon-fetcher header. 2018-07-14 18:05:34 +02:00
Dave Davenport
d526ae2ec3 [IconFetcher] preload the user set icon theme 2018-07-14 11:54:00 +02:00
Dave Davenport
09db7d5d3f [Tests] Fix window test. 2018-07-10 13:53:40 +02:00
Dave Davenport
a92bcc2818 [Theme] Change window layout for error dialog 2018-06-14 11:16:32 +02:00
Maxim Baz
ff9b0f5ccd Add default shortcuts: Shift+BackSpace to delete previous char, Ctrl+Left/Right for word movements (#790)
* Support Shift+BackSpace by default to delete previous char

* Support Ctrl+Arrow for word movements
2018-06-13 14:15:31 +02:00
Dave Davenport
bdb6abef4a
Sorting cleanup (#816)
* Add `-sorting-method` option remove weird -sort-levenshtein.

* Fix test for updated cmdline options.

* Update manpage
2018-06-13 11:57:23 +02:00
Dave Davenport
9909fb3d71 More documentation fixes 2018-06-12 14:11:08 +02:00
Dave Davenport
d2576e9f1f More source code documentation updates 2018-06-12 12:31:34 +02:00
Dave Davenport
32b45c2d10 Fix documentation
* theme
* view
* textbox
2018-06-12 12:16:33 +02:00
Dave Davenport
b8592f8b99 Documentation updates.
* theme,
* view,
* textbox
* helper
2018-06-12 12:00:00 +02:00
Dave Davenport
b837c3fdff Change log domain from Utils.IconFetcher to Helpers.IconFetcher
Matches doxygen.
2018-06-12 11:47:03 +02:00
Dave Davenport
c856c1a8ab [Widget::Icon] Fix doxygen documentation in header file. 2018-06-12 11:28:31 +02:00
Dave Davenport
0633bc9dad Remove (unused) widget ref counting. 2018-06-12 10:08:29 +02:00
Dave Davenport
d4cfb5bb4b Fix crash in error dialog and tests. 2018-06-12 09:46:24 +02:00
Dave Davenport
c96ebfc2de Re-add icon-theme option. 2018-06-09 22:17:32 +02:00
Dave Davenport
441c511296
Add an generic icon fetcher that can be used by any widget and re-uses the main threadpool.
Add an generic icon fetcher that can be used by any widget and re-uses the main threadpool.

* Make threadpool more generic usable.
* Add generic icon fetcher, that caches icons.
* Make DRUN use this fetcher.
* Add icon widget.

#809
2018-06-09 19:13:57 +02:00
Dave Davenport
a81e96fee7 Fix small memory leak in history. 2018-05-16 22:04:24 +02:00
Dave Davenport
2da5e5ee55 [TextBox] Add a reference to the cairo surface when displaying an icon. 2018-05-12 10:40:15 +02:00
Dave Davenport
3a726eabba
Fix how borders are drawn, so it looks correct when transparant. (#792)
* Try to fix borders a bit.

issue: #783

* Small cleanup to code, add comments to explain variables.
2018-04-08 10:19:43 +02:00
Dave Davenport
0f1717f829 [Script] Reset highlighting when reload view
Issue: #767
2018-02-08 17:56:31 +01:00
Dave Davenport
521843e9be
I749 (#766)
* [XCB] Use randr monitor API to get monitors.

Hopefully helps with issue #749.

* Add check for randr header version

* Fix API version check, and check the version of the server.

* Add some comments to the code.
2018-02-07 16:06:16 +01:00
Dave Davenport
ac29c537dd [SSH] Reload ssh when entry is deleted. 2018-02-06 21:03:07 +01:00
Quentin Glidic
5c5665efca
Revert "xcb: Add XKB_NEW_KEYBOARD_NOTIFY support"
This reverts commit e9532f584f.
It should not matter for rofi, which is not meant to stay around long,
and it messes with XTST (that tools like xscape use).

Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
2018-01-18 17:09:09 +01:00
Dave Davenport
7ad3ce25b1 [View] Added textboxes are set to autoheight and wrapping.
Fixes: #754
2018-01-14 11:47:04 +01:00
Dave Davenport
5ab0a642c9 [Theme] When reading double property, allow fallback to integer.
Otherwise the value '1' is not seen as valid entry, only '1.0'.

Fixes: #752
2018-01-14 11:21:02 +01:00
Quentin Glidic
101c4dcc26 bindings: Rework mouse bindings (#745)
Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
2017-12-26 10:10:40 +01:00
Quentin Glidic
14993a5a98
bindings: Fix double click delay
Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
2017-12-25 23:41:20 +01:00
Quentin Glidic
e9532f584f
xcb: Add XKB_NEW_KEYBOARD_NOTIFY support
Should not matter much for us, but not hard to support anyway.

Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
2017-12-18 17:51:59 +01:00
Dave Davenport
5a20094777 [Script] Reduce scope and swap tests. (cppcheck) 2017-12-11 18:42:35 +01:00
Dave Davenport
6abc8c920c DRun: Allow to select based on comment field.
Fixes: #733
2017-12-09 19:55:39 +01:00
Quentin Glidic
53e0f957d0
drun: Early return if already initialized
Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
2017-12-09 10:34:11 +01:00
Quentin Glidic
58ed481198
xrmoptions: Use a switch where possible
Signed-off-by: Quentin Glidic <sardemff7+git@sardemff7.net>
2017-12-09 10:34:11 +01:00
Dave Davenport
ae4ea622bb Fix (old style) fake-transparency and fake-background option.
- Broke and only setting it via theme worked.
2017-12-08 10:59:43 +01:00
Dave Davenport
f041313efb Allow theme to override width on box. 2017-12-08 10:48:22 +01:00
Dave Davenport
07cf9aabc7 Re-calculate size before showing. 2017-11-30 11:01:23 +01:00
Dave Davenport
f123deb37b When no new theme file present, don't print it in help. 2017-11-29 23:08:23 +01:00
Dave Davenport
10e2bc36cd Remove : from dmenu default prompt. 2017-11-28 17:53:45 +01:00
Edward Betts
79adae77d7 Correct spelling mistakes. (#722) 2017-11-23 18:41:52 +01:00